coverband 4.0.1.beta → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 287311c05b4d4bc1e85d1a8cc19d9a5630551fa8
-  data.tar.gz: f73c312bb5c4eceff8dd48e92d9191e5c57d80e9
+  metadata.gz: b7f0d091dfa76cb111bc6e76be9f03a644c9f7c9
+  data.tar.gz: d326e418b2612a0fd5ea9d17786918d9da90a5df
 SHA512:
-  metadata.gz: 2fd7fa9ceae554e6dba27834be7527b2df2a8160b68079124de97f3e986a0141dea24e467832c85881dd3f6753506b1fdc060d72226a0f009daf7c3dde66500c
-  data.tar.gz: 55566a5fef66122bcd908b6fb1d488727f55dabff12e0dfa0d73530727555c9bd6b6d7e104b1e14d9ebf5950984c7a82aaaa011e7aba68d32c923646d3a2f071
+  metadata.gz: 55288f996b6d5bc015e368c6952daf867b5a21fa0f5a09fdd7bfad3f19f0b11c6e12ca912e6121e315b23a15ca1ac03629552811874f8176ee882b91aafed967
+  data.tar.gz: 37fc422e6b917dacbede5a143bc2504f1da47dbf528e3164e91661545aa2bccd1c70332a2e8783414986c5bbd89925804c28961f20f321bf0073d034c9f56eaa

data/changes.md

@@ -64,15 +64,25 @@ Feature Ideas:
 
 # Alpha
 
-### Coverband 4.0.1.alpha
+### Coverband 4.0.2.alpha
 
-- drops simplecov runtime dependency
-  - still used to measure our own code coverage ;)
-- thanks SimpleCov for all the years of solid HTML reporting, and support!
-- reduced the S3 dependencies to minimal set (not loading all of aws-sdk), ensured they are optional
+- ?
 
 # Released
 
+### Coverband 4.0.1
+
+- drops Simplecov runtime dependency
+  - still used to measure our own code coverage ;)
+- thanks SimpleCov for all the years of solid HTML reporting, and support!
+- reduced the S3 dependencies to minimal set (not loading all of aws-sdk, only aws-sdk-s3), ensured they are optional
+- Improved Coverband web admin
+- Coverage reports include timestamps of Coverage collection
+- Added Coveralls to the dev process thanks @dondonz 
+- now tested under Ruby 2.6.0 thanks @Kbaum
+- improved full stack testing for Rails 5 & 4
+- warning before clear coverage on coverband web
+
 ### Coverband 4.0.0
 
 - Add support for Railties integration

data/lib/coverband/adapters/base.rb

@@ -22,15 +22,16 @@ module Coverband
       end
 
       def coverage
-        simple_report(get_report)
+        get_report
       end
 
       def covered_files
         coverage.keys || []
       end
 
+      # TODO: deprecate / remove?
       def covered_lines_for_file(file)
-        coverage[file] || []
+        Array(coverage.dig(file, 'data'))
       end
 
       protected

data/lib/coverband/reporters/console_report.rb

@@ -10,7 +10,11 @@ module Coverband
         scov_style_report = super(store, options)
 
         scov_style_report.each_pair do |file, usage|
-          Coverband.configuration.logger.info "#{file}: #{usage}"
+          if usage.is_a?(Hash)
+            Coverband.configuration.logger.info "#{file}: #{usage['data']}"
+          else
+            Coverband.configuration.logger.info "#{file}: #{usage}"
+          end
         end
         scov_style_report
       end

data/lib/coverband/utils/source_file.rb

@@ -81,9 +81,24 @@ module Coverband
       # The array of coverage data received from the Coverage.result
       attr_reader :coverage
 
-      def initialize(filename, coverage)
+      # the date this version of the file first started to record coverage
+      attr_reader :first_updated_at
+      # the date this version of the file last saw any coverage activity
+      attr_reader :last_updated_at
+      NOT_AVAILABLE = 'not available'
+
+      def initialize(filename, file_data)
         @filename = filename
-        @coverage = coverage
+        if file_data.is_a?(Hash)
+          @coverage = file_data['data']
+          @first_updated_at = @last_updated_at = NOT_AVAILABLE
+          @first_updated_at = Time.at(file_data['first_updated_at']) if file_data['first_updated_at']
+          @last_updated_at =  Time.at(file_data['last_updated_at']) if file_data['last_updated_at']
+        else
+          @coverage = file_data
+          @first_updated_at = NOT_AVAILABLE
+          @last_updated_at = NOT_AVAILABLE
+        end
       end
 
       # The path to this source file relative to the projects directory

data/lib/coverband/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Coverband
-  VERSION = '4.0.1.beta'
+  VERSION = '4.0.1'
 end

data/test/unit/adapters_redis_store_test.rb

@@ -16,16 +16,22 @@ class RedisTest < Minitest::Test
     mock_file_hash
     expected = basic_coverage
     @store.save_report(expected)
-    assert_equal expected, @store.coverage
+    assert_equal expected.keys, @store.coverage.keys
+    @store.coverage.each_pair do |key, data|
+      assert_equal expected[key], data['data']
+    end
   end
 
   def test_coverage_increments
     mock_file_hash
     expected = basic_coverage.dup
     @store.save_report(basic_coverage.dup)
-    assert_equal expected, @store.coverage
+    assert_equal expected.keys, @store.coverage.keys
+    @store.coverage.each_pair do |key, data|
+      assert_equal expected[key], data['data']
+    end
     @store.save_report(basic_coverage.dup)
-    assert_equal [0, 2, 4], @store.coverage['app_path/dog.rb']
+    assert_equal [0, 2, 4], @store.coverage['app_path/dog.rb']['data']
   end
 
   def test_covered_lines_for_file

data/test/unit/full_stack_test.rb

@@ -18,7 +18,7 @@ class FullStackTest < Minitest::Test
     Coverband.configuration.store.clear!
     Coverband.start
     @rack_file = File.expand_path(TEST_RACK_APP, File.dirname(__FILE__))
-    require @rack_file
+    load @rack_file
   end
 
   test 'call app' do
@@ -26,13 +26,15 @@ class FullStackTest < Minitest::Test
     middleware = Coverband::Middleware.new(fake_app_with_lines)
     results = middleware.call(request)
     assert_equal 'Hello Rack!', results.last
+    sleep(0.1)
     expected = [nil, nil, 1, nil, 1, 1, 1, nil, nil]
-    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]
+    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]['data']
 
     # additional calls increase count by 1
     middleware.call(request)
+    sleep(0.1)
     expected = [nil, nil, 1, nil, 1, 1, 2, nil, nil]
-    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]
+    assert_equal expected, Coverband.configuration.store.coverage[@rack_file]['data']
 
     # expected = nil
     # TODO: read the html to test it matches expectations? or return data as a hash?

data/test/unit/rails_full_stack_test.rb

@@ -24,7 +24,6 @@ class RailsFullStackTest < Minitest::Test
     assert_content('I am no dummy')
     sleep 0.2
     visit '/coverage'
-    click_link "view coverage report"
     within page.find('a',  text: /dummy_controller.rb/).find(:xpath, "../..") do
       assert_selector('td', text: '100.0 %')
     end

data/test/unit/reports_console_test.rb

@@ -27,6 +27,6 @@ class HTMLReportTest < Minitest::Test
 
     report = Coverband::Reporters::ConsoleReport.report(@store)
     expected = { 'app_path/dog.rb' => [0, 1, 2] }
-    assert_equal(expected, report)
+    assert_equal(expected.keys, report.keys)
   end
 end

data/test/unit/reports_web_test.rb

@@ -25,7 +25,7 @@ if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.0')
       test 'renders index content' do
         get '/'
         assert last_response.ok?
-        assert_match 'Coverband Web Admin Index', last_response.body
+        assert_match 'Coverband Admin', last_response.body
       end
 
       test 'renders show content' do

data/views/source_file.erb

@@ -3,12 +3,16 @@
     <h3><%= shortened_filename source_file %></h3>
     <h4><span class="<%= coverage_css_class(source_file.covered_percent) %>"><%= source_file.covered_percent.round(2).to_s %> %</span> covered</h4>
     <div>
-      <b><%= source_file.lines_of_code %></b> relevant lines. 
+      <b><%= source_file.lines_of_code %></b> relevant lines.
       <span class="green"><b><%= source_file.covered_lines.count %></b> lines covered</span> and
       <span class="red"><b><%= source_file.missed_lines.count %></b> lines missed.</span>
     </div>
+    <div>
+      Coverage first seen: <%= source_file.first_updated_at %>, last activity recorded: 
+      <%= source_file.last_updated_at %>
+    </div>
   </div>
-  
+
   <pre>
     <ol>
       <% source_file.lines.each do |line| %>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 4.0.1.beta
+  version: 4.0.1
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-29 00:00:00.000000000 Z
+date: 2018-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
@@ -368,9 +368,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.5.1