coverband 4.0.1.alpha → 4.0.1.beta

data/test/unit/adapters_base_test.rb

@@ -2,8 +2,9 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class AdaptersBaseTest < Test::Unit::TestCase
+class AdaptersBaseTest < Minitest::Test
   def setup
+    super
     @test_file_path = '/tmp/coverband_filestore_test_path.json'
     @store = Coverband::Adapters::FileStore.new(@test_file_path)
     mock_file_hash

data/test/unit/adapters_file_store_test.rb

@@ -2,8 +2,9 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class AdaptersFileStoreTest < Test::Unit::TestCase
+class AdaptersFileStoreTest < Minitest::Test
   def setup
+    super
     @test_file_path = '/tmp/coverband_filestore_test_path.json'
     File.open(@test_file_path, 'w') { |f| f.write(test_data.to_json) }
     @store = Coverband::Adapters::FileStore.new(@test_file_path)

data/test/unit/adapters_redis_store_test.rb

@@ -2,10 +2,11 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class RedisTest < Test::Unit::TestCase
+class RedisTest < Minitest::Test
   BASE_KEY = Coverband::Adapters::RedisStore::BASE_KEY
 
   def setup
+    super
     @redis = Redis.new
     @store = Coverband::Adapters::RedisStore.new(@redis)
     @store.clear!

data/test/unit/background_test.rb

@@ -2,23 +2,28 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class BackgroundTest < Test::Unit::TestCase
+class BackgroundTest < Minitest::Test
   def setup
-    Coverband::Collectors::Coverage.instance.reset_instance
+    super
     Coverband.configure do |config|
       config.store = Coverband::Adapters::RedisStore.new(Redis.new)
       config.background_reporting_enabled = true
+      config.background_reporting_sleep_seconds = 30
+    end
+    Coverband::Background.stop
+  end
+
+  class ThreadDouble
+    def exit
     end
-    Coverband::Background.instance_variable_set(:@background_reporting_running, nil)
   end
 
   def test_start
-    Thread.expects(:new).yields
+    Thread.expects(:new).yields.returns(ThreadDouble.new)
     Coverband::Background.expects(:loop).yields
-
     Coverband::Background.expects(:sleep).with(30)
-    Coverband::Background.expects(:at_exit).yields
-    Coverband::Collectors::Coverage.instance.expects(:report_coverage).twice
+    Coverband::Background.expects(:at_exit).returns(false)
+    Coverband::Collectors::Coverage.instance.expects(:report_coverage).once
     2.times { Coverband::Background.start }
   end
 end

data/test/unit/collectors_coverage_test.rb

@@ -4,10 +4,11 @@ require File.expand_path('../test_helper', File.dirname(__FILE__))
 require File.expand_path('./dog', File.dirname(__FILE__))
 
 if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.3.0')
-  class CollectorsCoverageTest < Test::Unit::TestCase
+  class CollectorsCoverageTest < Minitest::Test
     attr_accessor :coverband
 
     def setup
+      super
       Coverband.configure do |config|
         config.store = Coverband::Adapters::RedisStore.new(Redis.new)
       end
@@ -32,7 +33,7 @@ if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.3.0')
     test 'report_coverage raises errors in tests' do
       @coverband.reset_instance
       @coverband.expects(:ready_to_report?).raises('Oh no')
-      assert_raise RuntimeError do
+      assert_raises RuntimeError do
         @coverband.report_coverage
       end
     end

data/test/unit/configuration_test.rb

@@ -2,8 +2,9 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class BaseTest < Test::Unit::TestCase
+class BaseTest < Minitest::Test
   def setup
+    super
     Coverband.configure do |config|
       config.root                = Dir.pwd
       config.s3_bucket           = nil

data/test/unit/coverband_test.rb

@@ -2,7 +2,7 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class CoverbandTest < Test::Unit::TestCase
+class CoverbandTest < Minitest::Test
 
   test 'Coverband#start kicks off background reporting if enabled and not in rack server' do
     Coverband.configuration.stubs(:background_reporting_enabled).returns(:true)

data/test/unit/full_stack_test.rb

@@ -3,7 +3,7 @@
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 require 'rack'
 
-class FullStackTest < Test::Unit::TestCase
+class FullStackTest < Minitest::Test
   BASE_KEY = Coverband::Adapters::RedisStore::BASE_KEY
   TEST_RACK_APP = '../fake_app/basic_rack.rb'
 

data/test/unit/middleware_test.rb

@@ -3,10 +3,11 @@
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 require 'rack'
 
-class MiddlewareTest < Test::Unit::TestCase
+class MiddlewareTest < Minitest::Test
   BASE_KEY = Coverband::Adapters::RedisStore::BASE_KEY
 
   def setup
+    super
     Coverband.configure do |config|
       config.store = Coverband::Adapters::RedisStore.new(Redis.new)
       config.background_reporting_enabled = false

data/test/unit/rack_server_checkout_test.rb

@@ -2,23 +2,22 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class RackServerCheckTest < Test::Unit::TestCase
-
+class RackServerCheckTest < Minitest::Test
   test 'returns true when running in rack server' do
-    caller_locations = ['blah/lib/rack/server.rb'].map{ |path| OpenStruct.new(path: path, label: 'foo') }
+    caller_locations = ['blah/lib/rack/server.rb'].map { |path| OpenStruct.new(path: path, label: 'foo') }
     Kernel.expects(:caller_locations).returns(caller_locations)
-    assert_true(Coverband::RackServerCheck.running?)
+    assert(Coverband::RackServerCheck.running?)
   end
 
   test 'returns false when not running in rack server' do
-    caller_locations = ['blah/lib/sidekiq/worker.rb'].map{ |path| OpenStruct.new(path: path, label: 'foo') }
+    caller_locations = ['blah/lib/sidekiq/worker.rb'].map { |path| OpenStruct.new(path: path, label: 'foo') }
     Kernel.expects(:caller_locations).returns(caller_locations)
-    assert_false(Coverband::RackServerCheck.running?)
+    refute(Coverband::RackServerCheck.running?)
   end
 
   test 'returns true if running within a rails server' do
-    caller_locations = [OpenStruct.new(path: '/lib/rails/commands/commands_tasks.rb', label: 'server')] 
+    caller_locations = [OpenStruct.new(path: '/lib/rails/commands/commands_tasks.rb', label: 'server')]
     Kernel.expects(:caller_locations).returns(caller_locations)
-    assert_true(Coverband::RackServerCheck.running?)
+    assert(Coverband::RackServerCheck.running?)
   end
 end

data/test/unit/rails_full_stack_test.rb

@@ -2,16 +2,32 @@
 
 require File.expand_path('../rails_test_helper', File.dirname(__FILE__))
 
-class RailsFullStackTest < ActionDispatch::IntegrationTest
+class RailsFullStackTest < Minitest::Test
+  include Capybara::DSL
+  include Capybara::Minitest::Assertions
+
   def setup
-    Coverband.configuration.store.clear!
+    super
+    #The normal relative directory lookup of coverband won't work for our dummy rails project
+    Coverband.configure("./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband.rb")
+    Coverband.start
+  end
+
+  def teardown
+    super
+    Capybara.reset_sessions!
+    Capybara.use_default_driver
   end
 
   test 'this is how we do it' do
-    get '/dummy/show'
-    assert_response :success
-    assert_equal 'I am no dummy', response.body
-    assert_equal [1, 1, 1, nil, nil], Coverband.configuration.store.coverage["#{Rails.root}/app/controllers/dummy_controller.rb"]
+    visit '/dummy/show'
+    assert_content('I am no dummy')
+    sleep 0.2
+    visit '/coverage'
+    click_link "view coverage report"
+    within page.find('a',  text: /dummy_controller.rb/).find(:xpath, "../..") do
+      assert_selector('td', text: '100.0 %')
+    end
   end
 
   ###
@@ -29,8 +45,8 @@ class RailsFullStackTest < ActionDispatch::IntegrationTest
 
       # warmup
       3.times do
-        get '/dummy/show'
-        assert_response :success
+        visit '/dummy/show'
+        assert_content('I am no dummy')
         Coverband::Collectors::Coverage.instance.report_coverage(true)
       end
 
@@ -40,8 +56,8 @@ class RailsFullStackTest < ActionDispatch::IntegrationTest
 
       MemoryProfiler.report do
         15.times do
-          get '/dummy/show'
-          assert_response :success
+          visit '/dummy/show'
+          assert_content('I am no dummy')
           Coverband::Collectors::Coverage.instance.report_coverage(true)
           # this is expected to retain memory across requests
           # clear it to remove the false positive from test

data/test/unit/reports_base_test.rb

@@ -2,7 +2,7 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class ReportsBaseTest < Test::Unit::TestCase
+class ReportsBaseTest < Minitest::Test
   test 'filename_from_key fix filename from a key with a swappable path' do
     Coverband.configure do |config|
       config.reporter          = 'std_out'

data/test/unit/reports_console_test.rb

@@ -2,10 +2,11 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class HTMLReportTest < Test::Unit::TestCase
+class HTMLReportTest < Minitest::Test
   BASE_KEY = Coverband::Adapters::RedisStore::BASE_KEY
 
   def setup
+    super
     @redis = Redis.new
     @store = Coverband::Adapters::RedisStore.new(@redis)
     @store.clear!

data/test/unit/reports_html_test.rb

@@ -2,10 +2,11 @@
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
 
-class ReportHTMLTest < Test::Unit::TestCase
+class ReportHTMLTest < Minitest::Test
   BASE_KEY = Coverband::Adapters::RedisStore::BASE_KEY
 
   def setup
+    super
     @redis = Redis.new
     @store = Coverband::Adapters::RedisStore.new(@redis)
     @store.clear!

data/test/unit/reports_web_test.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require File.expand_path('../test_helper', File.dirname(__FILE__))
-require 'aws-sdk'
+require 'aws-sdk-s3'
 require File.expand_path('../../lib/coverband/reporters/web', File.dirname(__FILE__))
 require 'rack/test'
 
@@ -9,7 +9,7 @@ ENV['RACK_ENV'] = 'test'
 
 if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.0')
   module Coverband
-    class WebTest < Test::Unit::TestCase
+    class WebTest < Minitest::Test
       include Rack::Test::Methods
 
       def app
@@ -17,6 +17,7 @@ if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.0')
       end
 
       def teardown
+        super
         Coverband.configuration.s3_bucket = nil
       end
 

data/test/unit/utils/file_list_test.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+
+####
+# Thanks for all the help SimpleCov https://github.com/colszowka/simplecov-html
+# initial version of test pulled into Coverband from Simplecov 12/19/2018
+####
+describe Coverband::Utils::Result do
+  subject do
+    original_result = {
+      source_fixture('sample.rb') => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil],
+      source_fixture('app/models/user.rb') => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
+      source_fixture('app/controllers/sample_controller.rb') => [nil, 2, 2, 0, nil, nil, 0, nil, nil, nil]
+    }
+    Coverband::Utils::Result.new(original_result).files
+  end
+
+  it 'has 11 covered lines' do
+    assert_equal 11, subject.covered_lines
+  end
+
+  it 'has 3 missed lines' do
+    assert_equal 3, subject.missed_lines
+  end
+
+  it 'has 17 never lines' do
+    assert_equal 17, subject.never_lines
+  end
+
+  it 'has 14 lines of code' do
+    assert_equal 14, subject.lines_of_code
+  end
+
+  it 'has 5 skipped lines' do
+    assert_equal 5, subject.skipped_lines
+  end
+
+  it 'has the correct covered percent' do
+    assert_equal 78.57142857142857, subject.covered_percent
+  end
+
+  it 'has the correct covered percentages' do
+    assert_equal [50.0, 80.0, 100.0], subject.covered_percentages
+  end
+
+  it 'has the correct least covered file' do
+    assert subject.least_covered_file.match(/sample_controller.rb/)
+  end
+
+  it 'has the correct covered strength' do
+    assert_equal 0.9285714285714286, subject.covered_strength
+  end
+end

data/test/unit/utils/lines_classifier_test.rb

@@ -0,0 +1,109 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../test_helper', File.dirname(__FILE__))
+
+####
+# Thanks for all the help SimpleCov https://github.com/colszowka/simplecov-html
+# initial version of test pulled into Coverband from Simplecov 12/17/2018
+####
+describe Coverband::Utils::LinesClassifier do
+  describe '#classify' do
+    def subject
+      Coverband::Utils::LinesClassifier.new
+    end
+
+    describe 'relevant lines' do
+      it 'determines code as relevant' do
+        classified_lines = subject.classify [
+          'module Foo',
+          '  class Baz',
+          '    def Bar',
+          "      puts 'hi'",
+          '    end',
+          '  end',
+          'end'
+        ]
+
+        assert_equal 7, classified_lines.length
+        assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::RELEVANT })
+      end
+
+      it 'determines invalid UTF-8 byte sequences as relevant' do
+        classified_lines = subject.classify [
+          "bytes = \"\xF1t\xEBrn\xE2ti\xF4n\xE0liz\xE6ti\xF8n\""
+        ]
+
+        assert_equal 1, classified_lines.length
+        assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::RELEVANT })
+      end
+    end
+
+    describe 'not-relevant lines' do
+      it 'determines whitespace is not-relevant' do
+        classified_lines = subject.classify [
+          '',
+          '   ',
+          "\t\t"
+        ]
+
+        assert_equal 3, classified_lines.length
+        assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::NOT_RELEVANT })
+      end
+
+      describe 'comments' do
+        it 'determines comments are not-relevant' do
+          classified_lines = subject.classify [
+            '#Comment',
+            ' # Leading space comment',
+            "\t# Leading tab comment"
+          ]
+
+          assert_equal 3, classified_lines.length
+          assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::NOT_RELEVANT })
+        end
+
+        it "doesn't mistake interpolation as a comment" do
+          classified_lines = subject.classify [
+            'puts "#{var}"'
+          ]
+
+          assert_equal 1, classified_lines.length
+          assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::RELEVANT })
+        end
+      end
+
+      describe ':nocov: blocks' do
+        it 'determines :nocov: blocks are not-relevant' do
+          classified_lines = subject.classify [
+            '# :nocov:',
+            'def hi',
+            'end',
+            '# :nocov:'
+          ]
+
+          assert_equal 4, classified_lines.length
+          assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::NOT_RELEVANT })
+        end
+
+        it 'determines all lines after a non-closing :nocov: as not-relevant' do
+          classified_lines = subject.classify [
+            '# :nocov:',
+            "puts 'Not relevant'",
+            '# :nocov:',
+            "puts 'Relevant again'",
+            "puts 'Still relevant'",
+            '# :nocov:',
+            "puts 'Not relevant till the end'",
+            "puts 'Ditto'"
+          ]
+
+          assert_equal 8, classified_lines.length
+
+          assert(classified_lines[0..2].all? { |line| line == Coverband::Utils::LinesClassifier::NOT_RELEVANT })
+          assert(classified_lines[3..4].all? { |line| line == Coverband::Utils::LinesClassifier::RELEVANT })
+          assert(classified_lines[5..7].all? { |line| line == Coverband::Utils::LinesClassifier::NOT_RELEVANT })
+        end
+      end
+    end
+  end
+end