coverband 3.0.1 → 4.0.0.alpha

data/test/unit/full_stack_test.rb

@@ -5,7 +5,7 @@ require 'rack'
 
 class FullStackTest < Test::Unit::TestCase
   BASE_KEY = Coverband::Adapters::RedisStore::BASE_KEY
-  TEST_RACK_APP = '../fake_app/basic_rack.rb'.freeze
+  TEST_RACK_APP = '../fake_app/basic_rack.rb'
 
   def setup
     Coverband::Collectors::Coverage.instance.reset_instance
@@ -13,6 +13,7 @@ class FullStackTest < Test::Unit::TestCase
       config.reporting_frequency = 100.0
       config.store = Coverband::Adapters::RedisStore.new(Redis.new)
       config.s3_bucket = nil
+      config.background_reporting_enabled = false
     end
     Coverband.configuration.store.clear!
     Coverband.start

data/test/unit/middleware_test.rb

@@ -9,6 +9,7 @@ class MiddlewareTest < Test::Unit::TestCase
   def setup
     Coverband.configure do |config|
       config.store = Coverband::Adapters::RedisStore.new(Redis.new)
+      config.background_reporting_enabled = false
     end
   end
 
@@ -27,6 +28,24 @@ class MiddlewareTest < Test::Unit::TestCase
     app.call(env)
   end
 
+  test 'starts background reporter when configured' do
+    request = Rack::MockRequest.env_for('/anything.json')
+    Coverband.configuration.stubs(:background_reporting_enabled).returns(true)
+    Coverband::Collectors::Coverage.instance.expects(:report_coverage).never
+    Coverband::Background.expects(:start)
+    middleware = Coverband::Middleware.new(fake_app)
+    middleware.call(request)
+  end
+
+  test 'reports coverage when not set to background mode' do
+    request = Rack::MockRequest.env_for('/anything.json')
+    Coverband.configuration.stubs(:background_reporting_enabled).returns(false)
+    Coverband::Collectors::Coverage.instance.expects(:report_coverage)
+    Coverband::Background.expects(:start).never
+    middleware = Coverband::Middleware.new(fake_app)
+    middleware.call(request)
+  end
+
   test 'never be report coverage with reporting_frequency of 0' do
     request = Rack::MockRequest.env_for('/anything.json')
     Coverband::Collectors::Coverage.instance.reset_instance

data/test/unit/rails_full_stack_test.rb

@@ -10,7 +10,51 @@ class RailsFullStackTest < ActionDispatch::IntegrationTest
   test 'this is how we do it' do
     get '/dummy/show'
     assert_response :success
-    assert_equal "I am no dummy", response.body
+    assert_equal 'I am no dummy', response.body
     assert_equal [1, 1, 1, nil, nil], Coverband.configuration.store.coverage["#{Rails.root}/app/controllers/dummy_controller.rb"]
   end
+
+  ###
+  # Please keep this test starting on line 22
+  # as we run it in single test mode via the benchmarks.
+  # Add new tests below this test
+  ###
+  test 'memory usage' do
+    return unless ENV['COVERBAND_MEMORY_TEST']
+    # we don't want this to run during our standard test suite
+    # as the below profiler changes the runtime
+    # and shold only be included for isolated processes
+    begin
+      require 'memory_profiler'
+
+      # warmup
+      3.times do
+        get '/dummy/show'
+        assert_response :success
+        Coverband::Collectors::Coverage.instance.report_coverage(true)
+      end
+
+      previous_out = $stdout
+      capture = StringIO.new
+      $stdout = capture
+
+      MemoryProfiler.report do
+        15.times do
+          get '/dummy/show'
+          assert_response :success
+          Coverband::Collectors::Coverage.instance.report_coverage(true)
+          # this is expected to retain memory across requests
+          # clear it to remove the false positive from test
+          Coverband::Collectors::Coverage.instance.send(:add_previous_results, nil)
+        end
+      end.pretty_print
+      data = $stdout.string
+      $stdout = previous_out
+      if data.match(/retained objects by gem(.*)retained objects by file/m)[0]&.match(/coverband/)
+        raise 'leaking memory!!!'
+      end
+    ensure
+      $stdout = previous_out
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 4.0.0.alpha
 platform: ruby
 authors:
 - Dan Mayer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-21 00:00:00.000000000 Z
+date: 2018-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk
@@ -53,21 +53,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: m
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rack
+  name: memory_profiler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,21 +81,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rack-test
+  name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.14.0
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: redis
+  name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: test-unit
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: m
+  name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -151,7 +151,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: memory_profiler
+  name: classifier-reborn
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -165,7 +165,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: classifier-reborn
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -179,13 +179,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -239,6 +239,7 @@ files:
 - lib/coverband/reporters/console_report.rb
 - lib/coverband/reporters/simple_cov_report.rb
 - lib/coverband/reporters/web.rb
+- lib/coverband/utils/railtie.rb
 - lib/coverband/utils/s3_report.rb
 - lib/coverband/utils/tasks.rb
 - lib/coverband/version.rb
@@ -295,12 +296,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Rack middleware to help measure production code usage (LOC runtime usage)