courtfinder-client 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c10363b23a4abddd239820d39fb1f96dbc0080f6
-  data.tar.gz: 08cb9e811c67d11728e4f61d43c1354cdf4b818f
+  metadata.gz: f1ab53beeb6d13ddd27994af64083a5ec6d27b53
+  data.tar.gz: ffc3a68b43d11cd3427b7fae84838178fedbae37
 SHA512:
-  metadata.gz: 99c976648f26c260a0a6d4fd326552fea827f0db3c831b6bf14ab433ad5c1ba583793d310084406a71033e89bf2b5f5402ce7309cdf08a3710411fcf85cc3410
-  data.tar.gz: b4f082467c62a7896ea47876857baeb866701d4935cbb9e94479c4541330f9ab039ed5412f1abff19186d6531f1b1b10e26583c19eef96edafd8ef5c814ad4d3
+  metadata.gz: 3eefb1c2d39ea0d3bf7651197c3de830fa59580236f10f270be1826d3fc0436a003663aad7f546841e24cbda0421a15ae62105775387a9fa1073bfff01f11502
+  data.tar.gz: f7917ce6d70cab2e90af84b0959fb7c1cb7ff6218a68bfeb4ff5fa6aa5323cb3462fecf5777479058a2d35b533d15363dd9bcfe6a13b05188485a821b4fe7725

data/lib/courtfinder/client.rb

@@ -21,11 +21,15 @@ module Courtfinder
       private
 
       def process data
-        @json = JSON.parse data
-        unwanted_attributes = ['areas_of_law', 'slug', 'dx_number',
+        begin
+          @json = JSON.parse data
+          unwanted_attributes = ['areas_of_law', 'slug', 'dx_number',
                                'lon', 'lat', 'types', 'number']
-        @json.each do |court|
-          unwanted_attributes.each {|attr| court.delete attr }
+          @json.each do |court|
+            unwanted_attributes.each {|attr| court.delete attr }
+          end
+        rescue JSON::ParserError
+          @json = []
         end
       end
     end

data/lib/courtfinder/client/version.rb

@@ -1,5 +1,5 @@
 module Courtfinder
   module Client
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/spec/client_spec.rb

@@ -37,32 +37,46 @@ describe Courtfinder::Client::HousingPossession do
                  :headers => {})
   end
 
+  def error_result postcode
+    stub_request(:get, full_url(postcode))
+      .to_return(:status => 404,
+                 :body => '',
+                 :headers => {})
+  end
+
   describe '.get' do
-    before { stub_with postcode }
+    context 'with valid postcode' do
+      before { stub_with postcode }
 
-    context 'when given postcode with no spaces' do
-      let(:postcode) { 'sg80lt' }
+      context 'when given postcode with no spaces' do
+        let(:postcode) { 'sg80lt' }
 
-      it 'should return the court address' do
-        expect(client.get(postcode)).to eql result
+        it 'should return the court address' do
+          expect(client.get(postcode)).to eql result
+        end
       end
-    end
 
-    context 'when given postcode with spaces' do
-      let(:postcode) { 'SG8 0LT' }
+      context 'when given postcode with spaces' do
+        let(:postcode) { 'SG8 0LT' }
 
-      it 'should return the court address' do
-        expect(client.get(postcode)).to eql result
+        it 'should return the court address' do
+          expect(client.get(postcode)).to eql result
+        end
       end
     end
 
     context 'when invalid postcode is provided' do
-      let(:postcode) { 'fake' }
-      before { blank_result postcode }
-
-      it 'should return an error' do
+      it 'should return a blank array' do
+        postcode = 'fake'
+        blank_result postcode
         expect(client.get(postcode)).to eql []
       end
+
+      it 'should not raise an error' do
+        postcode = 'break'
+        error_result postcode
+        expect { client.get(postcode) }.not_to raise_error
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: courtfinder-client
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Aleksandar Simić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-03 00:00:00.000000000 Z
+date: 2014-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler