counterwise 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 872eddb45910800263c3c79d08192c149f1a93e406b777ace0e37a069b27c581
-  data.tar.gz: f1c75031995349a525f45ef0127dbad1dd8e922a31c638936ebecd5da8995b7e
+  metadata.gz: 98ea12fd31d7f6fbf9d9e1c11c682825ff8f713558d50f6c16033251f8bc33af
+  data.tar.gz: 763508e600c386bbe73c8734619944bb9fbfd2081ee8315fadb1c2ac5fe83178
 SHA512:
-  metadata.gz: acc758026ab1392efd1a18abed79901b51a9b19b3b310e6dcbb71fdf4daec4b06e3c5a191f7232f47a25b1fc402ad054c769daa32d4ea080632cbad5383df939
-  data.tar.gz: a81196e23f65e894f2c31780633255fdf2900fe109ea5a7b240d9cd2d54310c79d8a6511886af1208e441b80214e42dcc455b06c1b3a0b7c8cbbd6af2b5de1f9
+  metadata.gz: cadb970d0a22154e6d2b38fe2b6a3573ea08812d966af0f6021bd7c9e52d7056a4a692cd768fa984fe666fcf0d7397d081b9f7cb1252650f37a6c5921e1a165b
+  data.tar.gz: f7c519035c5c1ad238827d6b70121537e983100c0150e29b9686fc8db15d6e1b72c3a89a0f9e306ec787d5fd1b1492cc3ee824488667f3a3dd7c05f18649b4fe

data/README.md

@@ -481,7 +481,7 @@ See the asociated project in Github but roughly I'm thinking:
 
 Bug reports and pull requests are welcome, especially around naming, internal APIs, bug fixes, and additional features. Please open an issue first if you're thinking of adding a new feature so we can discuss it.
 
-I'm unlikely to entertain suport for older Ruby or Rails versions, or databases other than Postgres.
+I'm unlikely to entertain support for older Ruby or Rails versions, or databases other than Postgres.
 
 ## License
 

data/app/models/concerns/counter/verifyable.rb

@@ -2,25 +2,29 @@ module Counter::Verifyable
   extend ActiveSupport::Concern
 
   def correct?
-    # We can't verify these values
-    return true if definition.global?
+    # We can't verify these values: manual counters (which includes globals)
+    # have no countable source of truth, so their stored value is authoritative.
+    return true if definition.manual?
 
-    old_value, new_value = verify
-    old_value == new_value
+    correct_value, current_value = verify
+    correct_value == current_value
   end
 
   def correct!
-    # We can't verify these values
-    return true if definition.global?
+    # We can't verify these values: manual counters (which includes globals)
+    # have no countable source of truth, so their stored value is authoritative.
+    return true if definition.manual?
 
-    old_value, new_value = verify
+    correct_value, current_value = verify
 
-    requires_recalculation = old_value != new_value
-    update! value: new_value if requires_recalculation
+    requires_recalculation = correct_value != current_value
+    update! value: correct_value if requires_recalculation
 
     !requires_recalculation
   end
 
+  # Returns [correct_value, current_value]: the value recomputed from live
+  # data, and the value currently stored on the counter.
   def verify
     if definition.calculated?
       [calculate, value]
@@ -43,7 +47,7 @@ module Counter::Verifyable
         counter = counters.where("id >= ?", random_id).limit(1).first
         next if counter.nil?
 
-        if counter.definition.global? || counter.definition.calculated?
+        if counter.definition.manual? || counter.definition.calculated?
           puts "➡️ Skipping counter #{counter.name} (#{counter.id})" if verbose
           next
         end

data/lib/counter/version.rb

@@ -1,3 +1,3 @@
 module Counter
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: counterwise
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Jamie Lawrence