counters 1.2.0 → 1.3.0

data/lib/counters/base.rb

@@ -10,9 +10,9 @@ module Counters
       @namespace = options[:namespace]
     end
 
-    def hit(key)
+    def hit(key, value=1)
       validate(key)
-      record_hit(namespaced_key(key))
+      record_hit(namespaced_key(key), value)
     end
 
     def magnitude(key, value)
@@ -47,7 +47,7 @@ module Counters
       end
     end
 
-    def record_hit(key)
+    def record_hit(key, value)
       raise "Subclass Responsibility Error: must be implemented in instances of #{self.class} but isn't"
     end
     protected :record_hit

data/lib/counters/file.rb

@@ -27,8 +27,8 @@ module Counters
                 end
     end
 
-    def record_hit(key)
-      @logger.info "hit: #{key}"
+    def record_hit(key, increment)
+      @logger.info "hit: #{key}#{ increment == 1 ? "" : ": #{increment}"}"
     end
 
     def record_magnitude(key, magnitude)

data/lib/counters/memory.rb

@@ -13,8 +13,8 @@ module Counters
       @pings      = Hash.new
     end
 
-    def record_hit(key)
-      @hits[key] += 1
+    def record_hit(key, increment)
+      @hits[key] += increment
     end
 
     def record_ping(key)

data/lib/counters/redis.rb

@@ -10,8 +10,8 @@ module Counters
       @base_key = options.fetch(:base_key) { raise "Missing :base_key from #{options.inspect}" }
     end
 
-    def record_hit(key)
-      @redis.hincrby(@base_key, "hits.#{key}", 1)
+    def record_hit(key, increment)
+      @redis.hincrby(@base_key, "hits.#{key}", increment)
     end
 
     def record_magnitude(key, amount)

data/lib/counters/stats_d.rb

@@ -27,8 +27,8 @@ module Counters
       socket.send("pings.#{key}:1|c", 0, host, port)
     end
 
-    def record_hit(key)
-      socket.send("hits.#{key}:1|c", 0, host, port)
+    def record_hit(key, increment)
+      socket.send("hits.#{key}:#{increment}|c", 0, host, port)
     end
 
     # StatsD expects millisecond resolution

data/lib/counters/version.rb

@@ -1,3 +1,3 @@
 module Counters
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

data/spec/spec_helper.rb

@@ -38,6 +38,10 @@ shared_examples_for "all counters" do
     value.should == "the returned value"
   end
 
+  it "should allow hitting with a specific value increment" do
+    lambda { counter.hit "tada", 17 }.should_not raise_error
+  end
+
   it "should return a sub-namespaced counter on-demand" do
     other = counter.namespace("sub")
     other.namespace.should == "#{counter.namespace}.sub"

data/spec/statsd_counter_spec.rb

@@ -90,5 +90,11 @@ describe Counters::StatsD do
       socket.should_receive(:send).with(/^pings\.beer\.tulip\b/, anything, anything, anything)
       counter.ping "tulip"
     end
+
+    it "should increment with the #hit value" do
+      counter.namespace = "pow"
+      socket.should_receive(:send).with(/^hits\.pow\.loudness:17\b/, anything, anything, anything)
+      counter.hit "loudness", 17
+    end
   end
 end

metadata

@@ -2,7 +2,7 @@
 name: counters
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors: 
 - "Fran\xC3\xA7ois Beausoleil"
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-31 00:00:00 -04:00
+date: 2011-06-01 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency