counter_culture 3.5.2 → 3.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9cb364451d9ed9870da702f56a916db61dd29792766ace4732eb915ef7e1d0fd
-  data.tar.gz: 547fe6bfa9068ff65f5fa48a3afe1a847956ab04150a97f316f147c510c6bba3
+  metadata.gz: 5f4fd84b17129a9385e310381e0a19d5dc94a77f99bc6375e296cbf88c08fe72
+  data.tar.gz: a717e7ce645837b369e9fa5d40f7e721efaa8815b0ece0d814e124b798ede467
 SHA512:
-  metadata.gz: 910b10128b0d1fab9145f12d77262cd007e0cfe3d6730d0d6e0606e4e4fa59de59822ad690211fe6563604bfdb7fe3f9d68cd10d9419c6b9b01c823f0eb6a307
-  data.tar.gz: 611498966bc1a81b6177909ccae783cc9c4e598337aaeb02eb9db3586c06748ce02e555c6f357a5cb4c63a73fad902d52e321f9f0e8af6212c776c7d6a9a9150
+  metadata.gz: 74b120975400617101789ac7721b839e57e210e68a28d1edc307e2b8e03086e0d6adc652cb9a96be7cd0a7921c7e8033216316d63f0c74da9e3b929a9d24ad39
+  data.tar.gz: 050d42b195d1c947aa79f8cbbaf2dea74441020c67b96aa2493463c6cdcf0a1ccb649b7a322921174a64a30f4ba9287a0450ab217915dd62844adafdc5f934cd

data/Appraisals

@@ -7,5 +7,8 @@
 ].each do |rails_version|
   appraise "rails-#{rails_version}" do
     gem 'rails', "~> #{rails_version}.0"
+    if Gem::Version.new(rails_version) < Gem::Version.new("7.2")
+      gem 'sqlite3', "~> 1.4"
+    end
   end
 end

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 3.6.0 (June 18, 2024)
+
+Improvements:
+  - Don't perform a query if the `delta_magnitude` is zero (#394)
+
+## 3.5.3 (February 16, 2024)
+
+Bugfixes:
+  - Correct polymorphic table name alias reference in join clauses (#388)
+
 ## 3.5.2 (January 16, 2024)
 
 Bugfixes:

data/counter_culture.gemspec

@@ -43,7 +43,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec-extra-formatters'
   spec.add_development_dependency 'simplecov', '~> 0.16.1'
   spec.add_development_dependency 'timecop'
-  spec.add_development_dependency 'sqlite3'
+  spec.add_development_dependency 'sqlite3', ">= 1.4"
   spec.add_development_dependency 'mysql2'
   spec.add_development_dependency 'pg'
 end

data/gemfiles/rails_5.2.gemfile

@@ -3,5 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~> 5.2.0"
+gem "sqlite3", "~> 1.4"
 
 gemspec path: "../"

data/gemfiles/rails_6.0.gemfile

@@ -3,5 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~> 6.0.0"
+gem "sqlite3", "~> 1.4"
 
 gemspec path: "../"

data/gemfiles/rails_6.1.gemfile

@@ -3,5 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~> 6.1.0"
+gem "sqlite3", "~> 1.4"
 
 gemspec path: "../"

data/gemfiles/rails_7.0.gemfile

@@ -3,5 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~> 7.0.0"
+gem "sqlite3", "~> 1.4"
 
 gemspec path: "../"

data/gemfiles/rails_7.1.gemfile

@@ -3,5 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~> 7.1.0"
+gem "sqlite3", "~> 1.4"
 
 gemspec path: "../"

data/lib/counter_culture/counter.rb

@@ -55,6 +55,8 @@ module CounterCulture
                           else
                             counter_delta_magnitude_for(obj)
                           end
+        return if delta_magnitude.zero?
+
         # increment or decrement?
         operator = options[:increment] ? '+' : '-'
 

data/lib/counter_culture/reconciler.rb

@@ -274,13 +274,13 @@ module CounterCulture
           # child in a Single Table Inheritance
           if reflect.active_record.column_names.include?('type') &&
               !model.descends_from_active_record?
-            joins_sql += " AND #{target_table}.type IN ('#{model.name}')"
+            joins_sql += " AND #{target_table_alias}.type IN ('#{model.name}')"
           end
           if polymorphic?
             # adds 'type' condition to JOIN clause if the current model is a
             # polymorphic relation
             # NB only works for one-level relations
-            joins_sql += " AND #{target_table}.#{reflect.foreign_type} = '#{relation_class.name}'"
+            joins_sql += " AND #{target_table_alias}.#{reflect.foreign_type} = '#{relation_class.name}'"
           end
           if index == reverse_relation.size - 1
             # conditions must be applied to the join on which we are counting

data/lib/counter_culture/version.rb

@@ -1,3 +1,3 @@
 module CounterCulture
-  VERSION = '3.5.2'.freeze
+  VERSION = '3.6.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 3.5.2
+  version: 3.6.0
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-01-16 00:00:00.000000000 Z
+date: 2024-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -254,14 +254,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
@@ -345,7 +345,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.19
+rubygems_version: 3.5.10
 signing_key:
 specification_version: 4
 summary: Turbo-charged counter caches for your Rails app.