counter_culture 3.5.0 → 3.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: acebc4b3981511ea35497a3f276372253cb709314002ab2c6c498fb9b60a0166
-  data.tar.gz: b659b8956b8e6911c58563e4f921487f49a3ddf8ada5fbee7b79b0de16f8796d
+  metadata.gz: 9cb364451d9ed9870da702f56a916db61dd29792766ace4732eb915ef7e1d0fd
+  data.tar.gz: 547fe6bfa9068ff65f5fa48a3afe1a847956ab04150a97f316f147c510c6bba3
 SHA512:
-  metadata.gz: 9ef804972ebbd99b5945b22d87c85d93dcd3af1ea78f04683a0799b67d25d42cb8c4ca52e08b9267fbd17f11e6fcd07a334e5990cccd5e4fd3ea27991da67fb4
-  data.tar.gz: 81fa1adc6e283a1fed1a661e08cc7bd4a5280062cb8567ef730ce59342b0cf49032d09a9fc05bcbff713fbbd37d9a7157f2de35bc25df696d48f5de5bed9281c
+  metadata.gz: 910b10128b0d1fab9145f12d77262cd007e0cfe3d6730d0d6e0606e4e4fa59de59822ad690211fe6563604bfdb7fe3f9d68cd10d9419c6b9b01c823f0eb6a307
+  data.tar.gz: 611498966bc1a81b6177909ccae783cc9c4e598337aaeb02eb9db3586c06748ce02e555c6f357a5cb4c63a73fad902d52e321f9f0e8af6212c776c7d6a9a9150

data/.circleci/config.yml

@@ -48,8 +48,8 @@ workflows:
       - test:
           matrix:
             parameters:
-              ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2"]
-              rails-version: ["5.2", "6.0", "6.1", "7.0"]
+              ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
+              rails-version: ["5.2", "6.0", "6.1", "7.0", "7.1"]
               database: ["postgresql", "sqlite3", "mysql2"]
             exclude:
               - ruby-version: "3.0"
@@ -57,28 +57,37 @@ workflows:
                 database: "postgresql"
               - ruby-version: "3.0"
                 rails-version: "5.2"
-                database: "sqlite3"
+                database: "mysql2"
               - ruby-version: "3.0"
                 rails-version: "5.2"
-                database: "mysql2"
+                database: "sqlite3"
               - ruby-version: "3.1"
                 rails-version: "5.2"
                 database: "postgresql"
+              - ruby-version: "3.1"
+                rails-version: "5.2"
+                database: "mysql2"
               - ruby-version: "3.1"
                 rails-version: "5.2"
                 database: "sqlite3"
               - ruby-version: "3.2"
                 rails-version: "5.2"
-                database: "mysql2"
+                database: "postgresql"
               - ruby-version: "3.2"
                 rails-version: "5.2"
-                database: "postgresql"
+                database: "mysql2"
               - ruby-version: "3.2"
                 rails-version: "5.2"
                 database: "sqlite3"
-              - ruby-version: "3.1"
+              - ruby-version: "3.3"
+                rails-version: "5.2"
+                database: "postgresql"
+              - ruby-version: "3.3"
                 rails-version: "5.2"
                 database: "mysql2"
+              - ruby-version: "3.3"
+                rails-version: "5.2"
+                database: "sqlite3"
               - ruby-version: "2.6"
                 rails-version: "7.0"
                 database: "postgresql"
@@ -88,3 +97,12 @@ workflows:
               - ruby-version: "2.6"
                 rails-version: "7.0"
                 database: "mysql2"
+              - ruby-version: "2.6"
+                rails-version: "7.1"
+                database: "postgresql"
+              - ruby-version: "2.6"
+                rails-version: "7.1"
+                database: "sqlite3"
+              - ruby-version: "2.6"
+                rails-version: "7.1"
+                database: "mysql2"

data/Appraisals

@@ -3,6 +3,7 @@
   6.0
   6.1
   7.0
+  7.1
 ].each do |rails_version|
   appraise "rails-#{rails_version}" do
     gem 'rails', "~> #{rails_version}.0"

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 3.5.2 (January 16, 2024)
+
+Bugfixes:
+  - Assign attributes to the duped model on a lower level when determining whether a model has changed to avoid invoking unrelated callbacks (#386)
+
+## 3.5.1 (January 8, 2024)
+
+Bugfixes:
+  - Fix touching for counted models without `updated_at` (#383)
+
 ## 3.5.0 (August 25, 2023)
 
 Improvements:

data/README.md

@@ -7,7 +7,7 @@ Turbo-charged counter caches for your Rails app. Huge improvements over the Rail
 * Supports dynamic column names, making it possible to split up the counter cache for different types of objects
 * Can keep a running count, or a running total
 
-Tested against Ruby 2.6, 2.7, 3.0, 3.1 and 3.2, and against the latest patch releases of Rails 5.2, 6.0, 6.1 and 7.0.
+Tested against Ruby 2.6, 2.7, 3.0, 3.1, 3.2 and 3.3 and against the latest patch releases of Rails 5.2, 6.0, 6.1, 7.0 and 7.1.
 
 Please note that -- unlike Rails' built-in counter-caches -- counter_culture does not currently change the behavior of the `.size` method on ActiveRecord associations. If you want to avoid a database query and read the cached value, please use the attribute name containing the counter cache directly.
 
@@ -74,7 +74,7 @@ class Group < ActiveRecord::Base
   has_many :members, through: :group_memberships, class: "User"
 end
 
-class Membership < ActiveRecord::Base
+class GroupMembership < ActiveRecord::Base
   belongs_to :group
   belongs_to :member, class: "User"
   counter_culture :group, column_name: "members_count"
@@ -358,6 +358,8 @@ Product.counter_culture_fix_counts touch: 'category_count_changed'
 
 The options start and finish are especially useful if you want multiple workers dealing with the same processing queue. You can make worker 1 handle all the records between id 1 and 9999 and worker 2 handle from 10000 and beyond by setting the :start and :finish option on each worker.
 
+>  **! NOTE**: the IDs we pass as `start` and `finish` here are in fact `Category` IDs, not `Product`!
+
 ```ruby
 Product.counter_culture_fix_counts start: 10_000
 # will fix counts for all counter caches defined on Product from record 10000 and onwards.
@@ -374,7 +376,7 @@ Product.counter_culture_fix_counts start: 2001, finish: 3000
 
 #### Fix counter cache using a replica database
 
-When fixing counter caches the number of reads usually vastly exceeds the number of writes. It can make sense to offload the road load to a replica database in this case. Rails 6 introduced [native handling of multiple database connections](https://guides.rubyonrails.org/v6.0/active_record_multiple_databases.html). You can use this to send read traffic to a read-only repliace using the option `db_connection_builder`:
+When fixing counter caches the number of reads usually vastly exceeds the number of writes. It can make sense to offload the read load to a replica database in this case. Rails 6 introduced [native handling of multiple database connections](https://guides.rubyonrails.org/v6.0/active_record_multiple_databases.html). You can use this to send read traffic to a read-only replica using the option `db_connection_builder`:
 
 ```ruby
 Product.counter_culture_fix_counts db_connection_builder: proc{|reading, block|

data/gemfiles/rails_7.1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 7.1.0"
+
+gemspec path: "../"

data/lib/counter_culture/counter.rb

@@ -81,8 +81,8 @@ module CounterCulture
         end
         # and here we update the timestamp, if so desired
         if touch
-          current_time = obj.send(:current_time_from_proper_timezone)
-          timestamp_columns = obj.send(:timestamp_attributes_for_update_in_model)
+          current_time = klass.send(:current_time_from_proper_timezone)
+          timestamp_columns = klass.send(:timestamp_attributes_for_update_in_model)
           if touch != true
             # starting in Rails 6 this is frozen
             timestamp_columns = timestamp_columns.dup
@@ -314,7 +314,9 @@ module CounterCulture
       changes_method = ACTIVE_RECORD_VERSION >= Gem::Version.new("5.1.0") ? :saved_changes : :changed_attributes
       obj.public_send(changes_method).each do |key, value|
         old_value = ACTIVE_RECORD_VERSION >= Gem::Version.new("5.1.0") ? value.first : value
-        prev[key] = old_value
+        # We set old values straight to AR @attributes variable to avoid
+        # write_attribute callbacks from other gems (e.g. ArTransactionChanges)
+        prev.instance_variable_get(:@attributes).write_from_user(key, old_value)
       end
 
       prev

data/lib/counter_culture/version.rb

@@ -1,3 +1,3 @@
 module CounterCulture
-  VERSION = '3.5.0'.freeze
+  VERSION = '3.5.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.2
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-08-25 00:00:00.000000000 Z
+date: 2024-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -317,6 +317,7 @@ files:
 - gemfiles/rails_6.0.gemfile
 - gemfiles/rails_6.1.gemfile
 - gemfiles/rails_7.0.gemfile
+- gemfiles/rails_7.1.gemfile
 - lib/counter_culture.rb
 - lib/counter_culture/counter.rb
 - lib/counter_culture/extensions.rb