counter_culture 3.11.1 → 3.11.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 593e3704f40322fade2c263f93bb6d88749b397d641586b30f4d616ee5c9ed0c
-  data.tar.gz: b183412de943dbe2390a4eef636ca8aae9fea6aeac6ac298177545d26b08413e
+  metadata.gz: 75ac99d8d45f3e16859bb04854958dac048a449aa4afe94f12885cefe3a94787
+  data.tar.gz: e90d1b87ea3e2d919434dbeea2263fa5556044dc273cab21a6a67b423519c012
 SHA512:
-  metadata.gz: c0a74d87a9d56ec4b19d7fe9a7aaf9bd2698d527387251a52b866e534117386005e830eef556b96bbc67122a125ebf942a4531be5b6f2d35a075b55b3133b052
-  data.tar.gz: 4cd891261ed5402cffa7eea851e2400f3b6d7ec8c4d617b36a3b0dd680e00f17b9b1a909a55bb94db1dbe636ca4b5d2d929d02df851e00869bb316a703fa8928
+  metadata.gz: dc1196535a528c5f87e39aca06d5e1a3e014f469c8aa3e8f01c56f75a59489c4db25dc9b67168b162ddf9ac24e45c55fe887c10176e76786dea5ffe72603f10b
+  data.tar.gz: a949a3856773028e954e00c8ce5ba89ac0e999230c47af3d1b0e312fdef827cbbf0dc71ed91406c6b2b77ba4d194b108f21df8b904f0e09592d2b5ef2a0e25d9

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 3.11.3 (October 22, 2025)
+
+Bugfixes:
+  - Fix in-memory counter updates for conditional counters when condition changes (#420)
+
+## 3.11.2 (July 10, 2025)
+
+Bugfixes:
+  - Fix regression for foreign_key_values by adding support for composite primary keys (#417)
+
 ## 3.11.1 (June 27, 2025)
 
 Bugfixes:

data/README.md

@@ -232,7 +232,7 @@ The ```:delta_column``` option supports all numeric column types, not just ```:i
 class Product < ActiveRecord::Base
   belongs_to :category
   counter_culture :category, foreign_key_values:
-      proc {|category_id| [category_id, Category.find_by_id(category_id).try(:parent_category).try(:id)] }
+      proc {|category_id| [category_id, Category.find_by(id: category_id)&.parent_category&.id] }
 end
 
 class Category < ActiveRecord::Base

data/lib/counter_culture/counter.rb

@@ -108,6 +108,15 @@ module CounterCulture
 
         primary_key = relation_primary_key(relation, source: obj, was: options[:was])
 
+        if foreign_key_values && id_to_change.is_a?(Enumerable) && id_to_change.count > 1 &&
+            Array.wrap(primary_key).count == 1
+          # To keep this feature backwards compatible, we need to accommodate a case where
+          # `foreign_key_values` returns an array, but we're _not_ using composite primary
+          # keys. In that case, we need to wrap the `id_to_change` in one more array to keep
+          # it compatible with the `.zip` call in `primary_key_conditions`.
+          id_to_change = [id_to_change]
+        end
+
         if Thread.current[:aggregate_counter_updates]
           Thread.current[:primary_key_map][klass] ||= primary_key
         end
@@ -141,7 +150,27 @@ module CounterCulture
           execute_now_or_after_commit(obj) do
             conditions = primary_key_conditions(primary_key, id_to_change)
             klass.where(conditions).update_all updates.join(', ')
-            unless options[:was]
+            # Determine if we should update the in-memory counter on the associated object.
+            # When updating the old counter (was: true), we need to carefully consider two scenarios:
+            # 1) The belongs_to relation changed (e.g., moving a child from parent A to parent B):
+            #    In this case, obj.association now points to parent B, but we're decrementing parent A's
+            #    counter. We should NOT update the in-memory counter because it would incorrectly
+            #    modify parent B's cached value.
+            # 2) A conditional counter's condition changed (e.g., condition: true → false):
+            #    In this case, obj.association still points to the same parent, but the counter column
+            #    name changed (e.g., from 'conditional_count' to nil). We SHOULD update the in-memory
+            #    counter so the parent object reflects the decremented value without requiring a reload.
+            # We distinguish these cases by comparing foreign keys: if the current and previous foreign
+            # keys are identical, we're in scenario 2 and should update the in-memory counter.
+            should_update_counter = if options[:was]
+              current_fk = foreign_key_value(obj, relation, false)
+              previous_fk = foreign_key_value(obj, relation, true)
+              current_fk == previous_fk && current_fk.present?
+            else
+              true
+            end
+
+            if should_update_counter
               assign_to_associated_object(obj, relation, change_counter_column, operator, delta_magnitude)
             end
           end

data/lib/counter_culture/version.rb

@@ -1,3 +1,3 @@
 module CounterCulture
-  VERSION = '3.11.1'.freeze
+  VERSION = '3.11.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 3.11.1
+  version: 3.11.3
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-06-27 00:00:00.000000000 Z
+date: 2025-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord