counter_culture 1.3.1 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 72f1f80ced7ce2b0a631cad618e4848f79a4281c
-  data.tar.gz: 7c2f05798e05997ff23fdb97b9eca1108f0a378d
+  metadata.gz: 8651d71833facf2f685c6fcbd0ae922bb55e295d
+  data.tar.gz: dab5d1dfecaa1a880171f5378de590385cf11218
 SHA512:
-  metadata.gz: 2a13a2d10fa178346a0fa836a2fe6fc2506919aa98cd7969e7db52c750f57df1a5ba0a34cf859d1bfadd9f3ed03d79951deb99784a0b1e2c5b358aca6d684a0b
-  data.tar.gz: ef7a5a47ed3c7f759132f6b0f03a8dfa65f5be6e69a07deb8ebe33fb08176d7000ac8790976468f2fab0cb83234732d645ac6499bf3d49c249548fa9e3218b43
+  metadata.gz: 817f09ec93f18c4a638b1db6e34ac811a73abe2b96179bc471547cce713bc8029d7131e9577f9aac152ad82993db2e922f1a2f68d3d0541de6b7e944db05ce1c
+  data.tar.gz: a7332118c2325d9124ad1053dddb6a947e2fc2e416bdb6999e7d5c36e3cb5452c8a8ba48a6ea21d0a13d364334990cf9ee2a840bfb00b7dd738683465fdb9ed4

data/.travis.yml

@@ -8,6 +8,7 @@ env:
   - "RAILS_VERSION=4.1.0"
   - "RAILS_VERSION=4.2.0"
   - "RAILS_VERSION=5.0.0"
+  - "RAILS_VERSION=5.1.0.rc1"
 install:
   - bundle update
 script: TRAVIS=true bundle exec rake spec

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 1.4.0 (March 21, 2017)
+
+Improvements:
+  - Avoid Rails 5.1 deprecation warnings
+
+## 1.3.1 (February 23, 2017)
+
+Bugfixes:
+  - Removed requirement for Rails 5 added by mistake (in fact, this gem supports and tests Rails versions as far back as Rails 3.2 now)
+
 ## 1.3.0 (February 21, 2017)
 Removed features:
   - Removed support for `has_one`; this did not work properly. If you need this, consider adding the `counter_culture` call on the model with the `belongs_to` instead.

data/README.md

@@ -2,11 +2,13 @@
 
 Turbo-charged counter caches for your Rails app. Huge improvements over the Rails standard counter caches:
 
-* Updates counter cache when values change, not just when creating and destroying 
+* Updates counter cache when values change, not just when creating and destroying
 * Supports counter caches through multiple levels of relations
 * Supports dynamic column names, making it possible to split up the counter cache for different types of objects
 * Can keep a running count, or a running total
 
+Tested against Ruby 2.2.5 and 2.3.1 and against the latest patch releases of Rails 3.2, 4.0, 4.1, 4.2, 5.0 and 5.1.
+
 ## Installation
 
 Add counter_culture to your Gemfile:
@@ -27,7 +29,7 @@ rails generate counter_culture Category products_count
 
 Which will generate a migration with code like the following:
 ```ruby
-add_column :categories, :products_count, :integer, :null => false, :default => 0
+add_column :categories, :products_count, :integer, null: false, default: 0
 ```
 Note that the column must be ```NOT NULL``` and have a default of zero for this gem to work correctly.
 
@@ -85,7 +87,7 @@ end
 ```ruby
 class Product < ActiveRecord::Base
   belongs_to :category
-  counter_culture :category, :column_name => "products_counter_cache"
+  counter_culture :category, column_name: "products_counter_cache"
 end
 
 class Category < ActiveRecord::Base
@@ -100,7 +102,7 @@ Now, the ```Category``` model will keep an up-to-date counter-cache in the ```pr
 ```ruby
 class Product < ActiveRecord::Base
   belongs_to :category
-  counter_culture :category, :column_name => proc {|model| "#{model.product_type}_count" }
+  counter_culture :category, column_name: proc {|model| "#{model.product_type}_count" }
   # attribute product_type may be one of ['awesome', 'sucky']
 end
 
@@ -143,7 +145,7 @@ Now adding a `Product` will increase the `weight` column in its `Category` by 3;
 ```ruby
 class Product < ActiveRecord::Base
   belongs_to :category
-  counter_culture :category, :column_name => proc {|model| model.special? ? 'special_count' : nil }
+  counter_culture :category, column_name: proc {|model| model.special? ? 'special_count' : nil }
 end
 
 class Category < ActiveRecord::Base
@@ -164,7 +166,7 @@ total of the weight for all the products in the Category model's ```product_weig
 ```ruby
 class Product < ActiveRecord::Base
   belongs_to :category
-  counter_culture :category, :column_name => 'product_weight_ounces', :delta_column => 'weight_ounces'
+  counter_culture :category, column_name: 'product_weight_ounces', delta_column: 'weight_ounces'
 end
 
 class Category < ActiveRecord::Base
@@ -182,14 +184,14 @@ The ```:delta_column``` option supports all numeric column types, not just ```:i
 ```ruby
 class Product < ActiveRecord::Base
   belongs_to :category
-  counter_culture :category, :foreign_key_values => 
+  counter_culture :category, foreign_key_values:
       proc {|category_id| [category_id, Category.find_by_id(category_id).try(:parent_category).try(:id)] }
 end
 
 class Category < ActiveRecord::Base
-  belongs_to :parent_category, :class_name => 'Category', :foreign_key => 'parent_id'
-  has_many :children, :class_name => 'Category', :foreign_key => 'parent_id'
-  
+  belongs_to :parent_category, class_name: 'Category', foreign_key: 'parent_id'
+  has_many :children, class_name: 'Category', foreign_key: 'parent_id'
+
   has_many :products
 end
 ```
@@ -200,7 +202,7 @@ Now, the ```Category``` model will keep an up-to-date counter-cache in the ```pr
 
 By default, counter_culture does not update the timestamp of models when it updates their counter caches. If you would like every change in the counter cache column to result in an updated timestamp, simply set the touch option to true:
 ```ruby
-  counter_culture :category, :touch => true
+  counter_culture :category, touch: true
 ```
 
 This is useful when you require your caches to get invalidated when the counter cache changes.
@@ -209,7 +211,7 @@ This is useful when you require your caches to get invalidated when the counter
 
 You may also specify a custom timestamp column that gets updated only when a particular counter cache changes:
 ```ruby
-  counter_culture :category, :touch => 'category_count_changed'
+  counter_culture :category, touch: 'category_count_changed'
 ```
 
 With this option, any time the `category_counter_cache` changes both the `category_count_changed` and `updated_at` columns will get updated.
@@ -218,9 +220,12 @@ With this option, any time the `category_counter_cache` changes both the `catego
 
 By default, counter_culture will run counter cache updates inside of the same ActiveRecord transaction that triggered it. (Note that this bevavior [changed from version 0.2.3 to 1.0.0](CHANGELOG.md#100-november-15-2016).) If you would like to run counter cache updates outside of that transaction, for example because you are experiencing [deadlocks with older versions of PostgreSQL](http://mina.naguib.ca/blog/2010/11/22/postgresql-foreign-key-deadlocks.html), you can enable that behavior:
 ```ruby
-  counter_culture :category, :execute_after_commit => true
+  counter_culture :category, execute_after_commit: true
 ```
 
+Please note that using `execute_after_commit` in conjunction with transactional
+fixtures will lead to your tests no longer seeing updated counter values.
+
 ### Manually populating counter cache values
 
 You will sometimes want to populate counter-cache values from primary data. This is required when adding counter-caches to existing data. It is also recommended to run this regularly (at BestVendor, we run it once a week) to catch any incorrect values in the counter caches.
@@ -229,16 +234,16 @@ You will sometimes want to populate counter-cache values from primary data. This
 Product.counter_culture_fix_counts
 # will automatically fix counts for all counter caches defined on Product
 
-Product.counter_culture_fix_counts :except => :category
+Product.counter_culture_fix_counts except: :category
 # will automatically fix counts for all counter caches defined on Product, except for the :category relation
 
-Product.counter_culture_fix_counts :only => :category
+Product.counter_culture_fix_counts only: :category
 # will automatically fix counts only on the :category relation on Product
 
 # :except and :only also accept arrays of one level relations
 # if you want to fix counts on a more than one level relation you need to use convention below:
 
-Product.counter_culture_fix_counts :only => [[:subcategory, :category]]
+Product.counter_culture_fix_counts only: [[:subcategory, :category]]
 # will automatically fix counts only on the two-level [:subcategory, :category] relation on Product
 
 # :except and :only also accept arrays
@@ -252,17 +257,17 @@ CounterCulture.config.batch_size = 100
 or by passing the :batch_size option to the method call
 
 ```ruby
-Product.counter_culture_fix_counts :batch_size => 100
+Product.counter_culture_fix_counts batch_size: 100
 ```
 
 ```counter_culture_fix_counts``` returns an array of hashes of all incorrect values for debugging purposes. The hashes have the following format:
 
 ```ruby
-{ :entity => which model the count was fixed on,
-  :id => the id of the model that had the incorrect count,
-  :what => which column contained the incorrect count,
-  :wrong => the previously saved, incorrect count,
-  :right => the newly fixed, correct count }
+{ entity: which model the count was fixed on,
+  id: the id of the model that had the incorrect count,
+  what: which column contained the incorrect count,
+  wrong: the previously saved, incorrect count,
+  right: the newly fixed, correct count }
 ```
 
 ```counter_culture_fix_counts``` is optimized to minimize the number of queries and runs very quickly.
@@ -274,9 +279,9 @@ Manually populating counter caches with dynamic column names requires additional
 ```ruby
 class Product < ActiveRecord::Base
   belongs_to :category
-  counter_culture :category, 
-      :column_name => proc {|model| "#{model.product_type}_count" },
-      :column_names => {
+  counter_culture :category,
+      column_name: proc {|model| "#{model.product_type}_count" },
+      column_names: {
           ["products.product_type = ?", 'awesome'] => 'awesome_count',
           ["products.product_type = ?", 'sucky'] => 'sucky_count'
       }
@@ -292,14 +297,8 @@ Manually populating counter caches with dynamically over-written foreign keys (`
 
 counter_culture currently does *not* support polymorphic associations. Check [this issue](https://github.com/magnusvk/counter_culture/issues/4) for progress and alternatives.
 
-## A note on testing
-
-counter_culture will not update counters in your automated tests *if* you use transactional fixtures. That's because transactional fixtures roll back all your database transactions and they are never committed. But counter_culture will only update its counters in the ```after_commit``` callback, which in this case will never run.
-
-counter_culture itself has extensive automated tests so there should not be a need to test counter caches in your own tests. I therefore recommend removing any checks of counter caches as that will avoid this issue. If that is not an option for you, you can use the [`test_after_commit` gem](https://github.com/grosser/test_after_commit) to trigger `after_commit` callbacks even with transactional fixtures enabled. Another option is to turn off transactional fixtures and use something like [database_cleaner](https://github.com/bmabey/database_cleaner) instead to clean your database between tests.
-
 ## Contributing to counter_culture
- 
+
 * Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
 * Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
 * Fork the project.

data/VERSION

@@ -1 +1 @@
-1.3.1
+1.4.0

data/counter_culture.gemspec

@@ -2,18 +2,18 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: counter_culture 1.3.1 ruby lib
+# stub: counter_culture 1.4.0 ruby lib
 
 Gem::Specification.new do |s|
-  s.name = "counter_culture"
-  s.version = "1.3.1"
+  s.name = "counter_culture".freeze
+  s.version = "1.4.0"
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib"]
-  s.authors = ["Magnus von Koeller"]
-  s.date = "2017-02-23"
-  s.description = "counter_culture provides turbo-charged counter caches that are kept up-to-date not just on create and destroy, that support multiple levels of indirection through relationships, allow dynamic column names and that avoid deadlocks by updating in the after_commit callback."
-  s.email = "magnus@vonkoeller.de"
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib".freeze]
+  s.authors = ["Magnus von Koeller".freeze]
+  s.date = "2017-03-21"
+  s.description = "counter_culture provides turbo-charged counter caches that are kept up-to-date not just on create and destroy, that support multiple levels of indirection through relationships, allow dynamic column names and that avoid deadlocks by updating in the after_commit callback.".freeze
+  s.email = "magnus@vonkoeller.de".freeze
   s.extra_rdoc_files = [
     "CHANGELOG.md",
     "LICENSE.txt",
@@ -25,7 +25,6 @@ Gem::Specification.new do |s|
     ".travis.yml",
     "CHANGELOG.md",
     "Gemfile",
-    "Gemfile.lock",
     "LICENSE.txt",
     "README.md",
     "Rakefile",
@@ -112,51 +111,51 @@ Gem::Specification.new do |s|
     "spec/spec_helper.rb",
     "test_rails_versions.sh"
   ]
-  s.homepage = "http://github.com/magnusvk/counter_culture"
-  s.licenses = ["MIT"]
-  s.rubygems_version = "2.4.5.1"
-  s.summary = "Turbo-charged counter caches for your Rails app."
+  s.homepage = "http://github.com/magnusvk/counter_culture".freeze
+  s.licenses = ["MIT".freeze]
+  s.rubygems_version = "2.6.10".freeze
+  s.summary = "Turbo-charged counter caches for your Rails app.".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<after_commit_action>, ["~> 1.0"])
-      s.add_runtime_dependency(%q<activerecord>, [">= 3.0.0"])
-      s.add_runtime_dependency(%q<activesupport>, [">= 3.0.0"])
-      s.add_development_dependency(%q<rake>, [">= 0"])
-      s.add_development_dependency(%q<rails>, [">= 3.1.0"])
-      s.add_development_dependency(%q<rspec>, ["~> 3.0"])
-      s.add_development_dependency(%q<awesome_print>, [">= 0"])
-      s.add_development_dependency(%q<timecop>, [">= 0"])
-      s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
-      s.add_development_dependency(%q<bundler>, [">= 1.2.0"])
-      s.add_development_dependency(%q<jeweler>, ["~> 2.1"])
+      s.add_runtime_dependency(%q<after_commit_action>.freeze, ["~> 1.0"])
+      s.add_runtime_dependency(%q<activerecord>.freeze, [">= 3.0.0"])
+      s.add_runtime_dependency(%q<activesupport>.freeze, [">= 3.0.0"])
+      s.add_development_dependency(%q<rake>.freeze, [">= 0"])
+      s.add_development_dependency(%q<rails>.freeze, [">= 3.1.0"])
+      s.add_development_dependency(%q<rspec>.freeze, ["~> 3.0"])
+      s.add_development_dependency(%q<awesome_print>.freeze, [">= 0"])
+      s.add_development_dependency(%q<timecop>.freeze, [">= 0"])
+      s.add_development_dependency(%q<rdoc>.freeze, ["~> 3.12"])
+      s.add_development_dependency(%q<bundler>.freeze, [">= 1.2.0"])
+      s.add_development_dependency(%q<jeweler>.freeze, ["~> 2.1"])
     else
-      s.add_dependency(%q<after_commit_action>, ["~> 1.0"])
-      s.add_dependency(%q<activerecord>, [">= 3.0.0"])
-      s.add_dependency(%q<activesupport>, [">= 3.0.0"])
-      s.add_dependency(%q<rake>, [">= 0"])
-      s.add_dependency(%q<rails>, [">= 3.1.0"])
-      s.add_dependency(%q<rspec>, ["~> 3.0"])
-      s.add_dependency(%q<awesome_print>, [">= 0"])
-      s.add_dependency(%q<timecop>, [">= 0"])
-      s.add_dependency(%q<rdoc>, ["~> 3.12"])
-      s.add_dependency(%q<bundler>, [">= 1.2.0"])
-      s.add_dependency(%q<jeweler>, ["~> 2.1"])
+      s.add_dependency(%q<after_commit_action>.freeze, ["~> 1.0"])
+      s.add_dependency(%q<activerecord>.freeze, [">= 3.0.0"])
+      s.add_dependency(%q<activesupport>.freeze, [">= 3.0.0"])
+      s.add_dependency(%q<rake>.freeze, [">= 0"])
+      s.add_dependency(%q<rails>.freeze, [">= 3.1.0"])
+      s.add_dependency(%q<rspec>.freeze, ["~> 3.0"])
+      s.add_dependency(%q<awesome_print>.freeze, [">= 0"])
+      s.add_dependency(%q<timecop>.freeze, [">= 0"])
+      s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
+      s.add_dependency(%q<bundler>.freeze, [">= 1.2.0"])
+      s.add_dependency(%q<jeweler>.freeze, ["~> 2.1"])
     end
   else
-    s.add_dependency(%q<after_commit_action>, ["~> 1.0"])
-    s.add_dependency(%q<activerecord>, [">= 3.0.0"])
-    s.add_dependency(%q<activesupport>, [">= 3.0.0"])
-    s.add_dependency(%q<rake>, [">= 0"])
-    s.add_dependency(%q<rails>, [">= 3.1.0"])
-    s.add_dependency(%q<rspec>, ["~> 3.0"])
-    s.add_dependency(%q<awesome_print>, [">= 0"])
-    s.add_dependency(%q<timecop>, [">= 0"])
-    s.add_dependency(%q<rdoc>, ["~> 3.12"])
-    s.add_dependency(%q<bundler>, [">= 1.2.0"])
-    s.add_dependency(%q<jeweler>, ["~> 2.1"])
+    s.add_dependency(%q<after_commit_action>.freeze, ["~> 1.0"])
+    s.add_dependency(%q<activerecord>.freeze, [">= 3.0.0"])
+    s.add_dependency(%q<activesupport>.freeze, [">= 3.0.0"])
+    s.add_dependency(%q<rake>.freeze, [">= 0"])
+    s.add_dependency(%q<rails>.freeze, [">= 3.1.0"])
+    s.add_dependency(%q<rspec>.freeze, ["~> 3.0"])
+    s.add_dependency(%q<awesome_print>.freeze, [">= 0"])
+    s.add_dependency(%q<timecop>.freeze, [">= 0"])
+    s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
+    s.add_dependency(%q<bundler>.freeze, [">= 1.2.0"])
+    s.add_dependency(%q<jeweler>.freeze, ["~> 2.1"])
   end
 end
 

data/lib/counter_culture/counter.rb

@@ -38,8 +38,7 @@ module CounterCulture
 
       if id_to_change && change_counter_column
         delta_magnitude = if delta_column
-                            delta_attr_name = options[:was] ? "#{delta_column}_was" : delta_column
-                            obj.send(delta_attr_name) || 0
+                            (options[:was] ? attribute_was(obj, delta_column) : obj.public_send(delta_column)) || 0
                           else
                             counter_delta_magnitude_for(obj)
                           end
@@ -112,7 +111,7 @@ module CounterCulture
       first_relation = relation.first
       if was
         first = relation.shift
-        foreign_key_value = obj.send("#{relation_foreign_key(first)}_was")
+        foreign_key_value = attribute_was(obj, relation_foreign_key(first))
         klass = relation_klass(first)
         value = klass.where("#{klass.table_name}.#{relation_primary_key(first)} = ?", foreign_key_value).first if foreign_key_value
       else
@@ -181,8 +180,10 @@ module CounterCulture
     def previous_model(obj)
       prev = obj.dup
 
-      obj.changed_attributes.each do |key, value|
-        prev.send("#{key}=", value)
+      changes_method = Rails.version >= "5.1.0" ? :saved_changes : :changed_attributes
+      obj.public_send(changes_method).each do |key, value|
+        old_value = Rails.version >= "5.1.0" ? value.first : value
+        prev.public_send("#{key}=", old_value)
       end
 
       prev
@@ -197,5 +198,15 @@ module CounterCulture
         yield
       end
     end
+
+    def attribute_was(obj, attr)
+      changes_method =
+        if Rails.version >= "5.1.0"
+          "_before_last_save"
+        else
+          "_was"
+        end
+      obj.public_send("#{attr}#{changes_method}")
+    end
   end
 end

data/lib/counter_culture/extensions.rb

@@ -1,7 +1,7 @@
 module CounterCulture
   module Extensions
     extend ActiveSupport::Concern
-    
+
     module ClassMethods
       # this holds all configuration data
       def after_commit_counter_cache
@@ -27,7 +27,7 @@ module CounterCulture
         end
 
         if options[:column_names] && !options[:column_names].is_a?(Hash)
-          raise ":column_names must be a Hash of conditions and column names" 
+          raise ":column_names must be a Hash of conditions and column names"
         end
 
         # add the counter to our collection
@@ -111,9 +111,14 @@ module CounterCulture
           counter_cache_name_was = counter.counter_cache_name_for(counter.previous_model(self))
           counter_cache_name = counter.counter_cache_name_for(self)
 
-          if send("#{counter.first_level_relation_foreign_key}_changed?") ||
-            (counter.delta_column && send("#{counter.delta_column}_changed?")) ||
-            counter_cache_name != counter_cache_name_was
+          if Rails.version >= "5.1.0"
+            foreign_key_changed = saved_changes[counter.first_level_relation_foreign_key].present?
+            delta_column_changed = (counter.delta_column && saved_changes[counter.delta_column].present?)
+          else
+            foreign_key_changed = attribute_changed?(counter.first_level_relation_foreign_key)
+            delta_column_changed = (counter.delta_column && attribute_changed?(counter.delta_column))
+          end
+          if foreign_key_changed || delta_column_changed || counter_cache_name != counter_cache_name_was
 
             # increment the counter cache of the new value
             counter.change_counter_cache(self, :increment => true, :counter_column => counter_cache_name)
@@ -125,4 +130,4 @@ module CounterCulture
     end
 
   end
-end
+end

data/spec/counter_culture_spec.rb

@@ -1500,6 +1500,12 @@ describe "CounterCulture" do
     it "should return a copy of the original model" do
       user.name = "Joe Smith"
       user.manages_company_id = 2
+
+      if Rails.version >= "5.1.0"
+        # must save to make the actual "saved_changes" available in Rails 5.1
+        # whereas we simply use the "changed_attributes" before that
+        user.save!
+      end
       prev = CounterCulture::Counter.new(user, :foobar, {}).previous_model(user)
 
       expect(prev.name).to eq("John Smith")

data/spec/rails_app/config/environments/test.rb

@@ -7,9 +7,6 @@ RailsApp::Application.configure do
   # and recreated between test runs. Don't rely on the data there!
   config.cache_classes = true
 
-  # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_files = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false

data/spec/spec_helper.rb

@@ -8,10 +8,15 @@ require "rails_app/config/environment"
 require 'rspec'
 require 'counter_culture'
 
-load "#{File.dirname(__FILE__)}/schema.rb"
-
 CI_TEST_RUN = (ENV['TRAVIS'] && 'TRAVIS') || (ENV['CIRCLECI'] && 'CIRCLE') || ENV["CI"] && 'CI'
 
+begin
+  was, ActiveRecord::Migration.verbose = ActiveRecord::Migration.verbose, false unless ENV['SHOW_MIGRATION_MESSAGES']
+  load "#{File.dirname(__FILE__)}/schema.rb"
+ensure
+  ActiveRecord::Migration.verbose = was unless ENV['SHOW_MIGRATION_MESSAGES']
+end
+
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}

data/test_rails_versions.sh

@@ -2,8 +2,12 @@
 
 set -e
 
-for RAILS_VERSION in "3.2.0" "4.0.0" "4.1.0" "5.0.0"
+for RAILS_VERSION in "3.2.0" "4.0.0" "4.1.0" "4.2.0" "5.0.0" "5.1.0.rc1"
 do
+  export RAILS_VERSION
+  echo "Rails $RAILS_VERSION"
   bundle update
   bundle exec rspec spec
 done
+
+unset RAILS_VERSION

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.4.0
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-23 00:00:00.000000000 Z
+date: 2017-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: after_commit_action
@@ -181,7 +181,6 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -287,7 +286,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Turbo-charged counter caches for your Rails app.

data/Gemfile.lock

@@ -1,189 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actioncable (5.0.1)
-      actionpack (= 5.0.1)
-      nio4r (~> 1.2)
-      websocket-driver (~> 0.6.1)
-    actionmailer (5.0.1)
-      actionpack (= 5.0.1)
-      actionview (= 5.0.1)
-      activejob (= 5.0.1)
-      mail (~> 2.5, >= 2.5.4)
-      rails-dom-testing (~> 2.0)
-    actionpack (5.0.1)
-      actionview (= 5.0.1)
-      activesupport (= 5.0.1)
-      rack (~> 2.0)
-      rack-test (~> 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.0.1)
-      activesupport (= 5.0.1)
-      builder (~> 3.1)
-      erubis (~> 2.7.0)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    activejob (5.0.1)
-      activesupport (= 5.0.1)
-      globalid (>= 0.3.6)
-    activemodel (5.0.1)
-      activesupport (= 5.0.1)
-    activerecord (5.0.1)
-      activemodel (= 5.0.1)
-      activesupport (= 5.0.1)
-      arel (~> 7.0)
-    activesupport (5.0.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    addressable (2.5.0)
-      public_suffix (~> 2.0, >= 2.0.2)
-    after_commit_action (1.0.1)
-      activerecord (>= 3.0.0)
-      activesupport (>= 3.0.0)
-    arel (7.1.4)
-    awesome_print (1.7.0)
-    builder (3.2.3)
-    concurrent-ruby (1.0.4)
-    database_cleaner (1.5.3)
-    descendants_tracker (0.0.4)
-      thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.3)
-    erubis (2.7.0)
-    faraday (0.9.2)
-      multipart-post (>= 1.2, < 3)
-    git (1.3.0)
-    github_api (0.11.3)
-      addressable (~> 2.3)
-      descendants_tracker (~> 0.0.1)
-      faraday (~> 0.8, < 0.10)
-      hashie (>= 1.2)
-      multi_json (>= 1.7.5, < 2.0)
-      nokogiri (~> 1.6.0)
-      oauth2
-    globalid (0.3.7)
-      activesupport (>= 4.1.0)
-    hashie (3.5.3)
-    highline (1.7.8)
-    i18n (0.8.0)
-    jeweler (2.3.3)
-      builder
-      bundler (>= 1.0)
-      git (>= 1.2.5)
-      github_api (~> 0.11.0)
-      highline (>= 1.6.15)
-      nokogiri (>= 1.5.10)
-      psych (~> 2.2)
-      rake
-      rdoc
-      semver2
-    json (1.8.6)
-    jwt (1.5.6)
-    loofah (2.0.3)
-      nokogiri (>= 1.5.9)
-    mail (2.6.4)
-      mime-types (>= 1.16, < 4)
-    method_source (0.8.2)
-    mime-types (3.1)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2016.0521)
-    mini_portile2 (2.1.0)
-    minitest (5.10.1)
-    multi_json (1.12.1)
-    multi_xml (0.6.0)
-    multipart-post (2.0.0)
-    nio4r (1.2.1)
-    nokogiri (1.6.8.1)
-      mini_portile2 (~> 2.1.0)
-    oauth2 (1.3.0)
-      faraday (>= 0.8, < 0.11)
-      jwt (~> 1.0)
-      multi_json (~> 1.3)
-      multi_xml (~> 0.5)
-      rack (>= 1.2, < 3)
-    psych (2.2.2)
-    public_suffix (2.0.5)
-    rack (2.0.1)
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rails (5.0.1)
-      actioncable (= 5.0.1)
-      actionmailer (= 5.0.1)
-      actionpack (= 5.0.1)
-      actionview (= 5.0.1)
-      activejob (= 5.0.1)
-      activemodel (= 5.0.1)
-      activerecord (= 5.0.1)
-      activesupport (= 5.0.1)
-      bundler (>= 1.3.0, < 2.0)
-      railties (= 5.0.1)
-      sprockets-rails (>= 2.0.0)
-    rails-dom-testing (2.0.2)
-      activesupport (>= 4.2.0, < 6.0)
-      nokogiri (~> 1.6)
-    rails-html-sanitizer (1.0.3)
-      loofah (~> 2.0)
-    railties (5.0.1)
-      actionpack (= 5.0.1)
-      activesupport (= 5.0.1)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
-    rake (12.0.0)
-    rdoc (3.12.2)
-      json (~> 1.4)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-extra-formatters (1.0.0)
-    rspec-mocks (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    semver2 (3.4.2)
-    sprockets (3.7.1)
-      concurrent-ruby (~> 1.0)
-      rack (> 1, < 3)
-    sprockets-rails (3.2.0)
-      actionpack (>= 4.0)
-      activesupport (>= 4.0)
-      sprockets (>= 3.0.0)
-    sqlite3 (1.3.13)
-    thor (0.19.4)
-    thread_safe (0.3.5)
-    timecop (0.8.1)
-    tzinfo (1.2.2)
-      thread_safe (~> 0.1)
-    websocket-driver (0.6.5)
-      websocket-extensions (>= 0.1.0)
-    websocket-extensions (0.1.2)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activerecord (>= 3.0.0)
-  activesupport (>= 3.0.0)
-  after_commit_action (~> 1.0)
-  awesome_print
-  bundler (>= 1.2.0)
-  database_cleaner (>= 1.1.1)
-  jeweler (~> 2.1)
-  rails (>= 3.1.0)
-  rake
-  rdoc (~> 3.12)
-  rspec (~> 3.0)
-  rspec-extra-formatters
-  sqlite3
-  timecop
-
-BUNDLED WITH
-   1.14.4