counter_culture 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e66602a56b11c2f0d339149bbae08eea6904c87
-  data.tar.gz: 5e7bbc39f261492db78d74d1ae81f6cf5d98f824
+  metadata.gz: 17e2e8471fc8063fc35d135431aee0c6f9b88945
+  data.tar.gz: 3501cf53a5553393f1d23727938f09b8c2007447
 SHA512:
-  metadata.gz: be97b621e4e6c783ffa371ba7177af1c529bf7b0238e02a92c2c435cf8ed468ae95a81bdfab2f2a11731ad1fd339e97145beb3ecf1459358b61c879f154d8619
-  data.tar.gz: 23bd89ddcd5b651a835442f43795b14dcf3afc450e88fb57963663b3ed70a00c7d7739bfd6110347d5b0e468417a0e189df0836303f517f349f894f866f1fe9d
+  metadata.gz: e1081eced18d4ef33bb20ea1ceabd0bab38e2deb9a9549dd1610274879739ef48e047fb2d2cdf45ebe7f644a7cc4723e4b8213b4db3b692c0a8c50cad7147fbf
+  data.tar.gz: 0cbf2af0334ee313cb789fadb3a38e592fe5f712b5c703d702fac6ae78a55c892ecde74f0108bab0b35c054abe9bed24716fb8621ff961ee27b5f7756159d1ce

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.2.3 (October 18, 2016)
+
+Improvements:
+  - When running `fix_counts` on a table, wrap each batch in a transaction because that is faster on large tables.
+
 ## 0.2.2 (July 11, 2016)
 
 Bugfixes:

data/README.md

@@ -281,7 +281,7 @@ counter_culture currently does *not* support polymorphic associations. Check [th
 
 counter_culture will not update counters in your automated tests *if* you use transactional fixtures. That's because transactional fixtures roll back all your database transactions and they are never committed. But counter_culture will only update its counters in the ```after_commit``` callback, which in this case will never run.
 
-counter_culture itself has extensive automated tests so there should not be a need to test counter caches in your own tests. I therefore recommend removing any checks of counter caches as that will avoid this issue. If that is not an option for you, you can use the [`test_after_commit` gem](https://github.com/grosser/test_after_commit) to trigger `after_commit` callbacks even with transactional fitures enabled. Another option is to turn off transactional fixtures and use something like [database_cleaner](https://github.com/bmabey/database_cleaner) instead to clean your database between tests.
+counter_culture itself has extensive automated tests so there should not be a need to test counter caches in your own tests. I therefore recommend removing any checks of counter caches as that will avoid this issue. If that is not an option for you, you can use the [`test_after_commit` gem](https://github.com/grosser/test_after_commit) to trigger `after_commit` callbacks even with transactional fixtures enabled. Another option is to turn off transactional fixtures and use something like [database_cleaner](https://github.com/bmabey/database_cleaner) instead to clean your database between tests.
 
 ## Contributing to counter_culture
  

data/VERSION

@@ -1 +1 @@
-0.2.2
+0.2.3

data/counter_culture.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: counter_culture 0.2.2 ruby lib
+# stub: counter_culture 0.2.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "counter_culture"
-  s.version = "0.2.2"
+  s.version = "0.2.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Magnus von Koeller"]
-  s.date = "2016-07-11"
+  s.date = "2016-10-18"
   s.description = "counter_culture provides turbo-charged counter caches that are kept up-to-date not just on create and destroy, that support multiple levels of indirection through relationships, allow dynamic column names and that avoid deadlocks by updating in the after_commit callback."
   s.email = "magnus@vonkoeller.de"
   s.extra_rdoc_files = [

data/lib/counter_culture.rb

@@ -1,5 +1,6 @@
 require 'after_commit_action'
 require 'active_support/concern'
+require 'active_support/lazy_load_hooks'
 
 require 'counter_culture/extensions'
 require 'counter_culture/counter'

data/lib/counter_culture/reconciler.rb

@@ -1,3 +1,6 @@
+require 'active_support/core_ext/module/delegation'
+require 'active_support/core_ext/module/attribute_accessors'
+
 module CounterCulture
   class Reconciler
     attr_reader :counter, :options, :changes
@@ -54,14 +57,16 @@ module CounterCulture
 
         counts_query.group(full_primary_key(relation_class)).find_in_batches(batch_size: batch_size) do |records|
           # now iterate over all the models and see whether their counts are right
-          records.each do |record|
-            count = record.read_attribute('count') || 0
-            next if record.read_attribute(column_name) == count
+          ActiveRecord::Base.transaction do
+            records.each do |record|
+              count = record.read_attribute('count') || 0
+              next if record.read_attribute(column_name) == count
 
-            track_change(record, column_name, count)
+              track_change(record, column_name, count)
 
-            # use update_all because it's faster and because a fixed counter-cache shouldn't update the timestamp
-            relation_class.where(relation_class.primary_key => record.send(relation_class.primary_key)).update_all(column_name => count)
+              # use update_all because it's faster and because a fixed counter-cache shouldn't update the timestamp
+              relation_class.where(relation_class.primary_key => record.send(relation_class.primary_key)).update_all(column_name => count)
+            end
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-11 00:00:00.000000000 Z
+date: 2016-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: after_commit_action