counter_cache_update 0.0.3 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5a21fc1b22472205f939ea1c6518e5aacd6bb128
-  data.tar.gz: dd2e5334684f63c5d985779ef5223f4eccb1bdb5
+SHA256:
+  metadata.gz: f727cafaa635682ea718968a48a16181fbd331be75b2721435bc1c54afba595d
+  data.tar.gz: 0223c953148013b3b34099cda00b6fe2522810e1f51b38b1b54bde09fba11dce
 SHA512:
-  metadata.gz: 56a49fa503c5e5405de2da18ed7e5f8ad0bc9217f8c27a5b91097857cb9733d78052becf25c30f5a740464cf6f54a5119394263a9ea96b95d919f3dac093baf1
-  data.tar.gz: 759891b5030e227a1038d4d9d105335031d10580efb23146b562b9895df65681f7f4060bbc10fc45b4eeebfb779d095ed0f3169f43e42449371ad8d948f27fc2
+  metadata.gz: 5ba5596de6ebe289ca4d46919516005dc6fe3fe12f4032de4bd89065f49ab6a4c0d99b3b27ce04206efb9b207767883fbd5a006909c01cc3ad140bbbd920284e
+  data.tar.gz: 6c59c8f4d63629c14396cca7b4ed02098fef3aca63f70ae3460c96ae70874c0f690f3f0dd0d4a428e411d7b933631a9461e603796a7404e66127466016fefa1d

data/app/services/counter_cache_update/polymorphic_updator_service.rb

@@ -0,0 +1,23 @@
+class CounterCacheUpdate::PolymorphicUpdatorService < ServicePattern::Service
+  def initialize(reflection:)
+    @class = reflection.active_record
+    @reflection = reflection
+  end
+
+  def perform
+    foreign_types.each do |foreign_type|
+      CounterCacheUpdate::TableUpdatorService.execute!(reflection: @reflection, model_class: foreign_type.constantize)
+    end
+
+    succeed!
+  end
+
+private
+
+  # Returns the class names of those records that has the given polymorphic relationship
+  def foreign_types
+    @reflection.active_record
+      .group(@reflection.foreign_type)
+      .pluck(@reflection.foreign_type)
+  end
+end

data/app/services/counter_cache_update/table_updator_service.rb

@@ -1,14 +1,16 @@
 class CounterCacheUpdate::TableUpdatorService < ServicePattern::Service
   attr_reader :model_class, :reflection
 
-  def initialize(reflection:)
+  def initialize(reflection:, model_class: nil)
     @reflection = reflection
-    @model_class = @reflection.class_name.constantize
+
+    @model_class = model_class
+    @model_class ||= @reflection.class_name.constantize
   end
 
-  def execute!
+  def perform
     model_class.connection.execute(sql)
-    ServicePattern::Response.new(success: true)
+    succeed!
   end
 
 private
@@ -24,7 +26,9 @@ private
   end
 
   def count_sql
-    "SELECT COUNT(*) FROM #{reflection_table_name} WHERE #{reflection_table_name}.#{relation_foreign_key} = #{table_name}.#{primary_key}"
+    sql = "SELECT COUNT(*) FROM #{reflection_table_name} WHERE #{reflection_table_name}.#{relation_foreign_key} = #{table_name}.#{primary_key}"
+    sql << " AND #{reflection.foreign_type} = #{ActiveRecord::Base.connection.quote(model_class.name)}" if reflection.options[:polymorphic]
+    sql
   end
 
   def primary_key

data/app/services/counter_cache_update/update_service.rb

@@ -5,7 +5,7 @@ class CounterCacheUpdate::UpdateService < ServicePattern::Service
     @use_progress_bar = use_progress_bar
   end
 
-  def execute!
+  def perform
     Rails.application.eager_load!
 
     if use_progress_bar
@@ -14,7 +14,7 @@ class CounterCacheUpdate::UpdateService < ServicePattern::Service
     end
 
     update_relationships!
-    ServicePattern::Response.new(success: true)
+    succeed!
   end
 
 private
@@ -26,8 +26,12 @@ private
       model_class.reflections.each do |_name, reflection|
         next unless reflection.macro.to_sym == :belongs_to
         next unless reflection.options[:counter_cache]
-        next if reflection.options[:polymorphic]
-        CounterCacheUpdate::TableUpdatorService.execute!(reflection: reflection)
+
+        if reflection.options[:polymorphic]
+          CounterCacheUpdate::PolymorphicUpdatorService.execute!(reflection: reflection)
+        else
+          CounterCacheUpdate::TableUpdatorService.execute!(reflection: reflection)
+        end
       end
     end
   end

data/lib/counter_cache_update/version.rb

@@ -1,3 +1,3 @@
 module CounterCacheUpdate
-  VERSION = "0.0.3".freeze
+  VERSION = "0.0.7".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_cache_update
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.7
 platform: ruby
 authors:
 - kaspernj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-17 00:00:00.000000000 Z
+date: 2021-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -30,14 +30,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: pry-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: tzinfo-data
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Scans all your models and updates all counter caches with optimised SQL.
 email:
 - kaspernj@gmail.com
@@ -56,6 +84,7 @@ files:
 - app/jobs/counter_cache_update/application_job.rb
 - app/mailers/counter_cache_update/application_mailer.rb
 - app/models/counter_cache_update/application_record.rb
+- app/services/counter_cache_update/polymorphic_updator_service.rb
 - app/services/counter_cache_update/table_updator_service.rb
 - app/services/counter_cache_update/update_service.rb
 - app/views/layouts/counter_cache_update/application.html.erb
@@ -76,15 +105,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Scans all your models and updates all counter caches with optimised SQL.