counter_cache_update 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a21fc1b22472205f939ea1c6518e5aacd6bb128
-  data.tar.gz: dd2e5334684f63c5d985779ef5223f4eccb1bdb5
+  metadata.gz: da60d0659cc80bc69235f6c6d8e3da19e9ff9b8d
+  data.tar.gz: efe7c55d60d096aa73dfe7df01bb02ed0fba690c
 SHA512:
-  metadata.gz: 56a49fa503c5e5405de2da18ed7e5f8ad0bc9217f8c27a5b91097857cb9733d78052becf25c30f5a740464cf6f54a5119394263a9ea96b95d919f3dac093baf1
-  data.tar.gz: 759891b5030e227a1038d4d9d105335031d10580efb23146b562b9895df65681f7f4060bbc10fc45b4eeebfb779d095ed0f3169f43e42449371ad8d948f27fc2
+  metadata.gz: 8d7cb3a66131cea09114c11025503d6471914fcca61bb0e88c499dae815fdd8bd9523dda9f13e272c22817a63198a29ba39d245dae96a09b07c30d8c9335798e
+  data.tar.gz: a4ec4d8c17afd0c1b0f572eb3b6978d7c0c34c9582f5f517b680bf3ba98c8fccde36e4d28a9fb876a867c113ed35c1af65bcf0678dcd53eeb5eff33f06053968

data/app/services/counter_cache_update/polymorphic_updator_service.rb

@@ -0,0 +1,21 @@
+class CounterCacheUpdate::PolymorphicUpdatorService < ServicePattern::Service
+  def initialize(reflection:)
+    @class = reflection.active_record
+    @reflection = reflection
+  end
+
+  def execute!
+    foreign_types.each do |foreign_type|
+      CounterCacheUpdate::TableUpdatorService.execute!(reflection: @reflection, model_class: foreign_type.constantize)
+    end
+  end
+
+private
+
+  # Returns the class names of those records that has the given polymorphic relationship
+  def foreign_types
+    @reflection.active_record
+      .group(@reflection.foreign_type)
+      .pluck(@reflection.foreign_type)
+  end
+end

data/app/services/counter_cache_update/table_updator_service.rb

@@ -1,9 +1,11 @@
 class CounterCacheUpdate::TableUpdatorService < ServicePattern::Service
   attr_reader :model_class, :reflection
 
-  def initialize(reflection:)
+  def initialize(reflection:, model_class: nil)
     @reflection = reflection
-    @model_class = @reflection.class_name.constantize
+
+    @model_class = model_class
+    @model_class ||= @reflection.class_name.constantize
   end
 
   def execute!
@@ -24,7 +26,9 @@ private
   end
 
   def count_sql
-    "SELECT COUNT(*) FROM #{reflection_table_name} WHERE #{reflection_table_name}.#{relation_foreign_key} = #{table_name}.#{primary_key}"
+    sql = "SELECT COUNT(*) FROM #{reflection_table_name} WHERE #{reflection_table_name}.#{relation_foreign_key} = #{table_name}.#{primary_key}"
+    sql << " AND #{reflection.foreign_type} = #{ActiveRecord::Base.connection.quote(model_class.name)}" if reflection.options[:polymorphic]
+    sql
   end
 
   def primary_key

data/app/services/counter_cache_update/update_service.rb

@@ -26,8 +26,12 @@ private
       model_class.reflections.each do |_name, reflection|
         next unless reflection.macro.to_sym == :belongs_to
         next unless reflection.options[:counter_cache]
-        next if reflection.options[:polymorphic]
-        CounterCacheUpdate::TableUpdatorService.execute!(reflection: reflection)
+
+        if reflection.options[:polymorphic]
+          CounterCacheUpdate::PolymorphicUpdatorService.execute!(reflection: reflection)
+        else
+          CounterCacheUpdate::TableUpdatorService.execute!(reflection: reflection)
+        end
       end
     end
   end

data/lib/counter_cache_update/version.rb

@@ -1,3 +1,3 @@
 module CounterCacheUpdate
-  VERSION = "0.0.3".freeze
+  VERSION = "0.0.4".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: counter_cache_update
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - kaspernj
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.3
+- !ruby/object:Gem::Dependency
+  name: pry-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.3.6
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.3.6
 description: Scans all your models and updates all counter caches with optimised SQL.
 email:
 - kaspernj@gmail.com
@@ -56,6 +70,7 @@ files:
 - app/jobs/counter_cache_update/application_job.rb
 - app/mailers/counter_cache_update/application_mailer.rb
 - app/models/counter_cache_update/application_record.rb
+- app/services/counter_cache_update/polymorphic_updator_service.rb
 - app/services/counter_cache_update/table_updator_service.rb
 - app/services/counter_cache_update/update_service.rb
 - app/views/layouts/counter_cache_update/application.html.erb