counter_cache_update 0.0.1 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 612e3322b4f6660aee4c90461cb98dc2a3b7d9d5
-  data.tar.gz: 83f8c0cec5da605ff621ce17b7a5220660d1d4a5
+SHA256:
+  metadata.gz: 3232bf33791a0d62bd54567cc7b4ba04e38e41e373a0b29b37be33858c8b2c21
+  data.tar.gz: 18d47f91a50f9a16ecfc3a0e795e83600ae5bc0812f04fb60732122467bc7762
 SHA512:
-  metadata.gz: fba1046c4769cf685c3c57d9420cfd28f5ebea989900760304eb859ee4e8bc094f31b0697329ccc1a54acff6f865248eb520e81c68790aa240ddb31229283209
-  data.tar.gz: e55553d1d386bc0ef45091d6fb23815950f0e92475001c8e67d8445ff24742d37a61f66698a27ec1461382dcf1889dfdd3623883edf53d0cde6125067a7589ec
+  metadata.gz: 7a3990b4d98619ae51a57c05095a84f03154970a200d47b6bb5d916eff6dc2eb5bdb67b83853ea2a75399c609286926169c7f99feca9d3bdb2d88752c5072098
+  data.tar.gz: ca5b97db68cd097c97b44aa538acf58706d7b1377a4e2187c4bc16ed6199fa0df554b20ab611a0769db8582922676431bdf59f4f50124aeed5e7b4087d94203c

data/app/services/counter_cache_update/polymorphic_updator_service.rb

@@ -0,0 +1,23 @@
+class CounterCacheUpdate::PolymorphicUpdatorService < ServicePattern::Service
+  def initialize(reflection:)
+    @class = reflection.active_record
+    @reflection = reflection
+  end
+
+  def perform
+    foreign_types.each do |foreign_type|
+      CounterCacheUpdate::TableUpdatorService.execute!(reflection: @reflection, model_class: foreign_type.constantize)
+    end
+
+    succeed!
+  end
+
+private
+
+  # Returns the class names of those records that has the given polymorphic relationship
+  def foreign_types
+    @reflection.active_record
+      .group(@reflection.foreign_type)
+      .pluck(@reflection.foreign_type)
+  end
+end

data/app/services/counter_cache_update/table_updator_service.rb

@@ -1,14 +1,16 @@
 class CounterCacheUpdate::TableUpdatorService < ServicePattern::Service
   attr_reader :model_class, :reflection
 
-  def initialize(reflection:)
+  def initialize(reflection:, model_class: nil)
     @reflection = reflection
-    @model_class = @reflection.class_name.constantize
+
+    @model_class = model_class
+    @model_class ||= @reflection.class_name.constantize
   end
 
-  def execute!
+  def perform
     model_class.connection.execute(sql)
-    ServicePattern::Response.new(success: true)
+    succeed!
   end
 
 private
@@ -24,7 +26,9 @@ private
   end
 
   def count_sql
-    "SELECT COUNT(*) FROM #{reflection_table_name} WHERE #{reflection_table_name}.#{relation_foreign_key} = #{table_name}.#{primary_key}"
+    sql = "SELECT COUNT(*) FROM #{reflection_table_name} WHERE #{reflection_table_name}.#{relation_foreign_key} = #{table_name}.#{primary_key}"
+    sql << " AND #{reflection.foreign_type} = #{ActiveRecord::Base.connection.quote(model_class.name)}" if reflection.options[:polymorphic]
+    sql
   end
 
   def primary_key

data/app/services/counter_cache_update/update_service.rb

@@ -5,7 +5,7 @@ class CounterCacheUpdate::UpdateService < ServicePattern::Service
     @use_progress_bar = use_progress_bar
   end
 
-  def execute!
+  def perform
     Rails.application.eager_load!
 
     if use_progress_bar
@@ -14,7 +14,7 @@ class CounterCacheUpdate::UpdateService < ServicePattern::Service
     end
 
     update_relationships!
-    ServicePattern::Response.new(success: true)
+    succeed!
   end
 
 private
@@ -26,7 +26,12 @@ private
       model_class.reflections.each do |_name, reflection|
         next unless reflection.macro.to_sym == :belongs_to
         next unless reflection.options[:counter_cache]
-        CounterCacheUpdate::TableUpdatorService.execute!(reflection: reflection)
+
+        if reflection.options[:polymorphic]
+          CounterCacheUpdate::PolymorphicUpdatorService.execute!(reflection: reflection)
+        else
+          CounterCacheUpdate::TableUpdatorService.execute!(reflection: reflection)
+        end
       end
     end
   end

data/lib/counter_cache_update/version.rb

@@ -1,3 +1,3 @@
 module CounterCacheUpdate
-  VERSION = "0.0.1".freeze
+  VERSION = "0.0.6".freeze
 end

metadata

@@ -1,43 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: counter_cache_update
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.6
 platform: ruby
 authors:
 - kaspernj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-25 00:00:00.000000000 Z
+date: 2021-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.5
+        version: 5.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.5
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: service_pattern
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: pry-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: tzinfo-data
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Scans all your models and updates all counter caches with optimised SQL.
 email:
 - kaspernj@gmail.com
@@ -56,6 +84,7 @@ files:
 - app/jobs/counter_cache_update/application_job.rb
 - app/mailers/counter_cache_update/application_mailer.rb
 - app/models/counter_cache_update/application_record.rb
+- app/services/counter_cache_update/polymorphic_updator_service.rb
 - app/services/counter_cache_update/table_updator_service.rb
 - app/services/counter_cache_update/update_service.rb
 - app/views/layouts/counter_cache_update/application.html.erb
@@ -76,15 +105,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Scans all your models and updates all counter caches with optimised SQL.