counter-cache 0.0.2 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 005de7af8ad6de2ac4db333a51a0b69037b415da
-  data.tar.gz: 82e11a2ff62767df0275d60e12ef8f6208f76dc3
+  metadata.gz: 65f431cac9a84b8abe458919608c07c66501c68e
+  data.tar.gz: c0582fc1f4d829fc50162ce50746b33fdf06f2c8
 SHA512:
-  metadata.gz: a19850cde42e9e3d8413bc8d2b0f8ab134736c16df4171c788c2cc611363429d6830191d29027084bd93d2466d64dcda731949d2313d0f07311db87faa96dbce
-  data.tar.gz: e90d15bae6c2de8781dcb792e90f9b7f1e40fe4fdbefa7d83b9a5bc91515dbc01ced62ff68f3f3450716f0e23319e845a38767528a8e5b3bd221bcbd72da8460
+  metadata.gz: db21a9548ac98191ddf559ff962c78f221656998efbe5f1a0c2af14e153e7256647fa3f54bc4f00faa8b3d34b9feabd9f94d6f82410805b241eb3384593ba1a9
+  data.tar.gz: 8b4abafb442cbdedef2ddffae83ebc7d71a418dedbef791ad3f963abc7c039b45e44fa8d4d2d992514da60091e8d555932439555c319f33923ac0fc12271f5a4

data/README.md

@@ -109,6 +109,20 @@ class Post
 end
 ```
 
+#### To increment dynamically:
+
+```ruby
+class Review
+  include Counter::Cache
+
+  counter_cache_on column: :reviews_sum,
+                   relation: :product,
+                   relation_class_name: "Product",
+                   increment_by: ->(review) { review.score },
+                   method: :recalculate_reviews_sum, # This is a method on the product.
+end
+```
+
 #### To control when recalculation happens:
 
 ```ruby

data/lib/counter/cache/counters/buffer_counter/updater.rb

@@ -33,11 +33,16 @@ module Counter
           end
 
           def incr
-            redis.incr(key)
+            redis.incr(key, increment_by)
           end
 
           def decr
-            redis.decr(key)
+            redis.decr(key, increment_by)
+          end
+
+          def increment_by
+            return options.increment_by.call(source_object) if options.increment_by.is_a?(Proc)
+            1
           end
 
           def key

data/lib/counter/cache/options_parser.rb

@@ -29,6 +29,10 @@ module Counter
         options[:method]
       end
 
+      def increment_by
+        options[:increment_by]
+      end
+
       def cached?
         option_or_true options[:cache]
       end

data/lib/counter/cache/redis.rb

@@ -1,15 +1,15 @@
 module Counter
   module Cache
     class Redis
-      def incr(key)
+      def incr(key, val = 1)
         with_redis do |redis|
-          redis.incr key
+          redis.incrby key, val
         end
       end
 
-      def decr(key)
+      def decr(key, val = 1)
         with_redis do |redis|
-          redis.decr(key)
+          redis.decrby(key, val)
         end
       end
 

data/lib/counter/cache/version.rb

@@ -1,5 +1,5 @@
 module Counter
   module Cache
-    VERSION = "0.0.2"
+    VERSION = "0.1.0"
   end
 end

data/spec/features/counter_spec.rb

@@ -91,5 +91,12 @@ RSpec.describe "Counting" do
       expect(user.reload.bogus_followed_count).to eq(101)
     end
   end
+
+  describe '#reviews_sum' do
+    it 'increments the user review sum by the review score' do
+      Review.create(score: 4, user: user)
+      expect(user.reload.reviews_sum).to eq(4)
+    end
+  end
 end
 

data/spec/lib/counter/cache/buffer_counter/updater_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe Counter::Cache::Counters::BufferCounter::Updater do
-  let(:options) { double(relation: "boo", relation_class_name: "Boo", column: "boo", relation_id: nil) }
+  let(:options) { double(relation: "boo", relation_class_name: "Boo", column: "boo", relation_id: nil, increment_by: 1) }
   let(:source_object) { double(boo_id: 1) }
   let(:updater) { Counter::Cache::Counters::BufferCounter::Updater.new(source_object, options, "Hello") }
 

data/spec/lib/counter/cache/redis_spec.rb

@@ -16,16 +16,26 @@ RSpec.describe Counter::Cache::Redis do
 
   describe '#decr' do
     it 'calls decr on redis with the key' do
-      expect(redis).to receive(:decr).with("hello")
+      expect(redis).to receive(:decrby).with("hello", 1)
       helper.decr("hello")
     end
+
+    it 'calls decr on redis with the key and increment value' do
+      expect(redis).to receive(:decrby).with("hello", 2)
+      helper.decr("hello", 2)
+    end
   end
 
   describe '#incr' do
     it 'calls incr on redis with the key' do
-      expect(redis).to receive(:incr).with("hello")
+      expect(redis).to receive(:incrby).with("hello", 1)
       helper.incr("hello")
     end
+
+    it 'calls incr on redis with the key and increment value' do
+      expect(redis).to receive(:incrby).with("hello", 2)
+      helper.incr("hello", 2)
+    end
   end
 
   describe '#del' do

data/spec/support/models.rb

@@ -12,6 +12,7 @@ class CreateModelsForTest < ActiveRecord::Migration
       t.integer :followers_count, :default => 0
       t.integer :users_i_follow_count, :default => 0
       t.integer :bogus_followed_count, :default => 0
+      t.integer :reviews_sum, :default => 0
     end
 
     create_table :follows do |t|
@@ -24,17 +25,24 @@ class CreateModelsForTest < ActiveRecord::Migration
       t.string :body
       t.belongs_to :user
     end
+
+    create_table :reviews do |t|
+      t.integer :score
+      t.belongs_to :user
+    end
   end
 
   def self.down
     drop_table(:users)
     drop_table(:posts)
     drop_table(:follows)
+    drop_table(:reviews)
   end
 end
 
 class User < ActiveRecord::Base
   has_many :posts
+  has_many :reviews
 
   def calculate_posts_count
     posts.count
@@ -85,3 +93,15 @@ class Post < ActiveRecord::Base
                    relation_class_name: "User",
                    recalculation: false
 end
+
+class Review < ActiveRecord::Base
+  belongs_to :user
+
+  include Counter::Cache
+
+  counter_cache_on column: :reviews_sum,
+    relation: :user,
+    increment_by: ->(review) { review.score },
+    recalculation: false
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter-cache
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Paul Henry & Matt Camuto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-28 00:00:00.000000000 Z
+date: 2015-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -207,7 +207,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Counting is hard.
@@ -227,4 +227,3 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/models.rb
 - spec/support/worker_adapter.rb
-has_rdoc: