couchrest_model 1.1.2 → 1.2.0.beta

data/spec/unit/designs_spec.rb

@@ -1,6 +1,8 @@
 require "spec_helper"
 
 class DesignModel < CouchRest::Model::Base
+  use_database DB
+  property :name
 end
 
 describe CouchRest::Model::Designs do
@@ -12,26 +14,89 @@ describe CouchRest::Model::Designs do
   describe "class methods" do
 
     describe ".design" do
-      before :each do 
-        @mapper = mock('DesignMapper')
-        @mapper.stub!(:create_view_method)
+
+      before :each do
+        @klass = DesignModel.dup
       end
 
-      it "should instantiate a new DesignMapper" do
-        CouchRest::Model::Designs::DesignMapper.should_receive(:new).with(DesignModel).and_return(@mapper)
-        @mapper.should_receive(:create_view_method).with(:all)
-        @mapper.should_receive(:instance_eval)
-        DesignModel.design() { }
+      describe "without block" do
+        it "should create design_doc and all methods" do
+          @klass.design
+          @klass.should respond_to(:design_doc)
+          @klass.should respond_to(:all)
+        end
+
+        it "should created named design_doc method and not all" do
+          @klass.design :stats
+          @klass.should respond_to(:stats_design_doc)
+          @klass.should_not respond_to(:all)
+        end
+
+        it "should have added itself to a design_blocks array" do
+          @klass.design
+          blocks = @klass.instance_variable_get(:@_design_blocks)
+          blocks.length.should eql(1)
+          blocks.first.should eql({:args => [nil], :block => nil})
+        end
+
+        it "should have added itself to a design_blocks array" do
+          @klass.design
+          blocks = @klass.instance_variable_get(:@_design_blocks)
+          blocks.length.should eql(1)
+          blocks.first.should eql({:args => [nil], :block => nil})
+        end
+
+        it "should have added itself to a design_blocks array with prefix" do
+          @klass.design :stats
+          blocks = @klass.instance_variable_get(:@_design_blocks)
+          blocks.length.should eql(1)
+          blocks.first.should eql({:args => [:stats], :block => nil})
+        end
+      end
+
+      describe "with block" do
+        before :each do
+          @block = Proc.new do
+            disable_auto_update
+          end
+          @klass.design &@block
+        end
+
+        it "should pass calls to mapper" do
+          @klass.design_doc.auto_update.should be_false
+        end
+
+        it "should have added itself to a design_blocks array" do
+          blocks = @klass.instance_variable_get(:@_design_blocks)
+          blocks.length.should eql(1)
+          blocks.first.should eql({:args => [nil], :block => @block})
+        end
+
+        it "should handle multiple designs" do
+          @block2 = Proc.new do
+            view :by_name
+          end
+          @klass.design :stats, &@block2
+          blocks = @klass.instance_variable_get(:@_design_blocks)
+          blocks.length.should eql(2)
+          blocks.first.should eql({:args => [nil], :block => @block})
+          blocks.last.should eql({:args => [:stats], :block => @block2})
+        end
       end
 
-      it "should allow methods to be called in mapper" do
-        @mapper.should_receive(:foo)
-        CouchRest::Model::Designs::DesignMapper.stub!(:new).and_return(@mapper)
-        DesignModel.design { foo }
+    end
+
+    describe "inheritance" do
+      before :each do
+        klass = DesignModel.dup
+        klass.design do
+          view :by_name
+        end
+        @klass = Class.new(klass)
       end
 
-      it "should work even if a block is not provided" do
-        lambda { DesignModel.design }.should_not raise_error
+      it "should add designs to sub module" do
+        @klass.should respond_to(:design_doc)
       end
 
     end
@@ -51,14 +116,85 @@ describe CouchRest::Model::Designs do
   end
 
   describe "DesignMapper" do
-    
+
     before :all do
       @klass = CouchRest::Model::Designs::DesignMapper
     end
 
-    it "should initialize and set model" do
-      object = @klass.new(DesignModel)
-      object.send(:model).should eql(DesignModel)
+    describe 'initialize without prefix' do
+
+      before :all do
+        @object = @klass.new(DesignModel)
+      end
+
+      it "should set basic variables" do
+        @object.send(:model).should eql(DesignModel)
+        @object.send(:prefix).should be_nil
+        @object.send(:method).should eql('design_doc')
+      end
+
+      it "should add design doc to list" do
+        @object.model.design_docs.should include(@object.model.design_doc)
+      end
+
+      it "should create a design doc method" do
+        @object.model.should respond_to('design_doc')
+        @object.design_doc.should eql(@object.model.design_doc)
+      end
+
+      it "should use default for autoupdate" do
+        @object.design_doc.auto_update.should be_true
+      end
+
+    end
+
+    describe 'initialize with prefix' do
+      before :all do
+        @object = @klass.new(DesignModel, 'stats')
+      end
+
+      it "should set basics" do
+        @object.send(:model).should eql(DesignModel)
+        @object.send(:prefix).should eql('stats')
+        @object.send(:method).should eql('stats_design_doc')
+      end
+
+      it "should add design doc to list" do
+        @object.model.design_docs.should include(@object.model.stats_design_doc)
+      end
+
+      it "should not create an all method" do
+        @object.model.should_not respond_to('all')
+      end
+
+      it "should create a design doc method" do
+        @object.model.should respond_to('stats_design_doc')
+        @object.design_doc.should eql(@object.model.stats_design_doc)
+      end
+
+    end
+
+    describe "#disable_auto_update" do
+      it "should disable auto updates" do
+        @object = @klass.new(DesignModel)
+        @object.disable_auto_update
+        @object.design_doc.auto_update.should be_false
+      end
+    end
+
+    describe "#enable_auto_update" do
+      it "should enable auto updates" do
+        @object = @klass.new(DesignModel)
+        @object.enable_auto_update
+        @object.design_doc.auto_update.should be_true
+      end
+    end
+
+    describe "#model_type_key" do
+      it "should return models type key" do
+        @object = @klass.new(DesignModel)
+        @object.model_type_key.should eql(@object.model.model_type_key)
+      end
     end
 
     describe "#view" do
@@ -68,22 +204,20 @@ describe CouchRest::Model::Designs do
       end
 
       it "should call create method on view" do
-        CouchRest::Model::Designs::View.should_receive(:create).with(DesignModel, 'test', {})
+        CouchRest::Model::Designs::View.should_receive(:define).with(@object.design_doc, 'test', {})
         @object.view('test')
       end
 
       it "should create a method on parent model" do
-        CouchRest::Model::Designs::View.stub!(:create)
+        CouchRest::Model::Designs::View.stub!(:define)
         @object.view('test_view')
         DesignModel.should respond_to(:test_view)
       end
 
       it "should create a method for view instance" do
-        CouchRest::Model::Designs::View.stub!(:create)
-        @object.should_receive(:create_view_method).with('test')
+        @object.design_doc.should_receive(:create_view).with('test', {})
         @object.view('test')
       end
-
     end
 
     describe "#filter" do
@@ -97,22 +231,199 @@ describe CouchRest::Model::Designs do
         DesignModel.design_doc['filters'].should_not be_empty
         DesignModel.design_doc['filters']['important'].should_not be_blank
       end
+    end
 
+  end
+
+
+  class DesignsNoAutoUpdate < CouchRest::Model::Base
+    use_database DB
+    property :title, String
+    design do
+      disable_auto_update
+      view :by_title_fail, :by => ['title']
+      view :by_title, :reduce => true
     end
+  end
 
-    describe "#create_view_method" do
-      before :each do
-        @object = @klass.new(DesignModel)
+  describe "Scenario testing" do
+
+    describe "with auto update disabled" do
+
+      before :all do
+        reset_test_db!
+        @mod = DesignsNoAutoUpdate
+      end
+
+      before(:all) do
+        id = @mod.to_s
+        doc = CouchRest::Document.new("_id" => "_design/#{id}")
+        doc["language"] = "javascript"
+        doc["views"] = {"all"     => {"map" => "function(doc) { if (doc['type'] == '#{id}') { emit(doc['_id'],1); } }"},
+                        "by_title" => {"map" => 
+                                  "function(doc) {
+                                     if ((doc['type'] == '#{id}') && (doc['title'] != null)) {
+                                       emit(doc['title'], 1);
+                                     }
+                                   }", "reduce" => "function(k,v,r) { return sum(v); }"}}
+        DB.save_doc doc
+      end
+
+      it "will fail if reduce is not specific in view" do
+        @mod.create(:title => 'This is a test')
+        lambda { @mod.by_title_fail.first }.should raise_error(RestClient::ResourceNotFound)
       end
 
-      it "should create a method that returns view instance" do
-        CouchRest::Model::Designs::View.should_receive(:new).with(DesignModel, {}, 'test_view').and_return(nil)
-        @object.create_view_method('test_view')
-        DesignModel.test_view
+      it "will perform view request" do
+        @mod.create(:title => 'This is a test')
+        @mod.by_title.first.title.should eql("This is a test")
       end
 
     end
 
+    describe "using views" do
+
+      describe "to find a single item" do
+  
+        before(:all) do
+          reset_test_db!
+          %w{aaa bbb ddd eee}.each do |title|
+            Course.new(:title => title, :active => (title == 'bbb')).save
+          end
+        end
+
+        it "should return single matched record with find helper" do
+          course = Course.find_by_title('bbb')
+          course.should_not be_nil
+          course.title.should eql('bbb') # Ensure really is a Course!
+        end
+
+        it "should return nil if not found" do
+          course = Course.find_by_title('fff')
+          course.should be_nil
+        end
+
+        it "should peform search on view with two properties" do
+          course = Course.find_by_title_and_active(['bbb', true])
+          course.should_not be_nil
+          course.title.should eql('bbb') # Ensure really is a Course!
+        end
+
+        it "should return nil if not found" do
+          course = Course.find_by_title_and_active(['bbb', false])
+          course.should be_nil
+        end
+
+        it "should raise exception if view not present" do
+          lambda { Course.find_by_foobar('123') }.should raise_error(NoMethodError)
+        end
+
+      end
+
+      describe "a model class with database provided manually" do
+
+        class Unattached < CouchRest::Model::Base
+          property :title
+          property :questions
+          property :professor
+          design do
+            view :by_title
+          end
+
+          # Force the database to always be nil
+          def self.database
+            nil
+          end
+        end
+
+        before(:all) do
+          reset_test_db!
+          @db = DB 
+          %w{aaa bbb ddd eee}.each do |title|
+            u = Unattached.new(:title => title)
+            u.database = @db
+            u.save
+            @first_id ||= u.id
+          end
+        end
+        it "should barf on all if no database given" do
+          lambda{Unattached.all.first}.should raise_error
+        end
+        it "should query all" do
+          rs = Unattached.all.database(@db).all
+          rs.length.should == 4
+        end
+        it "should barf on query if no database given" do
+          lambda{Unattached.by_title.all}.should raise_error /Database must be defined/
+        end
+        it "should make the design doc upon first query" do
+          Unattached.by_title.database(@db)
+          doc = Unattached.design_doc
+          doc['views']['all']['map'].should include('Unattached')
+        end
+        it "should merge query params" do
+          rs = Unattached.by_title.database(@db).startkey("bbb").endkey("eee")
+          rs.length.should == 3
+        end
+        it "should return nil on get if no database given" do
+          Unattached.get("aaa").should be_nil
+        end
+        it "should barf on get! if no database given" do
+          lambda{Unattached.get!("aaa")}.should raise_error
+        end
+        it "should get from specific database" do
+          u = Unattached.get(@first_id, @db)
+          u.title.should == "aaa"
+        end
+        it "should barf on first if no database given" do
+          lambda{Unattached.first}.should raise_error
+        end
+        it "should get first" do
+          u = Unattached.all.database(@db).first
+          u.title.should =~ /\A...\z/
+        end
+        it "should get last" do
+          u = Unattached.all.database(@db).last
+          u.title.should == "aaa"
+        end
+
+      end
+
+      describe "a model with a compound key view" do
+        before(:all) do
+          reset_test_db!
+          written_at = Time.now - 24 * 3600 * 7
+          @titles    = ["uniq one", "even more interesting", "less fun", "not junk"]
+          @user_ids  = ["quentin", "aaron"]
+          @titles.each_with_index do |title,i|
+            u = i % 2
+            a = Article.new(:title => title, :user_id => @user_ids[u])
+            a.date = written_at
+            a.save
+            written_at += 24 * 3600
+          end
+        end
+        it "should create the design doc" do
+          Article.by_user_id_and_date rescue nil
+          doc = Article.design_doc
+          doc['views']['by_date'].should_not be_nil
+        end
+        it "should sort correctly" do
+          articles = Article.by_user_id_and_date.all
+          articles.collect{|a|a['user_id']}.should == ['aaron', 'aaron', 'quentin', 
+            'quentin']
+          articles[1].title.should == 'not junk'
+        end
+        it "should be queryable with couchrest options" do
+          articles = Article.by_user_id_and_date(:limit => 1, :startkey => 'quentin').all
+          articles.length.should == 1
+          articles[0].title.should == "even more interesting"
+        end
+      end
+
+
+    end
+
   end
 
 end

data/spec/unit/dirty_spec.rb

@@ -99,6 +99,32 @@ describe "Dirty" do
       @card.first_name_changed?.should be_true
     end
 
+    it 'should report changes if the record is modified by attributes' do
+      @card = Card.new
+      @card.attributes = {:first_name => 'danny'}
+      @card.changed?.should be_true
+      @card.first_name_changed?.should be_true
+    end
+
+    it 'should report no changes if the record is modified with an invalid property by attributes' do
+      @card = Card.new
+      @card.attributes = {:middle_name => 'danny'}
+      @card.changed?.should be_false
+      @card.first_name_changed?.should be_false
+    end
+
+    it "should report no changes if the record is modified with update_attributes" do
+      @card = Card.new
+      @card.update_attributes(:first_name => 'henry')
+      @card.changed?.should be_false
+    end
+
+    it "should report no changes if the record is modified with an invalid property by update_attributes" do
+      @card = Card.new
+      @card.update_attributes(:middle_name => 'peter')
+      @card.changed?.should be_false
+    end
+
     it "should report no changes for unmodified records" do
       card_id = Card.create!(:first_name => "matt").id
       @card = Card.find(card_id)
@@ -433,4 +459,45 @@ describe "Dirty" do
 
   end
 
+
+  describe "when mass_assign_any_attribute true" do
+    before(:each) do
+      # dupe Card class so that no other tests are effected
+      card_class = Card.dup
+      card_class.class_eval do
+        mass_assign_any_attribute true
+      end
+      @card = card_class.new(:first_name => 'Sam')
+    end
+
+    it "should report no changes if the record is modified with update_attributes" do
+      @card.update_attributes(:other_name => 'henry')
+      @card.changed?.should be_false
+    end
+
+    it "should report not new if the record is modified with update_attributes" do
+      @card.update_attributes(:other_name => 'henry')
+      @card.new?.should be_false
+    end
+
+    it 'should report changes when updated with attributes' do
+      @card.save
+      @card.attributes = {:testing => 'fooobar'}
+      @card.changed?.should be_true
+    end
+
+    it 'should report changes when updated with a known property' do
+      @card.save
+      @card.first_name = 'Danny'
+      @card.changed?.should be_true
+    end
+
+    it "should not report changes if property is updated with same value" do
+      @card.update_attributes :testing => 'fooobar'
+      @card.attributes = {'testing' => 'fooobar'}
+      @card.changed?.should be_false
+    end
+
+  end
+
 end

data/spec/unit/inherited_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 class PlainParent
-  class_inheritable_accessor :foo
+  class_attribute :foo
   self.foo = :bar
 end
 
@@ -9,7 +9,7 @@ class PlainChild < PlainParent
 end
 
 class ExtendedParent < CouchRest::Model::Base
-  class_inheritable_accessor :foo
+  class_attribute :foo
   self.foo = :bar
 end
 

data/spec/unit/property_protection_spec.rb

@@ -150,7 +150,9 @@ describe "Model Attributes" do
       use_database TEST_SERVER.default_database
       property :name
       property :admin, :default => false, :protected => true
-      view_by :name
+      design do
+        view :by_name
+      end
     end
 
     before(:each) do

data/spec/unit/property_spec.rb

@@ -148,6 +148,26 @@ describe CouchRest::Model::Property do
         @card['test'].should be_nil
       end
 
+     it 'should not allow them to be updated with update_attributes' do
+       @card.update_attributes(:test => 'fooobar')
+       @card['test'].should be_nil
+     end
+
+     it 'should not have a different revision after update_attributes' do
+       @card.save
+       rev = @card.rev
+       @card.update_attributes(:test => 'fooobar')
+       @card.rev.should eql(rev)
+     end
+
+     it 'should not have a different revision after save' do
+       @card.save
+       rev = @card.rev
+       @card.attributes = {:test => 'fooobar'}
+       @card.save
+       @card.rev.should eql(rev)
+     end
+
     end
 
     describe "when mass_assign_any_attribute true" do
@@ -161,13 +181,33 @@ describe CouchRest::Model::Property do
       end
 
       it 'should allow them to be updated' do
-        @card.attributes = {:test => 'fooobar'}
-        @card['test'].should eql('fooobar')
+        @card.attributes = {:testing => 'fooobar'}
+        @card['testing'].should eql('fooobar')
+      end
+
+      it 'should allow them to be updated with update_attributes' do
+        @card.update_attributes(:testing => 'fooobar')
+        @card['testing'].should eql('fooobar')
       end
+
+      it 'should have a different revision after update_attributes' do
+        @card.save
+        rev = @card.rev
+        @card.update_attributes(:testing => 'fooobar')
+        @card.rev.should_not eql(rev)
+      end
+
+      it 'should have a different revision after save' do
+        @card.save
+        rev = @card.rev
+        @card.attributes = {:testing => 'fooobar'}
+        @card.save
+        @card.rev.should_not eql(rev)
+      end
+
     end
   end
 
-
   describe "mass assignment protection" do
 
     it "should not store protected attribute using mass assignment" do