couchrest_model 1.0.0.beta8 → 1.0.0

data/spec/couchrest/casted_model_spec.rb

@@ -31,11 +31,11 @@ class WithCastedCallBackModel < Hash
   property :name
   property :run_before_validate
   property :run_after_validate
-  
+
   before_validate do |object|
     object.run_before_validate = true
   end
-  after_validate do |object| 
+  after_validate do |object|
     object.run_after_validate = true
   end
 end
@@ -47,7 +47,7 @@ class CastedCallbackDoc < CouchRest::Model::Base
 end
 
 describe CouchRest::Model::CastedModel do
-  
+
   describe "A non hash class including CastedModel" do
     it "should fail raising and include error" do
       lambda do
@@ -55,27 +55,27 @@ describe CouchRest::Model::CastedModel do
           include CouchRest::CastedModel
           property :name
         end
-        
+
       end.should raise_error
     end
   end
-  
+
   describe "isolated" do
     before(:each) do
       @obj = WithCastedModelMixin.new
     end
     it "should automatically include the property mixin and define getters and setters" do
       @obj.name = 'Matt'
-      @obj.name.should == 'Matt' 
+      @obj.name.should == 'Matt'
     end
-    
+
     it "should allow override of default" do
       @obj = WithCastedModelMixin.new(:name => 'Eric', :details => {'color' => 'orange'})
       @obj.name.should == 'Eric'
       @obj.details['color'].should == 'orange'
     end
   end
-  
+
   describe "casted as an attribute, but without a value" do
     before(:each) do
       @obj = DummyModel.new
@@ -99,22 +99,22 @@ describe CouchRest::Model::CastedModel do
       @obj.sub_models.first.title.should eql('test')
     end
   end
-  
+
   describe "casted as attribute" do
     before(:each) do
       casted = {:name => 'not whatever'}
       @obj = DummyModel.new(:casted_attribute => {:name => 'whatever', :casted_attribute => casted})
       @casted_obj = @obj.casted_attribute
     end
-    
+
     it "should be available from its parent" do
       @casted_obj.should be_an_instance_of(WithCastedModelMixin)
     end
-    
+
     it "should have the getters defined" do
       @casted_obj.name.should == 'whatever'
     end
-    
+
     it "should know who casted it" do
       @casted_obj.casted_by.should == @obj
     end
@@ -126,27 +126,32 @@ describe CouchRest::Model::CastedModel do
     it "should return nil for the unknown attribute" do
       @casted_obj["unknown"].should be_nil
     end
-    
+
     it "should return {} for the hash attribute" do
       @casted_obj.details.should == {}
     end
-    
+
     it "should cast its own attributes" do
       @casted_obj.casted_attribute.should be_instance_of(WithCastedModelMixin)
     end
+
+    it "should raise an error if save or update_attributes called" do
+      expect { @casted_obj.casted_attribute.save }.to raise_error(NoMethodError)
+      expect { @casted_obj.casted_attribute.update_attributes(:name => "Fubar") }.to raise_error(NoMethodError)
+    end
   end
-  
+
   describe "casted as an array of a different type" do
     before(:each) do
       @obj = DummyModel.new(:keywords => ['couch', 'sofa', 'relax', 'canapé'])
     end
-    
+
     it "should cast the array properly" do
       @obj.keywords.should be_an_instance_of(Array)
       @obj.keywords.first.should == 'couch'
     end
   end
-  
+
   describe "update attributes without saving" do
     before(:each) do
       @question = Question.new(:q => "What is your quest?", :a => "To seek the Holy Grail")
@@ -158,20 +163,20 @@ describe CouchRest::Model::CastedModel do
       @question['q'].should == "What is your favorite color?"
       @question.a.should == "Blue"
     end
-    
+
     it "should also work for attributes= alias" do
       @question.respond_to?(:attributes=).should be_true
       @question.attributes = {:q => "What is your favorite color?", 'a' => "Blue"}
       @question['q'].should == "What is your favorite color?"
       @question.a.should == "Blue"
     end
-    
+
     it "should flip out if an attribute= method is missing" do
       lambda {
         @q.update_attributes_without_saving('foo' => "something", :a => "No green")
       }.should raise_error(NoMethodError)
     end
-    
+
     it "should not change any attributes if there is an error" do
       lambda {
         @q.update_attributes_without_saving('foo' => "something", :a => "No green")
@@ -179,8 +184,9 @@ describe CouchRest::Model::CastedModel do
       @question.q.should == "What is your quest?"
       @question.a.should == "To seek the Holy Grail"
     end
+
   end
-  
+
   describe "saved document with casted models" do
     before(:each) do
       reset_test_db!
@@ -188,24 +194,24 @@ describe CouchRest::Model::CastedModel do
       @obj.save.should be_true
       @obj = DummyModel.get(@obj.id)
     end
-    
+
     it "should be able to load with the casted models" do
       casted_obj = @obj.casted_attribute
       casted_obj.should_not be_nil
       casted_obj.should be_an_instance_of(WithCastedModelMixin)
     end
-    
+
     it "should have defined getters for the casted model" do
       casted_obj = @obj.casted_attribute
       casted_obj.name.should == "whatever"
     end
-    
+
     it "should have defined setters for the casted model" do
       casted_obj = @obj.casted_attribute
       casted_obj.name = "test"
       casted_obj.name.should == "test"
     end
-    
+
     it "should retain an override of a casted model attribute's default" do
       casted_obj = @obj.casted_attribute
       casted_obj.details['color'] = 'orange'
@@ -213,7 +219,7 @@ describe CouchRest::Model::CastedModel do
       casted_obj = DummyModel.get(@obj.id).casted_attribute
       casted_obj.details['color'].should == 'orange'
     end
-    
+
   end
 
   describe "saving document with array of casted models and validation" do
@@ -238,7 +244,7 @@ describe CouchRest::Model::CastedModel do
       @cat.should_not be_valid
       @cat.save.should be_false
     end
-    
+
     it "should not fail if the casted model doesn't have validation" do
       Cat.property :masters, [Person], :default => []
       Cat.validates_presence_of :name
@@ -248,7 +254,7 @@ describe CouchRest::Model::CastedModel do
       cat.should be_valid
     end
   end
-  
+
   describe "calling valid?" do
     before :each do
       @cat = Cat.new
@@ -259,7 +265,7 @@ describe CouchRest::Model::CastedModel do
       @cat.toys << @toy2
       @cat.toys << @toy3
     end
-    
+
     describe "on the top document" do
       it "should put errors on all invalid casted models" do
         @cat.should_not be_valid
@@ -268,10 +274,10 @@ describe CouchRest::Model::CastedModel do
         @toy2.errors.should_not be_empty
         @toy3.errors.should_not be_empty
       end
-      
+
       it "should not put errors on valid casted models" do
         @toy1.name = "Feather"
-        @toy2.name = "Twine" 
+        @toy2.name = "Twine"
         @cat.should_not be_valid
         @cat.errors.should_not be_empty
         @toy1.errors.should be_empty
@@ -279,7 +285,7 @@ describe CouchRest::Model::CastedModel do
         @toy3.errors.should_not be_empty
       end
     end
-    
+
     describe "on a casted model property" do
       it "should only validate itself" do
         @toy1.should_not be_valid
@@ -289,7 +295,7 @@ describe CouchRest::Model::CastedModel do
         @toy3.errors.should be_empty
       end
     end
-    
+
     describe "on a casted model inside a casted collection" do
       it "should only validate itself" do
         @toy2.should_not be_valid
@@ -300,7 +306,7 @@ describe CouchRest::Model::CastedModel do
       end
     end
   end
-  
+
   describe "calling new? on a casted model" do
     before :each do
       reset_test_db!
@@ -309,18 +315,18 @@ describe CouchRest::Model::CastedModel do
       @cat.favorite_toy = @favorite_toy
       @cat.toys << CatToy.new(:name => 'Fuzzy Stick')
     end
-    
+
     it "should be true on new" do
       CatToy.new.should be_new
       CatToy.new.new_record?.should be_true
     end
-    
+
     it "should be true after assignment" do
       @cat.should be_new
       @cat.favorite_toy.should be_new
       @cat.toys.first.should be_new
     end
-    
+
     it "should not be true after create or save" do
       @cat.create
       @cat.save
@@ -328,14 +334,14 @@ describe CouchRest::Model::CastedModel do
       @cat.toys.first.casted_by.should eql(@cat)
       @cat.toys.first.should_not be_new
     end
-    
+
     it "should not be true after get from the database" do
       @cat.save
       @cat = Cat.get(@cat.id)
       @cat.favorite_toy.should_not be_new
       @cat.toys.first.should_not be_new
     end
-    
+
     it "should still be true after a failed create or save" do
       @cat.name = nil
       @cat.create.should be_false
@@ -344,7 +350,7 @@ describe CouchRest::Model::CastedModel do
       @cat.toys.first.should be_new
     end
   end
-  
+
   describe "calling base_doc from a nested casted model" do
     before :each do
       @course = Course.new(:title => 'Science 101')
@@ -357,7 +363,15 @@ describe CouchRest::Model::CastedModel do
       @cat.favorite_toy = @toy1
       @cat.toys << @toy2
     end
-    
+
+    it 'should let you copy over casted arrays' do
+      question = Question.new
+      @course.questions << question
+      new_course = Course.new
+      new_course.questions = @course.questions
+      new_course.questions.should include(question)
+    end
+
     it "should reference the top document for" do
       @course.base_doc.should === @course
       @professor.casted_by.should === @course
@@ -366,19 +380,19 @@ describe CouchRest::Model::CastedModel do
       @toy1.base_doc.should === @course
       @toy2.base_doc.should === @course
     end
-    
+
     it "should call setter on top document" do
       @toy1.base_doc.should_not be_nil
       @toy1.base_doc.title = 'Tom Foolery'
       @course.title.should == 'Tom Foolery'
     end
-    
+
     it "should return nil if not yet casted" do
       person = Person.new
       person.base_doc.should == nil
     end
   end
-  
+
   describe "calling base_doc.save from a nested casted model" do
     before :each do
       reset_test_db!
@@ -386,13 +400,13 @@ describe CouchRest::Model::CastedModel do
       @toy = CatToy.new
       @cat.favorite_toy = @toy
     end
-    
+
     it "should not save parent document when casted model is invalid" do
       @toy.should_not be_valid
       @toy.base_doc.save.should be_false
       lambda{@toy.base_doc.save!}.should raise_error
     end
-    
+
     it "should save parent document when nested casted model is valid" do
       @toy.name = "Mr Squeaks"
       @toy.should be_valid
@@ -400,14 +414,14 @@ describe CouchRest::Model::CastedModel do
       lambda{@toy.base_doc.save!}.should_not raise_error
     end
   end
-  
+
   describe "callbacks" do
     before(:each) do
       @doc = CastedCallbackDoc.new
       @model = WithCastedCallBackModel.new
       @doc.callback_model = @model
     end
-    
+
     describe "validate" do
       it "should run before_validate before validating" do
         @model.run_before_validate.should be_nil
@@ -418,7 +432,7 @@ describe CouchRest::Model::CastedModel do
         @model.run_after_validate.should be_nil
         @model.should be_valid
         @model.run_after_validate.should be_true
-      end      
+      end
     end
   end
 end

data/spec/couchrest/class_proxy_spec.rb

@@ -87,6 +87,12 @@ describe "Proxy Class" do
     u = @us.first
     u.title.should =~ /\A...\z/
   end
+  
+  it "should get last" do
+    u = @us.last
+    u.title.should == "aaa"
+  end
+  
   it "should set database on first retreived document" do
     u = @us.first
     u.database.should === DB

data/spec/couchrest/configuration_spec.rb

@@ -0,0 +1,78 @@
+# encoding: utf-8
+require File.expand_path('../../spec_helper', __FILE__)
+require File.join(FIXTURE_PATH, 'more', 'cat')
+
+describe CouchRest::Model::Base do
+
+  before do
+    @class = Class.new(CouchRest::Model::Base)
+  end
+
+  describe '.configure' do
+    it "should set a configuration parameter" do
+      @class.add_config :foo_bar
+      @class.configure do |config|
+        config.foo_bar = 'monkey'
+      end
+      @class.foo_bar.should == 'monkey'
+    end
+  end
+
+  describe '.add_config' do
+    
+    it "should add a class level accessor" do
+      @class.add_config :foo_bar
+      @class.foo_bar = 'foo'
+      @class.foo_bar.should == 'foo'
+    end
+    
+    ['foo', :foo, 45, ['foo', :bar]].each do |val|
+      it "should be inheritable for a #{val.class}" do
+        @class.add_config :foo_bar
+        @child_class = Class.new(@class)
+
+        @class.foo_bar = val
+        @class.foo_bar.should == val
+        @child_class.foo_bar.should == val
+
+        @child_class.foo_bar = "bar"
+        @child_class.foo_bar.should == "bar"
+
+        @class.foo_bar.should == val
+      end
+    end
+    
+    
+    it "should add an instance level accessor" do
+      @class.add_config :foo_bar
+      @class.foo_bar = 'foo'
+      @class.new.foo_bar.should == 'foo'
+    end
+    
+    it "should add a convenient in-class setter" do
+      @class.add_config :foo_bar
+      @class.foo_bar "monkey"
+      @class.foo_bar.should == "monkey"
+    end
+  end
+
+  describe "General examples" do
+
+    before(:all) do
+      @default_model_key = 'model'
+    end
+
+
+    it "should be possible to override on class using configure method" do
+      default_model_key = Cat.model_type_key
+      Cat.instance_eval do
+        model_type_key 'cat-type'
+      end
+      CouchRest::Model::Base.model_type_key.should eql(default_model_key)
+      Cat.model_type_key.should eql('cat-type')
+      cat = Cat.new
+      cat.model_type_key.should eql('cat-type')
+    end
+  end
+
+end

data/spec/couchrest/persistence_spec.rb

@@ -25,7 +25,7 @@ describe "Model Persistence" do
     end
 
     it "should instantialize document of different type" do
-      doc = Article.create_from_database({'_id' => 'testitem2', '_rev' => 123, 'couchrest-type' => 'WithTemplateAndUniqueID', 'name' => 'my test'})
+      doc = Article.create_from_database({'_id' => 'testitem2', '_rev' => 123, Article.model_type_key => 'WithTemplateAndUniqueID', 'name' => 'my test'})
       doc.class.should eql(WithTemplateAndUniqueID)
     end
 
@@ -114,7 +114,7 @@ describe "Model Persistence" do
     end
     
     it "should set the type" do
-      @sobj['couchrest-type'].should == 'Basic'
+      @sobj[@sobj.model_type_key].should == 'Basic'
     end
 
     it "should accept true or false on save for validation" do
@@ -282,11 +282,17 @@ describe "Model Persistence" do
       foundart = Article.get 'matt aimonetti'
       foundart.should be_nil
     end                     
+    it "should return nil if a blank id is requested" do
+      Article.get("").should be_nil
+    end
     it "should raise an error if `get!` is used and the document doesn't exist" do
-       lambda{foundart = Article.get!('matt aimonetti')}.should raise_error
+      expect{ Article.get!('matt aimonetti') }.to raise_error
+    end
+    it "should raise an error if `get!` is requested with a blank id" do
+      expect{ Article.get!("") }.to raise_error
     end
     it "should raise an error if `find!` is used and the document doesn't exist" do
-       lambda{foundart = Article.find!('matt aimonetti')}.should raise_error
+      expect{ Article.find!('matt aimonetti') }.to raise_error
     end
   end
 

data/spec/couchrest/{attribute_protection_spec.rb → property_protection_spec.rb}

@@ -34,6 +34,12 @@ describe "Model Attributes" do
       user.name.should == "will"
       user.phone.should == "555-5555"
     end
+
+    it "should provide a list of all properties as accessible" do
+      user = NoProtection.new(:name => "will", :phone => "555-5555")
+      user.accessible_properties.length.should eql(2)
+      user.protected_properties.should be_empty
+    end
   end
 
   describe "Model Base", "accessible flag" do
@@ -65,6 +71,12 @@ describe "Model Attributes" do
       user.name.should == "will"
       user.admin.should == false
     end
+    
+    it "should provide correct accessible and protected property lists" do
+      user = WithAccessible.new(:name => 'will', :admin => true)
+      user.accessible_properties.map{|p| p.to_s}.should eql(['name'])
+      user.protected_properties.map{|p| p.to_s}.should eql(['admin'])
+    end
   end
 
   describe "Model Base", "protected flag" do
@@ -96,6 +108,21 @@ describe "Model Attributes" do
       user.name.should == "will"
       user.admin.should == false
     end
+
+    it "should not modify the provided attribute hash" do
+      user = WithProtected.new
+      attrs = {:name => "will", :admin => true}
+      user.attributes = attrs
+      attrs[:admin].should be_true
+      attrs[:name].should eql('will')
+    end
+
+    it "should provide correct accessible and protected property lists" do
+      user = WithProtected.new(:name => 'will', :admin => true)
+      user.accessible_properties.map{|p| p.to_s}.should eql(['name'])
+      user.protected_properties.map{|p| p.to_s}.should eql(['admin'])
+    end
+
   end
 
   describe "Model Base", "mixing protected and accessible flags" do
@@ -107,7 +134,6 @@ describe "Model Attributes" do
     end
 
     it { expect { WithBothAndUnspecified.new }.to_not raise_error }
-    it { expect { WithBothAndUnspecified.new(nil) }.to_not raise_error }
 
     it 'should assume that any unspecified property is protected by default' do
       user = WithBothAndUnspecified.new(:name => 'will', :admin => true, :phone => '555-1234')
@@ -116,6 +142,7 @@ describe "Model Attributes" do
       user.admin.should == false
       user.phone.should == 'unset phone number'
     end
+
   end
 
   describe "from database" do
@@ -151,7 +178,7 @@ describe "Model Attributes" do
     it "Base#all should not strip protected attributes" do
       # all creates a CollectionProxy
       docs = WithProtected.all(:key => @user.id)
-      docs.size.should == 1
+      docs.length.should == 1
       reloaded = docs.first
       verify_attrs reloaded
     end

data/spec/couchrest/property_spec.rb

@@ -22,6 +22,11 @@ describe "Model properties" do
     @card.properties.map{|p| p.name}.should include("first_name")
   end
 
+  it "should list object properties with values" do
+    @card.properties_with_values.should be_an_instance_of(Hash)
+    @card.properties_with_values["first_name"].should == "matt"
+  end
+
   it "should let you access a property value (getter)" do
     @card.first_name.should == "matt"
   end
@@ -88,6 +93,7 @@ describe "Model properties" do
       expect { @card.write_attribute(:this_property_should_not_exist, 823) }.to raise_error(ArgumentError)
     end
 
+
     it "should let you use write_attribute on readonly properties" do
       lambda {
         @card.read_only_value = "foo"
@@ -109,6 +115,34 @@ describe "Model properties" do
     end
   end
 
+  describe "mass updating attributes without property" do
+    
+    describe "when mass_assign_any_attribute false" do
+      
+      it "should not allow them to be set" do
+        @card.attributes = {:test => 'fooobar'}
+        @card['test'].should be_nil
+      end
+
+    end
+
+    describe "when mass_assign_any_attribute true" do
+      before(:each) do
+        # dup Card class so that no other tests are effected
+        card_class = Card.dup
+        card_class.class_eval do
+          mass_assign_any_attribute true
+        end
+        @card = card_class.new(:first_name => 'Sam')
+      end
+
+      it 'should allow them to be updated' do
+        @card.attributes = {:test => 'fooobar'}
+        @card['test'].should eql('fooobar')
+      end
+    end
+  end
+
 
   describe "mass assignment protection" do
 
@@ -291,12 +325,28 @@ describe "Model properties" do
         @course['estimate'].should eql(-24.35)
       end
 
+      it 'return float of a number with commas instead of points for decimals' do
+        @course.estimate = '23,35'
+        @course['estimate'].should eql(23.35)
+      end
+
+      it "should handle numbers with commas and points" do
+        @course.estimate = '1,234.00'
+        @course.estimate.should eql(1234.00)
+      end
+
+      it "should handle a mis-match of commas and points and maintain the last one" do
+        @course.estimate = "1,232.434.123,323"
+        @course.estimate.should eql(1232434123.323)
+      end
+
       [ Object.new, true, '00.0', '0.', '-.0', 'string' ].each do |value|
         it "does not typecast non-numeric value #{value.inspect}" do
           @course.estimate = value
           @course['estimate'].should equal(value)
         end
       end
+
     end
 
     describe 'when type primitive is a Integer' do
@@ -571,6 +621,16 @@ describe "Model properties" do
           @course['ends_at'].min.should   eql(t.min)
           @course['ends_at'].sec.should   eql(t.sec)
         end
+        it 'parses the string without offset' do
+          t = Time.now
+          @course.ends_at = t.strftime("%Y-%m-%d %H:%M:%S")
+          @course['ends_at'].year.should  eql(t.year)
+          @course['ends_at'].month.should eql(t.month)
+          @course['ends_at'].day.should   eql(t.day)
+          @course['ends_at'].hour.should  eql(t.hour)
+          @course['ends_at'].min.should   eql(t.min)
+          @course['ends_at'].sec.should   eql(t.sec)
+        end
       end
 
       it 'does not typecast non-time values' do
@@ -814,3 +874,4 @@ describe "Property Class" do
   end
 
 end
+