couchbase 3.8.2 → 3.9.1

data/ext/couchbase/core/transactions/get_multi_orchestrator.cxx

@@ -18,15 +18,22 @@
 
 #include "active_transaction_record.hxx"
 #include "attempt_context_impl.hxx"
+#include "core/cluster.hxx"
 #include "core/document_id.hxx"
 #include "core/transactions/error_class.hxx"
 #include "core/transactions/exceptions.hxx"
 #include "forward_compat.hxx"
+#include "get_multi_fetch.hxx"
+#include "get_multi_transaction_id.hxx"
+#include "internal/utils.hxx"
+
+#include <asio/steady_timer.hpp>
 
-#include <algorithm>
 #include <chrono>
 #include <exception>
+#include <memory>
 #include <queue>
+#include <set>
 #include <vector>
 
 namespace couchbase::core::transactions
@@ -82,31 +89,6 @@ struct get_multi_spec {
   core::document_id id{};
 };
 
-// TODO(SA): I believe it should be accessible as an object directly
-struct transaction_id {
-  std::string transaction;
-  std::string attempt;
-  std::string operation;
-
-  auto operator==(const transaction_id& other) const -> bool
-  {
-    return transaction == other.transaction && attempt == other.attempt &&
-           operation == other.operation;
-  }
-  auto operator<(const transaction_id& other) const -> bool
-  {
-    if (transaction != other.transaction) {
-      return transaction < other.transaction;
-    }
-
-    if (attempt != other.attempt) {
-      return attempt < other.attempt;
-    }
-
-    return operation < other.operation;
-  }
-};
-
 struct get_multi_result {
   get_multi_spec spec;
   std::optional<transaction_get_result> get_result{};
@@ -128,17 +110,9 @@ struct get_multi_result {
   [[nodiscard]] auto extract_transaction_id() const -> std::optional<transaction_id>
   {
     if (const auto& result = get_result; result) {
-      auto txn = result->links().staged_transaction_id();
-      auto atmpt = result->links().staged_attempt_id();
-      auto op = result->links().staged_operation_id();
-
-      if (txn && atmpt && op) {
-        return transaction_id{
-          txn.value(),
-          atmpt.value(),
-          op.value(),
-        };
-      }
+      return make_transaction_id(result->links().staged_transaction_id(),
+                                 result->links().staged_attempt_id(),
+                                 result->links().staged_operation_id());
     }
     return {};
   }
@@ -191,22 +165,33 @@ classify_error(const std::exception_ptr& err) -> classified_error
   return classified_error{ error_class::FAIL_OTHER, external_exception::UNKNOWN };
 }
 
-auto
-contains_mutation(const std::optional<std::vector<doc_record>>& mutated_ids,
-                  const core::document_id& id) -> bool
-{
-  if (!mutated_ids) {
-    return false;
-  }
-  return std::any_of(mutated_ids->begin(), mutated_ids->end(), [&id](const auto& mutation) {
-    return mutation == id;
-  });
-}
-
+/**
+ * Drives a single transactional get-multi operation: fetch N documents and, where there is
+ * evidence of read skew, resolve it to return a consistent snapshot.
+ *
+ * This implements the algorithm in the "ExtGetMulti" transactions spec
+ * (couchbase-transactions-specs/transactions-get-multi.md). The spec is written as a set of
+ * function-like sections that call one another; the methods here mirror those sections:
+ *   - fetch_multiple_documents()  -> "Fetching multiple documents"
+ *   - fetch_individual_document() -> "Fetching an individual document"
+ *   - disambiguate_results()      -> "Document disambiguation"
+ *   - resolve_read_skew()         -> "Read skew resolution"
+ * The driving loop (spec "GetMulti" / "Implementation") is realised asynchronously: each fetch
+ * round completes into disambiguate_results(), which either finishes the operation or schedules a
+ * further round via retry()/reset_and_retry(). The spec's control-flow signals (Continue, Retry,
+ * ResetAndRetry, Completed, BoundExceeded) are expressed as those direct method calls rather than
+ * as returned values.
+ */
 class get_multi_operation : public std::enable_shared_from_this<get_multi_operation>
 {
 public:
   static constexpr std::size_t default_number_of_concurrent_requests{ 100 };
+  // Spec "Fetching an individual document": bound each read by min(remaining, the default 2.5s KV
+  // read timeout).
+  static constexpr std::chrono::milliseconds get_multi_key_value_read_timeout{ 2500 };
+  // Backstop on per-document transient retries; the read-skew bound is the primary terminator, so
+  // this only caps a document that keeps failing before the bound elapses.
+  static constexpr std::size_t get_multi_max_transient_retries{ 100 };
 
   ~get_multi_operation() = default;
   get_multi_operation(const get_multi_operation&) = delete;
@@ -263,6 +248,14 @@ public:
     --responses_left_;
   }
 
+  // Mark one in-flight fetch complete without touching results_[index]. Used when the read-skew
+  // bound is exceeded: the value already fetched for this spec (if any) must be preserved for the
+  // best-effort snapshot instead of being overwritten with an empty result.
+  void note_fetch_complete_without_result()
+  {
+    --responses_left_;
+  }
+
   auto pop_next_spec() -> std::optional<get_multi_spec>
   {
     if (to_fetch_.empty()) {
@@ -280,6 +273,10 @@ public:
     }
   }
 
+  /**
+   * Realises the spec's "Retry" signal: refetch the given subset of specs (retaining the rest of
+   * the operation state and the current phase), then re-run disambiguation when they complete.
+   */
   void retry(std::queue<get_multi_spec> specs)
   {
     to_fetch_ = std::move(specs);
@@ -287,13 +284,21 @@ public:
     fetch_multiple_documents();
   }
 
+  /**
+   * Realises the spec's "ResetAndRetry" signal: discard the fetched results and refetch every
+   * original spec from scratch (the state is too complex to resolve incrementally).
+   */
   void reset_and_retry()
   {
     std::queue<get_multi_spec> to_fetch;
     for (const auto& spec : specs_) {
       to_fetch.emplace(spec);
     }
+    // Restore one slot per spec before refetching: results are stored by spec index, so the
+    // container must stay sized to the spec count. A bare clear() would leave size() at 0 and the
+    // subsequent index assignments from the refetch handlers would be out of bounds.
     results_.clear();
+    results_.resize(specs_.size());
     if (phase_ != get_multi_phase::first_doc_fetch) {
       phase_ = get_multi_phase::subsequent_to_first_doc_fetch;
     }
@@ -305,6 +310,13 @@ public:
     invoke_callback();
   }
 
+  /**
+   * Implements the spec's "Read skew resolution" section. Reaches here only when exactly one other
+   * transaction T1 is involved in the fetched documents. Fetches T1's ATR entry and, based on its
+   * state and the current phase, either: returns the documents as-is (T1 not committed), refetches
+   * the documents we missed were in T1 (committed, "SubsequentToFirstDocFetch"/"DiscoveredDocsInT1"
+   * branches), disambiguates a missing ATR entry, or resets and retries.
+   */
   void resolve_read_skew()
   {
     std::string other_attempt_id;
@@ -356,82 +368,114 @@ public:
           }
         }
 
+        std::optional<atr_entry> attempt{};
         if (atr) {
-          std::optional<atr_entry> attempt{};
           for (const auto& entry : atr->entries()) {
             if (entry.attempt_id() == other_attempt_id) {
               attempt = entry;
             }
           }
-          if (attempt) {
-            auto state = attempt->state();
-
-            if (state == attempt_state::PENDING || state == attempt_state::ABORTED) {
-              return self->completed();
-            }
-
-            if (state == attempt_state::COMMITTED) {
-              if (self->phase_ == get_multi_phase::subsequent_to_first_doc_fetch) {
-                std::vector<get_multi_result> were_in_t1;
-                for (auto& result : self->results_) {
-                  if (result.has_transactional_metadata() &&
-                      (contains_mutation(attempt->inserted_ids(), result.spec.id) ||
-                       contains_mutation(attempt->replaced_ids(), result.spec.id) ||
-                       contains_mutation(attempt->removed_ids(), result.spec.id))) {
-                    were_in_t1.emplace_back(result);
-                  }
-                }
-
-                if (were_in_t1.empty()) {
-                  for (auto& result : fetched_in_t1) {
-                    result->copy_content_from_staged_operation_into_result();
-                  }
-                  return self->completed();
-                }
+        }
+        if (attempt) {
+          // Reading T1's ATR entry must run the GETS_READING_ATR forward-compatibility check, as
+          // the normal MAV get path does. The raw get_multi fetch performs no ATR read, so this
+          // check would otherwise be skipped entirely.
+          if (auto fc_err = check_forward_compat(forward_compat_stage::GETS_READING_ATR,
+                                                 attempt->forward_compat());
+              fc_err) {
+            return self->invoke_callback(std::make_exception_ptr(fc_err.value()));
+          }
+          auto state = attempt->state();
 
-                self->phase_ = get_multi_phase::discovered_docs_in_t1;
+          if (state == attempt_state::PENDING || state == attempt_state::ABORTED) {
+            return self->completed();
+          }
 
-                std::queue<get_multi_spec> to_fetch;
-                for (const auto& result : were_in_t1) {
-                  to_fetch.emplace(result.spec);
+          if (state == attempt_state::COMMITTED) {
+            if (self->phase_ == get_multi_phase::subsequent_to_first_doc_fetch) {
+              // The read-skew victims are documents we fetched WITHOUT T1's metadata (e.g. read
+              // before T1 committed) yet which T1's ATR entry records as mutated. They must be
+              // re-fetched to obtain a consistent snapshot. Mirror the reference SDK: build this
+              // set from the docs not fetched as part of T1 and filter by T1's ATR document list
+              // -- not from the docs that happen to already carry T1's metadata (those are the
+              // ones we have already resolved, not the stale ones).
+              std::vector<get_multi_result> were_in_t1;
+              for (auto& result : self->results_) {
+                if (is_read_skew_victim(result.doc_exists(),
+                                        result.extract_transaction_id(),
+                                        other_attempt_id,
+                                        result.spec.id,
+                                        attempt->inserted_ids(),
+                                        attempt->replaced_ids(),
+                                        attempt->removed_ids())) {
+                  were_in_t1.emplace_back(result);
                 }
-                return self->retry(std::move(to_fetch));
               }
-              if (self->phase_ == get_multi_phase::discovered_docs_in_t1) {
+
+              if (were_in_t1.empty()) {
                 for (auto& result : fetched_in_t1) {
                   result->copy_content_from_staged_operation_into_result();
                 }
                 return self->completed();
               }
-            }
 
-            return self->reset_and_retry();
-          }
+              self->phase_ = get_multi_phase::discovered_docs_in_t1;
 
-          // T1's ATR entry is missing
-          if (self->phase_ == get_multi_phase::resolving_t1_atr_entry_missing) {
-            if (fetched_in_t1.empty()) {
-              return self->reset_and_retry();
+              std::queue<get_multi_spec> to_fetch;
+              for (const auto& result : were_in_t1) {
+                to_fetch.emplace(result.spec);
+              }
+              return self->retry(std::move(to_fetch));
+            }
+            if (self->phase_ == get_multi_phase::discovered_docs_in_t1) {
+              for (auto& result : fetched_in_t1) {
+                result->copy_content_from_staged_operation_into_result();
+              }
+              return self->completed();
             }
-            return self->completed();
           }
-          self->phase_ = get_multi_phase::resolving_t1_atr_entry_missing;
-          std::queue<get_multi_spec> to_fetch;
-          for (const auto& result : fetched_in_t1) {
-            to_fetch.emplace(result->spec);
+
+          return self->reset_and_retry();
+        }
+
+        // There is no ATR record for T1: either the ATR document holds no entry for
+        // T1, or the ATR document itself is absent (get_atr yields an empty record on
+        // document-not-found). Both mean the same thing and are handled identically
+        // here, per the spec's "ATR entry missing" case.
+        if (self->phase_ == get_multi_phase::resolving_t1_atr_entry_missing) {
+          if (fetched_in_t1.empty()) {
+            return self->reset_and_retry();
           }
-          return self->retry(std::move(to_fetch));
+          return self->completed();
+        }
+        self->phase_ = get_multi_phase::resolving_t1_atr_entry_missing;
+        std::queue<get_multi_spec> to_fetch;
+        for (const auto& result : fetched_in_t1) {
+          to_fetch.emplace(result->spec);
         }
+        return self->retry(std::move(to_fetch));
       });
   }
 
+  /**
+   * Implements the spec's "Document disambiguation" section. Runs once a fetch round has completed.
+   * Counts how many distinct other transactions the fetched documents are involved in: zero means
+   * no detectable read skew (done); exactly one proceeds to read-skew resolution; two or more is
+   * too complex to resolve and resets. Also enforces the operation deadline (see spec "Timeouts").
+   */
   void disambiguate_results()
   {
     if (std::chrono::steady_clock::now() >= deadline_) {
-      return invoke_callback(std::make_exception_ptr(
-        transaction_operation_failed(error_class::FAIL_EXPIRY,
-                                     "timeout while fetching multiple documents")
-          .expired()));
+      // The read-skew resolution bound has been exceeded (spec "Global signal handling" for a
+      // BoundExceeded signal). Disambiguation is only entered once a fetch round has fully
+      // completed, so results_ holds an entry for every spec. Per the spec, when we have something
+      // for every document we return it as a best-effort snapshot -- which may still contain read
+      // skew we ran out of time to resolve -- rather than failing the operation. Any genuine
+      // per-document fetch error recorded in results_ is still surfaced by the completion callback.
+      // The bound is checked here between fetch rounds; an individual fetch still runs to the
+      // regular key-value timeout, so a single slow document can overshoot the bound within a
+      // round.
+      return completed();
     }
 
     std::set<transaction_id> transaction_ids{};
@@ -457,50 +501,207 @@ public:
     }
   }
 
-  void fetch_individual_document(const get_multi_spec& spec)
+  /**
+   * Implements the spec's "Fetching an individual document" section. Performs a raw lookupIn for
+   * the document body and transactional metadata (explicitly not a MAV read), runs the
+   * forward-compatibility checks the normal get path would, and records the result. As each fetch
+   * completes it pulls the next queued spec, and once the round is drained it advances the deadline
+   * per the mode and hands off to disambiguate_results().
+   */
+  void fetch_individual_document(const get_multi_spec& spec,
+                                 std::shared_ptr<async_exp_delay> backoff = nullptr)
   {
-    auto handler = [spec, self = shared_from_this()](const std::exception_ptr& error,
-                                                     std::optional<transaction_get_result> res) {
-      if (res) {
-        auto forward_compat_err =
-          check_forward_compat(forward_compat_stage::GET_MULTI_GET, res->links().forward_compat());
-        if (forward_compat_err) {
-          self->invoke_callback(std::make_exception_ptr(forward_compat_err.value()));
+    // Per spec, a read-skew-resolution fetch is bounded by min(time left before the bound, the KV
+    // read timeout); the first-doc fetch has no bound yet, so it uses the SDK's default read
+    // timeout (a nullopt override).
+    std::optional<std::chrono::milliseconds> timeout{};
+    if (phase_ != get_multi_phase::first_doc_fetch) {
+      timeout = get_multi_fetch_timeout(deadline_ - std::chrono::steady_clock::now(),
+                                        get_multi_key_value_read_timeout);
+    }
+
+    // get_multi must fetch the raw document body and transactional metadata with a plain lookupIn
+    // -- explicitly NOT a MAV read, which would perform its own ATR lookup and resolution and rob
+    // the orchestrator of the metadata it needs to detect and resolve read skew itself.
+    attempt_->get_doc(
+      spec.id,
+      use_replicas_,
+      timeout,
+      [spec, backoff, self = shared_from_this()](
+        std::optional<error_class> ec,
+        std::optional<external_exception> cause,
+        std::optional<std::string> message,
+        std::optional<transaction_get_result> res) mutable {
+        if (!self->callback_) {
+          // The operation already completed (e.g. a sibling fetch hit a forward-compat failure and
+          // invoked the callback, moving results_ out). Concurrently-dispatched fetches can still
+          // complete afterwards; ignore them so we never index the moved-from results_ vector.
           return;
         }
-        self->handle_individual_document_success(spec, std::move(res));
-      } else {
-        self->handle_individual_document_error(spec, error);
-      }
-      if (auto next_spec = self->pop_next_spec(); next_spec) {
-        return self->fetch_individual_document(next_spec.value());
+
+        if (res) {
+          // The raw fetch does not perform MAV, so the forward-compatibility checks the normal get
+          // path would run must be done here. Per spec, run two checks in order: GET_MULTI_GET
+          // ("GM_G", so newer clients can block getMulti specifically) then GETS ("G", which older
+          // clients use and which anything blocking get likely needs to block getMulti too).
+          for (const auto stage :
+               { forward_compat_stage::GET_MULTI_GET, forward_compat_stage::GETS }) {
+            if (auto fc_err = check_forward_compat(stage, res->links().forward_compat()); fc_err) {
+              self->invoke_callback(std::make_exception_ptr(fc_err.value()));
+              return;
+            }
+          }
+          self->handle_individual_document_success(spec, std::move(res));
+          return self->advance_after_fetch();
+        }
+
+        // No document: classify the failure per the spec's "Fetching an individual document /
+        // Error handling" section (classify_get_multi_fetch_error documents the error-model
+        // adaptation).
+        const auto fetch_outcome =
+          classify_get_multi_fetch_error(ec, cause, self->read_skew_bound_exceeded());
+        switch (fetch_outcome) {
+          case get_multi_fetch_outcome::document_absent:
+            // Not a failure: record the document as absent so the round completes.
+            self->handle_individual_document_error(spec, nullptr);
+            return self->advance_after_fetch();
+          case get_multi_fetch_outcome::bound_exceeded:
+            switch (get_multi_bound_exceeded_action(self->results_[spec.index].doc_exists())) {
+              case bound_exceeded_action::preserve_prior_value:
+                // Best-effort: a value fetched for this spec in an earlier round must stay in the
+                // snapshot, so mark the fetch complete without overwriting results_[index].
+                self->note_fetch_complete_without_result();
+                break;
+              case bound_exceeded_action::fail_retryable: {
+                // No value held for this spec (e.g. reset_and_retry() cleared the slots and the
+                // re-fetch hit a transient at the already-elapsed bound). A transient is never a
+                // document-not-found, so record it as retryable rather than leaving the slot blank
+                // -- a blank would be misreported as an absent document. The retry drives the
+                // enclosing transaction to try again.
+                auto err = transaction_operation_failed(
+                             ec.value(),
+                             message.value_or("get_multi read-skew bound exceeded before the "
+                                              "document could be fetched"))
+                             .retry();
+                if (cause) {
+                  err.cause(cause.value());
+                }
+                self->handle_individual_document_error(spec, std::make_exception_ptr(err));
+                break;
+              }
+            }
+            return self->advance_after_fetch();
+          case get_multi_fetch_outcome::retry_after_backoff:
+            return self->retry_individual_document_after_backoff(
+              spec, std::move(backoff), ec, cause, message);
+          case get_multi_fetch_outcome::fail_expired:
+          case get_multi_fetch_outcome::fail_without_rollback:
+          case get_multi_fetch_outcome::fail_with_rollback: {
+            // Build the failure once; the outcome only selects the modifier applied to it.
+            auto err = transaction_operation_failed(
+              ec.value(), message.value_or("error fetching document in get_multi"));
+            if (cause) {
+              err.cause(cause.value());
+            }
+            if (fetch_outcome == get_multi_fetch_outcome::fail_expired) {
+              err = err.expired();
+            } else if (fetch_outcome == get_multi_fetch_outcome::fail_without_rollback) {
+              err = err.no_rollback();
+            }
+            self->handle_individual_document_error(spec, std::make_exception_ptr(err));
+            return self->advance_after_fetch();
+          }
+        }
+      });
+  }
+
+  // True once the read-skew resolution bound has elapsed. There is no bound during the first fetch
+  // round (it uses the SDK read timeout), so a transient error there always retries rather than
+  // being treated as bound-exceeded.
+  [[nodiscard]] auto read_skew_bound_exceeded() const -> bool
+  {
+    return phase_ != get_multi_phase::first_doc_fetch &&
+           std::chrono::steady_clock::now() >= deadline_;
+  }
+
+  // Spec "Fetching an individual document / Error handling": a transient failure retries this fetch
+  // after an exponential backoff starting from 1ms. The backoff is threaded through the retries of
+  // one document so the delay grows across them; a fresh document starts a new one. If it is
+  // exhausted the document has stayed transiently unavailable for too long, so retry the whole
+  // transaction.
+  void retry_individual_document_after_backoff(const get_multi_spec& spec,
+                                               std::shared_ptr<async_exp_delay> backoff,
+                                               std::optional<error_class> last_ec,
+                                               std::optional<external_exception> last_cause,
+                                               std::optional<std::string> last_message)
+  {
+    if (!backoff) {
+      backoff = std::make_shared<async_exp_delay>(
+        std::make_shared<asio::steady_timer>(attempt_->cluster_ref().io_context()),
+        std::chrono::milliseconds{ 1 },
+        std::chrono::milliseconds{ 100 },
+        get_multi_max_transient_retries);
+    }
+    (*backoff)([spec, backoff, last_ec, last_cause, last_message, self = shared_from_this()](
+                 std::exception_ptr err) mutable {
+      if (!self->callback_) {
+        return;
       }
-      if (self->responses_left_ == 0) {
-        if (self->phase_ == get_multi_phase::first_doc_fetch) {
-          self->phase_ = get_multi_phase::subsequent_to_first_doc_fetch;
+      if (err) {
+        // Backoff exhausted: the document stayed transiently unavailable for too long. Retry the
+        // whole transaction, preserving the last fetch's error class/cause/message so the failure
+        // keeps its diagnostics (timeout vs ambiguous vs transient) instead of a generic one.
+        auto tof = transaction_operation_failed(
+                     last_ec.value_or(FAIL_TRANSIENT),
+                     last_message.value_or("get_multi document fetch kept failing transiently"))
+                     .retry();
+        if (last_cause) {
+          tof.cause(last_cause.value());
         }
+        self->handle_individual_document_error(spec, std::make_exception_ptr(tof));
+        return self->advance_after_fetch();
+      }
+      self->fetch_individual_document(spec, std::move(backoff));
+    });
+  }
 
-        switch (self->mode_) {
+  // Common tail of a completed individual fetch: start the next queued spec, or, once the round is
+  // drained, set the read-skew bound (once, on leaving the first-doc-fetch phase) and hand off to
+  // disambiguation. The bound is set only on the first-doc-fetch -> subsequent transition and left
+  // fixed for the remaining rounds; recomputing it every round in latency mode would push the 100ms
+  // bound indefinitely into the future and defeat the best-effort BoundExceeded return.
+  void advance_after_fetch()
+  {
+    if (auto next_spec = pop_next_spec(); next_spec) {
+      return fetch_individual_document(next_spec.value());
+    }
+    if (responses_left_ == 0) {
+      if (phase_ == get_multi_phase::first_doc_fetch) {
+        switch (mode_) {
           case get_multi_mode::disable_read_skew_detection:
-            return self->invoke_callback();
+            break;
           case get_multi_mode::prioritise_latency:
-            self->deadline_ = std::chrono::steady_clock::now() + std::chrono::milliseconds{ 100 };
+            deadline_ = std::chrono::steady_clock::now() + std::chrono::milliseconds{ 100 };
             break;
           case get_multi_mode::prioritise_read_skew_detection:
-            self->deadline_ = self->attempt_->expiry_time();
+            deadline_ = attempt_->expiry_time();
             break;
         }
+        phase_ = get_multi_phase::subsequent_to_first_doc_fetch;
+      }
 
-        self->disambiguate_results();
+      if (mode_ == get_multi_mode::disable_read_skew_detection) {
+        return invoke_callback();
       }
-    };
-    if (use_replicas_) {
-      attempt_->get_replica_from_preferred_server_group(spec.id, std::move(handler));
-    } else {
-      attempt_->get_optional(spec.id, std::move(handler));
+      disambiguate_results();
     }
   }
 
+  /**
+   * Implements the spec's "Fetching multiple documents" section. Schedules the queued specs to be
+   * fetched concurrently, with no more than default_number_of_concurrent_requests in flight at
+   * once; each completing fetch starts the next, so the cap is maintained without a barrier.
+   */
   void fetch_multiple_documents()
   {
     std::size_t requests_scheduled{ 0 };

data/ext/couchbase/core/transactions/get_multi_transaction_id.hxx

@@ -0,0 +1,62 @@
+/*
+ *     Copyright 2021-Present Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+#pragma once
+
+#include <optional>
+#include <string>
+
+namespace couchbase::core::transactions
+{
+// Identifies the transaction attempt a document is staged in. Identity is the (transaction,
+// attempt) pair only: the per-mutation operation id is deliberately NOT part of it. Read-skew
+// detection groups the fetched documents by the *transaction* they belong to (spec "Document
+// disambiguation"), and two documents staged by the same attempt always carry different operation
+// ids -- including the operation id here would make them count as separate transactions and send
+// disambiguation down the "two or more transactions, too complex" reset-and-retry path forever.
+struct transaction_id {
+  std::string transaction;
+  std::string attempt;
+
+  auto operator==(const transaction_id& other) const -> bool
+  {
+    return transaction == other.transaction && attempt == other.attempt;
+  }
+  auto operator<(const transaction_id& other) const -> bool
+  {
+    if (transaction != other.transaction) {
+      return transaction < other.transaction;
+    }
+    return attempt < other.attempt;
+  }
+};
+
+// Build a transaction_id from the staged (transaction, attempt, operation) ids carried on a
+// document's transactional metadata. All three must be present -- a document genuinely staged in a
+// transaction always carries the full triplet, so a missing id means the document is not staged --
+// but the operation id is deliberately dropped from the resulting identity (see transaction_id).
+// Returns nullopt if any of the three ids is absent.
+[[nodiscard]] inline auto
+make_transaction_id(const std::optional<std::string>& transaction,
+                    const std::optional<std::string>& attempt,
+                    const std::optional<std::string>& operation) -> std::optional<transaction_id>
+{
+  if (transaction && attempt && operation) {
+    return transaction_id{ transaction.value(), attempt.value() };
+  }
+  return {};
+}
+
+} // namespace couchbase::core::transactions