couchbase 3.5.3 → 3.5.4

data/ext/couchbase/core/impl/analytics_index_manager.cxx

@@ -159,7 +159,7 @@ public:
         {},
         options.timeout,
       },
-      [dataverse_name, handler = std::move(handler)](auto resp) {
+      [dataverse_name, handler = std::move(handler)](const auto& resp) {
         CB_LOG_DEBUG(
           "Dataverse create for {} error code = {}", dataverse_name, resp.ctx.ec.value());
         handler(core::impl::make_error(resp.ctx));
@@ -177,7 +177,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -197,7 +197,7 @@ public:
         options.timeout,
         options.ignore_if_exists,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -214,7 +214,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -262,7 +262,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -281,7 +281,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -324,7 +324,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -339,7 +339,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -386,7 +386,7 @@ public:
             {},
             options.timeout,
           },
-          [handler = std::move(handler)](auto resp) {
+          [handler = std::move(handler)](const auto& resp) {
             handler(core::impl::make_error(resp.ctx));
           });
 
@@ -398,7 +398,7 @@ public:
             {},
             options.timeout,
           },
-          [handler = std::move(handler)](auto resp) {
+          [handler = std::move(handler)](const auto& resp) {
             handler(core::impl::make_error(resp.ctx));
           });
 
@@ -410,7 +410,7 @@ public:
             {},
             options.timeout,
           },
-          [handler = std::move(handler)](auto resp) {
+          [handler = std::move(handler)](const auto& resp) {
             handler(core::impl::make_error(resp.ctx));
           });
     }
@@ -429,7 +429,7 @@ public:
             {},
             options.timeout,
           },
-          [handler = std::move(handler)](auto resp) {
+          [handler = std::move(handler)](const auto& resp) {
             handler(core::impl::make_error(resp.ctx));
           });
 
@@ -441,7 +441,7 @@ public:
             {},
             options.timeout,
           },
-          [handler = std::move(handler)](auto resp) {
+          [handler = std::move(handler)](const auto& resp) {
             handler(core::impl::make_error(resp.ctx));
           });
 
@@ -453,7 +453,7 @@ public:
             {},
             options.timeout,
           },
-          [handler = std::move(handler)](auto resp) {
+          [handler = std::move(handler)](const auto& resp) {
             handler(core::impl::make_error(resp.ctx));
           });
     }
@@ -471,7 +471,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }

data/ext/couchbase/core/impl/bootstrap_error.hxx

@@ -20,8 +20,12 @@
 #include <optional>
 #include <string>
 #include <system_error>
+#include <variant>
 
-namespace couchbase::core::impl
+namespace couchbase::core
+{
+
+namespace impl
 {
 
 struct bootstrap_error {
@@ -31,4 +35,8 @@ struct bootstrap_error {
   std::optional<std::string> port;
 };
 
-} // namespace couchbase::core::impl
+} // namespace impl
+
+using error_union = std::variant<std::monostate, std::error_code, impl::bootstrap_error>;
+
+} // namespace couchbase::core

data/ext/couchbase/core/impl/bucket.cxx

@@ -59,7 +59,7 @@ public:
                       name_,
                       core::impl::to_core_service_types(options.service_types),
                       options.timeout,
-                      [handler = std::move(handler)](auto resp) mutable {
+                      [handler = std::move(handler)](const auto& resp) mutable {
                         return handler({}, core::impl::build_result(resp));
                       });
   }

data/ext/couchbase/core/impl/bucket_manager.cxx

@@ -269,7 +269,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx), map_bucket_settings(resp.bucket));
       });
   }
@@ -282,7 +282,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx), map_all_bucket_settings(resp.buckets));
       });
   }
@@ -297,7 +297,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -312,7 +312,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -327,7 +327,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -342,7 +342,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }

data/ext/couchbase/core/impl/cluster.cxx

@@ -140,7 +140,6 @@ options_to_origin(const std::string& connection_string,
   user_options.enable_mutation_tokens = opts.behavior.enable_mutation_tokens;
   user_options.enable_unordered_execution = opts.behavior.enable_unordered_execution;
   user_options.user_agent_extra = opts.behavior.user_agent_extra;
-  user_options.network = opts.behavior.network;
 
   user_options.server_group = opts.network.server_group;
   user_options.enable_tcp_keep_alive = opts.network.enable_tcp_keep_alive;
@@ -150,8 +149,10 @@ options_to_origin(const std::string& connection_string,
   if (opts.network.max_http_connections) {
     user_options.max_http_connections = opts.network.max_http_connections.value();
   }
-  if (!opts.network.network.empty()) {
-    user_options.network = opts.network.network;
+  user_options.network = opts.network.network;
+  if (user_options.network.empty()) {
+    // this is deprecated option, but use it in case main options is empty
+    user_options.network = opts.behavior.network;
   }
   switch (opts.network.ip_protocol) {
     case ip_protocol::any:
@@ -229,21 +230,8 @@ public:
     // We cannot use close() method here, as it is capturing self as a shared
     // pointer to extend lifetime for the user's callback. Here the reference
     // counter has reached zero already, so we can only capture `*this`.
-    std::thread([this, &barrier]() mutable {
-      if (auto txns = std::move(transactions_); txns != nullptr) {
-        // blocks until cleanup is finished
-        txns->close();
-      }
-      std::promise<void> core_stopped;
-      auto f = core_stopped.get_future();
-      core_.close([&core_stopped]() {
-        core_stopped.set_value();
-      });
-      f.get();
-      io_.stop();
-      if (io_thread_.joinable()) {
-        io_thread_.join();
-      }
+    std::thread([this, barrier = std::move(barrier)]() mutable {
+      do_close();
       barrier.set_value();
     }).detach();
 
@@ -290,7 +278,7 @@ public:
                 }));
               return;
             }
-            impl->transactions_ = txns;
+            impl->transactions_ = std::move(txns);
             handler(ec, couchbase::cluster(std::move(impl)));
           });
       });
@@ -322,16 +310,17 @@ public:
                       {},
                       core::impl::to_core_service_types(options.service_types),
                       options.timeout,
-                      [handler = std::move(handler)](auto resp) mutable {
+                      [handler = std::move(handler)](const auto& resp) mutable {
                         return handler({}, core::impl::build_result(resp));
                       });
   };
 
   void diagnostics(const diagnostics_options::built& options, diagnostics_handler&& handler) const
   {
-    return core_.diagnostics(options.report_id, [handler = std::move(handler)](auto resp) mutable {
-      return handler({}, core::impl::build_result(resp));
-    });
+    return core_.diagnostics(options.report_id,
+                             [handler = std::move(handler)](const auto& resp) mutable {
+                               return handler({}, core::impl::build_result(resp));
+                             });
   }
 
   void search(std::string index_name,
@@ -341,7 +330,7 @@ public:
   {
     return core_.execute(
       core::impl::build_search_request(std::move(index_name), std::move(request), options, {}, {}),
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx),
                        search_result{ internal_search_result{ resp } });
       });
@@ -370,20 +359,7 @@ public:
   {
     // Spawn new thread to avoid joining IO thread from the same thread
     std::thread([self = shared_from_this(), handler = std::move(handler)]() mutable {
-      if (auto txns = std::move(self->transactions_); txns != nullptr) {
-        // blocks until cleanup is finished
-        txns->close();
-      }
-      std::promise<void> barrier;
-      auto future = barrier.get_future();
-      self->core_.close([&barrier]() {
-        barrier.set_value();
-      });
-      future.get();
-      self->io_.stop();
-      if (self->io_thread_.joinable()) {
-        self->io_thread_.join();
-      }
+      self->do_close();
       handler();
     }).detach();
   }
@@ -399,7 +375,25 @@ public:
   }
 
 private:
-  asio::io_context io_{ ASIO_CONCURRENCY_HINT_1 };
+  void do_close()
+  {
+    if (auto txns = std::move(transactions_); txns != nullptr) {
+      // blocks until cleanup is finished
+      txns->close();
+    }
+    std::promise<void> core_stopped;
+    auto f = core_stopped.get_future();
+    core_.close([core_stopped = std::move(core_stopped)]() mutable {
+      core_stopped.set_value();
+    });
+    f.get();
+    io_.stop();
+    if (io_thread_.joinable()) {
+      io_thread_.join();
+    }
+  }
+
+  asio::io_context io_{ ASIO_CONCURRENCY_HINT_SAFE };
   core::cluster core_{ io_ };
   std::shared_ptr<core::transactions::transactions> transactions_{ nullptr };
   std::thread io_thread_{ [&io = io_] {
@@ -538,12 +532,15 @@ cluster::connect(const std::string& connection_string,
   // Spawn new thread for connection to ensure that cluster_impl pointer will
   // not be deallocated in IO thread in case of error.
   std::thread([connection_string, options, handler = std::move(handler)]() {
-    auto impl = std::make_shared<cluster_impl>();
     auto barrier = std::make_shared<std::promise<std::pair<error, cluster>>>();
     auto future = barrier->get_future();
-    impl->open(connection_string, options, [barrier](auto err, auto c) {
-      barrier->set_value({ std::move(err), std::move(c) });
-    });
+    {
+      auto impl = std::make_shared<cluster_impl>();
+      impl->open(connection_string, options, [barrier](auto err, auto c) {
+        barrier->set_value({ std::move(err), std::move(c) });
+      });
+    }
+
     auto [err, c] = future.get();
     handler(std::move(err), std::move(c));
   }).detach();

data/ext/couchbase/core/impl/collection.cxx

@@ -211,7 +211,7 @@ public:
         options.timeout,
         { options.retry_strategy },
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(std::move(resp.ctx)), result{ resp.cas });
       });
   }
@@ -1390,7 +1390,7 @@ collection::scan(const couchbase::scan_type& scan_type, const couchbase::scan_op
 {
   auto barrier = std::make_shared<std::promise<std::pair<error, scan_result>>>();
   auto future = barrier->get_future();
-  scan(scan_type, options, [barrier](auto err, auto result) {
+  scan(scan_type, options, [barrier](const auto& err, auto result) {
     barrier->set_value({ err, std::move(result) });
   });
   return future;

data/ext/couchbase/core/impl/collection_manager.cxx

@@ -101,7 +101,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -122,7 +122,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -143,7 +143,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -173,7 +173,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -189,7 +189,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }

data/ext/couchbase/core/impl/lookup_in_replica.cxx

@@ -16,10 +16,14 @@
  */
 
 #include "lookup_in_replica.hxx"
+
 #include "core/impl/subdoc/path_flags.hxx"
+#include "core/utils/json.hxx"
 
 #include <couchbase/error_codes.hxx>
 
+#include <tao/json/value.hpp>
+
 namespace couchbase::core::impl
 {
 auto

data/ext/couchbase/core/impl/observe_poll.cxx

@@ -26,6 +26,7 @@
 
 #include <memory>
 #include <mutex>
+#include <system_error>
 
 namespace couchbase::core::impl
 {
@@ -240,8 +241,7 @@ public:
   void handle_response(observe_seqno_response&& response)
   {
     --expect_number_of_responses_;
-    auto r = std::move(response);
-    status_.examine(r);
+    status_.examine(response);
     maybe_finish();
   }
 
@@ -249,6 +249,8 @@ public:
   {
     poll_backoff_.cancel();
     poll_deadline_.cancel();
+    on_last_response(0, [](std::error_code) {
+    });
     observe_handler handler{};
     {
       const std::scoped_lock lock(handler_mutex_);
@@ -268,10 +270,16 @@ public:
         return;
       }
       if (status_.meets_condition(persist_to_, replicate_to_)) {
+        poll_backoff_.cancel();
+        poll_deadline_.cancel();
+        on_last_response(0, [](std::error_code) {
+        });
         std::swap(handler_, handler);
-      } else if (expect_number_of_responses_ == 0 && on_last_response_) {
-        poll_backoff_.expires_after(poll_backoff_interval_);
-        return poll_backoff_.async_wait(std::move(on_last_response_));
+      } else if (expect_number_of_responses_ == 0) {
+        if (auto on_last_response = std::move(on_last_response_); on_last_response) {
+          poll_backoff_.expires_after(poll_backoff_interval_);
+          return poll_backoff_.async_wait(std::move(on_last_response));
+        }
       }
     }
     if (handler) {

data/ext/couchbase/core/impl/observe_poll.hxx

@@ -17,7 +17,6 @@
 
 #pragma once
 
-#include "core/error_context/key_value_error_context.hxx"
 #include <couchbase/mutation_token.hxx>
 #include <couchbase/persist_to.hxx>
 #include <couchbase/replicate_to.hxx>
@@ -26,8 +25,7 @@
 #include "core/utils/movable_function.hxx"
 
 #include <chrono>
-#include <functional>
-#include <memory>
+#include <system_error>
 
 namespace couchbase::core
 {

data/ext/couchbase/core/impl/query_index_manager.cxx

@@ -232,7 +232,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -259,7 +259,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -283,7 +283,7 @@ public:
         {},
         options.timeout,
       },
-      [handler = std::move(handler)](auto resp) {
+      [handler = std::move(handler)](const auto& resp) {
         handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -342,7 +342,7 @@ public:
                                                                    std::move(list_resp.index_names),
                                                                    {},
                                                                    timeout },
-          [handler = std::move(handler)](auto build_resp) {
+          [handler = std::move(handler)](const auto& build_resp) {
             return handler(core::impl::make_error(build_resp.ctx));
           });
       });
@@ -390,7 +390,7 @@ query_index_manager::get_all_indexes(const std::string& bucket_name,
   auto barrier =
     std::make_shared<std::promise<std::pair<error, std::vector<management::query_index>>>>();
   auto future = barrier->get_future();
-  get_all_indexes(bucket_name, options, [barrier](auto err, auto resp) mutable {
+  get_all_indexes(bucket_name, options, [barrier](auto err, const auto& resp) mutable {
     barrier->set_value({ std::move(err), resp });
   });
   return future;
@@ -563,7 +563,7 @@ collection_query_index_manager::get_all_indexes(const get_all_query_indexes_opti
   auto barrier =
     std::make_shared<std::promise<std::pair<error, std::vector<management::query_index>>>>();
   auto future = barrier->get_future();
-  get_all_indexes(options, [barrier](auto err, auto resp) mutable {
+  get_all_indexes(options, [barrier](auto err, const auto& resp) mutable {
     barrier->set_value({ std::move(err), resp });
   });
   return future;

data/ext/couchbase/core/impl/scan_result.cxx

@@ -97,7 +97,7 @@ scan_result::next() const -> std::future<std::pair<error, std::optional<scan_res
 {
   auto barrier =
     std::make_shared<std::promise<std::pair<error, std::optional<scan_result_item>>>>();
-  internal_->next([barrier](auto err, auto item) mutable {
+  internal_->next([barrier](const auto& err, const auto& item) mutable {
     barrier->set_value({ err, item });
   });
   return barrier->get_future();

data/ext/couchbase/core/impl/search_index_manager.cxx

@@ -150,7 +150,7 @@ public:
     core_.execute(
       core::operations::management::search_index_get_request{
         std::move(index_name), bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx), map_search_index(resp.index));
       });
   }
@@ -161,7 +161,7 @@ public:
     core_.execute(
       core::operations::management::search_index_get_all_request{
         bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx), map_all_search_indexes(resp.indexes));
       });
   }
@@ -173,7 +173,7 @@ public:
     core_.execute(
       core::operations::management::search_index_upsert_request{
         map_search_index(search_index), bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -185,7 +185,7 @@ public:
     core_.execute(
       core::operations::management::search_index_drop_request{
         std::move(index_name), bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -197,7 +197,7 @@ public:
     core_.execute(
       core::operations::management::search_index_get_documents_count_request{
         std::move(index_name), bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx), resp.count);
       });
   }
@@ -209,7 +209,7 @@ public:
     core_.execute(
       core::operations::management::search_index_control_ingest_request{
         std::move(index_name), true, bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -221,7 +221,7 @@ public:
     core_.execute(
       core::operations::management::search_index_control_ingest_request{
         std::move(index_name), false, bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -233,7 +233,7 @@ public:
     core_.execute(
       core::operations::management::search_index_control_query_request{
         std::move(index_name), true, bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -245,7 +245,7 @@ public:
     core_.execute(
       core::operations::management::search_index_control_query_request{
         std::move(index_name), false, bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -257,7 +257,7 @@ public:
     core_.execute(
       core::operations::management::search_index_control_plan_freeze_request{
         std::move(index_name), true, bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -269,7 +269,7 @@ public:
     core_.execute(
       core::operations::management::search_index_control_plan_freeze_request{
         std::move(index_name), false, bucket_name_, scope_name_, {}, options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx));
       });
   }
@@ -286,7 +286,7 @@ public:
                                                                            scope_name_,
                                                                            {},
                                                                            options.timeout },
-      [handler = std::move(handler)](auto resp) mutable {
+      [handler = std::move(handler)](const auto& resp) mutable {
         return handler(core::impl::make_error(resp.ctx), convert_analysis(resp.analysis));
       });
   }