couchbase 3.5.1 → 3.5.2

data/ext/couchbase/core/impl/search_sort_id.cxx

@@ -24,20 +24,20 @@ namespace couchbase
 auto
 search_sort_id::descending(bool desc) -> search_sort_id&
 {
-    descending_ = desc;
-    return *this;
+  descending_ = desc;
+  return *this;
 }
 
 auto
 search_sort_id::encode() const -> encoded_search_sort
 {
-    encoded_search_sort built;
-    built.sort = {
-        { "by", "id" },
-    };
-    if (const auto& desc = descending_; desc.has_value()) {
-        built.sort["desc"] = desc.value();
-    }
-    return built;
+  encoded_search_sort built;
+  built.sort = {
+    { "by", "id" },
+  };
+  if (const auto& desc = descending_; desc.has_value()) {
+    built.sort["desc"] = desc.value();
+  }
+  return built;
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/search_sort_score.cxx

@@ -24,20 +24,20 @@ namespace couchbase
 auto
 search_sort_score::descending(bool desc) -> search_sort_score&
 {
-    descending_ = desc;
-    return *this;
+  descending_ = desc;
+  return *this;
 }
 
 auto
 search_sort_score::encode() const -> encoded_search_sort
 {
-    encoded_search_sort built;
-    built.sort = {
-        { "by", "score" },
-    };
-    if (const auto& desc = descending_; desc.has_value()) {
-        built.sort["desc"] = desc.value();
-    }
-    return built;
+  encoded_search_sort built;
+  built.sort = {
+    { "by", "score" },
+  };
+  if (const auto& desc = descending_; desc.has_value()) {
+    built.sort["desc"] = desc.value();
+  }
+  return built;
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/streaming_json_lexer_error_category.cxx

@@ -23,80 +23,82 @@ namespace couchbase::core::impl
 {
 
 struct streaming_json_lexer_error_category : std::error_category {
-    [[nodiscard]] const char* name() const noexcept override
-    {
-        return "couchbase.streaming_json_lexer";
-    }
+  [[nodiscard]] auto name() const noexcept -> const char* override
+  {
+    return "couchbase.streaming_json_lexer";
+  }
 
-    [[nodiscard]] std::string message(int ev) const noexcept override
-    {
-        switch (static_cast<errc::streaming_json_lexer>(ev)) {
-            case errc::streaming_json_lexer::garbage_trailing:
-                return "garbage_trailing (1101)";
-            case errc::streaming_json_lexer::special_expected:
-                return "special_expected (1102)";
-            case errc::streaming_json_lexer::special_incomplete:
-                return "special_incomplete (1103)";
-            case errc::streaming_json_lexer::stray_token:
-                return "stray_token (1104)";
-            case errc::streaming_json_lexer::missing_token:
-                return "missing_token (1105)";
-            case errc::streaming_json_lexer::cannot_insert:
-                return "cannot_insert (1106)";
-            case errc::streaming_json_lexer::escape_outside_string:
-                return "escape_outside_string (1107)";
-            case errc::streaming_json_lexer::key_outside_object:
-                return "key_outside_object (1108)";
-            case errc::streaming_json_lexer::string_outside_container:
-                return "string_outside_container (1109)";
-            case errc::streaming_json_lexer::found_null_byte:
-                return "found_null_byte (1110)";
-            case errc::streaming_json_lexer::levels_exceeded:
-                return "levels_exceeded (1111)";
-            case errc::streaming_json_lexer::bracket_mismatch:
-                return "bracket_mismatch (1112)";
-            case errc::streaming_json_lexer::object_key_expected:
-                return "object_key_expected (1113)";
-            case errc::streaming_json_lexer::weird_whitespace:
-                return "weird_whitespace (1114)";
-            case errc::streaming_json_lexer::unicode_escape_is_too_short:
-                return "unicode_escape_is_too_short (1115)";
-            case errc::streaming_json_lexer::escape_invalid:
-                return "escape_invalid (1116)";
-            case errc::streaming_json_lexer::trailing_comma:
-                return "trailing_comma (1117)";
-            case errc::streaming_json_lexer::invalid_number:
-                return "invalid_number (1118)";
-            case errc::streaming_json_lexer::value_expected:
-                return "value_expected (1119)";
-            case errc::streaming_json_lexer::percent_bad_hex:
-                return "percent_bad_hex (1120)";
-            case errc::streaming_json_lexer::json_pointer_bad_path:
-                return "json_pointer_bad_path (1121)";
-            case errc::streaming_json_lexer::json_pointer_duplicated_slash:
-                return "json_pointer_duplicated_slash (1122)";
-            case errc::streaming_json_lexer::json_pointer_missing_root:
-                return "json_pointer_missing_root (1123)";
-            case errc::streaming_json_lexer::not_enough_memory:
-                return "not_enough_memory (1124)";
-            case errc::streaming_json_lexer::invalid_codepoint:
-                return "invalid_codepoint (1125)";
-            case errc::streaming_json_lexer::generic:
-                return "generic (1126)";
-            case errc::streaming_json_lexer::root_is_not_an_object:
-                return "root_is_not_an_object (1127)";
-            case errc::streaming_json_lexer::root_does_not_match_json_pointer:
-                return "root_does_not_match_json_pointer (1128)";
-        }
-        return "FIXME: unknown error code (recompile with newer library): couchbase.streaming_json_lexer." + std::to_string(ev);
+  [[nodiscard]] auto message(int ev) const noexcept -> std::string override
+  {
+    switch (static_cast<errc::streaming_json_lexer>(ev)) {
+      case errc::streaming_json_lexer::garbage_trailing:
+        return "garbage_trailing (1101)";
+      case errc::streaming_json_lexer::special_expected:
+        return "special_expected (1102)";
+      case errc::streaming_json_lexer::special_incomplete:
+        return "special_incomplete (1103)";
+      case errc::streaming_json_lexer::stray_token:
+        return "stray_token (1104)";
+      case errc::streaming_json_lexer::missing_token:
+        return "missing_token (1105)";
+      case errc::streaming_json_lexer::cannot_insert:
+        return "cannot_insert (1106)";
+      case errc::streaming_json_lexer::escape_outside_string:
+        return "escape_outside_string (1107)";
+      case errc::streaming_json_lexer::key_outside_object:
+        return "key_outside_object (1108)";
+      case errc::streaming_json_lexer::string_outside_container:
+        return "string_outside_container (1109)";
+      case errc::streaming_json_lexer::found_null_byte:
+        return "found_null_byte (1110)";
+      case errc::streaming_json_lexer::levels_exceeded:
+        return "levels_exceeded (1111)";
+      case errc::streaming_json_lexer::bracket_mismatch:
+        return "bracket_mismatch (1112)";
+      case errc::streaming_json_lexer::object_key_expected:
+        return "object_key_expected (1113)";
+      case errc::streaming_json_lexer::weird_whitespace:
+        return "weird_whitespace (1114)";
+      case errc::streaming_json_lexer::unicode_escape_is_too_short:
+        return "unicode_escape_is_too_short (1115)";
+      case errc::streaming_json_lexer::escape_invalid:
+        return "escape_invalid (1116)";
+      case errc::streaming_json_lexer::trailing_comma:
+        return "trailing_comma (1117)";
+      case errc::streaming_json_lexer::invalid_number:
+        return "invalid_number (1118)";
+      case errc::streaming_json_lexer::value_expected:
+        return "value_expected (1119)";
+      case errc::streaming_json_lexer::percent_bad_hex:
+        return "percent_bad_hex (1120)";
+      case errc::streaming_json_lexer::json_pointer_bad_path:
+        return "json_pointer_bad_path (1121)";
+      case errc::streaming_json_lexer::json_pointer_duplicated_slash:
+        return "json_pointer_duplicated_slash (1122)";
+      case errc::streaming_json_lexer::json_pointer_missing_root:
+        return "json_pointer_missing_root (1123)";
+      case errc::streaming_json_lexer::not_enough_memory:
+        return "not_enough_memory (1124)";
+      case errc::streaming_json_lexer::invalid_codepoint:
+        return "invalid_codepoint (1125)";
+      case errc::streaming_json_lexer::generic:
+        return "generic (1126)";
+      case errc::streaming_json_lexer::root_is_not_an_object:
+        return "root_is_not_an_object (1127)";
+      case errc::streaming_json_lexer::root_does_not_match_json_pointer:
+        return "root_does_not_match_json_pointer (1128)";
     }
+    return "FIXME: unknown error code (recompile with newer library): "
+           "couchbase.streaming_json_lexer." +
+           std::to_string(ev);
+  }
 };
 
 const inline static streaming_json_lexer_error_category category_instance;
 
-const std::error_category&
-streaming_json_lexer_category() noexcept
+auto
+streaming_json_lexer_category() noexcept -> const std::error_category&
 {
-    return category_instance;
+  return category_instance;
 }
 } // namespace couchbase::core::impl

data/ext/couchbase/core/impl/subdoc/array_add_unique.cxx

@@ -26,11 +26,11 @@ namespace couchbase
 void
 subdoc::array_add_unique::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      core::impl::subdoc::opcode::array_add_unique,
-      path_,
-      value_,
-      core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, expand_macro_),
-    });
+  bundle.emplace_back({
+    core::impl::subdoc::opcode::array_add_unique,
+    path_,
+    value_,
+    core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, expand_macro_, false),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/array_append.cxx

@@ -27,11 +27,11 @@ namespace couchbase
 void
 subdoc::array_append::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      core::impl::subdoc::opcode::array_push_last,
-      path_,
-      core::impl::subdoc::join_values(values_),
-      core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, false),
-    });
+  bundle.emplace_back({
+    core::impl::subdoc::opcode::array_push_last,
+    path_,
+    core::impl::subdoc::join_values(values_),
+    core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, false, false),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/array_insert.cxx

@@ -27,11 +27,11 @@ namespace couchbase
 void
 subdoc::array_insert::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      core::impl::subdoc::opcode::array_insert,
-      path_,
-      core::impl::subdoc::join_values(values_),
-      core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, false),
-    });
+  bundle.emplace_back({
+    core::impl::subdoc::opcode::array_insert,
+    path_,
+    core::impl::subdoc::join_values(values_),
+    core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, false, false),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/array_prepend.cxx

@@ -27,11 +27,11 @@ namespace couchbase
 void
 subdoc::array_prepend::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      core::impl::subdoc::opcode::array_push_first,
-      path_,
-      core::impl::subdoc::join_values(values_),
-      core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, false),
-    });
+  bundle.emplace_back({
+    core::impl::subdoc::opcode::array_push_first,
+    path_,
+    core::impl::subdoc::join_values(values_),
+    core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, false, false),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/command.hxx

@@ -32,10 +32,10 @@ namespace couchbase::core::impl::subdoc
  * @internal
  */
 struct command {
-    opcode opcode_;
-    std::string path_;
-    std::vector<std::byte> value_;
-    std::byte flags_;
-    std::size_t original_index_{};
+  opcode opcode_;
+  std::string path_;
+  std::vector<std::byte> value_;
+  std::byte flags_;
+  std::size_t original_index_{};
 };
 } // namespace couchbase::core::impl::subdoc

data/ext/couchbase/core/impl/subdoc/command_bundle.hxx

@@ -25,18 +25,18 @@ namespace couchbase::core::impl::subdoc
 {
 class command_bundle
 {
-  public:
-    void emplace_back(command&& cmd)
-    {
-        store_.emplace_back(std::move(cmd));
-    }
+public:
+  void emplace_back(command&& cmd)
+  {
+    store_.emplace_back(std::move(cmd));
+  }
 
-    [[nodiscard]] auto specs() const -> const std::vector<command>&
-    {
-        return store_;
-    }
+  [[nodiscard]] auto specs() const -> const std::vector<command>&
+  {
+    return store_;
+  }
 
-  private:
-    std::vector<command> store_{};
+private:
+  std::vector<command> store_{};
 };
 } // namespace couchbase::core::impl::subdoc

data/ext/couchbase/core/impl/subdoc/count.cxx

@@ -26,11 +26,11 @@ namespace couchbase
 void
 subdoc::count::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      core::impl::subdoc::opcode::get_count,
-      path_,
-      {},
-      core::impl::subdoc::build_lookup_in_path_flags(xattr_),
-    });
+  bundle.emplace_back({
+    core::impl::subdoc::opcode::get_count,
+    path_,
+    {},
+    core::impl::subdoc::build_lookup_in_path_flags(xattr_, false),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/counter.cxx

@@ -27,11 +27,11 @@ namespace couchbase
 void
 subdoc::counter::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      core::impl::subdoc::opcode::counter,
-      path_,
-      codec::tao_json_serializer::serialize(delta_),
-      core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, false),
-    });
+  bundle.emplace_back({
+    core::impl::subdoc::opcode::counter,
+    path_,
+    codec::tao_json_serializer::serialize(delta_),
+    core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, false, false),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/exists.cxx

@@ -26,11 +26,11 @@ namespace couchbase
 void
 subdoc::exists::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      core::impl::subdoc::opcode::exists,
-      path_,
-      {},
-      core::impl::subdoc::build_lookup_in_path_flags(xattr_),
-    });
+  bundle.emplace_back({
+    core::impl::subdoc::opcode::exists,
+    path_,
+    {},
+    core::impl::subdoc::build_lookup_in_path_flags(xattr_, false),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/get.cxx

@@ -26,11 +26,11 @@ namespace couchbase
 void
 subdoc::get::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      path_.empty() ? core::impl::subdoc::opcode::get_doc : core::impl::subdoc::opcode::get,
-      path_,
-      {},
-      core::impl::subdoc::build_lookup_in_path_flags(xattr_),
-    });
+  bundle.emplace_back({
+    path_.empty() ? core::impl::subdoc::opcode::get_doc : core::impl::subdoc::opcode::get,
+    path_,
+    {},
+    core::impl::subdoc::build_lookup_in_path_flags(xattr_, binary_),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/insert.cxx

@@ -26,11 +26,11 @@ namespace couchbase
 void
 subdoc::insert::encode(core::impl::subdoc::command_bundle& bundle) const
 {
-    bundle.emplace_back({
-      core::impl::subdoc::opcode::dict_add,
-      path_,
-      value_,
-      core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, expand_macro_),
-    });
+  bundle.emplace_back({
+    core::impl::subdoc::opcode::dict_add,
+    path_,
+    value_,
+    core::impl::subdoc::build_mutate_in_path_flags(xattr_, create_path_, expand_macro_, false),
+  });
 }
 } // namespace couchbase

data/ext/couchbase/core/impl/subdoc/join_values.cxx

@@ -24,33 +24,33 @@ namespace couchbase::core::impl::subdoc
 std::vector<std::byte>
 join_values(const std::vector<std::vector<std::byte>>& values)
 {
-    if (values.empty()) {
-        return {};
-    }
-    if (values.size() == 1) {
-        return values.front();
-    }
-    constexpr std::byte comma{ ',' };
-    std::size_t total_length = values.size() - 1;
-    for (const auto& v : values) {
-        total_length += v.size();
-    }
+  if (values.empty()) {
+    return {};
+  }
+  if (values.size() == 1) {
+    return values.front();
+  }
+  constexpr std::byte comma{ ',' };
+  std::size_t total_length = values.size() - 1;
+  for (const auto& v : values) {
+    total_length += v.size();
+  }
 
-    std::vector<std::byte> result;
-    result.resize(total_length);
+  std::vector<std::byte> result;
+  result.resize(total_length);
 
-    auto sentinel = std::end(values);
-    auto output = result.begin();
-    if (auto it = std::begin(values); it != sentinel) {
-        output = std::copy(it->begin(), it->end(), output);
-        ++it;
-        while (it != sentinel) {
-            *output = comma;
-            ++output;
-            output = std::copy(it->begin(), it->end(), output);
-            ++it;
-        }
+  auto sentinel = std::end(values);
+  auto output = result.begin();
+  if (auto it = std::begin(values); it != sentinel) {
+    output = std::copy(it->begin(), it->end(), output);
+    ++it;
+    while (it != sentinel) {
+      *output = comma;
+      ++output;
+      output = std::copy(it->begin(), it->end(), output);
+      ++it;
     }
-    return result;
+  }
+  return result;
 }
 } // namespace couchbase::core::impl::subdoc

data/ext/couchbase/core/impl/subdoc/lookup_in_macro.cxx

@@ -38,80 +38,81 @@ static const std::string macro_vbucket{ "$vbucket" };
 auto
 to_lookup_in_macro(std::string_view input) -> std::optional<couchbase::subdoc::lookup_in_macro>
 {
-    if (input == macro_document) {
-        return lookup_in_macro::document;
-    }
-    if (input == macro_expiry_time) {
-        return lookup_in_macro::expiry_time;
-    }
-    if (input == macro_cas) {
-        return lookup_in_macro::cas;
-    }
-    if (input == macro_sequence_number) {
-        return lookup_in_macro::sequence_number;
-    }
-    if (input == macro_vbucket_uuid) {
-        return lookup_in_macro::vbucket_uuid;
-    }
-    if (input == macro_last_modified) {
-        return lookup_in_macro::last_modified;
-    }
-    if (input == macro_is_deleted) {
-        return lookup_in_macro::is_deleted;
-    }
-    if (input == macro_value_size_bytes) {
-        return lookup_in_macro::value_size_bytes;
-    }
-    if (input == macro_revision_id) {
-        return lookup_in_macro::revision_id;
-    }
-    if (input == macro_flags) {
-        return lookup_in_macro::flags;
-    }
-    if (input == macro_vbucket) {
-        return lookup_in_macro::vbucket;
-    }
-    return {};
+  if (input == macro_document) {
+    return lookup_in_macro::document;
+  }
+  if (input == macro_expiry_time) {
+    return lookup_in_macro::expiry_time;
+  }
+  if (input == macro_cas) {
+    return lookup_in_macro::cas;
+  }
+  if (input == macro_sequence_number) {
+    return lookup_in_macro::sequence_number;
+  }
+  if (input == macro_vbucket_uuid) {
+    return lookup_in_macro::vbucket_uuid;
+  }
+  if (input == macro_last_modified) {
+    return lookup_in_macro::last_modified;
+  }
+  if (input == macro_is_deleted) {
+    return lookup_in_macro::is_deleted;
+  }
+  if (input == macro_value_size_bytes) {
+    return lookup_in_macro::value_size_bytes;
+  }
+  if (input == macro_revision_id) {
+    return lookup_in_macro::revision_id;
+  }
+  if (input == macro_flags) {
+    return lookup_in_macro::flags;
+  }
+  if (input == macro_vbucket) {
+    return lookup_in_macro::vbucket;
+  }
+  return {};
 }
 
 auto
 to_string(lookup_in_macro value) -> const std::string&
 {
-    switch (value) {
-        case lookup_in_macro::document:
-            return macro_document;
+  switch (value) {
+    case lookup_in_macro::document:
+      return macro_document;
 
-        case lookup_in_macro::expiry_time:
-            return macro_expiry_time;
+    case lookup_in_macro::expiry_time:
+      return macro_expiry_time;
 
-        case lookup_in_macro::cas:
-            return macro_cas;
+    case lookup_in_macro::cas:
+      return macro_cas;
 
-        case lookup_in_macro::sequence_number:
-            return macro_sequence_number;
+    case lookup_in_macro::sequence_number:
+      return macro_sequence_number;
 
-        case lookup_in_macro::vbucket_uuid:
-            return macro_vbucket_uuid;
+    case lookup_in_macro::vbucket_uuid:
+      return macro_vbucket_uuid;
 
-        case lookup_in_macro::last_modified:
-            return macro_last_modified;
+    case lookup_in_macro::last_modified:
+      return macro_last_modified;
 
-        case lookup_in_macro::is_deleted:
-            return macro_is_deleted;
+    case lookup_in_macro::is_deleted:
+      return macro_is_deleted;
 
-        case lookup_in_macro::value_size_bytes:
-            return macro_value_size_bytes;
+    case lookup_in_macro::value_size_bytes:
+      return macro_value_size_bytes;
 
-        case lookup_in_macro::revision_id:
-            return macro_revision_id;
+    case lookup_in_macro::revision_id:
+      return macro_revision_id;
 
-        case lookup_in_macro::flags:
-            return macro_flags;
+    case lookup_in_macro::flags:
+      return macro_flags;
 
-        case lookup_in_macro::vbucket:
-            return macro_vbucket;
-    }
-    throw std::system_error(errc::common::invalid_argument,
-                            "Unexpected lookup_in macro: " + std::to_string(static_cast<std::uint32_t>(value)));
+    case lookup_in_macro::vbucket:
+      return macro_vbucket;
+  }
+  throw std::system_error(errc::common::invalid_argument,
+                          "Unexpected lookup_in macro: " +
+                            std::to_string(static_cast<std::uint32_t>(value)));
 }
 } // namespace couchbase::subdoc