couchbase 3.4.3 → 3.4.4

data/ext/couchbase/core/impl/get_bucket.cxx

@@ -0,0 +1,153 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2020-Present Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#include <couchbase/manager_error_context.hxx>
+#include <utility>
+
+#include "core/cluster.hxx"
+#include "core/operations/management/bucket_get.hxx"
+#include "couchbase/bucket_manager.hxx"
+
+namespace couchbase
+{
+template<typename Response>
+static manager_error_context
+build_context(Response& resp)
+{
+    return manager_error_context(internal_manager_error_context{ resp.ctx.ec,
+                                                                 resp.ctx.last_dispatched_to,
+                                                                 resp.ctx.last_dispatched_from,
+                                                                 resp.ctx.retry_attempts,
+                                                                 std::move(resp.ctx.retry_reasons),
+                                                                 std::move(resp.ctx.client_context_id),
+                                                                 resp.ctx.http_status,
+                                                                 std::move(resp.ctx.http_body),
+                                                                 std::move(resp.ctx.path) });
+}
+
+static core::operations::management::bucket_get_request
+build_get_bucket_request(std::string bucket_name, const get_bucket_options::built& options)
+{
+    core::operations::management::bucket_get_request request{ std::move(bucket_name), {}, options.timeout };
+    return request;
+}
+
+static couchbase::management::cluster::bucket_settings
+map_bucket_settings(const couchbase::core::management::cluster::bucket_settings& bucket)
+{
+    couchbase::management::cluster::bucket_settings bucket_settings{};
+    bucket_settings.name = bucket.name;
+    bucket_settings.ram_quota_mb = bucket.ram_quota_mb;
+    bucket_settings.max_expiry = bucket.max_expiry;
+    bucket_settings.minimum_durability_level = bucket.minimum_durability_level;
+    bucket_settings.num_replicas = bucket.num_replicas;
+    bucket_settings.replica_indexes = bucket.replica_indexes;
+    bucket_settings.flush_enabled = bucket.flush_enabled;
+    switch (bucket.conflict_resolution_type) {
+        case core::management::cluster::bucket_conflict_resolution::unknown:
+            bucket_settings.conflict_resolution_type = management::cluster::bucket_conflict_resolution::unknown;
+            break;
+        case core::management::cluster::bucket_conflict_resolution::timestamp:
+            bucket_settings.conflict_resolution_type = management::cluster::bucket_conflict_resolution::timestamp;
+            break;
+        case core::management::cluster::bucket_conflict_resolution::sequence_number:
+            bucket_settings.conflict_resolution_type = management::cluster::bucket_conflict_resolution::sequence_number;
+            break;
+        case core::management::cluster::bucket_conflict_resolution::custom:
+            bucket_settings.conflict_resolution_type = management::cluster::bucket_conflict_resolution::custom;
+            break;
+    }
+    switch (bucket.eviction_policy) {
+        case core::management::cluster::bucket_eviction_policy::unknown:
+            bucket_settings.eviction_policy = management::cluster::bucket_eviction_policy::unknown;
+            break;
+        case core::management::cluster::bucket_eviction_policy::full:
+            bucket_settings.eviction_policy = management::cluster::bucket_eviction_policy::full;
+            break;
+        case core::management::cluster::bucket_eviction_policy::value_only:
+            bucket_settings.eviction_policy = management::cluster::bucket_eviction_policy::value_only;
+            break;
+        case core::management::cluster::bucket_eviction_policy::no_eviction:
+            bucket_settings.eviction_policy = management::cluster::bucket_eviction_policy::no_eviction;
+            break;
+        case core::management::cluster::bucket_eviction_policy::not_recently_used:
+            bucket_settings.eviction_policy = management::cluster::bucket_eviction_policy::not_recently_used;
+            break;
+    }
+    switch (bucket.compression_mode) {
+        case core::management::cluster::bucket_compression::unknown:
+            bucket_settings.compression_mode = management::cluster::bucket_compression::unknown;
+            break;
+        case core::management::cluster::bucket_compression::off:
+            bucket_settings.compression_mode = management::cluster::bucket_compression::off;
+            break;
+        case core::management::cluster::bucket_compression::active:
+            bucket_settings.compression_mode = management::cluster::bucket_compression::active;
+            break;
+        case core::management::cluster::bucket_compression::passive:
+            bucket_settings.compression_mode = management::cluster::bucket_compression::passive;
+            break;
+    }
+    switch (bucket.bucket_type) {
+        case core::management::cluster::bucket_type::unknown:
+            bucket_settings.bucket_type = management::cluster::bucket_type::unknown;
+            break;
+        case core::management::cluster::bucket_type::couchbase:
+            bucket_settings.bucket_type = management::cluster::bucket_type::couchbase;
+            break;
+        case core::management::cluster::bucket_type::memcached:
+            bucket_settings.bucket_type = management::cluster::bucket_type::memcached;
+            break;
+        case core::management::cluster::bucket_type::ephemeral:
+            bucket_settings.bucket_type = management::cluster::bucket_type::ephemeral;
+            break;
+    }
+    switch (bucket.storage_backend) {
+        case core::management::cluster::bucket_storage_backend::unknown:
+            bucket_settings.storage_backend = management::cluster::bucket_storage_backend::unknown;
+            break;
+        case core::management::cluster::bucket_storage_backend::couchstore:
+            bucket_settings.storage_backend = management::cluster::bucket_storage_backend::couchstore;
+            break;
+        case core::management::cluster::bucket_storage_backend::magma:
+            bucket_settings.storage_backend = management::cluster::bucket_storage_backend::magma;
+            break;
+    }
+    return bucket_settings;
+}
+
+void
+bucket_manager::get_bucket(std::string bucket_name, const get_bucket_options& options, get_bucket_handler&& handler) const
+{
+    auto request = build_get_bucket_request(std::move(bucket_name), options.build());
+
+    core_->execute(std::move(request), [handler = std::move(handler)](core::operations::management::bucket_get_response resp) mutable {
+        return handler(build_context(resp), map_bucket_settings(resp.bucket));
+    });
+}
+
+auto
+bucket_manager::get_bucket(std::string bucket_name, const get_bucket_options& options) const
+  -> std::future<std::pair<manager_error_context, management::cluster::bucket_settings>>
+{
+    auto barrier = std::make_shared<std::promise<std::pair<manager_error_context, management::cluster::bucket_settings>>>();
+    get_bucket(std::move(bucket_name), options, [barrier](auto ctx, auto result) mutable {
+        barrier->set_value(std::make_pair(std::move(ctx), std::move(result)));
+    });
+    return barrier->get_future();
+}
+} // namespace couchbase

data/ext/couchbase/core/impl/internal_manager_error_context.cxx

@@ -0,0 +1,113 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2023-Present Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#include "internal_manager_error_context.hxx"
+#include <couchbase/error_context.hxx>
+
+#include <optional>
+
+namespace couchbase
+{
+internal_manager_error_context::internal_manager_error_context(internal_manager_error_context&& other) noexcept = default;
+
+internal_manager_error_context&
+internal_manager_error_context::operator=(internal_manager_error_context&& other) noexcept = default;
+
+internal_manager_error_context::internal_manager_error_context(std::error_code ec,
+                                                               std::optional<std::string> last_dispatched_to,
+                                                               std::optional<std::string> last_dispatched_from,
+                                                               std::size_t retry_attempts,
+                                                               std::set<retry_reason> retry_reasons,
+                                                               std::string client_context_id,
+                                                               std::uint32_t http_status,
+                                                               std::string content,
+                                                               std::string path)
+  : ctx_{ ec,
+          std::move(client_context_id),
+          {},
+          std::move(path),
+          http_status,
+          { std::move(content) },
+          {},
+          {},
+          std::move(last_dispatched_to),
+          std::move(last_dispatched_from),
+          retry_attempts,
+          std::move(retry_reasons) }
+{
+}
+
+auto
+internal_manager_error_context::path() const -> const std::string&
+{
+    return ctx_.path;
+}
+
+auto
+internal_manager_error_context::content() const -> const std::string&
+{
+    return ctx_.http_body;
+}
+
+auto
+internal_manager_error_context::client_context_id() const -> const std::string&
+{
+    return ctx_.client_context_id;
+}
+
+auto
+internal_manager_error_context::http_status() const -> std::uint32_t
+{
+    return ctx_.http_status;
+}
+
+auto
+internal_manager_error_context::ec() const -> std::error_code
+{
+    return ctx_.ec;
+}
+
+auto
+internal_manager_error_context::last_dispatched_to() const -> const std::optional<std::string>&
+{
+    return ctx_.last_dispatched_to;
+}
+
+auto
+internal_manager_error_context::last_dispatched_from() const -> const std::optional<std::string>&
+{
+    return ctx_.last_dispatched_from;
+}
+
+auto
+internal_manager_error_context::retry_attempts() const -> std::size_t
+{
+    return ctx_.retry_attempts;
+}
+
+auto
+internal_manager_error_context::retry_reasons() const -> const std::set<retry_reason>&
+{
+    return ctx_.retry_reasons;
+}
+
+auto
+internal_manager_error_context::retried_because_of(retry_reason reason) const -> bool
+{
+    return ctx_.retry_reasons.count(reason) > 0;
+}
+} // namespace couchbase

data/ext/couchbase/core/impl/internal_manager_error_context.hxx

@@ -0,0 +1,60 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2023-Present Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#pragma once
+
+#include "core/error_context/http.hxx"
+
+#include <cstdint>
+#include <optional>
+#include <string>
+
+namespace couchbase
+{
+class internal_manager_error_context
+{
+  public:
+    explicit internal_manager_error_context(std::error_code ec,
+                                            std::optional<std::string> last_dispatched_to,
+                                            std::optional<std::string> last_dispatched_from,
+                                            std::size_t retry_attempts,
+                                            std::set<retry_reason> retry_reasons,
+                                            std::string client_context_id,
+                                            std::uint32_t http_status,
+                                            std::string content,
+                                            std::string path);
+    internal_manager_error_context(internal_manager_error_context&& other) noexcept;
+    internal_manager_error_context& operator=(internal_manager_error_context&& other) noexcept;
+    internal_manager_error_context(const internal_manager_error_context& other) = delete;
+    internal_manager_error_context& operator=(const internal_manager_error_context& other) = delete;
+
+    [[nodiscard]] auto path() const -> const std::string&;
+    [[nodiscard]] auto content() const -> const std::string&;
+    [[nodiscard]] auto client_context_id() const -> const std::string&;
+    [[nodiscard]] auto http_status() const -> std::uint32_t;
+
+    [[nodiscard]] auto ec() const -> std::error_code;
+    [[nodiscard]] auto last_dispatched_to() const -> const std::optional<std::string>&;
+    [[nodiscard]] auto last_dispatched_from() const -> const std::optional<std::string>&;
+    [[nodiscard]] auto retry_attempts() const -> std::size_t;
+    [[nodiscard]] auto retry_reasons() const -> const std::set<retry_reason>&;
+    [[nodiscard]] auto retried_because_of(retry_reason reason) const -> bool;
+
+  private:
+    core::error_context::http ctx_;
+};
+} // namespace couchbase

data/ext/couchbase/core/impl/key_value_error_category.cxx

@@ -84,10 +84,8 @@ struct key_value_error_category : std::error_category {
                 return "cannot_revive_living_document (131)";
             case errc::key_value::xattr_no_access:
                 return "xattr_no_access (130)";
-            case errc::key_value::range_scan_cancelled:
-                return "range_scan_cancelled (132)";
-            case errc::key_value::range_scan_vb_uuid_not_equal:
-                return "range_scan_vb_uuid_not_equal (133)";
+            case errc::key_value::mutation_token_outdated:
+                return "mutation_token_outdated (133)";
             case errc::key_value::range_scan_completed:
                 return "range_scan_completed (134)";
         }

data/ext/couchbase/core/impl/key_value_error_context.cxx

@@ -0,0 +1,98 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2020-Present Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#include <couchbase/key_value_error_context.hxx>
+
+#include <couchbase/fmt/cas.hxx>
+#include <couchbase/fmt/key_value_error_map_attribute.hxx>
+#include <couchbase/fmt/key_value_status_code.hxx>
+#include <couchbase/fmt/retry_reason.hxx>
+
+#include <tao/json/to_string.hpp>
+
+namespace couchbase
+{
+auto
+key_value_error_context::to_json() const -> std::string
+{
+    tao::json::value json = {
+        {
+          "ec",
+          tao::json::value{
+            { "value", ec().value() },
+            { "message", ec().message() },
+          },
+        },
+        { "operation_id", operation_id() },
+        { "id", id_ },
+        { "bucket", bucket_ },
+        { "scope", scope_ },
+        { "collection", collection_ },
+    };
+
+    if (auto val = retry_attempts(); val > 0) {
+        json["retry_attempts"] = val;
+    }
+    if (opaque_ > 0) {
+        json["opaque"] = opaque_;
+    }
+
+    if (!cas_.empty()) {
+        json["cas"] = fmt::format("{}", cas_);
+    }
+
+    if (const auto& reasons = retry_reasons(); !reasons.empty()) {
+        tao::json::value reasons_json = tao::json::empty_array;
+        for (const auto& reason : reasons) {
+            reasons_json.emplace_back(fmt::format("{}", reason));
+        }
+        json["retry_reasons"] = reasons_json;
+    }
+    if (const auto& val = last_dispatched_from(); val.has_value()) {
+        json["last_dispatched_from"] = val.value();
+    }
+    if (const auto& val = last_dispatched_to(); val.has_value()) {
+        json["last_dispatched_to"] = val.value();
+    }
+    if (const auto& val = status_code_; val.has_value()) {
+        json["status_code"] = fmt::format("{}", val.value());
+    }
+    if (const auto& val = extended_error_info_; val.has_value()) {
+        json["extended_error_info"] = tao::json::value{
+            { "context", val->context() },
+            { "reference", val->reference() },
+        };
+    }
+    if (const auto& val = error_map_info_; val.has_value()) {
+        tao::json::value info{
+            { "code", val->code() },
+            { "name", val->name() },
+            { "description", val->description() },
+        };
+        if (const auto& attributes = val->attributes(); !attributes.empty()) {
+            tao::json::value attrs_json = tao::json::empty_array;
+            for (const auto& attr : attributes) {
+                attrs_json.emplace_back(fmt::format("{}", attr));
+            }
+            info["attributes"] = attrs_json;
+        }
+        json["error_map_info"] = info;
+    }
+
+    return tao::json::to_string(json, 2);
+}
+} // namespace couchbase

data/ext/couchbase/core/impl/lookup_in.cxx

@@ -60,6 +60,7 @@ initiate_lookup_in_operation(std::shared_ptr<couchbase::core::cluster> core,
                 std::move(entry.value),
                 entry.original_index,
                 entry.exists,
+                entry.ec,
               });
           }
           return handler(std::move(resp.ctx), lookup_in_result{ resp.cas, std::move(entries), resp.deleted });

data/ext/couchbase/core/impl/lookup_in_all_replicas.cxx

@@ -0,0 +1,176 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2020-Present Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#include "lookup_in_all_replicas.hxx"
+#include "lookup_in_replica.hxx"
+
+#include "core/cluster.hxx"
+#include "core/error_context/key_value.hxx"
+#include "core/operations/document_lookup_in.hxx"
+#include "core/topology/configuration.hxx"
+
+namespace couchbase::core::impl
+{
+
+void
+initiate_lookup_in_all_replicas_operation(std::shared_ptr<cluster> core,
+                                          const std::string& bucket_name,
+                                          const std::string& scope_name,
+                                          const std::string& collection_name,
+                                          std::string document_key,
+                                          const std::vector<subdoc::command>& specs,
+                                          lookup_in_all_replicas_options::built options,
+                                          lookup_in_all_replicas_handler&& handler)
+{
+    return initiate_lookup_in_all_replicas_operation(std::move(core),
+                                                     bucket_name,
+                                                     scope_name,
+                                                     collection_name,
+                                                     std::move(document_key),
+                                                     specs,
+                                                     options.timeout,
+                                                     movable_lookup_in_all_replicas_handler{ std::move(handler) });
+}
+
+void
+initiate_lookup_in_all_replicas_operation(std::shared_ptr<cluster> core,
+                                          const std::string& bucket_name,
+                                          const std::string& scope_name,
+                                          const std::string& collection_name,
+                                          std::string document_key,
+                                          const std::vector<subdoc::command>& specs,
+                                          std::optional<std::chrono::milliseconds> timeout,
+                                          movable_lookup_in_all_replicas_handler&& handler)
+{
+    auto request = std::make_shared<couchbase::core::impl::lookup_in_all_replicas_request>(
+      bucket_name, scope_name, collection_name, std::move(document_key), specs, timeout);
+    core->with_bucket_configuration(
+      bucket_name,
+      [core, r = std::move(request), h = std::move(handler)](std::error_code ec, const core::topology::configuration& config) mutable {
+          if (!config.supports_subdoc_read_replica()) {
+              ec = errc::common::feature_not_available;
+          }
+
+          if (ec) {
+              std::optional<std::string> first_error_path{};
+              std::optional<std::size_t> first_error_index{};
+              return h(
+                make_subdocument_error_context(make_key_value_error_context(ec, r->id()), ec, first_error_path, first_error_index, false),
+                lookup_in_all_replicas_result{});
+          }
+          struct replica_context {
+              replica_context(movable_lookup_in_all_replicas_handler handler, std::uint32_t expected_responses)
+                : handler_(std::move(handler))
+                , expected_responses_(expected_responses)
+              {
+              }
+
+              movable_lookup_in_all_replicas_handler handler_;
+              std::uint32_t expected_responses_;
+              bool done_{ false };
+              std::mutex mutex_{};
+              lookup_in_all_replicas_result result_{};
+          };
+          auto ctx = std::make_shared<replica_context>(std::move(h), config.num_replicas.value_or(0U) + 1U);
+
+          for (std::size_t idx = 1U; idx <= config.num_replicas.value_or(0U); ++idx) {
+              document_id replica_id{ r->id() };
+              replica_id.node_index(idx);
+              core->execute(
+                impl::lookup_in_replica_request{ std::move(replica_id), r->specs(), r->timeout() },
+                [ctx](impl::lookup_in_replica_response&& resp) {
+                    movable_lookup_in_all_replicas_handler local_handler{};
+                    {
+                        std::scoped_lock lock(ctx->mutex_);
+                        if (ctx->done_) {
+                            return;
+                        }
+                        --ctx->expected_responses_;
+                        if (resp.ctx.ec()) {
+                            if (ctx->expected_responses_ > 0) {
+                                // just ignore the response
+                                return;
+                            }
+                        } else {
+                            std::vector<lookup_in_replica_result::entry> entries{};
+                            for (auto& field : resp.fields) {
+                                lookup_in_replica_result::entry lookup_in_entry{};
+                                lookup_in_entry.path = field.path;
+                                lookup_in_entry.value = field.value;
+                                lookup_in_entry.exists = field.exists;
+                                lookup_in_entry.original_index = field.original_index;
+                                entries.emplace_back(lookup_in_entry);
+                            }
+                            ctx->result_.emplace_back(lookup_in_replica_result{ resp.cas, entries, resp.deleted, true /* replica */ });
+                        }
+                        if (ctx->expected_responses_ == 0) {
+                            ctx->done_ = true;
+                            std::swap(local_handler, ctx->handler_);
+                        }
+                    }
+                    if (local_handler) {
+                        if (!ctx->result_.empty()) {
+                            resp.ctx.override_ec({});
+                        }
+                        return local_handler(std::move(resp.ctx), std::move(ctx->result_));
+                    }
+                });
+          }
+
+          core::operations::lookup_in_request active{ document_id{ r->id() } };
+          active.specs = r->specs();
+          active.timeout = r->timeout();
+          core->execute(active, [ctx](core::operations::lookup_in_response&& resp) {
+              movable_lookup_in_all_replicas_handler local_handler{};
+              {
+                  std::scoped_lock lock(ctx->mutex_);
+                  if (ctx->done_) {
+                      return;
+                  }
+                  --ctx->expected_responses_;
+                  if (resp.ctx.ec()) {
+                      if (ctx->expected_responses_ > 0) {
+                          // just ignore the response
+                          return;
+                      }
+                  } else {
+                      std::vector<lookup_in_replica_result::entry> entries{};
+                      for (auto& field : resp.fields) {
+                          lookup_in_replica_result::entry lookup_in_entry{};
+                          lookup_in_entry.path = field.path;
+                          lookup_in_entry.value = field.value;
+                          lookup_in_entry.exists = field.exists;
+                          lookup_in_entry.original_index = field.original_index;
+                          entries.emplace_back(lookup_in_entry);
+                      }
+                      ctx->result_.emplace_back(lookup_in_replica_result{ resp.cas, entries, resp.deleted, false /* active */ });
+                  }
+                  if (ctx->expected_responses_ == 0) {
+                      ctx->done_ = true;
+                      std::swap(local_handler, ctx->handler_);
+                  }
+              }
+              if (local_handler) {
+                  if (!ctx->result_.empty()) {
+                      resp.ctx.override_ec({});
+                  }
+                  return local_handler(std::move(resp.ctx), std::move(ctx->result_));
+              }
+          });
+      });
+}
+} // namespace couchbase::core::impl