couchbase 3.0.1 → 3.0.2

data/ext/couchbase/operations/query_index_drop.hxx

@@ -51,7 +51,7 @@ struct query_index_drop_request {
     bool ignore_if_does_not_exist{ false };
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.headers["content-type"] = "application/json";
         std::string keyspace = fmt::format("`{}`", bucket_name);
@@ -68,11 +68,12 @@ struct query_index_drop_request {
         encoded.method = "POST";
         encoded.path = "/query/service";
         encoded.body = tao::json::to_string(body);
+        return {};
     }
 };
 
 query_index_drop_response
-make_response(std::error_code ec, query_index_drop_request& request, query_index_drop_request::encoded_response_type encoded)
+make_response(std::error_code ec, query_index_drop_request& request, query_index_drop_request::encoded_response_type&& encoded)
 {
     query_index_drop_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/query_index_get_all.hxx

@@ -56,7 +56,7 @@ struct query_index_get_all_request {
     std::string bucket_name;
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.headers["content-type"] = "application/json";
         tao::json::value body{
@@ -70,11 +70,12 @@ struct query_index_get_all_request {
         encoded.method = "POST";
         encoded.path = "/query/service";
         encoded.body = tao::json::to_string(body);
+        return {};
     }
 };
 
 query_index_get_all_response
-make_response(std::error_code ec, query_index_get_all_request& request, query_index_get_all_request::encoded_response_type encoded)
+make_response(std::error_code ec, query_index_get_all_request& request, query_index_get_all_request::encoded_response_type&& encoded)
 {
     query_index_get_all_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/role_get_all.hxx

@@ -42,16 +42,17 @@ struct role_get_all_request {
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
     std::string client_context_id{ uuid::to_string(uuid::random()) };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = "/settings/rbac/roles";
         encoded.headers["content-type"] = "application/x-www-form-urlencoded";
+        return {};
     }
 };
 
 role_get_all_response
-make_response(std::error_code ec, role_get_all_request& request, role_get_all_request::encoded_response_type encoded)
+make_response(std::error_code ec, role_get_all_request& request, role_get_all_request::encoded_response_type&& encoded)
 {
     role_get_all_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/scope_create.hxx

@@ -44,17 +44,18 @@ struct scope_create_request {
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
     std::string client_context_id{ uuid::to_string(uuid::random()) };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "POST";
         encoded.path = fmt::format("/pools/default/buckets/{}/collections", bucket_name);
         encoded.headers["content-type"] = "application/x-www-form-urlencoded";
         encoded.body = fmt::format("name={}", utils::string_codec::form_encode(scope_name));
+        return {};
     }
 };
 
 scope_create_response
-make_response(std::error_code ec, scope_create_request& request, scope_create_request::encoded_response_type encoded)
+make_response(std::error_code ec, scope_create_request& request, scope_create_request::encoded_response_type&& encoded)
 {
     scope_create_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/scope_drop.hxx

@@ -44,15 +44,16 @@ struct scope_drop_request {
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
     std::string client_context_id{ uuid::to_string(uuid::random()) };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "DELETE";
         encoded.path = fmt::format("/pools/default/buckets/{}/collections/{}", bucket_name, scope_name);
+        return {};
     }
 };
 
 scope_drop_response
-make_response(std::error_code ec, scope_drop_request& request, scope_drop_request::encoded_response_type encoded)
+make_response(std::error_code ec, scope_drop_request& request, scope_drop_request::encoded_response_type&& encoded)
 {
     scope_drop_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/scope_get_all.hxx

@@ -43,15 +43,16 @@ struct scope_get_all_request {
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
     std::string client_context_id{ uuid::to_string(uuid::random()) };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = fmt::format("/pools/default/buckets/{}/collections", bucket_name);
+        return {};
     }
 };
 
 scope_get_all_response
-make_response(std::error_code ec, scope_get_all_request& request, scope_get_all_request::encoded_response_type encoded)
+make_response(std::error_code ec, scope_get_all_request& request, scope_get_all_request::encoded_response_type&& encoded)
 {
     scope_get_all_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_get_stats.hxx

@@ -39,15 +39,16 @@ struct search_index_stats_request {
     std::string client_context_id{ uuid::to_string(uuid::random()) };
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = "/api/nsstats";
+        return {};
     }
 };
 
 search_index_stats_response
-make_response(std::error_code ec, search_index_stats_request& request, search_index_stats_request::encoded_response_type encoded)
+make_response(std::error_code ec, search_index_stats_request& request, search_index_stats_request::encoded_response_type&& encoded)
 {
     search_index_stats_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_analyze_document.hxx

@@ -44,20 +44,21 @@ struct search_index_analyze_document_request {
     std::string index_name;
     std::string encoded_document;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "POST";
         encoded.headers["cache-control"] = "no-cache";
         encoded.headers["content-type"] = "application/json";
         encoded.path = fmt::format("/api/index/{}/analyzeDoc", index_name);
         encoded.body = encoded_document;
+        return {};
     }
 };
 
 search_index_analyze_document_response
 make_response(std::error_code ec,
               search_index_analyze_document_request& request,
-              search_index_analyze_document_request::encoded_response_type encoded)
+              search_index_analyze_document_request::encoded_response_type&& encoded)
 {
     search_index_analyze_document_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_control_ingest.hxx

@@ -43,17 +43,18 @@ struct search_index_control_ingest_request {
     std::string index_name;
     bool pause;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "POST";
         encoded.path = fmt::format("/api/index/{}/ingestControl/{}", index_name, pause ? "pause" : "resume");
+        return {};
     }
 };
 
 search_index_control_ingest_response
 make_response(std::error_code ec,
               search_index_control_ingest_request& request,
-              search_index_control_ingest_request::encoded_response_type encoded)
+              search_index_control_ingest_request::encoded_response_type&& encoded)
 {
     search_index_control_ingest_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_control_plan_freeze.hxx

@@ -43,17 +43,18 @@ struct search_index_control_plan_freeze_request {
     std::string index_name;
     bool freeze;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "POST";
         encoded.path = fmt::format("/api/index/{}/planFreezeControl/{}", index_name, freeze ? "freeze" : "unfreeze");
+        return {};
     }
 };
 
 search_index_control_plan_freeze_response
 make_response(std::error_code ec,
               search_index_control_plan_freeze_request& request,
-              search_index_control_plan_freeze_request::encoded_response_type encoded)
+              search_index_control_plan_freeze_request::encoded_response_type&& encoded)
 {
     search_index_control_plan_freeze_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_control_query.hxx

@@ -43,17 +43,18 @@ struct search_index_control_query_request {
     std::string index_name;
     bool allow;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "POST";
         encoded.path = fmt::format("/api/index/{}/queryControl/{}", index_name, allow ? "allow" : "disallow");
+        return {};
     }
 };
 
 search_index_control_query_response
 make_response(std::error_code ec,
               search_index_control_query_request& request,
-              search_index_control_query_request::encoded_response_type encoded)
+              search_index_control_query_request::encoded_response_type&& encoded)
 {
     search_index_control_query_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_drop.hxx

@@ -42,15 +42,16 @@ struct search_index_drop_request {
 
     std::string index_name;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "DELETE";
         encoded.path = fmt::format("/api/index/{}", index_name);
+        return {};
     }
 };
 
 search_index_drop_response
-make_response(std::error_code ec, search_index_drop_request& request, search_index_drop_request::encoded_response_type encoded)
+make_response(std::error_code ec, search_index_drop_request& request, search_index_drop_request::encoded_response_type&& encoded)
 {
     search_index_drop_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_get.hxx

@@ -44,15 +44,16 @@ struct search_index_get_request {
 
     std::string index_name;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = fmt::format("/api/index/{}", index_name);
+        return {};
     }
 };
 
 search_index_get_response
-make_response(std::error_code ec, search_index_get_request& request, search_index_get_request::encoded_response_type encoded)
+make_response(std::error_code ec, search_index_get_request& request, search_index_get_request::encoded_response_type&& encoded)
 {
     search_index_get_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_get_all.hxx

@@ -44,15 +44,16 @@ struct search_index_get_all_request {
 
     std::string index_name;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = fmt::format("/api/index");
+        return {};
     }
 };
 
 search_index_get_all_response
-make_response(std::error_code ec, search_index_get_all_request& request, search_index_get_all_request::encoded_response_type encoded)
+make_response(std::error_code ec, search_index_get_all_request& request, search_index_get_all_request::encoded_response_type&& encoded)
 {
     search_index_get_all_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_get_documents_count.hxx

@@ -43,17 +43,18 @@ struct search_index_get_documents_count_request {
 
     std::string index_name;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = fmt::format("/api/index/{}/count", index_name);
+        return {};
     }
 };
 
 search_index_get_documents_count_response
 make_response(std::error_code ec,
               search_index_get_documents_count_request& request,
-              search_index_get_documents_count_request::encoded_response_type encoded)
+              search_index_get_documents_count_request::encoded_response_type&& encoded)
 {
     search_index_get_documents_count_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_get_stats.hxx

@@ -43,15 +43,16 @@ struct search_index_get_stats_request {
 
     std::string index_name;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = fmt::format("/api/stats/index/{}", index_name);
+        return {};
     }
 };
 
 search_index_get_stats_response
-make_response(std::error_code ec, search_index_get_stats_request& request, search_index_get_stats_request::encoded_response_type encoded)
+make_response(std::error_code ec, search_index_get_stats_request& request, search_index_get_stats_request::encoded_response_type&& encoded)
 {
     search_index_get_stats_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/search_index_upsert.hxx

@@ -42,7 +42,7 @@ struct search_index_upsert_request {
 
     search_index index;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "PUT";
         encoded.headers["cache-control"] = "no-cache";
@@ -72,11 +72,12 @@ struct search_index_upsert_request {
             body["planParams"] = tao::json::from_string(index.plan_params_json);
         }
         encoded.body = tao::json::to_string(body);
+        return {};
     }
 };
 
 search_index_upsert_response
-make_response(std::error_code ec, search_index_upsert_request& request, search_index_upsert_request::encoded_response_type encoded)
+make_response(std::error_code ec, search_index_upsert_request& request, search_index_upsert_request::encoded_response_type&& encoded)
 {
     search_index_upsert_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/user_drop.hxx

@@ -43,15 +43,16 @@ struct user_drop_request {
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
     std::string client_context_id{ uuid::to_string(uuid::random()) };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "DELETE";
         encoded.path = fmt::format("/settings/rbac/users/{}/{}", domain, username);
+        return {};
     }
 };
 
 user_drop_response
-make_response(std::error_code ec, user_drop_request& request, user_drop_request::encoded_response_type encoded)
+make_response(std::error_code ec, user_drop_request& request, user_drop_request::encoded_response_type&& encoded)
 {
     user_drop_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/user_get.hxx

@@ -44,16 +44,17 @@ struct user_get_request {
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
     std::string client_context_id{ uuid::to_string(uuid::random()) };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = fmt::format("/settings/rbac/users/{}/{}", domain, username);
         encoded.headers["content-type"] = "application/x-www-form-urlencoded";
+        return {};
     }
 };
 
 user_get_response
-make_response(std::error_code ec, user_get_request& request, user_get_request::encoded_response_type encoded)
+make_response(std::error_code ec, user_get_request& request, user_get_request::encoded_response_type&& encoded)
 {
     user_get_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/user_get_all.hxx

@@ -43,16 +43,17 @@ struct user_get_all_request {
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
     std::string client_context_id{ uuid::to_string(uuid::random()) };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "GET";
         encoded.path = fmt::format("/settings/rbac/users/{}", domain);
         encoded.headers["content-type"] = "application/x-www-form-urlencoded";
+        return {};
     }
 };
 
 user_get_all_response
-make_response(std::error_code ec, user_get_all_request& request, user_get_all_request::encoded_response_type encoded)
+make_response(std::error_code ec, user_get_all_request& request, user_get_all_request::encoded_response_type&& encoded)
 {
     user_get_all_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/user_upsert.hxx

@@ -48,7 +48,7 @@ struct user_upsert_request {
     std::chrono::milliseconds timeout{ timeout_defaults::management_timeout };
     std::string client_context_id{ uuid::to_string(uuid::random()) };
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "PUT";
         encoded.path = fmt::format("/settings/rbac/users/{}/{}", domain, user.username);
@@ -93,11 +93,12 @@ struct user_upsert_request {
         }
         encoded.body = fmt::format("{}", fmt::join(params, "&"));
         encoded.headers["content-type"] = "application/x-www-form-urlencoded";
+        return {};
     }
 };
 
 user_upsert_response
-make_response(std::error_code ec, user_upsert_request& request, user_upsert_request::encoded_response_type encoded)
+make_response(std::error_code ec, user_upsert_request& request, user_upsert_request::encoded_response_type&& encoded)
 {
     user_upsert_response response{ request.client_context_id, ec };
     if (!ec) {

data/ext/couchbase/operations/view_index_drop.hxx

@@ -40,16 +40,17 @@ struct view_index_drop_request {
     std::string document_name;
     design_document::name_space name_space;
 
-    void encode_to(encoded_request_type& encoded, http_context&)
+    [[nodiscard]] std::error_code encode_to(encoded_request_type& encoded, http_context&)
     {
         encoded.method = "DELETE";
         encoded.path =
           fmt::format("/{}/_design/{}{}", bucket_name, name_space == design_document::name_space::development ? "dev_" : "", document_name);
+        return {};
     }
 };
 
 view_index_drop_response
-make_response(std::error_code ec, view_index_drop_request& request, view_index_drop_request::encoded_response_type encoded)
+make_response(std::error_code ec, view_index_drop_request& request, view_index_drop_request::encoded_response_type&& encoded)
 {
     view_index_drop_response response{ request.client_context_id, ec };
     if (!ec) {