couch_potato 1.7.0 → 1.10.1

data/spec/unit/dirty_attributes_spec.rb

@@ -13,19 +13,13 @@ describe 'dirty attribute tracking' do
   end
 
   describe "save" do
-    it "should not save when nothing dirty" do
+    it "should save when nothing dirty" do
       plate = Plate.new :food => 'sushi'
       @db.save_document!(plate)
-      expect(@couchrest_db).not_to receive(:save_doc)
+      expect(@couchrest_db).to receive(:save_doc)
       @db.save_document(plate)
     end
 
-    it "should return true when not dirty" do
-      plate = Plate.new :food => 'sushi'
-      @db.save_document!(plate)
-      expect(@db.save_document(plate)).to be_truthy
-    end
-
     it "should save when there are dirty attributes" do
       plate = Plate.new :food => 'sushi'
       @db.save_document!(plate)
@@ -57,13 +51,13 @@ describe 'dirty attribute tracking' do
         it "should not dup BigDecimal" do
 
           expect {
-            Bowl.new :price => BigDecimal.new("5.23")
+            Bowl.new :price => BigDecimal("5.23")
           }.not_to raise_error
         end
 
         it "should return the old value" do
-          bowl = Bowl.new :price => BigDecimal.new("5.23")
-          bowl.price = BigDecimal.new("2.23")
+          bowl = Bowl.new :price => BigDecimal("5.23")
+          bowl.price = BigDecimal("2.23")
           expect(bowl.price_was).to eq(5.23)
         end
 
@@ -79,11 +73,6 @@ describe 'dirty attribute tracking' do
       it "should return false if attribute not changed" do
         expect(Plate.new).not_to be_food_changed
       end
-
-      it "should return true if forced dirty" do
-        @plate.is_dirty
-        expect(@plate).to be_dirty
-      end
     end
   end
 
@@ -122,15 +111,5 @@ describe 'dirty attribute tracking' do
       db.save! @plate
       expect(@plate).not_to be_food_changed
     end
-
-    it "should reset a forced dirty state" do
-      couchrest_db = double('database', :get => Plate.json_create({'_id' => '1', '_rev' => '2', 'food' => 'sushi', JSON.create_id => 'Plate'}), :info => nil, :save_doc => {'rev' =>  '3'})
-      db = CouchPotato::Database.new(couchrest_db)
-      @plate = db.load_document '1'
-      @plate.is_dirty
-      db.save! @plate
-      expect(@plate).not_to be_dirty
-    end
   end
-
 end

data/spec/unit/flex_view_spec_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe CouchPotato::View::FlexViewSpec::Results, '#reduce_count' do
+  it 'returns the value of the first row (which is the result of reduce)' do
+    result = CouchPotato::View::FlexViewSpec::Results.new 'rows' => [{ 'value' => 3 }]
+
+    expect(result.reduce_count).to eq(3)
+  end
+
+  it 'returns 0 if there is no first row (empty result set)' do
+    result = CouchPotato::View::FlexViewSpec::Results.new 'rows' => []
+
+    expect(result.reduce_count).to eq(0)
+  end
+end

data/spec/unit/model_view_spec_spec.rb

@@ -108,6 +108,6 @@ describe CouchPotato::View::ModelViewSpec, '#map_function' do
 
   it "should raise exception when emit value cannot be handled" do
     spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:emit_value => []}, {}
-    expect { spec.map_function }.to raise_error
+    expect { spec.map_function }.to raise_error(RuntimeError)
   end
 end

data/spec/unit/rspec_stub_db_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'couch_potato-rspec'
 
@@ -40,6 +42,35 @@ describe 'stubbing a view' do
     expect(@db.first!(WithStubbedView.stubbed_view('123'))).to eq(:result)
   end
 
+  it 'stubs the database to return fake results in batches with no given batch size' do
+    @db.stub_view(WithStubbedView, :stubbed_view).with('123').and_return([:result] * 501)
+
+    expect do |b|
+      @db.view_in_batches(WithStubbedView.stubbed_view('123'), &b)
+    end.to yield_successive_args([:result] * 500, [:result])
+  end
+
+  it 'stubs the database to return fake results in batches with a given batch size' do
+    @db.stub_view(WithStubbedView, :stubbed_view).with('123').and_return([:result] * 3)
+
+    expect do |b|
+      @db.view_in_batches(WithStubbedView.stubbed_view('123'), batch_size: 2, &b)
+    end.to yield_successive_args([:result] * 2, [:result])
+  end
+
+  it 'stubs the database to return fake results in batches for multiple view specs' do
+    @db.stub_view(WithStubbedView, :stubbed_view).with('123').and_return([:result])
+    @db.stub_view(WithStubbedView, :stubbed_view).with('456').and_return([:result2])
+
+    expect do |b|
+      @db.view_in_batches(WithStubbedView.stubbed_view('123'), &b)
+    end.to yield_successive_args([:result])
+
+    expect do |b|
+      @db.view_in_batches(WithStubbedView.stubbed_view('456'), &b)
+    end.to yield_successive_args([:result2])
+  end
+
   it 'raises an error if there is no first result' do
     @db.stub_view(WithStubbedView, :stubbed_view).and_return([])
     expect do

data/spec/unit/validation_spec.rb

@@ -1,13 +1,53 @@
 require 'spec_helper'
 
 describe 'CouchPotato Validation' do
-  
+
   describe "access to errors object" do
-    it "should description" do
+    it "adds an errors method the the errors object to be compatible with Validatable" do
       model_class = Class.new
       model_class.send(:include, CouchPotato::Persistence)
       expect(model_class.new.errors).to respond_to(:errors)
     end
   end
 
+  class Monkey
+    include CouchPotato::Persistence
+    property :create_property
+    property :update_property
+
+    validates :create_property, presence: true, on: :create
+    validates :update_property, presence: true, on: :update
+  end
+
+  context 'create' do
+    let(:monkey) { Monkey.new }
+
+    before do
+      monkey.valid?
+    end
+
+    it 'has an error on the create property' do
+      expect(monkey.errors[:create_property]).to be_present
+    end
+
+    it 'has no error on the update property' do
+      expect(monkey.errors[:update_property]).not_to be_present
+    end
+  end
+
+  context 'update' do
+    let(:monkey) { Monkey.new _rev: '1' }
+
+    before do
+      monkey.valid?
+    end
+
+    it 'has no error on the create property' do
+      expect(monkey.errors[:create_property]).to_not be_present
+    end
+
+    it 'has an error on the update property' do
+      expect(monkey.errors[:update_property]).to be_present
+    end
+  end
 end

data/spec/unit/view_query_spec.rb

@@ -15,10 +15,12 @@ describe CouchPotato::View::ViewQuery, 'query_view!' do
 
   it 'updates a view if it does not exist' do
     expect(db).to receive(:save_doc).with(
-      'views' => {'view' => {'map' => '<map_code>', 'reduce' => '<reduce_code>'}, 'lib' => {'test' => '<lib_code>'}},
-      'lists' => {},
-      "_id" => "_design/design",
-      "language" => "javascript"
+      {
+        'views' => {'view' => {'map' => '<map_code>', 'reduce' => '<reduce_code>'}, 'lib' => {'test' => '<lib_code>'}},
+        'lists' => {},
+        "_id" => "_design/design",
+        "language" => "javascript"
+        }
     )
 
     CouchPotato::View::ViewQuery.new(db, 'design', {:view => {:map => '<map_code>', :reduce => '<reduce_code>'}}, nil, {'test' => "<lib_code>"}).query_view!
@@ -46,8 +48,11 @@ describe CouchPotato::View::ViewQuery, 'query_view!' do
 
   it 'updates a view in erlang if it does not exist' do
     expect(db).to receive(:save_doc).with(
-      'views' => {'view' => {'map' => '<map_code>', 'reduce' => '<reduce_code>'}},
-      'lists' => {}, "_id" => "_design/design", "language" => "erlang")
+      {
+        'views' => {'view' => {'map' => '<map_code>', 'reduce' => '<reduce_code>'}},
+        'lists' => {}, "_id" => "_design/design", "language" => "erlang"
+      }
+    )
 
     CouchPotato::View::ViewQuery.new(db, 'design',
       {:view => {:map => '<map_code>', :reduce => '<reduce_code>'}},
@@ -120,7 +125,7 @@ describe CouchPotato::View::ViewQuery, 'query_view!' do
 
   it 'does not pass in reduce or lib keys if there is no lib or reduce object' do
     allow(db).to receive(:get).and_return({'views' => {}})
-    expect(db).to receive(:save_doc).with('views' => {'view7' => {'map' => '<map code>'}})
+    expect(db).to receive(:save_doc).with({'views' => {'view7' => {'map' => '<map code>'}}})
     CouchPotato::View::ViewQuery.new(db, 'design', :view7 => {:map => '<map code>', :reduce => nil}).query_view!
   end