couch_potato 1.22.0 → 1.22.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d8263b3487e2591fa53b3f19f6c7363bfa0d9478d449098d1bc2eee29b90ee7
-  data.tar.gz: 6ab3f176e570bcc2f94f531ba7248cd7bcfdd2a2bde2cf5f13b0fffd077a7dbd
+  metadata.gz: 666f7dd052f1c9fbaa75382ed1bca8103b41603950087f1081cf62ff184964bc
+  data.tar.gz: b6ac16b525eebb35e27d92c5546dcb4ff1359a15991d760ab5c5c39490664b88
 SHA512:
-  metadata.gz: 4f59675db667b580551a53f1a7e978d0f860f2cfad4b7aae58676d59679f84664e45544a38b39d501851d6a76752e097e3912fb3e15f4e5220621b8653c44f0b
-  data.tar.gz: 90c43f70f518f38e325066435b5b5ad3051df392a91399707fc814bb88615bbf90a9eada713781aa20fe5fde73a79730462a22eb8fc1da725218e16f560ba610
+  metadata.gz: 537ff4580ebe58fe9d5b29e10bae273ee70b3b85b7762af94448b70c11b213fc800ca434b6ef47156c62c436b6b398ec162344983fa0d508b2b95611c7560696
+  data.tar.gz: ccb0b54672f83d83762aa900887dbfd950e2d9f8a4fe92790cf01355d3945534fc4a969d9337ba9816dee8715c58a02657795c59074e8a8c553a67a76f9b0f00

data/CHANGES.md

@@ -1,159 +1,175 @@
-## Changes
+# Changes
 
-# 1.22.00
+## 1.22.2
+
+- fix instantiating properties that include CouchPotato::Persistence (call .json_create instead of .new)
+
+## 1.22.1
+
+- fix lazy property loading calling overridden setters (use private `assign_attribute` instead)
+
+## couch_potato-rspec 4.4.0
+
+- support multiple return values in `stub_view(...).and_return` for consecutive `view` / `first` / `first!` / `view_in_batches` calls
+
+## couch_potato-rspec 4.3.0
+
+- support flex views in `stub_db` / `stub_view` (array returns a `FlexViewSpec::Results` stub with `docs`; `first`/`first!` stubbed on the db)
+
+## 1.22.00
 
 - support `Database#first` / `#first!` for flex views
 
-# 1.21.0
+## 1.21.0
 
 - add railties 8.1, Ruby 3.4 to CI
 
-# 1.20.1
+## 1.20.1
 
 - fix `database.save!` did not use passed block
 
-# 1.20.0
+## 1.20.0
 
 - add passing validation context to save methods
 
-# 1.19.2
+## 1.19.2
 
 - fix 404/409 error when querying single design doc with `digest_view_names` enabled
 
-# 1.19.1
+## 1.19.1
 
 - add digest to design doc name if `single_design_document` and `digest_view_names` are enabled
 
-# 1.19.0 / rspec-matchers 4.2.0
+## 1.19.0 / rspec-matchers 4.2.0
 
 - add `single_design_document` config option
 - remove support for lists and lib
 
-# 1.18.0
+## 1.18.0
 
 - add testing Rails 7.2/8 on CI
 - change gemspec to allow for Rails 8
 - remove support for Rails < 7.2
 
-# 1.17.0
+## 1.17.0
 
 - filter out nil ids for loading multiple documents
 - cache nil documents
 
-# 1.16.0
+## 1.16.0
 
 - add payload to ActiveSupport instrumentation calls
 - only notify load.cached when there are cached documents
 
-# 1.15.0
+## 1.15.0
 
 - cache loading multiple documents
 - keep the database cache when switching to another database and back to the original one
 
-# 1.14.0
+## 1.14.0
 
 - add database_collection to models to help avoid n+1 requests
 
-# 1.13.0
+## 1.13.0
 
 - add Ruby 3.2 support
 - remove Ruby 2.7 support
 - add active_support 7.1 support
 - remove active_support 6.x support
 
-# 1.12.1
+## 1.12.1
 
 - re-enable aliases when parsing config yaml file
 
-# 1.12.0
+## 1.12.0
 
 - remove active_support 5.x
 - add Ruby 3.1 support (active_support 6.1, 7.0)
 
-# 1.11.0
+## 1.11.0
 
 - improve view_in_batches performance by switching to using startkey_docid over skip
 
-### 1.10.1
+## 1.10.1
 
 - support passing an empty array to CouchPotato::Database#load
 
-### 1.10.0
+## 1.10.0
 
 - add spec/support for Rails 7
 
-### 1.9.0
+## 1.9.0
 
 - add spec/support for Rails 6.1
 - add caching Couchrest connections to reduce total number created
 
-### 1.8.0
+## 1.8.0
 
 - remove not saving model if it is not dirty. this could lead to missed document updates if the document has been updated in a different process in-between being loaded and saved in the current process.
 
 - remove deep dirty tracking
 
-### 1.7.1
+## 1.7.1
 
 - added support for properties of type Integer
 
-### 1.7.0
+## 1.7.0
 
 - added `_revisions` method that returns all available revisions of a document.
 
-### 1.6.4
+## 1.6.4
 
 - bug fix for accessing inherited properties (Alexander Lang)
 
-### 1.6.3
+## 1.6.3
 
 - added ActiveSupport instrumentation (Alexander Lang)
 
-### 1.6.2
+## 1.6.2
 
 - view digest bugfix (Alexander Lang)
 
-### 1.6.1
+## 1.6.1
 
 - added option to add digests to a single view (Alexander Lang)
 
-### 1.6.0
+## 1.6.0
 
 - added global option to add digests to view names (Alexander Lang)
 
-### 1.5.1
+## 1.5.1
 
 - updated CouchRest to 2.0.0.rc3 in order to re-use http connections. Performance improvements. (Thilo Utke)
 - added passing params to lists (Alexander Lang)
 
-### 1.5.0
+## 1.5.0
 
 - Moved RSpec matchers into couch_potato-rspec gem. This way, people not using RSpec don't need to install the helpers, plus we can release separate matchers for RSpec 2 and 3.
 
-### 1.4.0
+## 1.4.0
 
 - Added support for passing the model to blocks for computing the default value of a property (Alexander Lang)
 
-### 1.3.0
+## 1.3.0
 
 - Add support for built-in couchdb reduce functions in map reduce specs (Andy Morris)
 - Make specs handle CommonJS modules via module.exports as well as exports (Andy Morris)
 - Changed #attributes to return a HashWithIndifferentAccess (Owen Davies)
 
-### 1.2.0
+## 1.2.0
 
 - adds optional deep dirty tracking (andymorris)
 - fixes an exception when deleting an already deleted document (Alexander Lang)
 
-### 1.1.4
+## 1.1.4
 
 - Removes the dependency to json/add/core (cstettner)
 
-### 1.1.3
+## 1.1.3
 
 - removes check if database exists to avoid lots of additional requests (Alexander Lang)
 
-### 1.1.2
+## 1.1.2
 
 - fixes `CouchPotato.models` did not include subclasses
 - adds `CouchPotato.use` (Daniel Lohse)
@@ -161,19 +177,19 @@
 - adds `CouchPotato::Config.database_host` for using multiple databases in a project (Daniel Lohse)
 - makes `cast_native` cast floats with no leading digits (wrshawn)
 
-### 1.1.1
+## 1.1.1
 
 - fixes properties were leaked to sibling classes (Alexander Lang)
 
-### 1.1.0
+## 1.1.0
 
 - adds conflict handling for Database#save/destroy (Alexander Lang)
 
-### 1.0.1
+## 1.0.1
 
 - fixes error when bulk loaded document does not respond to database= (Alexander Lang)
 
-### 1.0.0
+## 1.0.0
 
 - adds `reload` method (Alexander Lang)
 - removes `total_rows` from database results (Alexander Lang)
@@ -187,11 +203,11 @@
 - adds suppot for BigDecimal properties (Fredrik Rubensson)
 - adds support for 2.0, Rubinius, 1.9.3, drops Ruby 1.8, 1.9.2
 
-### 0.7.1
+## 0.7.1
 
 - fixes a bug when trying to bulk-load non-existant documents
 
-### 0.7.0
+## 0.7.0
 
 - ActiveSupport/Rails 3.2 compatibility (Alexander Lang)
 - removed Object#try, String#blank? as they are part of ActiveSupport - ActiveSupport's try behaves differently than the couch potato implementation so this change might break your app (now calling a non-existant method on a non-nil raises a NoMethodError, before it did not) (Alexander Lang)
@@ -205,168 +221,168 @@
 - don't crash, only warn if couchdb.yml is missing (Alexander Lang)
 - use the therubyracer gem to run view specs instead of relying on a `js` executable (Alexander Lang)
 
-### 0.6.0
+## 0.6.0
 
 - ActiveSupport/Rails 3.1 compatibility (Maximilian Mack)
 - fix no such file to load with json/add/rails (Simone Carletti)
 
-### 0.5.7
+## 0.5.7
 
 - support CouchPotato::Database#first/#first! calls when using `stub_db` from tests (langalex)
 - support RSpec2 block syntax in `stub_db` (langalex)
 
-### 0.5.6
+## 0.5.6
 
 - remove the stale parameter from a view query if it's nil, as couchdb only allows stale to be ok or update_after (langalex)
 
-### 0.5.5
+## 0.5.5
 
 - support for split_design_documents_per_view (jweiss)
 - errors now returns a Hash instead of an Array (bterkuile)
 - support passing in list names as symbols in view specs (langalex)
 
-### 0.5.4
+## 0.5.4
 
 - cast 'false' to false for boolean properties (langalex)
 
-### 0.5.3
+## 0.5.3
 
 - added CouchPotato::Database.load! (langalex)
 
-### 0.5.2
+## 0.5.2
 
 - added CouchPotato::Database#first and #first! methods (langalex)
 - added workaround for BigCouch/Cloudant to not add null reduce functions to views (langalex)
 - don't add \_attachments if there are none (langalex)
 
-### 0.5.1
+## 0.5.1
 
 - fixed issues with tzinfo gem (Bernd Ahlers)
 
-### 0.5.0
+## 0.5.0
 
 - time zone support (Time properties are now converted to current Time.zone) (langalex)
 - lazy property initialization (performance!) (langalex)
 - active_model is now the default validation framework (langalex)
 
-### 0.4.0
+## 0.4.0
 
 - ruby 1.9.2 compatibility (langalex)
 - couch potato objects now behave correctly when used as keys in Hashes (langalex)
 - use as_json instead of to_s(:json), which is the rails way
 - use ActiveModel dirty tracking (langalex) - this means no more "deep tracking", e.g. `user.tags << 'new_tag'; user.dirty? # false`
 
-### 0.3.2
+## 0.3.2
 
 - support yielding to blocks on #initialize (martinrehfeld)
 - support for negative numbers in Fixnum/Float properties (langalex)
 
-### 0.3.1
+## 0.3.1
 
 - ActiveModel callbacks (kazjote)
 - do not use Rails.env in initializer as it will free Rails.env for all times and in Rails 2.3.x apps it will be called too early thus always beeing development (jweiss)
 - ruby 1.9.2 compatibility (langalex)
 - can configure validation framework in couchdb.yml, process couchdb.yml with erb (langalex)
 
-### 0.3.0
+## 0.3.0
 
 - support for lists (langalex)
 
-### 0.2.32
+## 0.2.32
 
 - added persisted? and to_key for proper ActiveModel compliance (thilo)
 - id setter (jhohertz-work)
 - load document ids if include_documents is false (jweiss)
 - persist given created_at/updated_at instead of Time.now (langalex)
 
-### 0.2.31
+## 0.2.31
 
 - Removed requirement for validatable gem. Allows for using more uptodate versions of the library, or doesn't install it when you're using ActiveModel. (mattmatt)
 - fixed callbacks of super classes were not run (langalex)
 
-### 0.2.30
+## 0.2.30
 
 - pass in multiple keys when querying a view (langalex)
 
-### 0.2.29
+## 0.2.29
 
 - nicer inspect() for models (mattmatt)
 - fixed (re)reduce for property views wasn't working (langalex)
 
-### 0.2.28
+## 0.2.28
 
 - fixed reloading nested classes (langalex)
 - fixed constant missing error when loading models with uninitialized classes via views (langalex)
 - added rspec helpers for stubbing out views (langalex)
 - fixed design document names for nested model classes (svenfuchs)
 
-### 0.2.27
+## 0.2.27
 
 - workaround for Rails apps using bundler: database name was not initialized from couchdb.yml (langalex)
 
-### 0.2.26
+## 0.2.26
 
 - added to_s(:json) to Date and Time to be able to get properly formatted dates/times for searching with dates/times (langalex)
 - all times are now stored as UTC (langalex)
 - added support for Float attributes (arbovm)
 
-### 0.2.25
+## 0.2.25
 
 - automatic view updates: when you change the definition of a view couch potato will now update the design document in the database (langalex)
 - support for properties of type Date, better support for Time (langalex)
 - support for default reduce count methods in custom views (jweiss)
 
-### 0.2.24
+## 0.2.24
 
 - persistent instances can now be marked as dirty with #is_dirty (langalex)
 
-### 0.2.23
+## 0.2.23
 
 - Couch Potato models now conform to the ActiveModel interface when ActiveModel is installed, see http://yehudakatz.com/2010/01/10/activemodel-make-any-ruby-object-feel-like-activerecord/ (langalex)
 - fixed error with dirty tracking and BigDecimals (thilo)
 - added the ability to use ActiveModel validations instead of validatable (martinrehfeld)
 
-### 0.2.22
+## 0.2.22
 
 - fixed properties with default values returned default when a blank value like '' or [] was set (langalex)
 
-### 0.2.21
+## 0.2.21
 
 - automatically set a database instance on results of CouchPotato::Database#view (langalex)
 - improved auto loading of unloaded constants - can now load constants that have never been loaded before (langalex)
 - raise exception on invalid parameters passed to a couchdb view query (langalex)
 - when querying a view: pass in ranges as key instead of startkey/endkey, pass in plain value instead of hash with key (langalex)
 
-### 0.2.20
+## 0.2.20
 
 - support for :boolean properties (jweiss)
 - return the total_rows when querying a view (langalex)
 
-### 0.2.19
+## 0.2.19
 
 - added conditions to views (langalex)
 
-### 0.2.18
+## 0.2.18
 
 - set Fixnum property to nil when given a blank string (langalex)
 
-### 0.2.17
+## 0.2.17
 
 - fixed nil attributes were omitted in json (jweiss, mattmatt)
 - support for properties of type Fixnum (langalex)
 
-### 0.2.16
+## 0.2.16
 
 - fixed problem with classes being not loaded in rails development mode (langalex)
 - fixed persist boolean false value (bernd)
 
-### 0.2.15
+## 0.2.15
 
 - ability to change the name of the attribute that stores the ruby class in the documents by setting JSON.create_id (lennart)
 - fixed double loading issue with bundler (jweiss)
 - fixed an issue with setting attachments (endor)
 
-### 0.2.13
+## 0.2.13
 
 - support adding errors in before_validation callbacks (mattmatt)
 - support for inheritance (mattmatt)
@@ -374,11 +390,11 @@
 - improved (de)serialization now supports deserializing nested objects (railsbros, specs by hagenburger)
 - RSpec matchers for testing map/reduce functions (langalex)
 
-### 0.2.10
+## 0.2.10
 
 - fixed bug with hardcoded timezone
 
-### 0.2.9
+## 0.2.9
 
 - allow to overwrite attribute accessor of properties and use super to call the original accessors
 - allow read access to attributes that are present in the Couchdb document but not defined as properties

data/lib/couch_potato/persistence/simple_property.rb

@@ -12,6 +12,13 @@ module CouchPotato
           value
         end
       end
+
+      def assign_attribute(name, value, from_json: false)
+        property = self.class.properties.find_property(name)
+        typecasted_value = type_caster.cast(value, property.type, from_json:)
+        send("#{name}_will_change!") unless @skip_dirty_tracking || typecasted_value == send(name)
+        instance_variable_set("@#{name}", typecasted_value)
+      end
     end
 
     class SimpleProperty  #:nodoc:
@@ -19,7 +26,6 @@ module CouchPotato
 
       def initialize(owner_clazz, name, options = {})
         self.name = name
-        @setter_name = "#{name}="
         self.type = options[:type]
         self.default_value = options[:default]
         @type_caster = TypeCaster.new
@@ -29,8 +35,7 @@ module CouchPotato
       end
 
       def build(object, json)
-        value = json[name]
-        object.send @setter_name, value
+        object.send(:assign_attribute, name, json[name], from_json: true)
       end
 
       def serialize(json, object)
@@ -77,9 +82,7 @@ module CouchPotato
           end
 
           define_method "#{name}=" do |value|
-            typecasted_value = type_caster.cast(value, options[:type])
-            send("#{name}_will_change!") unless @skip_dirty_tracking || typecasted_value == send(name)
-            self.instance_variable_set(ivar_name, typecasted_value)
+            assign_attribute(name, value)
           end
 
           define_method "#{name}?" do

data/lib/couch_potato/persistence/type_caster.rb

@@ -6,14 +6,14 @@ module CouchPotato
     class TypeCaster #:nodoc:
       NUMBER_REGEX = /-?\d*\.?\d*/.freeze
 
-      def cast(value, type)
+      def cast(value, type, from_json: false)
         if type == :boolean
           cast_boolean(value)
         elsif type.instance_of?(Array)
           nested_type = type.first
-          value&.map { |val| cast_native(val, nested_type) }
+          value&.map { |val| cast_native(val, nested_type, from_json:) }
         else
-          cast_native(value, type)
+          cast_native(value, type, from_json:)
         end
       end
 
@@ -29,7 +29,7 @@ module CouchPotato
         end
       end
 
-      def cast_native(value, type)
+      def cast_native(value, type, from_json:)
         if type && !value.is_a?(type)
 
           if %w[Integer Bignum].include?(type.to_s)
@@ -40,7 +40,7 @@ module CouchPotato
             value.to_d unless value.blank?
           elsif type == Hash
             value.to_hash unless value.blank?
-          elsif type.ancestors.include?(CouchPotato::Persistence)
+          elsif type.ancestors.include?(CouchPotato::Persistence) && !from_json
             type.new value unless value.blank?
           else
             type.json_create value unless value.blank?

data/lib/couch_potato/version.rb

@@ -1,4 +1,4 @@
 module CouchPotato
-  VERSION = '1.22.0'.freeze
-  RSPEC_VERSION = '4.2.0'.freeze
+  VERSION = '1.22.2'.freeze
+  RSPEC_VERSION = '4.4.0'.freeze
 end

data/spec/property_spec.rb

@@ -12,6 +12,7 @@ class Watch
   property :custom_address, type: [Address]
   property :overwritten_read
   property :overwritten_write
+  property :normalized_title
   property :diameter, type: Float
 
   def overwritten_read
@@ -21,6 +22,10 @@ class Watch
   def overwritten_write=(value)
     super value.to_s
   end
+
+  def normalized_title=(value)
+    super(value.to_s.upcase)
+  end
 end
 
 class Address2 < Address
@@ -59,6 +64,12 @@ describe 'properties' do
     expect(Watch.new(:overwritten_write => 1).overwritten_write).to eq('1')
   end
 
+  it "does not call overwritten write accessors when loading from a document" do
+    watch = Watch.json_create('normalized_title' => 'Hello', JSON.create_id => 'Watch')
+
+    expect(watch.normalized_title).to eq('Hello')
+  end
+
   it "should return the property names" do
     expect(Comment.property_names).to eq([:created_at, :updated_at, :title])
   end
@@ -121,8 +132,8 @@ describe 'properties' do
     expect(w.custom_address[0]).to be_an_instance_of Address2
   end
 
-  it 'initializes an typed array property from an array of hashes' do
-    w = Watch.new(custom_address: [{id: 'a1', city: 'Berlin'}])
+  it 'initializes a typed array property from an array of hashes' do
+    w = Watch.new(custom_address: [{_id: 'a1', city: 'Berlin'}])
 
     expect(w.custom_address.map(&:class)).to eq([Address])
     expect(w.custom_address.map(&:id)).to eq(['a1'])
@@ -187,6 +198,32 @@ describe 'properties' do
     expect(p.ship_address).to be_nil
   end
 
+  it "persists a nested object with non-couch potato attributes delegating to properties" do
+    class PersonWithName
+      include CouchPotato::Persistence
+
+      property :first_name
+      property :last_name
+
+      def name=(value)
+        self.first_name = value.split(' ').first
+        self.last_name = value.split(' ').last
+      end
+    end
+    class PersonContainer
+      include CouchPotato::Persistence
+
+      property :person, type: PersonWithName
+    end
+
+    container = PersonContainer.new(person: {name: 'John Doe'})
+    CouchPotato.database.save_document!(container)
+    container = CouchPotato.database.load_document(container.id)
+
+    expect(container.person.first_name).to eq('John')
+    expect(container.person.last_name).to eq('Doe')
+  end
+
   it "should actually pass the null value down in the JSON document " do
     p = Person.new
     p.ship_address = nil

data/spec/unit/rspec_stub_db_spec.rb

@@ -9,6 +9,12 @@ class WithStubbedView
   view :stubbed_view, key: :x
 end
 
+class WithStubbedFlexView
+  include CouchPotato::Persistence
+
+  view :stubbed_flex_view, type: :flex, key: :x
+end
+
 describe 'stubbing the db' do
   it 'replaces CouchPotato.database with a double' do
     CouchPotato.stub_db
@@ -37,6 +43,40 @@ describe 'stubbing a view' do
     expect(@db.view(WithStubbedView.stubbed_view('123'))).to eq([:result])
   end
 
+  it 'returns successive values on consecutive view calls' do
+    @db.stub_view(WithStubbedView, :stubbed_view).with('123').and_return([:first], [:second])
+
+    expect(@db.view(WithStubbedView.stubbed_view('123'))).to eq([:first])
+    expect(@db.view(WithStubbedView.stubbed_view('123'))).to eq([:second])
+  end
+
+  it 'returns successive first values on consecutive first calls' do
+    @db.stub_view(WithStubbedView, :stubbed_view).with('123').and_return([:a], [:b])
+
+    expect(@db.first(WithStubbedView.stubbed_view('123'))).to eq(:a)
+    expect(@db.first(WithStubbedView.stubbed_view('123'))).to eq(:b)
+  end
+
+  it 'returns successive values on consecutive first! calls and raises for a nil first value' do
+    @db.stub_view(WithStubbedView, :stubbed_view).with('123').and_return([:a], [], [:b])
+
+    expect(@db.first!(WithStubbedView.stubbed_view('123'))).to eq(:a)
+    expect { @db.first!(WithStubbedView.stubbed_view('123')) }.to raise_error(CouchPotato::NotFound)
+    expect(@db.first!(WithStubbedView.stubbed_view('123'))).to eq(:b)
+  end
+
+  it 'yields successive return values on consecutive view_in_batches calls' do
+    @db.stub_view(WithStubbedView, :stubbed_view).with('123').and_return([:a, :b], [:c])
+
+    expect do |b|
+      @db.view_in_batches(WithStubbedView.stubbed_view('123'), batch_size: 2, &b)
+    end.to yield_successive_args([:a, :b])
+
+    expect do |b|
+      @db.view_in_batches(WithStubbedView.stubbed_view('123'), batch_size: 2, &b)
+    end.to yield_successive_args([:c])
+  end
+
   it 'stubs the database to return the first fake result' do
     expect(@db.first(WithStubbedView.stubbed_view('123'))).to eq(:result)
     expect(@db.first!(WithStubbedView.stubbed_view('123'))).to eq(:result)
@@ -96,3 +136,55 @@ describe 'stubbing a view' do
     expect(@db.view(WithStubbedView.stubbed_view('123'))).to eq(:results)
   end
 end
+
+describe 'stubbing a flex view' do
+  before(:each) do
+    @db = CouchPotato.stub_db
+    @db.stub_view(WithStubbedFlexView, :stubbed_flex_view).with('123').and_return([:result])
+  end
+
+  it 'stubs the database to return a results stub with docs when given an array' do
+    expect(@db.view(WithStubbedFlexView.stubbed_flex_view('123')).docs).to eq([:result])
+  end
+
+  it 'stubs the database to return the first fake result' do
+    expect(@db.first(WithStubbedFlexView.stubbed_flex_view('123'))).to eq(:result)
+    expect(@db.first!(WithStubbedFlexView.stubbed_flex_view('123'))).to eq(:result)
+  end
+
+  it 'returns successive results stubs on consecutive view calls' do
+    @db.stub_view(WithStubbedFlexView, :stubbed_flex_view).with('123').and_return([:first], [:second])
+
+    expect(@db.view(WithStubbedFlexView.stubbed_flex_view('123')).docs).to eq([:first])
+    expect(@db.view(WithStubbedFlexView.stubbed_flex_view('123')).docs).to eq([:second])
+  end
+
+  it 'returns successive first values on consecutive first calls' do
+    @db.stub_view(WithStubbedFlexView, :stubbed_flex_view).with('123').and_return([:a], [:b])
+
+    expect(@db.first(WithStubbedFlexView.stubbed_flex_view('123'))).to eq(:a)
+    expect(@db.first(WithStubbedFlexView.stubbed_flex_view('123'))).to eq(:b)
+  end
+
+  it 'returns successive values on consecutive first! calls and raises for a nil first value' do
+    @db.stub_view(WithStubbedFlexView, :stubbed_flex_view).with('123').and_return([:a], [], [:b])
+
+    expect(@db.first!(WithStubbedFlexView.stubbed_flex_view('123'))).to eq(:a)
+    expect { @db.first!(WithStubbedFlexView.stubbed_flex_view('123')) }.to raise_error(CouchPotato::NotFound)
+    expect(@db.first!(WithStubbedFlexView.stubbed_flex_view('123'))).to eq(:b)
+  end
+
+  it 'raises from db.first! when the array is empty' do
+    @db.stub_view(WithStubbedFlexView, :stubbed_flex_view).and_return([])
+
+    expect do
+      @db.first!(WithStubbedFlexView.stubbed_flex_view)
+    end.to raise_error(CouchPotato::NotFound)
+  end
+
+  it 'returns a non-array return value directly' do
+    @db.stub_view(WithStubbedFlexView, :stubbed_flex_view).with('123').and_return(:reduced)
+
+    expect(@db.view(WithStubbedFlexView.stubbed_flex_view('123'))).to eq(:reduced)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: couch_potato
 version: !ruby/object:Gem::Version
-  version: 1.22.0
+  version: 1.22.2
 platform: ruby
 authors:
 - Alexander Lang