couch_potato 1.16.0 → 1.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3fd11db6b5bb37ef9b0d12115ae4586f8f0ec8afff586e7a2b381e1839af0196
-  data.tar.gz: 7f03e40ec9297bb669f28559e251b72f5b8e849010b8861d992c75c5ed7737a3
+  metadata.gz: a78d19f65a75932bb6f60639fc9ad3dff0151e9c7de7f8cbc31e1b61038f7fa8
+  data.tar.gz: c5383ffd3db50bd45d727a84b62588dcd70d6ea3d07ac96559e1318c145fb057
 SHA512:
-  metadata.gz: 72bc1831a2b773d3f64682f1fbe20fb10acccad204fd057e92676c53fe03f5f56b462c02905b3f3ee52ddb6fa640f6dfe6a05a3f1e1aeb8e750eaecb76922a38
-  data.tar.gz: 4a49349375cabe65b465c99336e3c0b05564d0b720faa6ae4d956633809ea52d6a73119118c7bc923d0ffde0aefd5af93f3fbdc587fed89696942b05ce421025
+  metadata.gz: 38aa7ce10b0f12429789ecc0f25e34b276f98eadedac900f2ea18b7c1845549be28becb624d4da1c89506d814fa403b7f9647f960f3be534ac47b02c839f6866
+  data.tar.gz: e0b48a96f9a485d0765b066b5e5bca043058b85af246775abdf2bf3afb598bf691b09ae156182b9ecf1ff9dcc0acdee3bb5cc899a8722d0a75bdff9ded965b7b

data/CHANGES.md

@@ -1,5 +1,10 @@
 ## Changes
 
+# 1.17.0
+
+- filter out nil ids for loading multiple documents
+- cache nil documents
+
 # 1.16.0
 
 - add payload to ActiveSupport instrumentation calls

data/lib/couch_potato/database.rb

@@ -149,7 +149,7 @@ module CouchPotato
       
       cached = cache && cache[id]
       if cache
-        if cached
+        if cache.key?(id)
           ActiveSupport::Notifications.instrument('couch_potato.load.cached', id: id, doc: cached) do
             cached
           end
@@ -164,6 +164,7 @@ module CouchPotato
     alias load load_document
 
     def load_documents(ids)
+      ids = ids.compact
       return [] if ids.empty?
 
       uncached_ids = ids - (cache&.keys || [])
@@ -177,7 +178,7 @@ module CouchPotato
       if cache
         uncached_ids.each do |id|
           doc = uncached_docs_by_id[id]
-          cache[id] = doc if doc
+          cache[id] = doc
         end
       end
       ids.filter_map { |id| (cached_docs_by_id[id]) || uncached_docs_by_id[id] }

data/lib/couch_potato/version.rb

@@ -1,4 +1,4 @@
 module CouchPotato
-  VERSION = '1.16.0'.freeze
+  VERSION = '1.17.0'.freeze
   RSPEC_VERSION = '4.1.0'.freeze
 end

data/spec/unit/caching_spec.rb

@@ -37,6 +37,15 @@ RSpec.describe 'database caching' do
       db.load '1'
     end
 
+    it 'caches nil' do
+      allow(couchrest_db).to receive(:get).with('1').and_return(nil)
+
+      db.load '1'
+      db.load '1'
+
+      expect(couchrest_db).to have_received(:get).with('1').exactly(1).times
+    end
+
     it 'gets an object from the cache the 2nd time via #load!' do
       expect(couchrest_db).to receive(:get).with('1').exactly(1).times
 
@@ -92,6 +101,17 @@ RSpec.describe 'database caching' do
       expect(couchrest_db).to have_received(:bulk_load).with(['2']).exactly(1).times
     end
 
+    it 'caches nil' do
+      allow(couchrest_db).to receive(:bulk_load).with(['1']).and_return('rows' => [{'doc' => nil}])
+      allow(couchrest_db).to receive(:bulk_load).with(['2']).and_return('rows' => [{'doc' => doc2}])
+      
+
+      db.load_document(['1'])
+      db.load_document(['1', '2'])
+
+      expect(couchrest_db).to have_received(:bulk_load).with(['1']).exactly(1).times
+    end
+
     it 'instruments the load call' do
       allow(couchrest_db).to receive(:bulk_load).with(['1'])
         .and_return('rows' => [{'doc' => doc1}])
@@ -137,22 +157,6 @@ RSpec.describe 'database caching' do
 
       expect(result).to eql([doc1, doc2])
     end
-
-    it 'does not cache documents that do not respond to id' do
-      doc1 = {
-        'id' => '1',
-      }
-      doc2 = {
-        'id' => '2',
-      }
-      allow(couchrest_db).to receive(:bulk_load).with(['1', '2'])
-        .and_return('rows' => [{'doc' => doc1}, {'doc' => doc2}])
-
-      db.load_document(['1', '2'])
-      db.load_document(['1', '2'])
-
-      expect(couchrest_db).to have_received(:bulk_load).with(['1', '2']).exactly(2).times
-    end
   end
 
   context 'when switching the database' do

data/spec/unit/database_spec.rb

@@ -92,6 +92,12 @@ describe CouchPotato::Database, 'load' do
       db.load %w[1 2 3]
     end
 
+    it 'does not request anything when nil is given' do
+      expect(db.load([nil])).to eq([])
+
+      expect(couchrest_db).not_to have_received(:bulk_load)
+    end
+
     it 'returns only found documents' do
       expect(db.load(%w[1 2 3]).size).to eq(2)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: couch_potato
 version: !ruby/object:Gem::Version
-  version: 1.16.0
+  version: 1.17.0
 platform: ruby
 authors:
 - Alexander Lang
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-02 00:00:00.000000000 Z
+date: 2024-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel