couch_potato 0.6.0 → 0.7.0.pre.1

data/spec/unit/couch_potato_spec.rb

@@ -26,23 +26,4 @@ describe CouchPotato, '.models' do
     
     CouchPotato.models.should include(clazz)
   end
-end
-
-describe CouchPotato, 'validation_framework' do
-  before(:each) do
-    @original_validation_framework = CouchPotato::Config.validation_framework
-  end
-  after(:each) do
-    CouchPotato::Config.validation_framework = @original_validation_framework
-  end
-
-  it "should allow setting the validation_framework to :active_model" do
-    CouchPotato::Config.validation_framework = :active_model
-    CouchPotato::Config.validation_framework.should == :active_model
-  end
-
-  it "should allow setting the validation_framework to :validatable" do
-    CouchPotato::Config.validation_framework = :validatable
-    CouchPotato::Config.validation_framework.should == :validatable
-  end
-end
+end

data/spec/unit/create_spec.rb

@@ -23,14 +23,14 @@ describe "create" do
 
     it "should set created at in the current time zone" do
       Time.zone = 'Europe/Berlin'
-      Timecop.travel 2010, 1, 1, 12 do
+      Timecop.travel Time.zone.parse('2010-01-01 12:00 +0100') do
         create_comment.created_at.to_s.should == '2010-01-01 12:00:00 +0100'
       end
     end
 
     it "should set updated at in the current time zone" do
       Time.zone = 'Europe/Berlin'
-      Timecop.travel 2010, 1, 1, 12 do
+      Timecop.travel Time.zone.parse('2010-01-01 12:00 +0100') do
         create_comment.updated_at.to_s.should == '2010-01-01 12:00:00 +0100'
       end
     end

data/spec/unit/database_spec.rb

@@ -27,17 +27,17 @@ describe CouchPotato::Database, 'full_url_to_database' do
   after(:all) do
     CouchPotato::Config.database_name = @database_url
   end
-  
+
   it "should return the full URL when it starts with https" do
     CouchPotato::Config.database_name = "https://example.com/database"
     CouchPotato.full_url_to_database.should == 'https://example.com/database'
   end
-  
+
   it "should return the full URL when it starts with http" do
     CouchPotato::Config.database_name = "http://example.com/database"
     CouchPotato.full_url_to_database.should == 'http://example.com/database'
   end
-  
+
   it "should use localhost when no protocol was specified" do
     CouchPotato::Config.database_name = "database"
     CouchPotato.full_url_to_database.should == 'http://127.0.0.1:5984/database'
@@ -45,8 +45,11 @@ describe CouchPotato::Database, 'full_url_to_database' do
 end
 
 describe CouchPotato::Database, 'load' do
+
+  let(:couchrest_db) { stub('couchrest db', :info => nil) }
+  let(:db) { CouchPotato::Database.new couchrest_db }
+
   it "should raise an exception if nil given" do
-    db = CouchPotato::Database.new(stub('couchrest db', :info => nil))
     lambda {
       db.load nil
     }.should raise_error("Can't load a document without an id (got nil)")
@@ -55,33 +58,95 @@ describe CouchPotato::Database, 'load' do
   it "should set itself on the model" do
     user = mock('user').as_null_object
     DbTestUser.stub!(:new).and_return(user)
-    db = CouchPotato::Database.new(stub('couchrest db', :info => nil, :get => DbTestUser.json_create({JSON.create_id => 'DbTestUser'})))
+    couchrest_db.stub(:get).and_return DbTestUser.json_create({JSON.create_id => 'DbTestUser'})
     user.should_receive(:database=).with(db)
     db.load '1'
   end
 
   it "should load namespaced models" do
-    db = CouchPotato::Database.new(stub('couchrest db', :info => nil, :get => Parent::Child.json_create({JSON.create_id => 'Parent::Child'})))
+    couchrest_db.stub(:get).and_return Parent::Child.json_create({JSON.create_id => 'Parent::Child'})
     db.load('1').class.should == Parent::Child
   end
+
+  context "when several ids given" do
+
+    let(:doc1) { DbTestUser.new }
+    let(:doc2) { DbTestUser.new }
+    let(:response) do
+      {"rows" => [{}, {"doc" => doc1}, {"doc" => doc2}]}
+    end
+
+    before(:each) do
+      couchrest_db.stub(:bulk_load).and_return response
+    end
+
+    it "requests the couchrest bulk method" do
+      couchrest_db.should_receive(:bulk_load).with(['1', '2', '3'])
+      db.load ['1', '2', '3']
+    end
+
+    it "returns only found documents" do
+      db.load(['1', '2', '3']).should have(2).items
+    end
+
+    it "writes itself to each of the documents" do
+      db.load(['1', '2', '3']).each do |doc|
+        doc.database.should eql(db)
+      end
+    end
+  end
 end
 
 describe CouchPotato::Database, 'load!' do
+
+  let(:db) { CouchPotato::Database.new(stub('couchrest db', :info => nil).as_null_object) }
+
   it "should raise an error if no document found" do
-    couchrest_db = stub('couchrest db', :info => nil)
-    couchrest_db.stub(:get).and_raise(RestClient::ResourceNotFound)
-    db = CouchPotato::Database.new(couchrest_db)
+    db.couchrest_database.stub(:get).and_raise(RestClient::ResourceNotFound)
     lambda {
       db.load! '1'
     }.should raise_error(CouchPotato::NotFound)
   end
+
+  it 'returns the found document' do
+    doc = stub(:doc).as_null_object
+    db.couchrest_database.stub(:get) {doc}
+    db.load!('1').should == doc
+  end
+
+  context "when several ids given" do
+
+    let(:docs) do
+      [
+        DbTestUser.new(:id => '1'),
+        DbTestUser.new(:id => '2')
+      ]
+    end
+
+    before(:each) do
+      db.stub(:load).and_return(docs)
+    end
+
+    it "raises an exception when not all documents could be found" do
+      lambda {
+        db.load! ['1', '2', '3', '4']
+      }.should raise_error(CouchPotato::NotFound, '3, 4')
+    end
+
+    it "raises no exception when all documents are found" do
+      docs << DbTestUser.new(:id => '3')
+      lambda {
+        db.load! ['1', '2', '3']
+      }.should_not raise_error(CouchPotato::NotFound)
+    end
+  end
 end
 
 describe CouchPotato::Database, 'save_document' do
   before(:each) do
     @db = CouchPotato::Database.new(stub('couchrest db').as_null_object)
   end
-  
+
   it "should set itself on the model for a new object before doing anything else" do
     @db.stub(:valid_document?).and_return false
     user = stub('user', :new? => true).as_null_object
@@ -94,18 +159,18 @@ describe CouchPotato::Database, 'save_document' do
     property :name
     validates_presence_of :name
   end
-  
+
   it "should return false when creating a new document and the validations failed" do
     CouchPotato.database.save_document(Category.new).should == false
   end
-  
+
   it "should return false when saving an existing document and the validations failed" do
     category = Category.new(:name => "pizza")
     CouchPotato.database.save_document(category).should == true
     category.name = nil
     CouchPotato.database.save_document(category).should == false
   end
-  
+
   describe "when creating with validate options" do
     it "should not run the validations when saved with false" do
       category = Category.new
@@ -155,27 +220,27 @@ describe CouchPotato::Database, 'save_document' do
       category.dirty?.should == true
     end
   end
-  
+
   describe "when saving documents with errors set in callbacks" do
     class Vulcan
       include CouchPotato::Persistence
       before_validation_on_create :set_errors
       before_validation_on_update :set_errors
-      
+
       property :name
       validates_presence_of :name
-      
+
       def set_errors
         errors.add(:validation, "failed")
       end
     end
-    
+
     it "should keep errors added in before_validation_on_* callbacks when creating a new object" do
       spock = Vulcan.new(:name => 'spock')
       @db.save_document(spock)
       spock.errors[:validation].should == ['failed']
     end
-    
+
     it "should keep errors added in before_validation_on_* callbacks when creating a new object" do
       spock = Vulcan.new(:name => 'spock')
       @db.save_document(spock, false)
@@ -184,36 +249,36 @@ describe CouchPotato::Database, 'save_document' do
       @db.save_document(spock)
       spock.errors[:validation].should == ['failed']
     end
-    
+
     it "should keep errors generated from normal validations together with errors set in normal validations" do
       spock = Vulcan.new
       @db.save_document(spock)
       spock.errors[:validation].should == ['failed']
       spock.errors[:name].first.should =~ /can't be (empty|blank)/
     end
-    
+
     it "should clear errors on subsequent, valid saves when creating" do
       spock = Vulcan.new
       @db.save_document(spock)
-      
+
       spock.name = 'Spock'
       @db.save_document(spock)
       spock.errors[:name].should == []
     end
-    
+
     it "should clear errors on subsequent, valid saves when updating" do
       spock = Vulcan.new(:name => 'spock')
       @db.save_document(spock, false)
-      
+
       spock.name = nil
       @db.save_document(spock)
       spock.errors[:name].first.should =~ /can't be (empty|blank)/
-      
+
       spock.name = 'Spock'
       @db.save_document(spock)
       spock.errors[:name].should == []
     end
-    
+
   end
 end
 
@@ -225,11 +290,11 @@ describe CouchPotato::Database, 'first' do
     @spec = stub('view spec', :process_results => [@result]).as_null_object
     CouchPotato::View::ViewQuery.stub(:new => stub('view query', :query_view! => {'rows' => [@result]}))
   end
-  
+
   it "should return the first result from a view query" do
     @db.first(@spec).should == @result
   end
-  
+
   it "should return nil if there are no results" do
     @spec.stub(:process_results => [])
     @db.first(@spec).should be_nil
@@ -244,12 +309,12 @@ describe CouchPotato::Database, 'first!' do
     @spec = stub('view spec', :process_results => [@result]).as_null_object
     CouchPotato::View::ViewQuery.stub(:new => stub('view query', :query_view! => {'rows' => [@result]}))
   end
-  
-  it "should return the first result from a view query" do
+
+  it "returns the first result from a view query" do
     @db.first!(@spec).should == @result
   end
-  
-  it "should raise an error if there are no results" do
+
+  it "raises an error if there are no results" do
     @spec.stub(:process_results => [])
     lambda {
       @db.first!(@spec)
@@ -265,11 +330,11 @@ describe CouchPotato::Database, 'view' do
     @spec = stub('view spec', :process_results => [@result]).as_null_object
     CouchPotato::View::ViewQuery.stub(:new => stub('view query', :query_view! => {'rows' => [@result]}))
   end
-  
-  it "should initialze a view query with map/reduce/list funtions" do
+
+  it "initialzes a view query with map/reduce/list funtions" do
     @spec.stub(:design_document => 'design_doc', :view_name => 'my_view',
       :map_function => '<map_code>', :reduce_function => '<reduce_code>',
-      :list_name => 'my_list', :list_function => '<list_code>')
+      :list_name => 'my_list', :list_function => '<list_code>', :language => 'javascript')
     CouchPotato::View::ViewQuery.should_receive(:new).with(
       @couchrest_db,
       'design_doc',
@@ -277,41 +342,42 @@ describe CouchPotato::Database, 'view' do
         :map => '<map_code>',
         :reduce => '<reduce_code>'
       }},
-      {'my_list' => '<list_code>'})
+      {'my_list' => '<list_code>'},
+      'javascript')
     @db.view(@spec)
   end
-  
-  it "should initialze a view query with only map/reduce functions" do
+
+  it "initialzes a view query with only map/reduce functions" do
     @spec.stub(:design_document => 'design_doc', :view_name => 'my_view',
       :map_function => '<map_code>', :reduce_function => '<reduce_code>',
-      :list_name => nil, :list_function => nil)
+      :list_name => nil, :list_function => nil).as_null_object
     CouchPotato::View::ViewQuery.should_receive(:new).with(
       @couchrest_db,
       'design_doc',
       {'my_view' => {
         :map => '<map_code>',
         :reduce => '<reduce_code>'
-      }}, nil)
+      }}, nil, anything)
     @db.view(@spec)
   end
-  
-  it "should set itself on returned results that have an accessor" do
+
+  it "sets itself on returned results that have an accessor" do
     @result.stub(:respond_to?).with(:database=).and_return(true)
     @result.should_receive(:database=).with(@db)
     @db.view(@spec)
   end
-  
-  it "should not set itself on returned results that don't have an accessor" do
+
+  it "does not set itself on returned results that don't have an accessor" do
     @result.stub(:respond_to?).with(:database=).and_return(false)
     @result.should_not_receive(:database=).with(@db)
     @db.view(@spec)
   end
-  
-  it "should not try to set itself on result sets that are not collections" do
+
+  it "does not try to set itself on result sets that are not collections" do
     lambda {
       @spec.stub(:process_results => 1)
     }.should_not raise_error
-    
+
     @db.view(@spec)
   end
-end
+end

data/spec/unit/dirty_attributes_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 class Plate
   include CouchPotato::Persistence
-  
+
   property :food
 end
 
@@ -11,7 +11,7 @@ describe 'dirty attribute tracking' do
     @couchrest_db = stub('database', :save_doc => {'id' => '1', 'rev' => '2'}, :info => nil)
     @db = CouchPotato::Database.new(@couchrest_db)
   end
-  
+
   describe "save" do
     it "should not save when nothing dirty" do
       plate = Plate.new :food => 'sushi'
@@ -19,13 +19,13 @@ describe 'dirty attribute tracking' do
       @couchrest_db.should_not_receive(:save_doc)
       @db.save_document(plate)
     end
-    
+
     it "should return true when not dirty" do
       plate = Plate.new :food => 'sushi'
       @db.save_document!(plate)
       @db.save_document(plate).should be_true
     end
-    
+
     it "should save when there are dirty attributes" do
       plate = Plate.new :food => 'sushi'
       @db.save_document!(plate)
@@ -34,19 +34,19 @@ describe 'dirty attribute tracking' do
       @db.save_document(plate)
     end
   end
-  
+
   describe "newly created object" do
-    
+
     before(:each) do
       @plate = Plate.new :food => 'sushi'
     end
-    
+
     describe "access old values" do
       it "should return the old value" do
         @plate.food = 'burger'
         @plate.food_was.should == 'sushi'
       end
-      
+
       describe "with type BigDecimal" do
         before(:each) do
           class Bowl
@@ -57,16 +57,16 @@ describe 'dirty attribute tracking' do
         it "should not dup BigDecimal" do
 
           lambda {
-            Bowl.new :price => BigDecimal.new("5.23") 
+            Bowl.new :price => BigDecimal.new("5.23")
           }.should_not raise_error(TypeError)
         end
-        
+
         it "should return the old value" do
-          bowl = Bowl.new :price => BigDecimal.new("5.23") 
+          bowl = Bowl.new :price => BigDecimal.new("5.23")
           bowl.price = BigDecimal.new("2.23")
           bowl.price_was.should == 5.23
         end
-        
+
       end
     end
 
@@ -79,20 +79,20 @@ describe 'dirty attribute tracking' do
       it "should return false if attribute not changed" do
         Plate.new.should_not be_food_changed
       end
-      
+
       it "should return true if forced dirty" do
         @plate.is_dirty
         @plate.should be_dirty
       end
     end
   end
-  
+
   describe "object loaded from database" do
     before(:each) do
       couchrest_db = stub('database', :get => Plate.json_create({'_id' => '1', '_rev' => '2', 'food' => 'sushi', JSON.create_id => 'Plate'}), :info => nil)
       @plate = CouchPotato::Database.new(couchrest_db).load_document '1'
     end
-    
+
     describe "access old values" do
       it "should return the old value" do
         @plate.food = 'burger'
@@ -111,8 +111,8 @@ describe 'dirty attribute tracking' do
       end
     end
   end
-  
-  
+
+
   describe "after save" do
     it "should reset all attributes to not dirty" do
       couchrest_db = stub('database', :get => Plate.json_create({'_id' => '1', '_rev' => '2', 'food' => 'sushi', JSON.create_id => 'Plate'}), :info => nil, :save_doc => {})
@@ -122,7 +122,7 @@ describe 'dirty attribute tracking' do
       db.save! @plate
       @plate.should_not be_food_changed
     end
-    
+
     it "should reset a forced dirty state" do
       couchrest_db = stub('database', :get => Plate.json_create({'_id' => '1', '_rev' => '2', 'food' => 'sushi', JSON.create_id => 'Plate'}), :info => nil, :save_doc => {'rev' =>  '3'})
       db = CouchPotato::Database.new(couchrest_db)
@@ -132,5 +132,5 @@ describe 'dirty attribute tracking' do
       @plate.should_not be_dirty
     end
   end
-  
+
 end

data/spec/unit/model_view_spec_spec.rb

@@ -5,9 +5,86 @@ describe CouchPotato::View::ModelViewSpec, 'map_function' do
     spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:conditions => 'doc.closed = true'}, {}
     spec.map_function.should include('if(doc.ruby_class && doc.ruby_class == \'Object\' && (doc.closed = true))')
   end
-  
+
+  it 'generates an erlang map function with a single key if the language is erlang' do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:key => :name, :language => :erlang}, {}
+    spec.map_function.should eql_ignoring_indentation(<<-ERL
+      fun({Doc}) ->
+        case proplists:get_value(<<"ruby_class">>, Doc) of
+        <<"Object">> ->
+            Key = proplists:get_value(<<"name">>, Doc, null),
+            Emit(Key, 1);
+        _ ->
+            ok
+        end
+      end.
+      ERL
+    )
+  end
+
+  it 'generates an erlang map function with a composite key if the language is erlang' do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:key => [:code, :name], :language => :erlang}, {}
+    spec.map_function.should eql_ignoring_indentation(<<-ERL
+      fun({Doc}) ->
+        case proplists:get_value(<<"ruby_class">>, Doc) of
+        <<"Object">> ->
+            Key_0 = proplists:get_value(<<"code">>, Doc, null),
+            Key_1 = proplists:get_value(<<"name">>, Doc, null),
+            Emit([Key_0, Key_1], 1);
+        _ ->
+            ok
+        end
+      end.
+      ERL
+    )
+  end
+
+  it 'does not support conditions in erlang' do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:language => :erlang, :conditions => 'abc'}, {}
+    lambda {
+      spec.map_function
+    }.should raise_error(NotImplementedError)
+  end
+
+  it 'does not support a custom emit value in erlang' do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:language => :erlang, :emit_value => :count}, {}
+    lambda {
+      spec.map_function
+    }.should raise_error(NotImplementedError)
+  end
+
   it "should not include conditions when they are nil" do
     spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {}, {}
     spec.map_function.should include('if(doc.ruby_class && doc.ruby_class == \'Object\')')
   end
+
+  it "should have a custom emit value when specified as symbol" do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:emit_value => :count}, {}
+    spec.map_function.should include(%{emit(doc[''], doc['count'])})
+  end
+
+  it "should have a custom emit value when specified as string" do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:emit_value => "doc['a'] + doc['b']"}, {}
+    spec.map_function.should include("emit(doc[''], doc['a'] + doc['b'])")
+  end
+
+  it "should have a custom emit value when specified as integer" do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:emit_value => 7}, {}
+    spec.map_function.should include("emit(doc[''], 7)")
+  end
+
+  it "should have a custom emit value when specified as float" do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:emit_value => 7.2}, {}
+    spec.map_function.should include("emit(doc[''], 7.2")
+  end
+
+  it "should have a emit value of 1 when nothing is specified" do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {}, {}
+    spec.map_function.should include("emit(doc[''], 1")
+  end
+
+  it "should raise exception when emit value cannot be handled" do
+    spec = CouchPotato::View::ModelViewSpec.new Object, 'all', {:emit_value => []}, {}
+    lambda { spec.map_function }.should raise_error
+  end
 end

data/spec/unit/properties_view_spec_spec.rb

@@ -3,29 +3,42 @@ require 'couch_potato/rspec'
 
 class Contract
   include CouchPotato::Persistence
-  
+
   property :date
   property :terms
-  
+
   view :by_date, :type => :properties, :key => :_id, :properties => [:date]
 end
 
 describe CouchPotato::View::PropertiesViewSpec do
+  before(:each) do
+    @default_language = CouchPotato::Config.default_language
+  end
+
+  after(:each) do
+    CouchPotato::Config.default_language = @default_language
+  end
+
   it "should map the given properties" do
     Contract.by_date.should map(
       Contract.new(:date => '2010-01-01', :_id => '1')
     ).to(['1', {"date" => "2010-01-01"}])
   end
-  
+
   it "should reduce to the number of documents" do
     Contract.by_date.should reduce(
       ['1', {"date" => "2010-01-01"}], ['2', {"date" => "2010-01-02"}]
     ).to(2)
   end
-  
+
   it "should rereduce the number of documents" do
     Contract.by_date.should rereduce(
       nil, [12, 13]
     ).to(25)
   end
-end
+
+  it 'always uses javascript' do
+    CouchPotato::Config.default_language = :erlang
+    CouchPotato::View::PropertiesViewSpec.new(Contract, 'all', {}, {}).language.should == :javascript
+  end
+end