cosmos 4.4.0-java → 4.5.1-java

data/lib/cosmos/dart/processes/dart.rb

@@ -30,7 +30,8 @@ class Dart
   #      streamed from the packet log binary file
   # 4. Decom Server - JSON DRB server which handles requests for decommutated
   #      or reduced data from the database
-  # 5..n Worker - Decommutates data from the packet log binary file into the DB
+  # 5. Master - Hands out packets to be decommutated by workers
+  # 6..n Worker - Decommutates data from the packet log binary file into the DB
   def run
     Cosmos::Logger.level = Cosmos::Logger::INFO
     dart_logging = DartLogging.new('dart')
@@ -53,7 +54,8 @@ class Dart
       [ruby_process_name, File.join(__dir__, 'dart_ingester.rb')],
       [ruby_process_name, File.join(__dir__, 'dart_reducer.rb')],
       [ruby_process_name, File.join(__dir__, 'dart_stream_server.rb')],
-      [ruby_process_name, File.join(__dir__, 'dart_decom_server.rb')]
+      [ruby_process_name, File.join(__dir__, 'dart_decom_server.rb')],
+      [ruby_process_name, File.join(__dir__, 'dart_master.rb')]
     ]
 
     num_workers.times do |index|

data/lib/cosmos/dart/processes/dart_decom_server.rb

@@ -25,9 +25,9 @@ Cosmos.catch_fatal_exception do
     json_drb.method_whitelist = ['query', 'item_names', 'dart_status', 'clear_errors']
     begin
       json_drb.start_service(Cosmos::System.listen_hosts['DART_DECOM'],
-        Cosmos::System.ports['DART_DECOM'], DartDecomQuery.new)
-    rescue Exception
-      raise Cosmos::FatalError.new("Error starting JsonDRb on port #{Cosmos::System.ports['DART_DECOM']}.\nPerhaps another DART Decom Server is already running?")
+        Cosmos::System.ports['DART_DECOM'], DartDecomQuery.new, 1000, Cosmos::System)
+    rescue Exception => error
+      raise Cosmos::FatalError.new("Error starting JsonDRb on port #{Cosmos::System.ports['DART_DECOM']}.\nPerhaps another DART Decom Server is already running?\n#{error.formatted}")
     end
     ["TERM", "INT"].each {|sig| Signal.trap(sig) {exit}}
     Cosmos::Logger.info("Dart Decom Server Started...")

data/lib/cosmos/dart/processes/dart_ingester.rb

@@ -16,20 +16,57 @@ require 'dart_logging'
 # Handles packets by writing them to the dart log file. New SYSTEM META packets
 # cause a new log file to be started.
 class DartInterfaceThread < Cosmos::InterfaceThread
+  include DartCommon
+  
   attr_writer :packet_log_writer
   attr_writer :log_type
-
+  
   def handle_packet(packet)
     if packet.target_name == 'SYSTEM'.freeze and packet.packet_name == 'META'.freeze
       Cosmos::Logger.info("#{@log_type}: #{packet.target_name} #{packet.packet_name}")
+      
+      # Manually read the configuration from the buffer because the packet might not be identified if
+      # identify_and_define is false
+      buffer = packet.buffer(false)
+      if buffer.length >= 33
+        system_config_name = Cosmos::BinaryAccessor.read(8, 256, :STRING, buffer, :BIG_ENDIAN)
+        # Switch to this system_config
+        begin
+          switch_and_get_system_config(system_config_name)
+        rescue Exception => e
+          Cosmos::Logger.error(e.formatted)
+          Cosmos::Logger.error("Could not load system_config: #{system_config_name}")
+        end
+      end      
+      
       # Update Current Value Table Used By Packet Log Writer
       cvt_packet = Cosmos::System.telemetry.update!(packet.target_name, packet.packet_name, packet.buffer)
       cvt_packet.received_time = packet.received_time
       cvt_packet.stored = packet.stored
       cvt_packet.extra = packet.extra
+      
       @packet_log_writer.start
       @packet_log_writer.write(cvt_packet)
     else
+      # Define the packet so that packet_time will work correctly
+      begin
+        packet_data = packet.buffer(false)
+        received_time = packet.received_time
+        stored = packet.stored
+        extra = packet.extra
+        if @log_type == :TLM
+          packet = Cosmos::System.telemetry.packet(packet.target_name, packet.packet_name)
+        else
+          packet = Cosmos::System.commands.packet(packet.target_name, packet.packet_name)
+        end
+        packet.buffer = packet_data
+        packet.received_time = received_time
+        packet.stored = stored
+        packet.extra = extra
+      rescue Exception => error
+        # Could not find a definition for this packet
+        Cosmos::Logger.error "Unknown packet #{target_name} #{packet_name}"
+      end
       @packet_log_writer.write(packet)
     end
   end

data/lib/cosmos/dart/processes/dart_master.rb

@@ -0,0 +1,44 @@
+# encoding: ascii-8bit
+
+# Copyright 2018 Ball Aerospace & Technologies Corp.
+# All Rights Reserved.
+#
+# This program is free software; you can modify and/or redistribute it
+# under the terms of the GNU General Public License
+# as published by the Free Software Foundation; version 3 with
+# attribution addendums as found in the LICENSE.txt
+
+ENV['RAILS_ENV'] = 'production'
+require File.expand_path('../../config/environment', __FILE__)
+require 'dart_common'
+require 'dart_master_query'
+
+ples_per_request = ENV['DART_PLE_REQ_SIZE']
+ples_per_request ||= 5
+ples_per_request = ples_per_request.to_i
+
+Cosmos.catch_fatal_exception do
+  DartCommon.handle_argv
+
+  Cosmos::Logger.level = Cosmos::Logger::INFO
+  dart_logging = DartLogging.new('dart_master')
+
+  json_drb = Cosmos::JsonDRb.new
+  json_drb.acl = Cosmos::System.acl if Cosmos::System.acl
+  begin
+    json_drb.method_whitelist = ['get_decom_ple_ids']
+    begin
+      json_drb.start_service(Cosmos::System.listen_hosts['DART_MASTER'],
+        Cosmos::System.ports['DART_MASTER'], DartMasterQuery.new(ples_per_request), 1000, Cosmos::System)
+    rescue Exception => error
+      raise Cosmos::FatalError.new("Error starting JsonDRb on port #{Cosmos::System.ports['DART_MASTER']}.\nPerhaps another DART Master is already running?\n#{error.formatted}")
+    end
+    ["TERM", "INT"].each {|sig| Signal.trap(sig) {exit}}
+    Cosmos::Logger.info("Dart Master Started...")
+    sleep(1) while true
+  rescue Interrupt
+    Cosmos::Logger.info("Dart Master Closing...")
+    json_drb.stop_service
+    dart_logging.stop
+  end
+end

data/lib/cosmos/dart/processes/dart_util.rb

@@ -56,6 +56,8 @@ ENV['RAILS_ENV'] = 'production'
 require File.expand_path('../../config/environment', __FILE__)
 require 'dart_database_cleaner'
 
+include DartCommon
+
 Cosmos.catch_fatal_exception do
   case action.downcase
   when 'showpleerrors'
@@ -77,6 +79,119 @@ Cosmos.catch_fatal_exception do
     Cosmos::Logger.level = Cosmos::Logger::INFO
     DartDatabaseCleaner.new.remove_packet_log(ARGV[1])
 
+  when 'showdatabase'
+    puts "Status:"
+    status = Status.last
+    puts "  Updated At: #{status.updated_at.formatted}"
+    puts "  Decom Count: #{status.decom_count}"
+    puts "  Decom Error Count: #{status.decom_error_count}"
+    puts "  Decom Message: #{status.decom_message}"
+    puts "  Decom Message Time: #{status.decom_message_time.formatted}"
+    puts "  Reduction Count: #{status.reduction_count}"
+    puts "  Reduction Error Count: #{status.reduction_error_count}"
+    puts "  Reduction Message: #{status.reduction_message}"
+    puts "  Reduction Message Time: #{status.reduction_message_time}"
+    puts ""
+
+    puts "System Configs:"
+    SystemConfig.all.each do |system_config|
+      puts "  #{sprintf("%6d", system_config.id)} #{system_config.name}"
+    end
+    puts ""
+
+    puts "Targets:"
+    Target.all.each do |target|
+      puts "  #{sprintf("%6d", target.id)} #{target.name}"
+    end
+    puts ""
+    
+    puts "Packets:"
+    Packet.all.each do |packet|
+      target = Target.find(packet.target_id)
+      puts "  #{sprintf("%6d", packet.id)} #{target.name} #{packet.name} (#{packet.is_tlm ? "TLM" : "CMD"})"
+    end
+    puts ""
+
+    puts "Items:"
+    Item.find_each do |item|
+      packet = Packet.find(item.packet_id)
+      target = Target.find(packet.target_id)
+      puts "  #{sprintf("%6d", item.id)} #{target.name} #{packet.name} #{item.name}"
+    end
+    puts ""
+
+    puts "Packet Logs:"
+    PacketLog.all.each do |packet_log|
+      puts "  #{sprintf("%6d", packet_log.id)} #{packet_log.filename} (#{packet_log.is_tlm ? "TLM" : "CMD"}) #{packet_log.created_at.formatted}"
+    end
+    puts ""
+    
+    puts "Packet Log Entry Count: #{PacketLogEntry.count}"
+    puts ""
+    
+    puts "Packet Configs:"
+    PacketConfig.all.each do |packet_config|
+      packet = Packet.find(packet_config.packet_id)
+      target = Target.find(packet.target_id)
+      puts "  #{sprintf("%6d", packet_config.id)} #{target.name} #{packet.name} (#{packet_config.name}) sysconfig:#{packet_config.first_system_config_id} maxindex:#{packet_config.max_table_index} ready:#{packet_config.ready} start:#{packet_config.start_time.formatted} end:#{packet_config.end_time.formatted}"
+    end
+    puts ""
+    
+    value_type_lookup = {0 => "RAW", 1 => "CONVERTED", 2 => "RAW_CON"}
+    puts "Item to Decom Table Mappings:"
+    ItemToDecomTableMapping.find_each do |itdtm|
+      item = Item.find(itdtm.item_id)
+      packet = Packet.find(item.packet_id)
+      target = Target.find(packet.target_id)
+      puts "  #{sprintf("%6d", itdtm.id)} #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]} packet_config:#{itdtm.packet_config_id} item_index:#{itdtm.item_index} table_index:#{itdtm.table_index} reduced:#{itdtm.reduced}"
+    end
+    puts ""
+    
+    puts "Decom and Reduced Tables:"
+    each_decom_and_reduced_table do |packet_config_id, table_index, decom_model, minute_model, hour_model, day_model|
+      puts "  t#{decom_model.name.split("::")[1][1..-1]}: (#{decom_model.count} entries)"
+      ItemToDecomTableMapping.where("packet_config_id = ? and table_index = ?", packet_config_id, table_index).order("item_index ASC").each do |itdtm|
+        item = Item.find(itdtm.item_id)
+        packet = Packet.find(item.packet_id)
+        target = Target.find(packet.target_id)
+        puts "    i#{itdtm.item_index} #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+      end
+      puts ""
+      puts "  t#{minute_model.name.split("::")[1][1..-1]}: (#{minute_model.count} entries)"
+      ItemToDecomTableMapping.where("packet_config_id = ? and table_index = ? and reduced = true", packet_config_id, table_index).order("item_index ASC").each do |itdtm|
+        item = Item.find(itdtm.item_id)
+        packet = Packet.find(item.packet_id)
+        target = Target.find(packet.target_id)
+        puts "    i#{itdtm.item_index}max #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}min #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}avg #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}stddev #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+      end      
+      puts ""
+      puts "  t#{hour_model.name.split("::")[1][1..-1]}: (#{hour_model.count} entries)"
+      ItemToDecomTableMapping.where("packet_config_id = ? and table_index = ? and reduced = true", packet_config_id, table_index).order("item_index ASC").each do |itdtm|
+        item = Item.find(itdtm.item_id)
+        packet = Packet.find(item.packet_id)
+        target = Target.find(packet.target_id)
+        puts "    i#{itdtm.item_index}max #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}min #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}avg #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}stddev #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+      end    
+      puts ""      
+      puts "  t#{day_model.name.split("::")[1][1..-1]}: (#{day_model.count} entries)"
+      ItemToDecomTableMapping.where("packet_config_id = ? and table_index = ? and reduced = true", packet_config_id, table_index).order("item_index ASC").each do |itdtm|
+        item = Item.find(itdtm.item_id)
+        packet = Packet.find(item.packet_id)
+        target = Target.find(packet.target_id)
+        puts "    i#{itdtm.item_index}max #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}min #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}avg #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+        puts "    i#{itdtm.item_index}stddev #{target.name} #{packet.name} #{item.name} #{value_type_lookup[itdtm.value_type]}"
+      end      
+      puts ""
+    end
+    
   when 'showpacketlogs'
     total_size = 0
     packet_logs = PacketLog.all

data/lib/cosmos/dart/spec/dart/dart_database_cleaner_spec.rb

@@ -189,7 +189,7 @@ describe DartDatabaseCleaner do
       end
       model.reset_column_information
       model_name = table_name.upcase
-      Cosmos.send(:remove_const, model_name) if Cosmos.const_defined?(model_name)
+      Cosmos.public_send(:remove_const, model_name) if Cosmos.const_defined?(model_name)
       Cosmos.const_set(model_name, model)
 
       expect(model.column_names).to include("delete_me")
@@ -205,7 +205,7 @@ describe DartDatabaseCleaner do
         end
         model.reset_column_information
         model_name = table_name.upcase
-        Cosmos.send(:remove_const, model_name) if Cosmos.const_defined?(model_name)
+        Cosmos.public_send(:remove_const, model_name) if Cosmos.const_defined?(model_name)
         Cosmos.const_set(model_name, model)
 
         expect(model.column_names).to include("delete_me")

data/lib/cosmos/gui/qt.rb

@@ -101,22 +101,22 @@ module Cosmos
     return color_r if (color_r.is_a? Qt::Color) || (color_r.is_a? Qt::Pen) || (color_r.is_a? Qt::LinearGradient)
 
     color = nil
-    key = color_r
-    key = key.to_i if key.is_a? Qt::Enum
+    color_key = color_r
+    color_key = color_key.to_i if color_key.is_a? Qt::Enum
 
     if color_r && color_g && color_b
-      key = (color_r.to_i << 24) + (color_g.to_i << 16) + (color_b.to_i << 8)
+      color_key = (color_r.to_i << 24) + (color_g.to_i << 16) + (color_b.to_i << 8)
     end
 
-    if Cosmos::COLORS[key]
-      color = Cosmos::COLORS[key]
+    if Cosmos::COLORS[color_key]
+      color = Cosmos::COLORS[color_key]
     else
       if color_r && color_g && color_b
         color = Qt::Color.new(color_r.to_i, color_g.to_i, color_b.to_i)
       else
         color = Qt::Color.new(color_r)
       end
-      Cosmos::COLORS[key] = color
+      Cosmos::COLORS[color_key] = color
     end
     color
   end
@@ -214,12 +214,12 @@ module Cosmos
   end
 
   def self.getCursor(shape)
-    key = shape
-    key = shape.to_i if shape.is_a? Qt::Enum
-    cursor = CURSORS[key]
+    shape_key = shape
+    shape_key = shape.to_i if shape.is_a? Qt::Enum
+    cursor = CURSORS[shape_key]
     unless cursor
       cursor = Qt::Cursor.new(shape)
-      CURSORS[key] = cursor
+      CURSORS[shape_key] = cursor
     end
     cursor
   end

data/lib/cosmos/gui/qt_tool.rb

@@ -61,6 +61,7 @@ module Cosmos
       @stylesheet = File.read(app_style) if File.exist? app_style
 
       self.class.normalize_config_options(@options)
+      setWindowFlags(windowFlags() | Qt::WindowStaysOnTopHint) if @options.stay_on_top
 
       # Add a banner based on system configuration
       add_classification_banner
@@ -82,7 +83,7 @@ module Cosmos
       else
         options.config_file = nil
         options.stylesheet = nil
-      end      
+      end
     end
 
     # Creates a path to a configuration file. If the file is given it is
@@ -209,28 +210,26 @@ module Cosmos
 
       # Handle manually positioning the window
       unless @options.auto_position
-        # Get the desktop's geometry
-        desktop = Qt::Application.desktop
-
-        # Handle position relative to right edge
-        @options.x = desktop.width - frameGeometry().width + @options.x + 1 if @options.x < 0
-
-        # Handle position relative to bottom edge
-        @options.y = desktop.height - frameGeometry().height + @options.y + 1 if @options.y < 0
-
         # Move to the desired position
         move(@options.x, @options.y)
       end
 
       if @options.remember_geometry and !@options.command_line_geometry
+        # Get the desktop's geometry
+        desktop = Qt::Application.desktop
+        screen = desktop.screen
         settings = Qt::Settings.new('Ball Aerospace', self.class.to_s)
         if settings.contains('size') and @options.restore_size and @options.startup_state != :DEFAULT
           size = settings.value('size').toSize
-          resize(size)
+          if size.height > 0 and size.height < screen.height and size.width > 0 and size.width < screen.width
+            resize(size)
+          end
         end
         if settings.contains('position') and @options.restore_position
           position = settings.value('position').toPoint
-          move(position)
+          if position.x > 0 and position.y > 0 and position.x < screen.width and position.y < screen.height
+            move(position)
+          end
         end
       end
 
@@ -352,6 +351,7 @@ module Cosmos
       options.remember_geometry = true
       options.restore_position = true
       options.restore_size = true
+      options.stay_on_top = false
       options.redirect_io = true
       options.title = "COSMOS Tool"
       options.config_file = nil
@@ -403,6 +403,11 @@ module Cosmos
           options.startup_state = :DEFAULT
         end
 
+        # Create the defaultsize option
+        option_parser.on("--stay-on-top", "Force the tool to stay on top of all other windows") do |arg|
+          options.stay_on_top = true
+        end
+
         # Create the x and y position options
         option_parser.separator("")
         option_parser.separator("Window X & Y Position Options:")

data/lib/cosmos/gui/text/completion_text_edit.rb

@@ -17,6 +17,7 @@ module Cosmos
   # This calss also includes many helper methods to access various
   # lines, indent selections, highlight lines and center the view.
   class CompletionTextEdit < Qt::PlainTextEdit
+    attr_accessor :read_only
     # Create a signal so users of CompletionTextEdit don't have to
     # subclass in order to listen to keyPressEvents
     signals 'key_pressed(QKeyEvent*)'
@@ -47,6 +48,7 @@ module Cosmos
 
       @last_hightlighted_line = 1
       @code_completion = nil
+      @read_only = false
       begin
         @code_completion = Completion.new(self)
       rescue

data/lib/cosmos/gui/widgets/dart_meta_frame.rb

@@ -16,6 +16,13 @@ module Cosmos
   class DartMetaFrame < Qt::Widget
     @@meta_filters = []
 
+    class LabelPopup < Qt::Label
+      attr_accessor :text
+      def mousePressEvent(event)
+        Qt::MessageBox.critical(self.parent, 'Error', @text)
+      end
+    end
+
     def initialize(parent)
       super(parent)
 
@@ -27,6 +34,7 @@ module Cosmos
       @groupbox = Qt::GroupBox.new("Meta Filter Selection")
       @vbox = Qt::VBoxLayout.new(@groupbox)
       @hbox1 = Qt::HBoxLayout.new
+
       @label = Qt::Label.new("Meta Filters: ")
       @hbox1.addWidget(@label)
       @meta_filters_text = Qt::LineEdit.new
@@ -43,6 +51,10 @@ module Cosmos
       @vbox.addLayout(@hbox1)
 
       @hbox2 = Qt::HBoxLayout.new
+      @error = LabelPopup.new
+      @error.setPixmap(Qt::Application.style.standardIcon(Qt::Style::SP_MessageBoxCritical).pixmap(20, 20))
+      @error.hide
+      @hbox2.addWidget(@error)
       @meta_item_name = Qt::ComboBox.new
       @meta_item_name.setMinimumWidth(200)
       @meta_item_name.setMaxVisibleItems(6)
@@ -102,7 +114,7 @@ module Cosmos
       if !@got_meta_item_names and !@update_thread
         @update_thread = Thread.new do
           begin
-            server = JsonDRbObject.new(System.connect_hosts['DART_DECOM'], System.ports['DART_DECOM'])
+            server = JsonDRbObject.new(System.connect_hosts['DART_DECOM'], System.ports['DART_DECOM'], 1.0, Cosmos::System.x_csrf_token)
             item_names = server.item_names("SYSTEM", "META")
             Qt.execute_in_main_thread do
               unless self.disposed?
@@ -113,8 +125,15 @@ module Cosmos
               end
             end
             @got_meta_item_names = true
-          rescue Exception
-            # We tried...
+            Qt.execute_in_main_thread { @error.hide }
+          rescue Exception => e
+            case e.message
+            when /execution expired/
+              @error.text = "Could not connect to the DART Decom Server. Is it running?"
+            else
+              @error.text = e.message
+            end
+            Qt.execute_in_main_thread { @error.show }
           ensure
             @update_thread = nil
             server.disconnect if defined? server

data/lib/cosmos/interfaces/dart_status_interface.rb

@@ -36,7 +36,7 @@ module Cosmos
       @status_packet.write('PACKET_ID', 1)
       @clear_errors_command = System.commands.packet('DART', 'CLEAR_ERRORS')
       @sleeper = Sleeper.new
-      @dart = JsonDRbObject.new(System.connect_hosts['DART_DECOM'], System.ports['DART_DECOM'])
+      @dart = JsonDRbObject.new(System.connect_hosts['DART_DECOM'], System.ports['DART_DECOM'], 1.0, Cosmos::System.x_csrf_token)
     end
 
     # Indicates if the interface is connected to its target(s) or not. Must be

data/lib/cosmos/interfaces/linc_interface.rb

@@ -256,7 +256,7 @@ module Cosmos
       # Handle handshake warnings and errors
       if status == "OK" and code != 0
         unless @ignored_error_codes[handshake_cmd.handshake.handshake.target_name].include? code
-          Logger.warn "Warning sending command (#{code}): #{source}"
+          Logger.warn "#{@name}: Warning sending command (#{code}): #{source}"
         end
       elsif status == "ERROR"
         unless @ignored_error_codes[handshake_cmd.handshake.handshake.target_name].include? code
@@ -295,7 +295,7 @@ module Cosmos
       command.received_count += 1
 
       # Put a log of the command onto the server for the user to see
-      Logger.info("External Command: " + System.commands.format(linc_handshake.identified_command, System.targets[linc_handshake.identified_command.target_name].ignored_parameters))
+      Logger.info("#{@name}: External Command: " + System.commands.format(linc_handshake.identified_command, System.targets[linc_handshake.identified_command.target_name].ignored_parameters))
 
       # Log the command to the command log(s)
       @packet_log_writer_pairs.each do |packet_log_writer_pair|
@@ -361,7 +361,7 @@ module Cosmos
       if @handshake
         timed_out = false
       else
-        Logger.warn "No handshake - must be timeout."
+        Logger.warn "#{@name}: No handshake - must be timeout."
         timed_out = true
       end
 

data/lib/cosmos/interfaces/protocols/burst_protocol.rb

@@ -156,7 +156,7 @@ module Cosmos
     end
 
     def log_discard(length, found)
-      Logger.error("Sync #{'not ' unless found}found. Discarding #{length} bytes of data.")
+      Logger.error("#{@interface ? @interface.name : ""}: Sync #{'not ' unless found}found. Discarding #{length} bytes of data.")
       if @data.length >= 0
         Logger.error(sprintf("Starting: 0x%02X 0x%02X 0x%02X 0x%02X 0x%02X 0x%02X\n",
           @data.length >= 1 ? @data.getbyte(0) : 0,

data/lib/cosmos/interfaces/protocols/crc_protocol.rb

@@ -140,7 +140,7 @@ module Cosmos
       crc = BinaryAccessor.read(@bit_offset, @bit_size, :UINT, data, @endianness)
       calculated_crc = @crc.calc(data[0...(@bit_offset / 8)])
       if calculated_crc != crc
-        Logger.error "Invalid CRC detected! Calculated 0x#{calculated_crc.to_s(16).upcase} vs found 0x#{crc.to_s(16).upcase}."
+        Logger.error "#{@interface ? @interface.name : ""}: Invalid CRC detected! Calculated 0x#{calculated_crc.to_s(16).upcase} vs found 0x#{crc.to_s(16).upcase}."
         if @bad_strategy == DISCONNECT
           return :DISCONNECT
         end

data/lib/cosmos/interfaces/protocols/length_protocol.rb

@@ -135,6 +135,11 @@ module Cosmos
                                    @length_endianness)
       raise "Length value received larger than max_length: #{length} > #{@max_length}" if @max_length and length > @max_length
       packet_length = (length * @length_bytes_per_count) + @length_value_offset
+      # Ensure the calculated packet length is long enough to support the location of the length field
+      # without overlap into the next packet
+      if (packet_length * 8) < (@length_bit_offset + @length_bit_size)
+        raise "Calculated packet length of #{packet_length * 8} bits < (offset:#{@length_bit_offset} + size:#{@length_bit_size})"
+      end
 
       # Make sure we have enough data for the packet
       return :STOP if @data.length < packet_length

data/lib/cosmos/interfaces/protocols/template_protocol.rb

@@ -146,13 +146,13 @@ module Cosmos
         # Write the packet value with each of the values received
         response_values = response_string.scan(response_regexp)[0]
         if !response_values || (response_values.length != response_item_names.length)
-          handle_error("#{@interface.name}: Unexpected response: #{response_string}")
+          handle_error("#{@interface ? @interface.name : ""}: Unexpected response: #{response_string}")
         else
           response_values.each_with_index do |value, i|
             begin
               result_packet.write(response_item_names[i], value)
             rescue => error
-              handle_error("#{@interface.name}: Could not write value #{value} due to #{error.message}")
+              handle_error("#{@interface ? @interface.name : ""}: Could not write value #{value} due to #{error.message}")
               break
             end
           end
@@ -234,7 +234,7 @@ module Cosmos
           sleep(@response_polling_period)
           retry if !response_timeout_time
           retry if response_timeout_time and Time.now < response_timeout_time
-          handle_error("#{@interface.name}: Timeout waiting for response")
+          handle_error("#{@interface ? @interface.name : ""}: Timeout waiting for response")
         end
 
         @response_template = nil

data/lib/cosmos/interfaces/serial_interface.rb

@@ -52,6 +52,7 @@ module Cosmos
       @read_allowed = false unless @read_port_name
       @flow_control = :NONE
       @data_bits = 8
+      @struct = []
     end
 
     # Creates a new {SerialStream} using the parameters passed in the constructor
@@ -65,13 +66,16 @@ module Cosmos
         @write_timeout,
         @read_timeout,
         @flow_control,
-        @data_bits
+        @data_bits,
+        @struct
       )
       super()
     end
 
     # Supported Options
     # FLOW_CONTROL - Flow control method NONE or RTSCTS. Defaults to NONE
+    # DATA_BITS - How many data bits to use
+    # STRUCT - Directly set fields in the Win32 DCB or POSIX termios structure
     def set_option(option_name, option_values)
       super(option_name, option_values)
       case option_name.upcase
@@ -79,6 +83,8 @@ module Cosmos
         @flow_control = option_values[0]
       when 'DATA_BITS'
         @data_bits = option_values[0].to_i
+      when 'STRUCT'
+        @struct << option_values
       end
     end
   end

data/lib/cosmos/interfaces/stream_interface.rb

@@ -49,7 +49,7 @@ module Cosmos
       begin
         data = @stream.read
       rescue Timeout::Error
-        Logger.instance.error "Timeout waiting for data to be read"
+        Logger.instance.error "#{@name}: Timeout waiting for data to be read"
         data = nil
       end
       return nil if data.nil? or data.length <= 0