cosmos 3.1.2 → 3.2.0

data/spec/packets/parsers/limits_parser_spec.rb

@@ -0,0 +1,282 @@
+# encoding: ascii-8bit
+
+# Copyright 2014 Ball Aerospace & Technologies Corp.
+# All Rights Reserved.
+#
+# This program is free software; you can modify and/or redistribute it
+# under the terms of the GNU General Public License
+# as published by the Free Software Foundation; version 3 with
+# attribution addendums as found in the LICENSE.txt
+
+require 'spec_helper'
+require 'cosmos'
+require 'cosmos/packets/packet_config'
+require 'cosmos/packets/parsers/limits_parser'
+require 'tempfile'
+
+module Cosmos
+
+  describe LimitsParser do
+
+    describe "parse" do
+      before(:each) do
+        @pc = PacketConfig.new
+      end
+
+      it "raises if a current item is not defined" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  LIMITS mylimits 1 ENABLED 0 10 20 30 12 18'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "No current item for LIMITS")
+        tf.unlink
+      end
+
+      it "raises if there are not enough parameters" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  ITEM myitem 0 8 UINT "Test Item"'
+        tf.puts '    LIMITS DEFAULT 1 ENABLED 0 10 20 30 12'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Must give both a green low and green high/)
+        tf.unlink
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  ITEM myitem 0 8 UINT "Test Item"'
+        tf.puts '    LIMITS DEFAULT 1 ENABLED 0 10 20'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Not enough parameters for LIMITS/)
+        tf.unlink
+      end
+
+      it "raises if there are too many parameters" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  ITEM myitem 0 8 UINT "Test Item"'
+        tf.puts '    LIMITS DEFAULT 1 ENABLED 0 10 20 30 12 18 20'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Too many parameters for LIMITS/)
+        tf.unlink
+      end
+
+      it "raises if applied to a command PARAMETER" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'COMMAND tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_PARAMETER item1 16 UINT 0 0 0 "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 7 3 5'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /LIMITS only applies to telemetry items/)
+        tf.unlink
+      end
+
+      it "raises if a DEFAULT limits set isn't defined" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS TVAC 3 ENABLED 1 2 6 7 3 5'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /DEFAULT limits set must be defined/)
+        tf.unlink
+      end
+
+      it "sets a warning if a new limits set persistence isn't consistent with DEFAULT" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 7 3 5'
+        tf.puts '    LIMITS TVAC 1 DISABLED 1 2 6 7 3 5'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        expect(@pc.warnings[-1]).to match(/persistence setting conflict with DEFAULT/)
+        tf.unlink
+      end
+
+      it "sets a warning if a new limits set enable isn't consistent with DEFAULT" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 7 3 5'
+        tf.puts '    LIMITS TVAC 3 DISABLED 1 2 6 7 3 5'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        expect(@pc.warnings[-1]).to match(/enable setting conflict with DEFAULT/)
+        tf.unlink
+      end
+
+      it "records 2 warnings if a new limits set persistence and enable isn't consistent with DEFAULT" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 7 3 5'
+        tf.puts '    LIMITS TVAC 1 DISABLED 1 2 6 7 3 5'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        expect(@pc.warnings.length).to eql 2
+        tf.unlink
+      end
+
+      it "raises if the second parameter isn't a number" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT TRUE ENABLED 1 2 6 7 3 5'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Persistence must be an integer/)
+        tf.unlink
+      end
+
+      it "raises if the third parameter isn't ENABLED or DISABLED" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 TRUE 1 2 6 7 3 5'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Initial LIMITS state must be ENABLED or DISABLED/)
+        tf.unlink
+      end
+
+      it "raises if the fourth through ninth parameter aren't numbers'" do
+        msgs = ['','','','','red low','yellow low','yellow high','red high','green low','green high']
+        (4..9).each do |index|
+          tf = Tempfile.new('unittest')
+          tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+          tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+          limits = %w(LIMITS DEFAULT 3 ENABLED 1 2 6 7 3 5)
+          limits[index] = 'X'
+          tf.puts limits.join(' ')
+          tf.close
+          expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Invalid #{msgs[index]} limit value/)
+          tf.unlink
+        end
+      end
+
+      it "raises if the 4 limits are out of order" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 2 1 3 4'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure yellow limits are within red limits.")
+        tf.unlink
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 5 3 7'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure yellow limits are within red limits.")
+        tf.unlink
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 5 4'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure yellow limits are within red limits.")
+        tf.unlink
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 3 0'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure yellow limits are within red limits.")
+        tf.unlink
+      end
+
+      it "raises if the 6 limits are out of order" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 7 0 5'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure green limits are within yellow limits.")
+        tf.unlink
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 3 6 7 2 5'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure green limits are within yellow limits.")
+        tf.unlink
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 8 3 7'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure green limits are within yellow limits.")
+        tf.unlink
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 8 3 9'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure green limits are within yellow limits.")
+        tf.unlink
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 8 4 3'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "Invalid limits specified. Ensure green limits are within yellow limits.")
+        tf.unlink
+      end
+
+      it "should take 4 limits values" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 1 ENABLED 1 2 6 7'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        item = @pc.telemetry["TGT1"]["PKT1"].items["ITEM1"]
+        item.limits.values[:DEFAULT].should_not be_nil
+        @pc.telemetry["TGT1"]["PKT1"].buffer = "\x04"
+        @pc.telemetry["TGT1"]["PKT1"].enable_limits("ITEM1")
+        @pc.telemetry["TGT1"]["PKT1"].check_limits
+        item.limits.state.should eql :GREEN
+        @pc.telemetry["TGT1"]["PKT1"].limits_items.should eql [item]
+        tf.unlink
+      end
+
+      it "should take 6 limits values" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 1 ENABLED 1 2 6 7 3 5'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        item = @pc.telemetry["TGT1"]["PKT1"].items["ITEM1"]
+        item.limits.values[:DEFAULT].should_not be_nil
+        @pc.telemetry["TGT1"]["PKT1"].buffer = "\x04"
+        @pc.telemetry["TGT1"]["PKT1"].enable_limits("ITEM1")
+        @pc.telemetry["TGT1"]["PKT1"].check_limits
+        item.limits.state.should eql :BLUE
+        @pc.telemetry["TGT1"]["PKT1"].limits_items.should eql [item]
+        tf.unlink
+      end
+
+      it "create multiple limits sets" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_ITEM item1 16 UINT "Item"'
+        tf.puts '    LIMITS DEFAULT 1 ENABLED 1 2 6 7'
+        tf.puts '    LIMITS TVAC 1 ENABLED 1 2 6 7'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        item = @pc.telemetry["TGT1"]["PKT1"].items["ITEM1"]
+        expect(item.limits.values.length).to eql 2
+        expect(item.limits.values[:DEFAULT]).to_not be_nil
+        expect(item.limits.values[:TVAC]).to_not be_nil
+        tf.unlink
+      end
+
+    end
+
+  end
+end

data/spec/packets/parsers/limits_response_parser_spec.rb

@@ -0,0 +1,149 @@
+# encoding: ascii-8bit
+
+# Copyright 2014 Ball Aerospace & Technologies Corp.
+# All Rights Reserved.
+#
+# This program is free software; you can modify and/or redistribute it
+# under the terms of the GNU General Public License
+# as published by the Free Software Foundation; version 3 with
+# attribution addendums as found in the LICENSE.txt
+
+require 'spec_helper'
+require 'cosmos'
+require 'cosmos/packets/packet_config'
+require 'cosmos/packets/parsers/limits_response_parser'
+require 'tempfile'
+
+module Cosmos
+
+  describe PacketConfig do
+
+    describe "parse" do
+      before(:each) do
+        @pc = PacketConfig.new
+      end
+
+      it "should complain if a current item is not defined" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  LIMITS_RESPONSE'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "No current item for LIMITS_RESPONSE")
+        tf.unlink
+      end
+
+      it "should complain if there are not enough parameters" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts 'ITEM myitem 0 8 UINT "Test Item"'
+        tf.puts '  LIMITS_RESPONSE'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Not enough parameters for LIMITS_RESPONSE/)
+        tf.unlink
+      end
+
+      it "should complain if applied to a command PARAMETER" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'COMMAND tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  APPEND_PARAMETER item1 16 UINT 0 0 0 "Item"'
+        tf.puts '    LIMITS_RESPONSE test.rb'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, "LIMITS_RESPONSE only applies to telemetry items")
+        tf.unlink
+      end
+
+      it "should complain about missing response file" do
+        filename = File.join(File.dirname(__FILE__), "../../test_only.rb")
+        File.delete(filename) if File.exist?(filename)
+        @pc = PacketConfig.new
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  ITEM item1 0 16 INT "Integer Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 7 3 5'
+        tf.puts '    LIMITS_RESPONSE test_only.rb'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /TestOnly class not found/)
+        tf.unlink
+      end
+
+      it "should complain about a non Cosmos::LimitsResponse class" do
+        filename = File.join(File.dirname(__FILE__), "../../limits_response1.rb")
+        File.open(filename, 'w') do |file|
+          file.puts "class LimitsResponse1"
+          file.puts "  def call(target_name, packet_name, item, old_limits_state, new_limits_state)"
+          file.puts "  end"
+          file.puts "end"
+        end
+        load 'limits_response1.rb'
+        File.delete(filename) if File.exist?(filename)
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  ITEM item1 0 16 INT "Integer Item"'
+        tf.puts '    LIMITS DEFAULT 3 ENABLED 1 2 6 7 3 5'
+        tf.puts '    LIMITS_RESPONSE limits_response1.rb'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /response must be a Cosmos::LimitsResponse but is a LimitsResponse1/)
+        tf.unlink
+      end
+
+      it "should set the response" do
+        filename = File.join(File.dirname(__FILE__), "../../limits_response2.rb")
+        File.open(filename, 'w') do |file|
+          file.puts "require 'cosmos/packets/limits_response'"
+          file.puts "class LimitsResponse2 < Cosmos::LimitsResponse"
+          file.puts "  def call(target_name, packet_name, item, old_limits_state, new_limits_state)"
+          file.puts "    puts \"\#{target_name} \#{packet_name} \#{item.name} \#{old_limits_state} \#{new_limits_state}\""
+          file.puts "  end"
+          file.puts "end"
+        end
+        load 'limits_response2.rb'
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  ITEM item1 0 16 INT "Integer Item"'
+        tf.puts '    LIMITS DEFAULT 1 ENABLED 1 2 6 7 3 5'
+        tf.puts '    LIMITS_RESPONSE limits_response2.rb'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        pkt = @pc.telemetry["TGT1"]["PKT1"]
+        pkt.get_item("ITEM1").limits.response.class.should eql LimitsResponse2
+
+        File.delete(filename) if File.exist?(filename)
+        tf.unlink
+      end
+
+      it "should call the response with parameters" do
+        filename = File.join(File.dirname(__FILE__), "../../limits_response2.rb")
+        File.open(filename, 'w') do |file|
+          file.puts "require 'cosmos/packets/limits_response'"
+          file.puts "class LimitsResponse2 < Cosmos::LimitsResponse"
+          file.puts "  def initialize(val)"
+          file.puts "    puts \"initialize: \#{val}\""
+          file.puts "  end"
+          file.puts "  def call(target_name, packet_name, item, old_limits_state, new_limits_state)"
+          file.puts "    puts \"\#{target_name} \#{packet_name} \#{item.name} \#{old_limits_state} \#{new_limits_state}\""
+          file.puts "  end"
+          file.puts "end"
+        end
+        load 'limits_response2.rb'
+
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  ITEM item1 0 16 INT "Integer Item"'
+        tf.puts '    LIMITS DEFAULT 1 ENABLED 1 2 6 7 3 5'
+        tf.puts '    LIMITS_RESPONSE limits_response2.rb 2'
+        tf.close
+        capture_io do |stdout|
+          @pc.process_file(tf.path, "TGT1")
+          stdout.string.should eql "initialize: 2\n"
+        end
+
+        File.delete(filename) if File.exist?(filename)
+        tf.unlink
+      end
+
+    end
+  end
+end

data/spec/packets/parsers/macro_parser_spec.rb

@@ -0,0 +1,184 @@
+# encoding: ascii-8bit
+
+# Copyright 2014 Ball Aerospace & Technologies Corp.
+# All Rights Reserved.
+#
+# This program is free software; you can modify and/or redistribute it
+# under the terms of the GNU General Public License
+# as published by the Free Software Foundation; version 3 with
+# attribution addendums as found in the LICENSE.txt
+
+require 'spec_helper'
+require 'cosmos'
+require 'cosmos/packets/packet_config'
+require 'cosmos/packets/parsers/macro_parser'
+require 'tempfile'
+
+module Cosmos
+
+  describe MacroParser do
+    before(:each) do
+      @pc = PacketConfig.new
+    end
+
+    describe "start" do
+      it "complains if a current packet is not defined" do
+        # Check for missing TELEMETRY line
+        tf = Tempfile.new('unittest')
+        tf.puts '  MACRO_APPEND_START'
+        tf.close
+        expect { @pc.process_file(tf.path, "SYSTEM") }.to raise_error(ConfigParser::Error, "No current packet for MACRO_APPEND_START")
+      end
+
+      it "complains if there are not enough parameters" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  MACRO_APPEND_START'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Not enough parameters for MACRO_APPEND_START/)
+        tf.unlink
+      end
+
+      it "complains if there are too many parameters" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts 'MACRO_APPEND_START 0 1 "%s_%d" extra'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Too many parameters for MACRO_APPEND_START/)
+        tf.unlink
+      end
+
+      it "complains if a previous START hasn't been closed" do
+        # Check for missing TELEMETRY line
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts '  MACRO_APPEND_START 1 5'
+        tf.puts '  MACRO_APPEND_START 1 5'
+        tf.close
+        expect { @pc.process_file(tf.path, "SYSTEM") }.to raise_error(ConfigParser::Error, /First close the previous/)
+      end
+
+      it "swaps reverse ranges to be in order" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Description"'
+        tf.puts 'MACRO_APPEND_START 4 1' # <-- Note the reverse order
+        tf.puts 'APPEND_ITEM BIT 16 UINT "Setting #x"'
+        tf.puts '  STATE BAD 0 RED'
+        tf.puts '  STATE GOOD 1 GREEN'
+        tf.puts 'MACRO_APPEND_END'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        pkt = @pc.telemetry["TGT1"]["PKT1"]
+        expect(pkt.items.length).to eql 7 # 4 plus the RECEIVED_XXX items
+        expect(pkt.items.keys).to include('BIT1','BIT2','BIT3','BIT4')
+        expect(pkt.sorted_items[3].name).to eql 'BIT1'
+        expect(pkt.sorted_items[4].name).to eql 'BIT2'
+        expect(pkt.sorted_items[5].name).to eql 'BIT3'
+        expect(pkt.sorted_items[6].name).to eql 'BIT4'
+        limits_items = []
+        pkt.items.each do |name, item|
+          limits_items << item if name.include?('BIT')
+        end
+        expect(pkt.limits_items).to eql limits_items
+        tf.unlink
+      end
+    end
+
+    describe "end" do
+      it "complains if there are too many parameters" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts 'MACRO_APPEND_START 0 1 "%s_%d"'
+        tf.puts 'MACRO_APPEND_END extra'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /Too many parameters for MACRO_APPEND_END/)
+        tf.unlink
+      end
+
+      it "complains if there are no items in the macro" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Packet"'
+        tf.puts 'MACRO_APPEND_START 0 1 "%s_%d"'
+        tf.puts 'MACRO_APPEND_END'
+        tf.close
+        expect { @pc.process_file(tf.path, "TGT1") }.to raise_error(ConfigParser::Error, /No items appended/)
+        tf.unlink
+      end
+    end
+
+    describe "add_item" do
+      it "adds items with states to the packet" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Description"'
+        tf.puts 'MACRO_APPEND_START 1 5'
+        tf.puts 'APPEND_ITEM BIT 16 UINT "Setting #x"'
+        tf.puts '  STATE BAD 0 RED'
+        tf.puts '  STATE GOOD 1 GREEN'
+        tf.puts 'MACRO_APPEND_END'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        pkt = @pc.telemetry["TGT1"]["PKT1"]
+        expect(pkt.items.length).to eql 8 # 5 plus the RECEIVED_XXX items
+        pkt.items.keys.should include('BIT1','BIT2','BIT3','BIT4','BIT5')
+        expect(pkt.sorted_items[3].name).to eql 'BIT1'
+        expect(pkt.sorted_items[4].name).to eql 'BIT2'
+        expect(pkt.sorted_items[5].name).to eql 'BIT3'
+        expect(pkt.sorted_items[6].name).to eql 'BIT4'
+        expect(pkt.sorted_items[7].name).to eql 'BIT5'
+        limits_items = []
+        pkt.items.each do |name, item|
+          limits_items << item if name.include?('BIT')
+        end
+        pkt.limits_items.should eql limits_items
+        tf.unlink
+      end
+
+      it "adds items with limits to the packet" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Description"'
+        tf.puts 'MACRO_APPEND_START 1 5'
+        tf.puts 'APPEND_ITEM BIT 16 UINT "Setting #x"'
+        tf.puts '  LIMITS DEFAULT 3 ENABLED 0 1 3 4'
+        tf.puts 'MACRO_APPEND_END'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        pkt = @pc.telemetry["TGT1"]["PKT1"]
+        expect(pkt.items.length).to eql 8 # 5 plus the RECEIVED_XXX items
+        expect(pkt.items.keys).to include('BIT1','BIT2','BIT3','BIT4','BIT5')
+        expect(pkt.limits_items.collect{|item| item.name}).to include('BIT1','BIT2','BIT3','BIT4','BIT5')
+        tf.unlink
+      end
+
+      it "adds array items to the packet" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Description"'
+        tf.puts 'MACRO_APPEND_START 1 5'
+        tf.puts 'APPEND_ARRAY_ITEM BIT 16 INT 64 "Int Array Parameter"'
+        tf.puts 'MACRO_APPEND_END'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        pkt = @pc.telemetry["TGT1"]["PKT1"]
+        expect(pkt.items.length).to eql 8 # 5 plus the RECEIVED_XXX items
+        pkt.items.keys.should include('BIT1','BIT2','BIT3','BIT4','BIT5')
+        pkt.limits_items.should be_empty
+        tf.unlink
+      end
+
+      it "works with printf format strings" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'TELEMETRY tgt1 pkt1 LITTLE_ENDIAN "Description"'
+        tf.puts 'MACRO_APPEND_START 8 12 "%02d_%s"'
+        tf.puts 'APPEND_ID_ITEM BIT 16 UINT 0 "Setting #x"'
+        tf.puts 'MACRO_APPEND_END'
+        tf.close
+        @pc.process_file(tf.path, "TGT1")
+        pkt = @pc.telemetry["TGT1"]["PKT1"]
+        expect(pkt.items.length).to eql 8 # 5 plus the RECEIVED_XXX items
+        pkt.items.keys.should include('08_BIT','09_BIT','10_BIT','11_BIT','12_BIT')
+        pkt.limits_items.should be_empty
+        tf.unlink
+      end
+
+    end
+  end
+end