cosmos 3.1.1 → 3.1.2

data/lib/cosmos/tools/test_runner/results_writer.rb

@@ -94,7 +94,7 @@ module Cosmos
           @file.puts "  Exceptions:"
           result.exceptions.each_with_index do |error, index|
             error.formatted(true).each_line do |line|
-              break if line =~ /cosmos_test.rb/
+              break if line =~ /test_runner\/test.rb/
               next  if line =~ cosmos_lib
               if line =~ /[\x00-\x08\x0B-\x0C\x0E-\x1F\x7F-\xFF]/
                 line.chomp!

data/lib/cosmos/tools/test_runner/test_runner.rb

@@ -1033,9 +1033,10 @@ module Cosmos
       end
 
       # Build list of TestSuites and Tests
-      @@test_suites = []
+      @@test_suites = @@test_suites.select {|my_suite| my_suite.name == 'Cosmos::CustomTestSuite'}
       tests         = []
       ObjectSpace.each_object(Class) do |object|
+        next if object.name == 'Cosmos::CustomTestSuite'
         if (object.ancestors.include?(TestSuite) &&
             object != TestSuite &&
             !ignored_test_suite_classes.include?(object))
@@ -1125,7 +1126,7 @@ module Cosmos
             end
           end
         end
-        @@suites[suite.name.split('::')[-1]] = cur_suite
+        @@suites[suite.name.split('::')[-1]] = cur_suite unless suite.name == 'Cosmos::CustomTestSuite'
       end
       Qt.execute_in_main_thread(true) { @test_runner_chooser.test_suites = @@suites }
     end

data/lib/cosmos/tools/tlm_grapher/data_objects/data_object.rb

@@ -101,17 +101,33 @@ module Cosmos
       raise "process_packet must be defined by class #{self.class}"
     end
 
+    def handle_process_exception(error, telemetry_point)
+      raise error if error.class == NoMemoryError
+      reset()
+      @plot.redraw_needed = true
+      @error = error
+      if error.is_a? TypeError
+        @error = FatalError.new("Telemetry point #{telemetry_point} could not be displayed. This is most likely due to this telemetry point being a String which can't be represented on the graph. Remove the point from the list of telemetry items to cause this exception to go away.\n\n#{error}")
+      else
+        @exceptions_reported ||= []
+        unless @exceptions_reported.include?(error.message)
+          @exceptions_reported << error.message
+          Cosmos.write_exception_file(error)
+        end
+      end
+    end
+
     # Resets the data object's data (everything that is not configuration)
     def reset
       @error = nil
-      #Reset this value at the max float so any x_value will be less than it
+      # Reset this value at the max float so any x_value will be less than it
       @first_x_value = Float::MAX
     end
 
     # Supplies text that should be appended to the popup string on mousing over the specified
     # x value
     def popup_modifier(x_value)
-      #The default class returns an empty value
+      # The default class returns an empty value
       return ""
     end
 

data/lib/cosmos/tools/tlm_grapher/data_objects/housekeeping_data_object.rb

@@ -161,8 +161,9 @@ module Cosmos
           y_value = packet.read(@item_name)
         end
         # Bail on the values if they are NaN or nil as we can't graph them
-        return if x_value.nan? || y_value.nan? || x_value.nil? || y_value.nil?
-
+        return if x_value.nil? || y_value.nil? ||
+          (x_value.respond_to?(:nan?) && x_value.nan?) ||
+          (y_value.respond_to?(:nan?) && y_value.nan?)
         @formatted_x_values << packet.read(@formatted_time_item_name) if @formatted_time_item_name
 
         upper_index  = nil
@@ -252,13 +253,7 @@ module Cosmos
         # Prune Data
         prune_to_max_points_saved()
       rescue Exception => error
-        raise error if error.class == NoMemoryError
-        reset()
-        @error = error
-        @plot.redraw_needed = true
-        if error.is_a? TypeError
-          @error = FatalError.new("Telemetry point #{packet.target_name} #{packet.packet_name} #{@item_name} could not be displayed. This is most likely due to this telemetry point being a String which can't be represented on the graph. Remove the point from the list of telemetry items to cause this exception to go away.\n\n#{error}")
-        end
+        handle_process_exception(error, "#{packet.target_name} #{packet.packet_name} #{@item_name}")
       end
     end # def process_packet
 

data/lib/cosmos/tools/tlm_grapher/data_objects/xy_data_object.rb

@@ -191,8 +191,11 @@ module Cosmos
         else
           y_value = packet.read(@y_item_name)
         end
+
         # Bail on the values if they are NaN or nil as we can't graph them
-        return if x_value.nan? || y_value.nan? || x_value.nil? || y_value.nil?
+        return if x_value.nil? || y_value.nil? ||
+          (x_value.respond_to?(:nan?) && x_value.nan?) ||
+          (y_value.respond_to?(:nan?) && y_value.nan?)
 
         time_value = packet.read(@time_item_name) if @time_item_name
 
@@ -205,10 +208,7 @@ module Cosmos
         # Prune Data
         prune_to_max_points_saved()
       rescue Exception => error
-        raise error if error.class == NoMemoryError
-        reset()
-        @error = error
-        @plot.redraw_needed = true
+        handle_process_exception(error, "#{packet.target_name} #{packet.packet_name} #{@x_item_name} or #{@y_item_name}")
       end
     end # def process_packet
 

data/lib/cosmos/top_level.rb

@@ -235,7 +235,7 @@ module Cosmos
           if real_lines > 0
             Logger.error output
             self.write_unexpected_file(output)
-            if defined? Qt and Qt::Application.instance
+            if defined? ::Qt and ::Qt::Application.instance
               Qt.execute_in_main_thread(false) do
                 dialog = Qt::Dialog.new do |box|
                   box.setWindowTitle('Unexpected text output')

data/lib/cosmos/version.rb

@@ -1,12 +1,12 @@
 # encoding: ascii-8bit
 
-COSMOS_VERSION = '3.1.1'
+COSMOS_VERSION = '3.1.2'
 module Cosmos
   module Version
     MAJOR = '3'
     MINOR = '1'
-    PATCH = '1'
-    BUILD = 'b48940656c271344ab5d18c7d2361bcb046a9fd4'
+    PATCH = '2'
+    BUILD = '5864bf4376d74014c01d625e46b5aefc843908ba'
   end
-  VERSION = '3.1.1'
+  VERSION = '3.1.2'
 end

data/run_gui_tests.bat

@@ -1,32 +1,34 @@
-ruby autohotkey\tools\CmdExtractorAHK --defaultsize
-ruby autohotkey\tools\CmdSenderAHK -w 650 -t 650
-ruby autohotkey\tools\CmdTlmServerAHK -x 50 -y 50 -w 900 -t 1000
-ruby autohotkey\tools\CmdTlmServerAHK2 -w 900 -t 1000 -p -n -c cmd_tlm_server.txt
-ruby autohotkey\tools\DataViewerAHK -w 600 -t 800
-ruby autohotkey\tools\HandbookCreatorAHK
-ruby autohotkey\tools\LauncherAHK
-ruby autohotkey\tools\LimitsMonitorAHK
-ruby autohotkey\tools\OpenGLBuilderAHK -w 600 -t 600
-ruby autohotkey\tools\PacketViewerAHK -w 600 -t 800
-ruby autohotkey\tools\PacketViewerAHK2 --defaultsize -p "INST ADCS"
-ruby autohotkey\tools\ReplayAHK
-ruby autohotkey\tools\ScriptRunnerAHK -w 600 -t 800
-ruby autohotkey\tools\ScriptRunnerAHK2 -w 600 -t 800
-ruby autohotkey\tools\TableManagerAHK -w 800 -t 800
-ruby autohotkey\tools\TestRunnerAHK -w 800 -t 800
-ruby autohotkey\tools\TestRunnerAHK2 -w 800 -t 800 -c test_runner2.txt
-ruby autohotkey\tools\TestRunnerAHK3 -w 800 -t 800 -c test_runner3.txt
-ruby autohotkey\tools\TestRunnerAHK4 -w 800 -t 800 -c test_runner4.txt
-ruby autohotkey\tools\TlmGrapherAHK -w 800 -t 800
-ruby autohotkey\tools\TlmGrapherAHK2 -s -c test2.txt -w 1200 -t 800
-ruby autohotkey\tools\TlmGrapherAHK3 -i 'INST HEALTH_STATUS TEMP1'
-ruby autohotkey\tools\TlmGrapherAHK4 -s -c bad.txt
-ruby autohotkey\tools\TlmExtractorAHK -w 800 -t 800
-ruby autohotkey\tools\TlmExtractorAHK2 -c tlm_extractor2.txt -i tlm.bin
-ruby autohotkey\tools\TlmExtractorAHK3 -c tlm_extractor2.txt -i tlm.bin -o outputs/logs/tlm.txt
-ruby autohotkey\tools\TlmViewerAHK
-ruby autohotkey\tools\TlmViewerAHK2 -c tlm_viewer2.txt
-ruby autohotkey\tools\TlmViewerAHK3 -s "BLAH" -c tlm_viewer3.txt
-ruby autohotkey\tools\TlmViewerAHK4 -c tlm_viewer3.txt
-ruby autohotkey\tools\TlmViewerAHK5 -n -s "INST ADCS"
+call bundle exec ruby autohotkey\tools\CmdExtractorAHK --defaultsize
+call bundle exec ruby autohotkey\tools\CmdSenderAHK -w 650 -t 650
+call bundle exec ruby autohotkey\tools\CmdTlmServerAHK -x 50 -y 50 -w 900 -t 1000
+call bundle exec ruby autohotkey\tools\CmdTlmServerAHK2 -w 900 -t 1000 -p -n -c cmd_tlm_server.txt
+call bundle exec ruby autohotkey\tools\DataViewerAHK -w 600 -t 800
+call bundle exec ruby autohotkey\tools\HandbookCreatorAHK
+call bundle exec ruby autohotkey\tools\LauncherAHK
+call bundle exec ruby autohotkey\tools\LimitsMonitorAHK
+call bundle exec ruby autohotkey\tools\OpenGLBuilderAHK -w 600 -t 600
+call bundle exec ruby autohotkey\tools\PacketViewerAHK -w 600 -t 800
+call bundle exec ruby autohotkey\tools\PacketViewerAHK2 --defaultsize -p "INST ADCS"
+call bundle exec ruby autohotkey\tools\ReplayAHK
+call bundle exec ruby autohotkey\tools\ScriptRunnerAHK -w 600 -t 800
+call bundle exec ruby autohotkey\tools\ScriptRunnerAHK2 -w 600 -t 800
+call bundle exec ruby autohotkey\tools\TableManagerAHK -w 800 -t 800
+call bundle exec ruby autohotkey\tools\TestRunnerAHK -w 800 -t 800
+call bundle exec ruby autohotkey\tools\TestRunnerAHK2 -w 800 -t 800 -c test_runner2.txt
+call bundle exec ruby autohotkey\tools\TestRunnerAHK3 -w 800 -t 800 -c test_runner3.txt
+call bundle exec ruby autohotkey\tools\TestRunnerAHK4 -w 800 -t 800 -c test_runner4.txt
+call bundle exec ruby autohotkey\tools\TlmGrapherAHK -w 800 -t 800
+call bundle exec ruby autohotkey\tools\TlmGrapherAHK2 -s -c test2.txt -w 1200 -t 800
+call bundle exec ruby autohotkey\tools\TlmGrapherAHK3 -i 'INST HEALTH_STATUS TEMP1'
+call bundle exec ruby autohotkey\tools\TlmGrapherAHK4 -s -c bad.txt
+call bundle exec ruby autohotkey\tools\TlmExtractorAHK -w 800 -t 800
+call bundle exec ruby autohotkey\tools\TlmExtractorAHK2 -c tlm_extractor2.txt -i tlm.bin
+call bundle exec ruby autohotkey\tools\TlmExtractorAHK3 -c tlm_extractor2.txt -i tlm.bin -o outputs/logs/tlm.txt
+call bundle exec ruby autohotkey\tools\TlmViewerAHK
+call bundle exec ruby autohotkey\tools\TlmViewerAHK2 -c tlm_viewer2.txt
+call bundle exec ruby autohotkey\tools\TlmViewerAHK3 -s "BLAH" -c tlm_viewer3.txt
+call bundle exec ruby autohotkey\tools\TlmViewerAHK4 -c tlm_viewer3.txt
+call bundle exec ruby autohotkey\tools\TlmViewerAHK5 -n -s "INST ADCS"
 
+REM Display any exception files that were generated
+dir autohotkey\outputs\logs\*exception.txt

data/spec/core_ext/time_spec.rb

@@ -135,6 +135,50 @@ describe Time do
     end
   end
 
+  describe "Time.julian2mdy" do
+    it "should return the YMD from a Julian date" do
+      # Result generated from aa.usno.navy.mil/data/docs/JulianDate.php
+      # Ignore the seconds value
+      Time.julian2mdy(2457024.627836)[0..-2].should eql [2015,1,2,3,4,5]
+      # Ignore the seconds value
+      Time.julian2mdy(2369916.021181)[0..-2].should eql [1776,7,4,12,30,30]
+    end
+  end
+
+  describe "Time.ccsds2mdy and Time.mdy2ccsds" do
+    it "should convert YMD to and from CCSDS" do
+      Time.ccsds2mdy(0, 1000, 2).should eql [1958,1,1,0,0,1,2]
+      ccsds_day, ccsds_ms, ccsds_us = Time.mdy2ccsds(2015,1,2,3,4,5,6)
+      Time.ccsds2mdy(ccsds_day, ccsds_ms, ccsds_us).should eql [2015,1,2,3,4,5,6]
+    end
+  end
+
+  describe "Time.ccsds2julian and Time.julian2ccsds" do
+    it "should convert CCSDS to and from Julian" do
+      Time.ccsds2julian(0, 1000, 2).should be_within(0.00001).of(2436204.500012)
+      time = Time.now
+      ccsds_day, ccsds_ms, ccsds_us = Time.mdy2ccsds(2015,1,2,3,4,5,100)
+      julian = Time.ccsds2julian(ccsds_day, ccsds_ms, ccsds_us)
+      parts = Time.julian2ccsds(julian)
+      parts[0].should eql ccsds_day
+      parts[1].should eql ccsds_ms
+      parts[2].should be_within(50).of(ccsds_us)
+    end
+  end
+
+  describe "Time.ccsds2sec and Time.sec2ccsds" do
+    it "should convert seconds to and from CCSDS" do
+      Time.ccsds2sec(0, 1000, 2).should be_within(0.00001).of(1)
+      time = Time.now
+      ccsds_day, ccsds_ms, ccsds_us = Time.mdy2ccsds(2015,1,2,3,4,5,100)
+      seconds = Time.ccsds2sec(ccsds_day, ccsds_ms, ccsds_us)
+      parts = Time.sec2ccsds(seconds)
+      parts[0].should eql ccsds_day
+      parts[1].should eql ccsds_ms
+      parts[2].should be_within(50).of(ccsds_us)
+    end
+  end
+
   describe "Time.yds2mdy" do
     it "should convert year, day, seconds" do
       Time.yds2mdy(2020, 1, 1.5).should eql [2020,1,1,0,0,1,500000]
@@ -148,4 +192,11 @@ describe Time do
       Time.yds2julian(2000,1,12*60*60).should eql Time::JULIAN_DATE_OF_J2000_EPOCH
     end
   end
+
+  describe "Time.unix_epoch_delta" do
+    it "should return a delta to the unix epoch" do
+      Time.init_epoch_delta("1970/01/01 00:00:00").should eql 0
+      Time.init_epoch_delta("1969/12/31 12:00:00").should eql 60*60*12
+    end
+  end
 end

data/spec/script/script_spec.rb

@@ -308,6 +308,23 @@ module Cosmos
       end
     end
 
+    describe "get_overall_limits_state" do
+      it "should get the overall limits state of the system" do
+        get_overall_limits_state.should eql :RED
+      end
+
+      it "should ignore specified items" do
+        ignore = []
+        ignore << %w(INST HEALTH_STATUS TEMP1)
+        ignore << %w(INST HEALTH_STATUS TEMP2)
+        ignore << %w(INST HEALTH_STATUS TEMP3)
+        ignore << %w(INST HEALTH_STATUS TEMP4)
+        ignore << %w(INST HEALTH_STATUS GROUND1STATUS)
+        ignore << %w(INST HEALTH_STATUS GROUND2STATUS)
+        get_overall_limits_state(ignore).should eql :STALE
+      end
+    end
+
     describe "limits_enabled?, disable_limits, enable_limits" do
       it "should enable, disable, and check limits for an item" do
         limits_enabled?("INST HEALTH_STATUS TEMP1").should be_truthy
@@ -375,6 +392,14 @@ module Cosmos
         result[0].should eql :LIMITS_SETTINGS
         unsubscribe_limits_events(id)
       end
+
+      it "should handle unknown limits events" do
+        id = subscribe_limits_events
+        CmdTlmServer.instance.post_limits_event(:UNKNOWN, "This is a test")
+        result = get_limits_event(id, true)
+        result[0].should eql :UNKNOWN
+        unsubscribe_limits_events(id)
+      end
     end
 
     describe "subscribe_packet_data, get_packet, unsubscribe_packet_data" do
@@ -394,6 +419,18 @@ module Cosmos
       end
     end
 
+    describe "play_wav_file" do
+      it "should play a wav file if Qt is available" do
+        module Qt
+          def self.execute_in_main_thread(bool); yield; end
+          class CoreApplication; def self.instance; true; end; end;
+          class Sound; def self.isAvailable; true; end; end
+        end
+        expect(Qt::Sound).to receive(:play).with("sound.wav")
+        play_wav_file("sound.wav")
+      end
+    end
+
     describe "status_bar" do
       it "should set the ScriptRunner status bar" do
         class ScriptRunner; end
@@ -649,6 +686,65 @@ module Cosmos
       end
     end
 
+    describe "display" do
+      it "should display a telemetry viewer screen" do
+        expect { display("HI") }.to raise_error(RuntimeError, /HI could not be displayed/)
+      end
+    end
+    describe "clear" do
+      it "should close a telemetry viewer screen" do
+        expect { clear("HI") }.to raise_error(RuntimeError, /HI could not be cleared/)
+      end
+    end
+
+    describe "ScriptRunnerFrame methods" do
+      it "should call various ScriptRunnerFrame methods" do
+        class Dummy; def method_missing(meth, *args, &block); end; end
+        class ScriptRunnerFrame
+          def self.method_missing(meth, *args, &block); end
+          def self.instance; Dummy.new; end
+        end
+        set_line_delay(1.0)
+        get_line_delay
+        get_scriptrunner_message_log_filename
+        start_new_scriptrunner_message_log
+        insert_return
+        step_mode
+        run_mode
+        show_backtrace
+      end
+    end
+
+    describe "start" do
+      it "should start a script locally" do
+        class ScriptRunnerFrame; def self.instance; false; end; end
+        start("cosmos.rb")
+      end
+
+      it "should start a script without the .rb extension" do
+        class ScriptRunnerFrame; def self.instance; false; end; end
+        start("cosmos")
+      end
+
+      it "should raise an error if the script can't be found" do
+        class ScriptRunnerFrame; def self.instance; false; end; end
+        expect { start("unknown_script.rb") }.to raise_error(RuntimeError)
+      end
+
+      it "should start a script within ScriptRunnerFrame" do
+        class ScriptRunnerFrame
+          @@instrumented_cache = {}
+          def self.instance; true; end
+          def self.instrumented_cache; @@instrumented_cache; end
+          def self.instrumented_cache=(value); @@instrumented_cache = value; end
+          def self.instrument_script(file_text, path, bool); "#"; end
+        end
+        start("cosmos.rb")
+        # This one should use the cached version
+        start("cosmos.rb")
+      end
+    end
+
   end
 end
 

data/spec/tools/cmd_tlm_server/commanding_spec.rb

@@ -48,12 +48,40 @@ module Cosmos
         # Set the target_name to nil to make it "unidentified"
         pkt.target_name = nil
 
+        count = System.targets['COSMOS'].cmd_cnt
         cmd.send_command_to_target('COSMOS', pkt)
         # Verify the COSMOS STARTLOGGING packet has been updated
         System.commands.packet("COSMOS","STARTLOGGING").buffer.should eql pkt.buffer
+        # Verify the target count didn't get updated
+        expect(System.targets['COSMOS'].cmd_cnt).to eq count
+        # Restore target name
+        pkt.target_name = 'COSMOS'
         tf.unlink
       end
 
+      it "should send already identified commands" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'INTERFACE MY_INT interface.rb'
+        tf.close
+        config = CmdTlmServerConfig.new(tf.path)
+        cmd = Commanding.new(config)
+        interfaces = Interfaces.new(config)
+        interfaces.map_target("COSMOS","MY_INT")
+        expect(interfaces.all["MY_INT"]).to receive(:write)
+        expect(interfaces.all["MY_INT"].packet_log_writer_pairs[0].cmd_log_writer).to receive(:write)
+
+        # Grab an existing packet
+        pkt = System.commands.packet('COSMOS','STARTLOGGING')
+
+        count = System.targets['COSMOS'].cmd_cnt
+        cmd.send_command_to_target('COSMOS', pkt)
+        # Verify the COSMOS STARTLOGGING packet has been updated
+        System.commands.packet("COSMOS","STARTLOGGING").buffer.should eql pkt.buffer
+        expect(System.targets['COSMOS'].cmd_cnt).to eq count + 1
+        tf.unlink
+      end
+
+
       it "should log unknown commands" do
         Logger.level = Logger::DEBUG
         stdout = StringIO.new('', 'r+')

data/spec/tools/cmd_tlm_server/connections_spec.rb

@@ -142,6 +142,94 @@ module Cosmos
         tf.unlink
       end
     end
+
+    describe "start_raw_logging" do
+      it "should start raw logging on all connections by default" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'INTERFACE INTERFACE1 interface.rb'
+        tf.puts 'INTERFACE INTERFACE2 interface.rb'
+        tf.puts 'INTERFACE INTERFACE3 interface.rb'
+        tf.close
+        interfaces = Connections.new(:INTERFACES, CmdTlmServerConfig.new(tf.path))
+        expect(interfaces.all['INTERFACE1']).to receive(:start_raw_logging)
+        expect(interfaces.all['INTERFACE2']).to receive(:start_raw_logging)
+        expect(interfaces.all['INTERFACE3']).to receive(:start_raw_logging)
+        interfaces.start_raw_logging
+        tf.unlink
+      end
+
+      it "should start raw logging on a specified connections by name" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'INTERFACE INTERFACE1 interface.rb'
+        tf.puts 'INTERFACE INTERFACE2 interface.rb'
+        tf.puts 'INTERFACE INTERFACE3 interface.rb'
+        tf.close
+        interfaces = Connections.new(:INTERFACES, CmdTlmServerConfig.new(tf.path))
+        expect(interfaces.all['INTERFACE1']).to_not receive(:start_raw_logging)
+        expect(interfaces.all['INTERFACE2']).to receive(:start_raw_logging)
+        expect(interfaces.all['INTERFACE3']).to_not receive(:start_raw_logging)
+        interfaces.start_raw_logging('INTERFACE2')
+        tf.unlink
+      end
+
+      it "should raise on an unknown connection" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'INTERFACE INTERFACE1 interface.rb'
+        tf.puts 'INTERFACE INTERFACE2 interface.rb'
+        tf.puts 'INTERFACE INTERFACE3 interface.rb'
+        tf.close
+        interfaces = Connections.new(:INTERFACES, CmdTlmServerConfig.new(tf.path))
+        expect(interfaces.all['INTERFACE1']).to_not receive(:start_raw_logging)
+        expect(interfaces.all['INTERFACE2']).to_not receive(:start_raw_logging)
+        expect(interfaces.all['INTERFACE3']).to_not receive(:start_raw_logging)
+        expect { interfaces.start_raw_logging('BLAH') }.to raise_error(/Unknown/)
+        tf.unlink
+      end
+    end
+
+    describe "stop_raw_logging" do
+      it "should stop raw logging on all connections by default" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'INTERFACE INTERFACE1 interface.rb'
+        tf.puts 'INTERFACE INTERFACE2 interface.rb'
+        tf.puts 'INTERFACE INTERFACE3 interface.rb'
+        tf.close
+        interfaces = Connections.new(:INTERFACES, CmdTlmServerConfig.new(tf.path))
+        expect(interfaces.all['INTERFACE1']).to receive(:stop_raw_logging)
+        expect(interfaces.all['INTERFACE2']).to receive(:stop_raw_logging)
+        expect(interfaces.all['INTERFACE3']).to receive(:stop_raw_logging)
+        interfaces.stop_raw_logging
+        tf.unlink
+      end
+
+      it "should stop raw logging on a specified connections by name" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'INTERFACE INTERFACE1 interface.rb'
+        tf.puts 'INTERFACE INTERFACE2 interface.rb'
+        tf.puts 'INTERFACE INTERFACE3 interface.rb'
+        tf.close
+        interfaces = Connections.new(:INTERFACES, CmdTlmServerConfig.new(tf.path))
+        expect(interfaces.all['INTERFACE1']).to_not receive(:stop_raw_logging)
+        expect(interfaces.all['INTERFACE2']).to receive(:stop_raw_logging)
+        expect(interfaces.all['INTERFACE3']).to_not receive(:stop_raw_logging)
+        interfaces.stop_raw_logging('INTERFACE2')
+        tf.unlink
+      end
+
+      it "should raise on an unknown connection" do
+        tf = Tempfile.new('unittest')
+        tf.puts 'INTERFACE INTERFACE1 interface.rb'
+        tf.puts 'INTERFACE INTERFACE2 interface.rb'
+        tf.puts 'INTERFACE INTERFACE3 interface.rb'
+        tf.close
+        interfaces = Connections.new(:INTERFACES, CmdTlmServerConfig.new(tf.path))
+        expect(interfaces.all['INTERFACE1']).to_not receive(:stop_raw_logging)
+        expect(interfaces.all['INTERFACE2']).to_not receive(:stop_raw_logging)
+        expect(interfaces.all['INTERFACE3']).to_not receive(:stop_raw_logging)
+        expect { interfaces.stop_raw_logging('BLAH') }.to raise_error(/Unknown/)
+        tf.unlink
+      end
+    end
   end
 end