corundum 0.1.0 → 0.1.2

data/lib/corundum/gemcutter.rb

@@ -80,19 +80,40 @@ module Corundum
         task :dependencies_available do
           require 'corundum/qa-report'
           checker = Gem::SpecFetcher.new
-          report = QA::Report.new("Gem dependencies")
+          report = QA::Report.new("Gem dependencies[#{File::basename(gemspec.loaded_from)}]")
           qa_rejections << report
           gemspec.runtime_dependencies.each do |dep|
             fulfilling = checker.find_matching(dep,true,false,false)
             if fulfilling.empty?
-              report.add("missing", File::basename(gemspec.loaded_from), nil, dep)
+              report.add("status", dep, nil, "missing")
               report.fail "Dependency unfulfilled remotely"
             else
-              report.add("fulfilled", File::basename(gemspec.loaded_from), nil, dep)
+              report.add("status", dep, nil, "fulfilled")
             end
           end
         end
 
+        task :pinned_dependencies do
+          return unless File::exists?("Gemfile.lock")
+          require 'corundum/qa-report'
+          require 'bundler/lockfile_parser'
+          parser = File::open("Gemfile.lock") do |lockfile|
+            Bundler::LockfileParser.new(lockfile.read)
+          end
+          report = QA::Report.new("Bundler pinned dependencies")
+          qa_rejections << report
+          runtime_deps = gemspec.runtime_dependencies.map(&:name)
+          pinned_dependencies = parser.dependencies.each do |dep|
+            next unless runtime_deps.include? dep.name
+            next if dep.source.nil?
+            next if dep.source.respond_to?(:path) and dep.source.path.to_s == "."
+            report.add("source", dep, nil, dep.source)
+            report.fail("Pinned runtime dependencies:\n" +
+                        "   Specs depended on by the gemspec are pinned and " +
+                        "as a result, spec results are suspect\n")
+          end
+        end
+
         task :is_unpushed do
           checker = Gem::SpecFetcher.new
           dep = Gem::Dependency.new(gemspec.name, "= #{gemspec.version}")
@@ -114,6 +135,7 @@ module Corundum
       task :release => in_namespace(:push)
       task :preflight => in_namespace(:is_unpushed)
       task :qa => in_namespace(:dependencies_available)
+      task :qa => in_namespace(:pinned_dependencies)
     end
   end
 end

data/lib/corundum/rspec-task.rb

@@ -62,7 +62,7 @@ module Corundum
     end
 
     def out_of_date?(stamp)
-      @prerequisites.any? { |n| application[n, @scope].timestamp > stamp}
+      prerequisites.any? { |n| application[n, @scope].timestamp > stamp}
     end
 
     def needed?

data/lib/corundum/rspec.rb

@@ -13,24 +13,25 @@ module Corundum
       :warning => false,
       :verbose => true,
       :ruby_opts => [],
-      :rspec_path => 'rspec',
+      :rspec_program => 'rspec',
       :rspec_opts => [],
       :failure_message => "Spec examples failed.",
       :files_to_run => "spec"
     )
 
+    setting :rspec_path
+
     required_fields :gemspec_path, :qa_finished_path, :file_lists, :file_dependencies
 
     def default_configuration(toolkit)
       super
       self.qa_finished_path = toolkit.finished_files.qa
       self.qa_rejections = toolkit.qa_rejections
+      self.file_dependencies = file_lists.code + file_lists.test + file_lists.project
     end
 
     def resolve_configuration
-      #XXX Que?
-      self.rspec_path = %x"which #{rspec_path}".chomp
-      self.file_dependencies = file_lists.code + file_lists.test + file_lists.project
+      self.rspec_path ||= %x"which #{rspec_program}".chomp
       super
     end
 
@@ -53,7 +54,7 @@ module Corundum
         test_task(:all)
 
         desc "Generate specifications documentation"
-        doc_task(:doc) do |t|
+        docn = doc_task(:doc => file_dependencies) do |t|
           t.rspec_opts = %w{-o /dev/null --failure-exit-code 0 -f h -o} + [t.doc_path]
         end
         file entry_path => :doc
@@ -64,7 +65,7 @@ module Corundum
 
           doc = Nokogiri::parse(File::read(entry_path))
 
-          rejections = QA::Report.new("RSpec")
+          rejections = QA::Report.new("RSpec[#{entry_path}]")
           qa_rejections << rejections
 
           def class_xpath(name)
@@ -73,7 +74,8 @@ module Corundum
 
           fails_path = "//*[" + %w{example failed}.map{|kind| class_xpath(kind)}.join(" and ") + "]"
           doc.xpath(fails_path).each do |node|
-            backtrace_line = node.xpath(".//*[#{class_xpath("backtrace")}]").first.content.split("\n").last
+            backtrace_line =
+              node.xpath(".//*[#{class_xpath("backtrace")}]").first.content.split("\n").first
             file,line,_ = backtrace_line.split(":")
             label = "fail"
             value = node.xpath(".//*[#{class_xpath("message")}]").first.content.gsub(/\s+/m, " ")

data/lib/corundum/simplecov.rb

@@ -79,7 +79,7 @@ module Corundum
         end
 
         @test_lib.doc_task(:report => [:config_exists] + all_files) do |t|
-          t.rspec_opts = %w{-r simplecov} + test_options + t.rspec_opts
+          t.rspec_opts = %w{-r simplecov -f progress} + test_options + t.rspec_opts
         end
         file entry_path => :report
 

metadata

@@ -2,14 +2,14 @@
 name: corundum
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Judson Lester
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-09 00:00:00.000000000 Z
+date: 2013-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   prerelease: false
@@ -415,7 +415,7 @@ licenses:
 post_install_message: 
 rdoc_options:
 - --title
-- corundum-0.1.0 RDoc
+- corundum-0.1.2 RDoc
 require_paths:
 - lib/
 required_ruby_version: !ruby/object:Gem::Requirement
@@ -424,7 +424,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       segments:
       - 0
-      hash: -367106271
+      hash: 2033551
       version: '0'
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement