corgibytes-tax_cloud 0.9.0 → 1.0.0

checksums.yaml

@@ -1,17 +1,17 @@
 ---
 !binary "U0hBMjU2":
   metadata.gz: !binary |-
-    NmU1Y2YyYmFlZjM4NzlkODhkMTBhYTc5MWQxNjg4NTU4YWM2NmE2YjBmZGQ0
-    MzZiMWY1NDI0MDc5ZmYwMDRiNA==
+    MWQ3OGNlMWUzOTZkMGI0NjkwNzI3OTUyNTBmMDZlNjcyMWRmNTc1MjNmMTNm
+    OThkZjhkNjMyOTkyMDM4Nzg2Zg==
   data.tar.gz: !binary |-
-    YzI0NWVlYWM5OGI0ZDJiZDc4ODViMzg1YTM5NmFhNjhhN2M3OTcyZDkwMmE0
-    YzYyMTgyMWI4NTkxN2Y4ODQ5Nw==
+    YjBlYmU1OGMxNGNlZDhjODE0ODM5MTRjZTA0YmU4ZjYyMTVmNjM4YjViYTg5
+    NzMwMzUyZjk4MDJlNWM4YzBjYw==
 SHA512:
   metadata.gz: !binary |-
-    NDY2YTliMmM2OTc5ZWUxN2RlNmUxMmNlYmQ2ZDA2NjViMjBhZWU5NzBmZjBl
-    MmM5YzNjZmQ2ZjMwMTFkNDVhMWJlNzhiMzhmOWJiN2Y0ZTczYzg3OWFiMjBl
-    NTA2Yzc5N2ZkYzE1OWU1Y2JiOWEzOTE4OGQwZmYxMDVmNmVjMTQ=
+    ZDU1MzIxMzMxNGUwMjZiY2JiZTNhNmJiOWMwMmM2MjliYTliYmQ2N2U2MTY4
+    N2UwN2I1ZTRiYWY1MjU0MzI4ZDIzNzQyNjk4ZmE5YjZjYjcyNzIzMjJmNGNk
+    MjQ1ZDkwNjk2N2VlZjM0MzIwNThjZWQ2NGI1YmUxZWMxOWNjYzE=
   data.tar.gz: !binary |-
-    NTNlMzkwYTQyOGVhMDAyNDE5YThlM2MyNGE5NmUxYjg4MmU0OGJjYmIwZWYz
-    ZTFjM2EyNmJjMGQzY2Q4ZTU2OTVjZDg0N2E3OGVhOGRlOTlkOTA2M2IwOWIx
-    MTE0YmZlNmNiNDMxZDc1NTNiNzA3YzRmNTBhZTA4MmI4Zjc3Mjg=
+    NjA1NTA0NmYzMzA3Y2Y5YzUwZDA2NGI2ODdmZjU1ZTBiMDMyNzBlMDUyZmU4
+    ZDczYmE2MTFlMzJmNjhhZDQ1MWM4ZGQwYmNkY2Q2MzgwMDQwMmQ1MzNmZjA2
+    ZjAyMDg2ZWU5Y2NjZDM0NGJlNmEyMDMyNTllYjQ4MDhiZWVlNmE=

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-11-09 23:32:49 -0500 using RuboCop version 0.51.0.
+# on 2019-04-30 18:06:16 +0000 using RuboCop version 0.41.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,36 +12,25 @@ Lint/AmbiguousRegexpLiteral:
     - 'lib/tasks/tax_code_groups.rake'
     - 'lib/tasks/tax_codes.rake'
 
-# Offense count: 2
-Lint/RescueWithoutErrorClass:
-  Exclude:
-    - 'lib/tasks/tax_code_groups.rake'
-    - 'lib/tasks/tax_codes.rake'
-
-# Offense count: 4
+# Offense count: 5
 Metrics/AbcSize:
   Max: 23
 
-# Offense count: 5
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/BlockLength:
-  Max: 39
-
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 261
 
-# Offense count: 236
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 239
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
 # URISchemes: http, https
 Metrics/LineLength:
   Max: 235
 
-# Offense count: 2
+# Offense count: 4
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 14
+  Max: 15
 
 # Offense count: 1
 Style/Documentation:

data/README.md

@@ -1,6 +1,9 @@
 # TaxCloud
 
-[TaxCloud](http://www.taxcloud.com) is a free service to calculate sales tax and generate tax reports. The <tt>tax_cloud</tt> gem allows you to easily integrate with TaxCloud's API.
+[![Gem Version](https://badge.fury.io/rb/corgibytes-tax_cloud.svg)](https://badge.fury.io/rb/corgibytes-tax_cloud)
+[![CircleCI](https://circleci.com/gh/corgibytes/tax_cloud/tree/master.svg?style=shield)](https://circleci.com/gh/corgibytes/tax_cloud/tree/master)
+
+[TaxCloud](http://www.taxcloud.com) is a free service to calculate sales tax and generate tax reports. The Corgibytes TaxCloud [gem](https://rubygems.org/gems/corgibytes-tax_cloud) allows you to easily integrate with TaxCloud's API.
 
 [Forked](https://github.com/drewtempelmeyer/tax_cloud) to add support for running this Gem on Ruby 1.9.3.  See issue [#39](https://github.com/drewtempelmeyer/tax_cloud/issues/39) on the original repo for more details.
 
@@ -13,9 +16,9 @@ Create a [TaxCloud](http://www.taxcloud.com) merchant account at http://www.taxc
 3. Once you have registered for your Shipping Assistant account, you can find your USPS Shipping Assistant UserID in the "About" box, in parentheses to the right of the name of the registered user.
 
 ### Setup
-Add the gem to your Gemfile.
+Add the Corgibytes TaxCloud [gem](https://rubygems.org/gems/corgibytes-tax_cloud) to your Gemfile.
 
-    gem 'tax_cloud'
+    gem 'corgibytes-tax_cloud', require: 'tax_cloud'
 
 Configure your environment. For example, create an initializer in Rails in <tt>config/initializers/tax_cloud.rb</tt>.
 

data/Rakefile

@@ -6,8 +6,6 @@ require 'vcr'
 Rake::TestTask.new(:test) do |test|
   test.libs << 'lib' << 'test'
   test.pattern = 'test/test_*.rb'
-  # REM
-  #test.verbose = false
 end
 
 RDoc::Task.new do |rd|

data/examples/lookup_example.rb

@@ -4,7 +4,7 @@
 # bundle exec ruby lookup_example.rb
 #
 # Make sure you copy the .env.example to .env an update the
-# values in it before running.  I also recommend no running
+# values in it before running.  I also recommend not running
 # this script against a live TaxCloud site.  Run it only against
 # test sites.
 ##
@@ -15,8 +15,7 @@ require 'securerandom'
 require_relative '../lib/tax_cloud'
 
 ##
-# Load the TaxCloud settings from the environment file.\
-#
+# Load the TaxCloud settings from the environment file.
 def load_config
   TaxCloud.configure do |config|
     config.api_login_id = ENV['TAX_CLOUD_LOGIN_ID']
@@ -28,7 +27,6 @@ end
 
 ##
 # Display the current TaxCloud settings.
-#
 def display_config
   TaxCloud.configure do |config|
     puts "API Login ID: #{config.api_login_id}"
@@ -38,6 +36,34 @@ def display_config
   end
 end
 
+##
+# Create a origin address for the lookup example.
+#
+# @return [TaxCloud::Address]
+def create_test_origin
+  TaxCloud::Address.new(
+    address1: '162 East Avenue',
+    address2: 'Third Floor',
+    city: 'Norwalk',
+    state: 'CT',
+    zip5:  '06851'
+  )
+end
+
+##
+# Create a destination address for the lookup example.
+#
+# @return [TaxCloud::Address]
+def create_test_destination
+  TaxCloud::Address.new(
+    address1: '3121 West Government Way',
+    address2: 'Suite 2B',
+    city: 'Seattle',
+    state: 'WA',
+    zip5: '98199'
+  )
+end
+
 ##
 # Create a test transaction with one cart item.
 #
@@ -45,33 +71,22 @@ end
 # the customer and cart IDs.  This prevents collisions with
 # existing customer/carts when running the script multiple times.
 #
+# @return [TaxCloud::Transaction]
 def create_test_transaction
-  origin = TaxCloud::Address.new(
-      :address1 => '162 East Avenue',
-      :address2 => 'Third Floor',
-      :city => 'Norwalk',
-      :state => 'CT',
-      :zip5 => '06851')
-
-  destination = TaxCloud::Address.new(
-      :address1 => '3121 West Government Way',
-      :address2 => 'Suite 2B',
-      :city => 'Seattle',
-      :state => 'WA',
-      :zip5 => '98199')
-
   transaction = TaxCloud::Transaction.new(
-      :customer_id => SecureRandom.uuid,
-      :cart_id => SecureRandom.uuid,
-      :origin => origin,
-      :destination => destination)
+    customer_id: SecureRandom.uuid,
+    cart_id: SecureRandom.uuid,
+    origin: create_test_origin,
+    destination: create_test_destination
+  )
 
   transaction.cart_items << TaxCloud::CartItem.new(
-      :index => 0,
-      :item_id => 'SKU-100',
-      :tic => TaxCloud::TaxCodes::GENERAL,
-      :price => 10.00,
-      :quantity => 1)
+    index: 0,
+    item_id: 'SKU-100',
+    tic: TaxCloud::TaxCodes::GENERAL,
+    price: 10.00,
+    quantity: 1
+  )
 
   transaction
 end
@@ -86,7 +101,6 @@ end
 # - Cart Items
 #
 # @param [TaxCloud::Transaction] transaction
-#
 def display_transaction(transaction)
   puts "Customer ID: #{transaction.customer_id}"
   puts "Cart ID: #{transaction.cart_id}"
@@ -107,7 +121,6 @@ def display_tax(lookup)
   end
 end
 
-
 ##
 # Run an example lookup
 ##
@@ -136,4 +149,4 @@ puts
 puts 'Tax lookup:'
 lookup = transaction.lookup
 display_tax(lookup)
-puts
+puts

data/lib/savon_soap_xml.rb

@@ -2,15 +2,12 @@
 module Savon #:nodoc:
   module SOAP #:nodoc:
     class XML #:nodoc:
-
       private
 
-      old_add_namespaces_to_body = self.instance_method(:add_namespaces_to_body)
-
       def add_namespaces_to_body(hash, path = [input[1].to_s])
         return unless hash
-        return hash if hash.kind_of? Array
-        return hash.to_s unless hash.kind_of? Hash
+        return hash if hash.is_a? Array
+        return hash.to_s unless hash.is_a? Hash
 
         hash.inject({}) do |newhash, (key, value)|
           camelcased_key = Gyoku::XMLKey.create(key)
@@ -18,15 +15,14 @@ module Savon #:nodoc:
 
           if used_namespaces[newpath]
             newhash.merge(
-                "#{used_namespaces[newpath]}:#{camelcased_key}" =>
-                    add_namespaces_to_body(value, types[newpath] ? [types[newpath]] : newpath)
+              "#{used_namespaces[newpath]}:#{camelcased_key}" =>
+                  add_namespaces_to_body(value, types[newpath] ? [types[newpath]] : newpath)
             )
           else
             newhash.merge(key => value)
           end
         end
       end
-
     end
   end
-end
+end

data/lib/tax_cloud/client.rb

@@ -5,13 +5,8 @@ module TaxCloud #:nodoc:
     def initialize
       super TaxCloud::WSDL_URL
 
-      if client_params.key?(:read_timeout)
-        http.read_timeout = client_params[:read_timeout]
-      end
-
-      if client_params.key?(:open_timeout)
-        http.open_timeout = client_params[:open_timeout]
-      end
+      http.read_timeout = client_params[:read_timeout] if client_params.key?(:read_timeout)
+      http.open_timeout = client_params[:open_timeout] if client_params.key?(:open_timeout)
     end
 
     # Make a safe SOAP call.
@@ -22,7 +17,7 @@ module TaxCloud #:nodoc:
     # [body] Body content.
     def request(method, body = {})
       safe do
-        super method, :body => body.merge(auth_params)
+        super method, body: body.merge(auth_params)
       end
     end
 

data/lib/tax_cloud/transaction.rb

@@ -42,9 +42,9 @@ module TaxCloud #:nodoc:
     # Once a purchase has been made and payment has been authorized, this method must be called. A matching Lookup call must have been made before this is called.
     #
     # === Options
-    # * <tt>date_authorized</tt> - The date the transaction was authorized. Default is today.
+    # [date_authorized] - The date the transaction was authorized. Default is today respecting timezone.
     def authorized(options = {})
-      options = { date_authorized: Date.today }.merge(options)
+      options = { date_authorized: Date.current }.merge(options)
 
       request_params = {
         'customerID' => customer_id,
@@ -60,9 +60,9 @@ module TaxCloud #:nodoc:
     # Complete the transaction. The <tt>order_id</tt> passed into <tt>captured</tt> must match the <tt>order_id</tt> that was passed into <tt>authorized</tt>.
     #
     # === Options
-    # [date_captured] The time the transaction was captured. Default is today.
+    # [date_captured] The time the transaction was captured. Default is today respecting timezone.
     def captured(options = {})
-      options = { date_captured: Date.today }.merge(options)
+      options = { date_captured: Date.current }.merge(options)
       request_params = {
         'customerID' => customer_id,
         'cartID' => cart_id,
@@ -77,10 +77,10 @@ module TaxCloud #:nodoc:
     # Combines the <tt>authorized</tt> and <tt>captured</tt> methods into a single call
     #
     # === Options
-    # [date_authorized] The date the transaction was authorized. Default is today.
-    # [date_captured] - The date the transaction was captured. Default is today.
+    # [date_authorized] The date the transaction was authorized. Default is today respecting timezone.
+    # [date_captured] - The date the transaction was captured. Default is today respecting timezone.
     def authorized_with_capture(options = {})
-      options = { date_authorized: Date.today, date_captured: Date.today }.merge(options)
+      options = { date_authorized: Date.current, date_captured: Date.current }.merge(options)
       request_params = {
         'customerID' => customer_id,
         'cartID' => cart_id,
@@ -96,9 +96,9 @@ module TaxCloud #:nodoc:
     # Marks any included cart items as returned.
     #
     # === Options
-    # [returned_date] The date the return occured. Default is today.
+    # [returned_date] The date the return occured. Default is today respecting timezone.
     def returned(options = {})
-      options = { returned_date: Date.today }.merge(options)
+      options = { returned_date: Date.current }.merge(options)
       request_params = {
         'orderID' => order_id,
         'cartItems' => { 'CartItem' => cart_items.map(&:to_hash) },

data/lib/tax_cloud/version.rb

@@ -1,4 +1,4 @@
 module TaxCloud #:nodoc:
   # The version of the <tt>tax_cloud</tt> gem.
-  VERSION = '0.9.0'.freeze
+  VERSION = '1.0.0'.freeze
 end

data/test/helper.rb

@@ -6,7 +6,6 @@ require 'json'
 # for Circle CI builds.
 require 'minitest/ci'
 
-
 Savon.configure do |config|
   config.log = false
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: corgibytes-tax_cloud
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Corgibytes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-07 00:00:00.000000000 Z
+date: 2019-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport