coradoc 2.0.3 → 2.0.5

data/coradoc-adoc/spec/coradoc/asciidoc/model/element_classification_spec.rb

@@ -0,0 +1,146 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Element classification' do
+  describe 'block_level?' do
+    it 'Section is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Section.new.block_level?).to be(true)
+    end
+
+    it 'Paragraph is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Paragraph.new.block_level?).to be(true)
+    end
+
+    it 'Admonition is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Admonition.new.block_level?).to be(true)
+    end
+
+    it 'CommentBlock is block-level' do
+      expect(Coradoc::AsciiDoc::Model::CommentBlock.new.block_level?).to be(true)
+    end
+
+    it 'Table is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Table.new.block_level?).to be(true)
+    end
+
+    it 'Block::Core is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Block::Core.new.block_level?).to be(true)
+    end
+
+    it 'Block::Listing is block-level (inherits from Core)' do
+      expect(Coradoc::AsciiDoc::Model::Block::Listing.new.block_level?).to be(true)
+    end
+
+    it 'Block::Quote is block-level (inherits from Core)' do
+      expect(Coradoc::AsciiDoc::Model::Block::Quote.new.block_level?).to be(true)
+    end
+
+    it 'List::Ordered is block-level' do
+      expect(Coradoc::AsciiDoc::Model::List::Ordered.new.block_level?).to be(true)
+    end
+
+    it 'List::Unordered is block-level' do
+      expect(Coradoc::AsciiDoc::Model::List::Unordered.new.block_level?).to be(true)
+    end
+
+    it 'BlockImage is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Image::BlockImage.new.block_level?).to be(true)
+    end
+  end
+
+  describe 'inline?' do
+    it 'Inline::Bold is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Bold.new.inline?).to be(true)
+    end
+
+    it 'Inline::Italic is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Italic.new.inline?).to be(true)
+    end
+
+    it 'Inline::Monospace is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Monospace.new.inline?).to be(true)
+    end
+
+    it 'Inline::Highlight is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Highlight.new.inline?).to be(true)
+    end
+
+    it 'Inline::Superscript is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Superscript.new.inline?).to be(true)
+    end
+
+    it 'Inline::Subscript is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Subscript.new.inline?).to be(true)
+    end
+
+    it 'Inline::Link is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Link.new.inline?).to be(true)
+    end
+
+    it 'Inline::Anchor is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Anchor.new.inline?).to be(true)
+    end
+
+    it 'TextElement is inline' do
+      expect(Coradoc::AsciiDoc::Model::TextElement.new.inline?).to be(true)
+    end
+
+    it 'InlineImage is inline' do
+      expect(Coradoc::AsciiDoc::Model::Image::InlineImage.new.inline?).to be(true)
+    end
+
+    it 'HardLineBreak returns :hardbreak' do
+      expect(Coradoc::AsciiDoc::Model::Inline::HardLineBreak.new.inline?).to eq(:hardbreak)
+    end
+  end
+
+  describe 'non-block, non-inline elements' do
+    it 'Title is neither block nor inline' do
+      title = Coradoc::AsciiDoc::Model::Title.new
+      expect(title.block_level?).to be(false)
+      expect(title.inline?).to be(false)
+    end
+
+    it 'List::Item is neither block nor inline' do
+      item = Coradoc::AsciiDoc::Model::List::Item.new
+      expect(item.block_level?).to be(false)
+      expect(item.inline?).to be(false)
+    end
+
+    it 'AttributeList is neither block nor inline' do
+      attrs = Coradoc::AsciiDoc::Model::AttributeList.new
+      expect(attrs.block_level?).to be(false)
+      expect(attrs.inline?).to be(false)
+    end
+  end
+
+  describe 'SpacingStrategy integration' do
+    let(:strategy) { Coradoc::AsciiDoc::Serializer::SpacingStrategy }
+
+    it 'uses polymorphic block_level? for spacing' do
+      para = Coradoc::AsciiDoc::Model::Paragraph.new
+      section = Coradoc::AsciiDoc::Model::Section.new
+
+      expect(strategy.block_level?(para)).to be(true)
+      expect(strategy.block_level?(section)).to be(true)
+    end
+
+    it 'uses polymorphic inline? for spacing' do
+      bold = Coradoc::AsciiDoc::Model::Inline::Bold.new
+      text = Coradoc::AsciiDoc::Model::TextElement.new
+
+      expect(strategy.inline_level?(bold)).to be(true)
+      expect(strategy.inline_level?(text)).to be(true)
+    end
+
+    it 'returns false for nil' do
+      expect(strategy.block_level?(nil)).to be(false)
+      expect(strategy.inline_level?(nil)).to be(false)
+    end
+
+    it 'treats strings as inline' do
+      expect(strategy.inline_level?('text')).to be(true)
+    end
+  end
+end

data/coradoc-adoc/spec/coradoc/asciidoc/round_trip_spec.rb

@@ -2,7 +2,6 @@
 
 require 'spec_helper'
 
-# rubocop:disable RSpec/DescribeClass
 RSpec.describe 'Round-Trip Conversion' do
   # Helper to parse, transform to CoreModel, transform back, and serialize
   def round_trip(adoc_text)

data/coradoc-adoc/spec/coradoc/developer_experience_spec.rb

@@ -2,7 +2,6 @@
 
 require 'spec_helper'
 
-# rubocop:disable RSpec/DescribeClass - This is a feature spec for the API facade
 RSpec.describe 'Developer Experience API' do
   # Load coradoc core and asciidoc
 

data/coradoc-html/spec/input/converters/converters_spec.rb

@@ -447,7 +447,7 @@ RSpec.describe Coradoc::Input::Html::Converters do
       result = converter_module.process_coradoc(node, {})
 
       # Extract text content from the block (use children for mixed content)
-      content = result.respond_to?(:children) && result.children.any? ? result.children : result.content
+      content = result.is_a?(Coradoc::CoreModel::Base) && result.children&.any? ? result.children : result.content
       text = extract_text_from_content(content)
       expect(text).to include('Simple text')
     end
@@ -459,7 +459,7 @@ RSpec.describe Coradoc::Input::Html::Converters do
 
       result = converter_module.process_coradoc(node, {})
 
-      content = result.respond_to?(:children) && result.children.any? ? result.children : result.content
+      content = result.is_a?(Coradoc::CoreModel::Base) && result.children&.any? ? result.children : result.content
       text = extract_text_from_content(content)
       expect(text).to include('Before')
       expect(text).to include('Bold')
@@ -477,15 +477,13 @@ RSpec.describe Coradoc::Input::Html::Converters do
       when Coradoc::CoreModel::InlineElement
         # Extract from both content and nested_elements
         text_parts = [extract_text_from_content(c.content)]
-        text_parts << extract_text_from_content(c.nested_elements) if c.respond_to?(:nested_elements) && c.nested_elements
+        text_parts << extract_text_from_content(c.nested_elements) if c.nested_elements
         text_parts.join
       when Coradoc::CoreModel::Base
-        if c.respond_to?(:children) && c.children.is_a?(Array)
+        if c.children.is_a?(Array)
           extract_text_from_content(c.children)
-        elsif c.respond_to?(:content)
-          extract_text_from_content(c.content)
         else
-          ''
+          extract_text_from_content(c.content)
         end
       when Array
         extract_text_from_content(c)

data/lib/coradoc/core_model/structural_element.rb

@@ -54,6 +54,10 @@ module Coradoc
       #   @return [Array<Base>, nil] child elements (sections, blocks, etc.)
       attribute :children, Base, collection: true
 
+      # @!attribute attributes
+      #   @return [Hash] document-level attributes (key-value pairs)
+      attribute :attributes, :hash, default: -> { {} }
+
       # Heading level with sensible default
       #
       # @return [Integer] level, defaulting to 1 when unset

data/lib/coradoc/document_manipulator.rb

@@ -132,7 +132,9 @@ module Coradoc
                                   .compact
       end
 
-      return nil if element.is_a?(CoreModel::StructuralElement) && element.section? && !element.document? && !section_matches?(element, level: level, title: title)
+      return nil if element.is_a?(CoreModel::StructuralElement) && element.section? && !element.document? && !section_matches?(
+        element, level: level, title: title
+      )
 
       element
     end

data/lib/coradoc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Coradoc
-  VERSION = '2.0.3'
+  VERSION = '2.0.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coradoc
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.5
 platform: ruby
 authors:
 - Ribose Inc.
@@ -288,6 +288,7 @@ files:
 - coradoc-adoc/lib/coradoc/util.rb
 - coradoc-adoc/lib/coradoc/util/asciidoc.rb
 - coradoc-adoc/spec/asciidoc/asciidoc_spec.rb
+- coradoc-adoc/spec/coradoc/asciidoc/integration_pipeline_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/list_continuation_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/admonition_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/attribute_list_spec.rb
@@ -300,6 +301,7 @@ files:
 - coradoc-adoc/spec/coradoc/asciidoc/model/break_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/document_attributes_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/document_spec.rb
+- coradoc-adoc/spec/coradoc/asciidoc/model/element_classification_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/header_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/image_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/inline/extended_spec.rb