coradoc-adoc 2.0.31 → 2.0.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22eb5a515f97c8954148e99ef280dd4bb8ac3bed03d59d745291dc3d7ac302c2
-  data.tar.gz: 0435ded18a2f7895426d1de9aba45c5c3ccaeea442c287fb1f5cd6d14581b117
+  metadata.gz: 70861dce3318bead6c8153bfa44090dc2da49a1f9889cb517dcdb559a4eaeb9c
+  data.tar.gz: 94b397c634354792bb99678f71d3fc15221cb1f7feb42894d514e96c644f47f1
 SHA512:
-  metadata.gz: cc35eb17f93b7c78fc2f935cf71ef18d76af08eb36a52ab7040d90e735c72a4d1f990339fc414803ccbf767d0b57bf636be79d76940fa8a091e52bcd37091544
-  data.tar.gz: 8c93968c63d400dfb86d0855c6bb1a2ebc6bbe200a85b07da5d2861771baeacf2beb11cd811c136e912fae302d0003c8aa822f12c73ef2ae5d127ced9caea829
+  metadata.gz: f2283331458aaae5a07cd9f135aa3e8e2a6b09f9e7df12336233dd43313c2dc4775e988ef49ef23428a131019fb00c3feaaf0127b9f7521e222fc460c12b5c83
+  data.tar.gz: 7c0cc22f6919a661e4d17adf687611ae7c2194bd4bf3dd7184ba073bc44e7e38ab716e20764affab27d97b7536f4caac02151ad170dde5c531871588ea7f643f

data/lib/coradoc/asciidoc/parser/list.rb

@@ -17,21 +17,56 @@ module Coradoc
           line_start? >> str("+\n")
         end
 
+        # Single source of truth for "what can appear between consecutive
+        # list items without ending the list". Asciidoctor treats blank
+        # lines and `//` comment lines as non-terminating inside every
+        # list type. Comments are consumed without capture — they are
+        # structurally invisible inside a list (no CommentLine node is
+        # emitted). Tag directives (`// tag::`) keep their separate
+        # handling via `comment_line_content`'s `tag.absent?` guard.
+        def list_item_separator
+          (comment_line_content | empty_line).repeat(0)
+        end
+
+        # Single source of truth for "what block can attach to a list
+        # item via a `+` continuation marker". The `+` line is consumed
+        # by {#list_item_attached}; this rule expresses only the block
+        # that follows. Definition lists are intentionally excluded —
+        # `+` before a continuing dlist run is handled inside
+        # `dlist_item` as a continuation marker so the run nests by
+        # delimiter depth (see there).
+        def list_attached_block
+          admonition_line | unordered_list(1) | ordered_list(1) | paragraph | block
+        end
+
+        # Shared `+`-continuation attachment for every list item type
+        # (ulist, olist, dlist). A `+` line directly followed by an
+        # attached block becomes a child of the current item. The
+        # `list_continuation.present?` lookahead prevents greedy
+        # over-match when the `+` actually belongs to surrounding
+        # context.
+        def list_item_attached
+          (list_continuation.present? >>
+             list_continuation >>
+             list_attached_block
+          ).repeat(0).as(:attached)
+        end
+
         def ordered_list(nesting_level = 1)
           attrs = (attribute_list >> newline).maybe
           r = olist_item(nesting_level)
-          attrs >> (empty_line.repeat(0) >> r).repeat(1).as(:ordered)
+          attrs >> (list_item_separator >> r).repeat(1).as(:ordered)
         end
 
         def unordered_list(nesting_level = 1)
           attrs = (attribute_list >> newline).maybe
           r = ulist_item(nesting_level)
-          attrs >> (empty_line.repeat(0) >> r).repeat(1).as(:unordered)
+          attrs >> (list_item_separator >> r).repeat(1).as(:unordered)
         end
 
         def definition_list(_delimiter = nil)
           (attribute_list >> newline).maybe >>
-            dlist_item.repeat(1).as(:definition_list) >>
+            (list_item_separator >> dlist_item).repeat(1).as(:definition_list) >>
             dlist_item.absent?
         end
 
@@ -56,11 +91,7 @@ module Coradoc
                  (list_body_text_line >>
                   list_item_continuation_lines).as(:lines)
 
-          att = (list_continuation.present? >>
-                  list_continuation >>
-                  (admonition_line | paragraph | block)
-                ).repeat(0).as(:attached)
-          item >>= att.maybe
+          item >>= list_item_attached.maybe
 
           if nesting_level <= 4
             item >>= (list_marker(nesting_level + 1).present? >>
@@ -108,11 +139,7 @@ module Coradoc
                  (list_body_text_line >>
                   list_item_continuation_lines).as(:lines)
 
-          att = (list_continuation.present? >>
-                  list_continuation >>
-                  (admonition_line | paragraph | block)
-                ).repeat(0).as(:attached)
-          item >>= att.maybe
+          item >>= list_item_attached.maybe
 
           if nesting_level <= 4
             item >>= (list_marker(nesting_level + 1).present? >>
@@ -273,11 +300,14 @@ module Coradoc
 
           item = multi_line | inline
 
-          attached = (list_continuation.present? >>
-                       list_continuation >>
-                       (admonition_line | paragraph | block)
-                     ).repeat(0).as(:attached)
-          item >>= attached.maybe
+          item >>= list_item_attached.maybe
+
+          # A `+` line directly before a continuing dlist run is a
+          # list-continuation marker (asciidoctor semantics): consume it
+          # so the following items stay in the current list and nest by
+          # delimiter depth. Without this, the `+` dangles and the run
+          # splits off as a detached sibling list.
+          item >>= (list_continuation >> dlist_item.present?).repeat(0)
 
           item.as(:definition_list_item)
         end

data/lib/coradoc/asciidoc/parser/text.rb

@@ -121,6 +121,26 @@ module Coradoc
           ).as(:block_image)
         end
 
+        # Non-capturing form of {#comment_line}. Same shape (a `//`
+        # comment line, excluding tag directives like `// tag::`), but
+        # consumes without producing an AST node.
+        #
+        # Used by list rules to absorb inter-item comments so the list
+        # continues across them — asciidoctor treats `//` comments inside
+        # any list as structurally invisible. Uses raw character matchers
+        # instead of `text` so no inner captures leak into the consuming
+        # rule's AST.
+        #
+        # Single source of truth for the comment-line shape: any future
+        # adjustment to the `//`-line grammar happens here and both the
+        # capturing and non-capturing forms stay in sync.
+        def comment_line_content
+          tag.absent? >>
+            str('//') >> str('/').absent? >>
+            space? >>
+            match('[^\n]').repeat(0) >> line_ending
+        end
+
         def comment_line
           tag.absent? >>
             (str('//') >> str('/').absent? >>

data/lib/coradoc/asciidoc/reference_materializers/navigation.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module Coradoc
+  module AsciiDoc
+    module ReferenceMaterializers
+      # Render a navigation edge as a first-class CrossReferenceElement
+      # — the model-driven xref node the AsciiDoc serializer already
+      # knows how to emit (never a raw macro string). Materializing for
+      # AsciiDoc fills in the visible text from the authored label or
+      # the resolved target's title.
+      class Navigation < Coradoc::Reference::Materializer::Base
+        class << self
+          def kind
+            :navigation
+          end
+
+          def presentation
+            :any
+          end
+
+          def format
+            :asciidoc
+          end
+        end
+
+        def materialize(edge:, result:, **)
+          text = display_text(edge, result)
+          Coradoc::CoreModel::CrossReferenceElement.new(
+            target: xref_target(edge.address),
+            content: text,
+            children: [
+              Coradoc::CoreModel::TextElement.new(content: text)
+            ]
+          )
+        end
+
+        private
+
+        def xref_target(address)
+          [address.target, address.fragment].compact.join('#')
+        end
+
+        def display_text(edge, result)
+          return edge.label if edge.label && !edge.label.empty?
+          return result.target.title if result.is_a?(Coradoc::Reference::Result::Resolved) && result.target&.title
+
+          edge.address.to_s
+        end
+      end
+    end
+  end
+end

data/lib/coradoc/asciidoc/reference_materializers.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Coradoc
+  module AsciiDoc
+    # Materializers rendering resolved reference Edges into
+    # AsciiDoc-shaped CoreModel nodes. They live in the format gem
+    # (not coradoc core) so format knowledge stays at the spoke of the
+    # hub-and-spoke architecture; registration is a load-time side
+    # effect via the Materializer registry's global extension point.
+    module ReferenceMaterializers
+      autoload :Navigation, "#{__dir__}/reference_materializers/navigation"
+    end
+  end
+end
+
+Coradoc::Reference::Materializer::Registry.register_global(
+  Coradoc::AsciiDoc::ReferenceMaterializers::Navigation
+)

data/lib/coradoc/asciidoc/transform/element_transformers/list_transformer.rb

@@ -114,14 +114,17 @@ module Coradoc
 
             def transform_list_item(item)
               content_val = item.content
-              children = ToCoreModel.transform_inline_content(content_val)
+              inline_children = ToCoreModel.transform_inline_content(content_val)
+              attached_children = Array(item.attached).filter_map do |block|
+                ToCoreModel.transform(block)
+              end
 
               li = Coradoc::CoreModel::ListItem.new(
                 content: ToCoreModel.extract_text_content(content_val),
                 marker: item.marker,
                 source_line: item.source_line
               )
-              li.children = children
+              li.children = inline_children + attached_children
 
               nested_lists = extract_nested_lists(item)
               li.nested_list = nested_lists.first if nested_lists.size == 1

data/lib/coradoc/asciidoc/version.rb

@@ -2,6 +2,6 @@
 
 module Coradoc
   module AsciiDoc
-    VERSION = '2.0.31'
+    VERSION = '2.0.33'
   end
 end

data/lib/coradoc/asciidoc.rb

@@ -94,6 +94,12 @@ module Coradoc
           document.to_adoc
         end
       end
+
+      # AsciiDoc round-trips include:: directives natively — graph-mode
+      # documents serialize losslessly, no hydration required.
+      def preserves_unresolved_includes?
+        true
+      end
     end
 
     # Backward-compatible aliases for model classes
@@ -152,3 +158,7 @@ Coradoc.register_format(:asciidoc, Coradoc::AsciiDoc,
 # Backward-compatibility: Coradoc::Model is now Coradoc::AsciiDoc::Model
 # This alias is provided for legacy code that hasn't been updated
 Coradoc::Model = Coradoc::AsciiDoc::Model unless defined?(Coradoc::Model)
+
+# Reference materializers for format: :asciidoc. Required (not autoloaded)
+# because registration is a load-time side effect, like register_format.
+require 'coradoc/asciidoc/reference_materializers'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coradoc-adoc
 version: !ruby/object:Gem::Version
-  version: 2.0.31
+  version: 2.0.33
 platform: ruby
 authors:
 - Ribose Inc.
@@ -235,6 +235,8 @@ files:
 - lib/coradoc/asciidoc/parser/table.rb
 - lib/coradoc/asciidoc/parser/term.rb
 - lib/coradoc/asciidoc/parser/text.rb
+- lib/coradoc/asciidoc/reference_materializers.rb
+- lib/coradoc/asciidoc/reference_materializers/navigation.rb
 - lib/coradoc/asciidoc/serializer.rb
 - lib/coradoc/asciidoc/serializer/adoc_serializer.rb
 - lib/coradoc/asciidoc/serializer/element_registry.rb