copyable 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6c394690b8922c1b1d88ff6665fb2b4e640d8459
-  data.tar.gz: c7f7852188d8a62166b93063d85c77b8a1b1f31a
+  metadata.gz: 0ae89109e012130ce8cc01fa12b08ada0b3e1d09
+  data.tar.gz: a62a5cd9c1573d6e0da5f4a2d0d05b703f2af36b
 SHA512:
-  metadata.gz: 5f5f9657c9506dd9583327da181245782944a57a54ced61627c87b3794aa851ba87e5a656aaeb391170c1b0cf31f5442a15398baa2931d2f7f2c918b88626f4d
-  data.tar.gz: e7dc40c25c3b728d940c648b6a528cc9ba2b740d85b12307b30e40dc3135bed51387b6c0f005036ba8279886b8d1ff6b9efec652a58b7b9b105e0c97979d8dc8
+  metadata.gz: 25b7247a6471abb6114632dfa7818cb9bfd1ccc51d1ca89a9a6a60fce3057fbb55432135f67445a2ef5bc9590db975616235275e20c16ca6f339bf1d91383fc1
+  data.tar.gz: 1341e8a9c2101a8980af25a9b3eade8c2cc321448465cd7398a3e4df802a96cfd6bc27cf69d0e49beed8ba27e6d91ab825c9be46a34d90e659cb8bc5cdfc38eb

data/README.md

@@ -121,16 +121,9 @@ The advice must be one of the following:
 
 ## Callbacks
 
-It depends on the situation as to whether you would want a particular callback to be fired when a model is copied.  Since the logic of callbacks is situational, Copyable makes the decision to completely disable all callbacks and observers for the duration of the `create_copy!` method.  The only exception are callbacks and observers related to validation.
-
-To make it easier to reason about the code, and for the sake of being obvious, every copyable declaration *must* include a declaration called `disable_all_callbacks_and_observers_except_validate`.  This declaration itself does not do anything; it exists as documentation.
-
-    copyable do
-      disable_all_callbacks_and_observers_except_validate
-      ...
-    end
-
-
+It depends on the situation as to whether you would want a particular callback to be fired when a model is copied.  Since the logic of callbacks is situational, Copyable makes the decision to bypass callbacks
+when saving the copied models by using raw SQL insert statements during the copy. It will check
+validations unless `skip_validations` is passed to `create_copy`.
 
 ## The After Copy Declaration
 
@@ -267,4 +260,4 @@ So the recommended approach is to use `after_copy` to tweak the columns of the c
 
 ## About
 
-Copyable was developed at [District Management Group](https://dmgroupK12.com).
+Copyable was developed at [District Management Group](https://dmgroupK12.com).

data/copyable.gemspec

@@ -18,11 +18,11 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activerecord", "~>4.1.0"
+  spec.add_dependency "activerecord", "~>4.2"
 
   spec.add_development_dependency "database_cleaner", "~> 1.4.0"
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "sqlite3", "~> 1.3.6"
 end

data/lib/copyable/declarations/associations.rb

@@ -11,7 +11,7 @@ module Copyable
           @skip_associations = skip_associations
           @global_override = global_override
           association_list.each do |assoc_name, advice|
-            association = original_model.class.reflections[assoc_name.to_sym]
+            association = original_model.class.reflections[assoc_name.to_s]
             check_advice(association, advice, original_model)
             unless advice == :do_not_copy || skip_associations.include?(assoc_name.to_sym)
               copy_association(association, original_model, new_model)
@@ -28,14 +28,14 @@ module Copyable
             message << "has unrecognized advice '#{advice}'."
             raise AssociationError.new(message)
           end
-          if association.macro == :has_and_belongs_to_many && advice == :copy
+          if association.is_a?(ActiveRecord::Reflection::HasAndBelongsToManyReflection) && advice == :copy
             message = "Error in copyable:associations of "
             message << "#{original_model.class.name}: the association '#{association.name}' "
             message << "only supports the :copy_only_habtm_join_records advice, not the :copy advice, "
             message << "because it is a has_and_belongs_to_many association."
             raise AssociationError.new(message)
           end
-          if association.macro != :has_and_belongs_to_many && advice == :copy_only_habtm_join_records
+          if !association.is_a?(ActiveRecord::Reflection::HasAndBelongsToManyReflection) && advice == :copy_only_habtm_join_records
             message = "Error in copyable:associations of "
             message << "#{original_model.class.name}: the association '#{association.name}' "
             message << "only supports the :copy advice, not the :copy_only_habtm_join_records advice, "
@@ -45,15 +45,14 @@ module Copyable
         end
 
         def copy_association(association, original_model, new_model)
-          case association.macro
-          when :has_many
+          if association.is_a?(ActiveRecord::Reflection::HasManyReflection)
             copy_has_many(association, original_model, new_model)
-          when :has_one
+          elsif association.is_a?(ActiveRecord::Reflection::HasOneReflection)
             copy_has_one(association, original_model, new_model)
-          when :has_and_belongs_to_many
+          elsif association.is_a?(ActiveRecord::Reflection::HasAndBelongsToManyReflection)
             copy_habtm(association, original_model, new_model)
           else
-            raise "Unsupported association #{association.macro}" # should never happen, since we filter out belongs_to
+            raise "Unsupported association #{association.class}" # should never happen, since we filter out belongs_to
           end
         end
 

data/lib/copyable/model_hooks.rb

@@ -16,30 +16,33 @@ module Copyable
 
     def self.disable_all_callbacks(klass)
       klass.class_eval do
-        # Don't do it if it was already done
-        return if self.method_defined? :__disabled__run_callbacks
-
-        alias_method :__disabled__run_callbacks, :run_callbacks
-        # We are violently duck-punching ActiveRecord because ActiveRecord
-        # gives us no way to turn off callbacks.  My apologies to the
-        # squeamish.
-        def run_callbacks(kind, *args, &block)
-          if block_given?
-            yield
-          else
-            true
-          end
+        return if self.method_defined? :old_save! # Don't do this more than once
+
+        @all_callbacks_disabled = true
+        class << self
+          attr_reader :all_callbacks_disabled
+        end
+
+        alias_method :old_save!, :save!
+
+        # Hold my beer while we bypass all the Rails callbacks
+        # in favor of some raw SQL
+        def save!
+          Copyable::Saver.save!(self)
         end
       end
     end
 
     def self.reenable_all_callbacks(klass)
       klass.class_eval do
-        # Only do it if the disabled callbacks are defined
-        return unless self.method_defined? :__disabled__run_callbacks
+        return unless self.method_defined? :old_save! # Don't do this more than once
+        @all_callbacks_disabled = false
+        class << self
+          attr_reader :all_callbacks_disabled
+        end
 
-        alias_method :run_callbacks, :__disabled__run_callbacks
-        remove_method :__disabled__run_callbacks
+        alias_method :save!, :old_save!
+        remove_method :old_save!
       end
     end
 

data/lib/copyable/saver.rb

@@ -1,19 +1,27 @@
 module Copyable
   class Saver
 
+    def self.direct_sql_insert!(new_model)
+      new_model.send(:_create_record) # bypass all callbacks and validations
+    end
+
+    def self.direct_sql_update!(new_model)
+      new_model.send(:_update_record) # bypass all callbacks and validations
+    end
+
     # this is the algorithm for saving the new record
-    def self.save!(new_model, skip_validations)
-      unless skip_validations
-        ModelHooks.reenable!(new_model.class) # we must re-enable or validation does not work
-        if !new_model.valid?(:create)
-          ModelHooks.disable!(new_model.class)
-          raise(ActiveRecord::RecordInvalid.new(new_model))
-        else
-          ModelHooks.disable!(new_model.class)
-        end
+    def self.save!(new_model, skip_validations=false)
+      unless skip_validations || new_model.valid?(:create)
+        raise(ActiveRecord::RecordInvalid.new(new_model))
       end
-      new_model.save!
-    end
 
+      if new_model.class.all_callbacks_disabled && new_model.id.nil?
+        self.direct_sql_insert!(new_model)
+      elsif new_model.class.all_callbacks_disabled
+        self.direct_sql_update!(new_model)
+      else
+        new_model.save!
+      end
+    end
   end
 end

data/lib/copyable/syntax_checking/association_checker.rb

@@ -10,7 +10,8 @@ module Copyable
     def expected_entries
       all_associations = model_class.reflect_on_all_associations
       required_associations = all_associations.select do |ass|
-        (ass.macro != :belongs_to) && ass.options[:through].blank?
+        !ass.is_a?(ActiveRecord::Reflection::BelongsToReflection) &&
+        !ass.is_a?(ActiveRecord::Reflection::ThroughReflection)
       end
       required_associations.map(&:name).map(&:to_s)
     end

data/lib/copyable/version.rb

@@ -1,3 +1,3 @@
 module Copyable
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/tasks/copyable.rake

@@ -39,7 +39,8 @@ task :copyable => :environment do
 
   all_associations = model_class.reflect_on_all_associations
   required_associations = all_associations.select do |ass|
-    (ass.macro != :belongs_to) && ass.options[:through].blank?
+    !ass.is_a?(ActiveRecord::Reflection::BelongsToReflection) &&
+    !ass.is_a?(ActiveRecord::Reflection::ThroughReflection)    
   end
   associations = required_associations.map(&:name).map(&:to_s)
   max_length = associations.map(&:length).max

data/spec/helper/test_tables.rb

@@ -11,14 +11,14 @@ module Copyable
 
           create_table :copyable_albums, force: true do |t|
             t.string :name, null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_amenities, force: true do |t|
             t.string   :name
             t.integer  :copyable_vehicle_id
             t.integer  :copyable_owner_id
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_addresses, force: true do |t|
@@ -27,30 +27,30 @@ module Copyable
             t.string   :city,                     null: false
             t.string   :state,                    null: false
             t.integer  :copyable_pet_profile_id,  null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_cars, force: true do |t|
             t.string   :make,   null: false
             t.string   :model,  null: false
             t.integer  :year,   null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_coins, force: true do |t|
             t.string  :kind
             t.integer :year
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_owners, force: true do |t|
             t.string :name, null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_pet_foods, force: true do |t|
             t.string :name, null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_pet_foods_pets, force: true, id: false do |t|
@@ -62,31 +62,31 @@ module Copyable
             t.string   :description,     null: false
             t.string   :nickname
             t.integer  :copyable_pet_id, null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_pet_sitters, force: true do |t|
             t.string  :name, null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_pet_sitting_patronages, force: true do |t|
             t.integer  :copyable_pet_id,        null: false
             t.integer  :copyable_pet_sitter_id, null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_pet_tags, force: true do |t|
             t.string   :registered_name, null: false
             t.integer  :copyable_pet_id, null: false
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_pets, force: true do |t|
             t.string  :name,        null: false
             t.string  :kind,        null: false
             t.integer :birth_year
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_pictures, force: true do |t|
@@ -94,36 +94,36 @@ module Copyable
             t.integer :imageable_id
             t.string  :imageable_type
             t.integer :picture_album_id
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_products, force: true do |t|
             t.string  :name
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_toys, force: true do |t|
             t.string   :name
             t.string   :kind
             t.integer  :copyable_pet_id
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_trees, force: true do |t|
             t.string  :kind
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_vehicles, force: true do |t|
             t.string  :name
             t.integer :copyable_owner_id
-            t.timestamps
+            t.timestamps null: false
           end
 
           create_table :copyable_warranties, force: true do |t|
             t.string   :name
             t.integer  :copyable_amenity_id
-            t.timestamps
+            t.timestamps null: false
           end
 
         end

data/spec/model_hooks_spec.rb

@@ -9,85 +9,31 @@ describe Copyable::ModelHooks do
       before(:each) do
         Copyable::ModelHooks.disable!(CopyableTree)
       end
+
       after(:each) do
         Copyable::ModelHooks.reenable!(CopyableTree)
       end
-      it 'should prevent callbacks from executing' do
-        expect {
-          CopyableTree.create!(kind: 'magnolia')
-        }.to_not raise_error
+
+      it 'defines an instance variable on the class' do
+        expect(CopyableTree.all_callbacks_disabled).to eq(true)
       end
+
       it 'should not prevent model actions from executing' do
         expect(CopyableTree.count).to eq(0)
-        CopyableTree.create!(kind: 'magnolia')
-        expect(CopyableTree.count).to eq(1)
       end
     end
 
     describe '.reenable!' do
-      it 'should allow callbacks to execute again' do
-        Copyable::ModelHooks.disable!(CopyableTree)
+      it 'defines an instance variable on the class' do
         Copyable::ModelHooks.reenable!(CopyableTree)
-        expect {
-          CopyableTree.create!(kind: 'magnolia')
-        }.to raise_error(RuntimeError, "callback2 called")
+        expect(CopyableTree.all_callbacks_disabled).to eq(false)
       end
-    end
-  end
-
-  context 'validations' do
 
-    # Note: the relevant model and observer class is defined in helper/test_models.rb
-
-    describe '.disable!' do
-      before(:each) do
-        Copyable::ModelHooks.disable!(CopyableCoin)
-      end
-      after(:each) do
-        Copyable::ModelHooks.reenable!(CopyableCoin)
-      end
-      it 'should prevent validations from executing' do
-        expect {
-          CopyableCoin.create!(year: -10)
-        }.to_not raise_error
-      end
-      it 'should not prevent model actions from executing' do
-        expect(CopyableCoin.count).to eq(0)
-        CopyableCoin.create!(year: -10)
-        expect(CopyableCoin.count).to eq(1)
-      end
-    end
-
-    describe '.reenable!' do
-      it 'should allow validations to execute again' do
-        Copyable::ModelHooks.disable!(CopyableCoin)
-        Copyable::ModelHooks.reenable!(CopyableCoin)
+      it 'should allow callbacks to execute again' do
         expect {
-          CopyableCoin.create!(year: -10)
-        }.to raise_error(ActiveRecord::RecordInvalid)
+          CopyableTree.create!(kind: 'magnolia')
+        }.to raise_error(RuntimeError, "callback2 called")
       end
     end
   end
-
-  describe 'nested disables and enables' do
-    it 'should allow callbacks to execute again' do
-      Copyable::ModelHooks.disable!(CopyableTree)
-      expect { CopyableTree.create!(kind: 'magnolia') }.to_not raise_error
-
-      Copyable::ModelHooks.disable!(CopyableCoin)
-      expect { CopyableCoin.create!(year: -10) }.to_not raise_error
-
-      Copyable::ModelHooks.disable!(CopyableTree)
-      expect { CopyableTree.create!(kind: 'magnolia') }.to_not raise_error
-
-      Copyable::ModelHooks.reenable!(CopyableCoin)
-      expect { CopyableCoin.create!(year: -10) }.to raise_error(ActiveRecord::RecordInvalid)
-
-      Copyable::ModelHooks.reenable!(CopyableTree)
-      expect { CopyableTree.create!(kind: 'magnolia') }.to raise_error(RuntimeError)
-
-      Copyable::ModelHooks.reenable!(CopyableTree)
-      expect { CopyableTree.create!(kind: 'magnolia') }.to raise_error(RuntimeError)
-    end
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: copyable
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Wyatt Greene
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-05 00:00:00.000000000 Z
+date: 2019-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -19,14 +19,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
@@ -87,16 +87,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
 description: Copyable makes it easy to copy ActiveRecord models.
 email:
 - dchan@dmgroupK12.com
@@ -178,7 +178,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: ActiveRecord copier