copyable 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f42c56201c71a8dae13510b60503300a1f8bfd27
-  data.tar.gz: c4efc57da93c3b9f0a3ff7134dc00bbb84fbba2d
+  metadata.gz: 4e51f2b73f6b3f642d8b9174567c245c2f875b6a
+  data.tar.gz: c56647390d32496da7fbe0f971d9e86d2299b070
 SHA512:
-  metadata.gz: 69a4aa712cf34f9cba8f598dee4b970bf482ab9b6b71558b14fd5fd0c9a9dfcf7dcb2644543db4ec21c71cc118af0bde080eda5b6f15ab78ba1baecc5d3d5f93
-  data.tar.gz: a64545cc78dea5befe38066e86cdda5a6486bfd5115d77fcda21810802674ce8e7f40a61e9c8637bef8efcc0aa8dcab0d6a041e617b2df40bd1fa96cf9c661bc
+  metadata.gz: 236d9f5a60f236f49d99b2a8f47586ea2678bbd1c2a97c86d2e0dd7eaabf4dafe90065f8e09b9fd32b6f8c9c75188e4ee27c4977c9e3ffd198a85124ed1c13c5
+  data.tar.gz: b59f9f190720c3dbc37646795017d52953078f7bf8d7a2726fef9aa891e29c67579e911d021029b9b2def2f9898f4a5f05b163644bbba2e7fcdea506b50bcb6d

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2016 Dennis Chan
+Copyright (c) 2017 District Management Group
 
 MIT License
 

data/README.md

@@ -267,4 +267,4 @@ So the recommended approach is to use `after_copy` to tweak the columns of the c
 
 ## About
 
-Copyable was developed at [the District Management Council](http://dmcouncil.org).
+Copyable was developed at [District Management Group](https://dmgroupK12.com).

data/lib/copyable/model_hooks.rb

@@ -16,6 +16,9 @@ module Copyable
 
     def self.disable_all_callbacks(klass)
       klass.class_eval do
+        # Don't do it if it was already done
+        return if self.method_defined? :__disabled__run_callbacks
+
         alias_method :__disabled__run_callbacks, :run_callbacks
         # We are violently duck-punching ActiveRecord because ActiveRecord
         # gives us no way to turn off callbacks.  My apologies to the
@@ -32,7 +35,11 @@ module Copyable
 
     def self.reenable_all_callbacks(klass)
       klass.class_eval do
+        # Only do it if the disabled callbacks are defined
+        return unless self.method_defined? :__disabled__run_callbacks
+
         alias_method :run_callbacks, :__disabled__run_callbacks
+        remove_method :__disabled__run_callbacks
       end
     end
 

data/lib/copyable/version.rb

@@ -1,3 +1,3 @@
 module Copyable
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/helper/test_models.rb

@@ -12,18 +12,6 @@ end
 
 
 
-#*******************************************************************************
-#  For testing observers.
-#
-
-class CopyableCar < ActiveRecord::Base
-  validates :make, presence: true
-  validates :model, presence: true
-  validates :year, presence: true
-end
-
-
-
 #*******************************************************************************
 #  For testing callbacks.
 #

data/spec/model_hooks_spec.rb

@@ -7,24 +7,19 @@ describe Copyable::ModelHooks do
 
     describe '.disable!' do
       before(:each) do
-        puts "Dennis before!"
         Copyable::ModelHooks.disable!(CopyableTree)
       end
       after(:each) do
-        puts "Dennis after"
         Copyable::ModelHooks.reenable!(CopyableTree)
       end
       it 'should prevent callbacks from executing' do
-        puts "Dennis 1"
         expect {
-          tree = CopyableTree.create!(kind: 'magnolia')
+          CopyableTree.create!(kind: 'magnolia')
         }.to_not raise_error
-        puts "Dennis 2"
       end
       it 'should not prevent model actions from executing' do
-        puts "Dennis 4"
         expect(CopyableTree.count).to eq(0)
-        tree = CopyableTree.create!(kind: 'magnolia')
+        CopyableTree.create!(kind: 'magnolia')
         expect(CopyableTree.count).to eq(1)
       end
     end
@@ -34,33 +29,65 @@ describe Copyable::ModelHooks do
         Copyable::ModelHooks.disable!(CopyableTree)
         Copyable::ModelHooks.reenable!(CopyableTree)
         expect {
-          tree = CopyableTree.create!(kind: 'magnolia')
+          CopyableTree.create!(kind: 'magnolia')
         }.to raise_error(RuntimeError, "callback2 called")
       end
     end
   end
 
-  context 'observers' do
+  context 'validations' do
 
     # Note: the relevant model and observer class is defined in helper/test_models.rb
 
     describe '.disable!' do
       before(:each) do
-        Copyable::ModelHooks.disable!(CopyableCar)
+        Copyable::ModelHooks.disable!(CopyableCoin)
       end
       after(:each) do
-        Copyable::ModelHooks.reenable!(CopyableCar)
+        Copyable::ModelHooks.reenable!(CopyableCoin)
       end
-      it 'should prevent observers from executing' do
+      it 'should prevent validations from executing' do
         expect {
-          car = CopyableCar.create!(make: 'Ferrari', model: 'California', year: 2009)
+          CopyableCoin.create!(year: -10)
         }.to_not raise_error
       end
       it 'should not prevent model actions from executing' do
-        expect(CopyableCar.count).to eq(0)
-        car = CopyableCar.create!(make: 'Ferrari', model: 'California', year: 2009)
-        expect(CopyableCar.count).to eq(1)
+        expect(CopyableCoin.count).to eq(0)
+        CopyableCoin.create!(year: -10)
+        expect(CopyableCoin.count).to eq(1)
       end
     end
+
+    describe '.reenable!' do
+      it 'should allow validations to execute again' do
+        Copyable::ModelHooks.disable!(CopyableCoin)
+        Copyable::ModelHooks.reenable!(CopyableCoin)
+        expect {
+          CopyableCoin.create!(year: -10)
+        }.to raise_error(ActiveRecord::RecordInvalid)
+      end
+    end
+  end
+
+  describe 'nested disables and enables' do
+    it 'should allow callbacks to execute again' do
+      Copyable::ModelHooks.disable!(CopyableTree)
+      expect { CopyableTree.create!(kind: 'magnolia') }.to_not raise_error
+
+      Copyable::ModelHooks.disable!(CopyableCoin)
+      expect { CopyableCoin.create!(year: -10) }.to_not raise_error
+
+      Copyable::ModelHooks.disable!(CopyableTree)
+      expect { CopyableTree.create!(kind: 'magnolia') }.to_not raise_error
+
+      Copyable::ModelHooks.reenable!(CopyableCoin)
+      expect { CopyableCoin.create!(year: -10) }.to raise_error(ActiveRecord::RecordInvalid)
+
+      Copyable::ModelHooks.reenable!(CopyableTree)
+      expect { CopyableTree.create!(kind: 'magnolia') }.to raise_error(RuntimeError)
+
+      Copyable::ModelHooks.reenable!(CopyableTree)
+      expect { CopyableTree.create!(kind: 'magnolia') }.to raise_error(RuntimeError)
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: copyable
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Wyatt Greene
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-21 00:00:00.000000000 Z
+date: 2018-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -174,7 +174,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: ActiveRecord copier