cool.io 1.10.1 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 84ec70f3ced722b0919a7e3348a6670e9d474343f8b831d9e942222a1edd0314
-  data.tar.gz: b60d4526c1c799119c43db2ae0e0f3debb85cba85086a6c65868477398a88a66
+  metadata.gz: 429eba65d9a49cece39e0c5315f02a72619581d58b2a40c5a3b4b54f5ed9450a
+  data.tar.gz: f2239fbc67d6a98f27c15e0a4acfe7136850eb2132b810cb60b10861902e81c6
 SHA512:
-  metadata.gz: 924f47393f2ae881e1afb914fa16bb67089840e8ef1c3599502919c5fa53263c06e0f6303d263ae376d8bff33da00ad9577b6549e3fc5128ead104a4f383e9d2
-  data.tar.gz: 8929ec98ce4161507309610d762c5f22f7fe4b756c361902fb0e37afa69ee2d8adc788383866ec7c9d270b80f27a99e902c2ef5128804e3b9e86c2b46c6e0535
+  metadata.gz: eeb064688621041ac6e3a68de8a7d4da6e873564bcbb7eb791cef2892801b67ea38d9ba7f7206dc0b541f2bc5ff63103779c090f8fb113f1d86d6902f3fc98dc
+  data.tar.gz: 95a1f57361191466510f22d0252a34c6b487af717bcc6209472c8f93e2da99b3607aa329cd912da2afd22aadb5df90b277ea0b54a17773b03c347e431fb7f309

data/.github/workflows/test.yaml

@@ -33,7 +33,7 @@ jobs:
             experimental: true
     
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{matrix.ruby}}

data/.github/workflows/valgrind.yaml

@@ -27,7 +27,7 @@ jobs:
             experimental: true
     
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{matrix.ruby}}

data/.gitignore

@@ -19,9 +19,6 @@ rdoc
 pkg
 tmp
 
-## RUBINIUS
-*.rbc
-
 ## PROJECT::SPECIFIC
 conftest.dSYM
 

data/CHANGES.md

@@ -1,3 +1,84 @@
+1.11.0
+------
+
+* Use kqueue notifications for StatWatcher on macOS, so that changes are reported promptly while polling remains as a backstop (#130)
+* Fix Watcher#attached? returning 0 instead of true (#132)
+* Fix the DSL examples and remove the HttpClient example (#133)
+* Add bug tracker, changelog and source code links to the gem metadata and require MFA for gem owners (#138)
+* Require Ruby 3.2 or later (#139, #140)
+
+1.10.1
+------
+
+* Fix listen failing with EISCONN on Windows after a Loop with a StatWatcher is freed (#128)
+
+1.10.0
+------
+
+* Use ReadDirectoryChangesW notifications for StatWatcher on Windows, so that changes are reported promptly while polling remains as a backstop (#109, #113)
+* Fix quadratic polling, stop, notification and registration costs with many StatWatchers on Windows (#120, #121)
+* Fix needless re-registration of Windows StatWatchers after the current directory changes (#122)
+* Fix Windows StatWatcher missing changes in a directory recreated under the same name (#123)
+* Speed up Windows StatWatcher name lookups (#124)
+* Fix heap overflow in Buffer#read and Buffer#to_str on 64-bit Windows (#111)
+* Fix memory leak when Buffer#clear is called repeatedly (#117)
+* Fix DNS resolver accepting an A record shorter than its RDLENGTH (#107)
+* Fix StatInfo fields truncated to 32 bits (#114)
+* Fix StatInfo#blksize and StatInfo#blocks always being nil (#115)
+* Fix IO and timer watcher reattachment (#112)
+* Fix NameError when creating a Loop with skip_environment (#118)
+* Fix SEGV when a Loop is created with no usable backend. It raises RuntimeError instead (#119)
+* Fix Buffer#read documentation to match its argument handling (#116)
+* Document that Loop.new raises RuntimeError when no backend is usable (#125)
+
+1.9.5
+-----
+
+* Fix 32-bit byte accounting in Buffer (#105)
+* Fix FD_SETSIZE mismatch silently dropping watchers on Windows (#103)
+* Fix dangling path pointer in StatWatcher under GC compaction (#98)
+* Validate Buffer#read_frame argument to prevent SEGV (#97)
+* Ignore IPv6 nameservers to prevent Socket::ResolutionError (#94)
+* Fix Buffer.default_node_size documentation to match DEFAULT_NODE_SIZE (#99)
+
+1.9.4
+-----
+
+* Fix memory leak when detaching watchers (#91)
+
+1.9.3
+-----
+
+* Fix freeing of Buffer memory allocated with xmalloc (#84)
+
+1.9.2
+-----
+
+* Fix TypeError when processing a detached watcher (#88)
+
+1.9.1
+-----
+
+* Use typed data APIs for the extension objects (#85)
+* Fix DNSResolver mutating the nameservers array given by the caller (commit 489ec55)
+
+1.9.0
+-----
+
+* Rename IO::Buffer to Coolio::Buffer and build it into the cool.io extension, since Ruby 3.1 added its own IO::Buffer (#82)
+
+1.8.1
+-----
+
+* Fix build error on Windows caused by incompatible pointer types (#81)
+
+1.8.0
+-----
+
+* Support Ruby 3.3 (#79)
+* Fix build failure with compilers that reject incompatible function pointer types (#78)
+* Fix fallback to the local loopback address when the hosts file has no localhost entry (#73)
+
 1.7.1
 -----
 

data/Rakefile

@@ -4,18 +4,13 @@ require 'rake/clean'
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new
 
-RSpec::Core::RakeTask.new(:rcov) do |task|
-  task.rcov = true
-end
-
 task :default => %w(compile spec)
 
 require 'rdoc/task'
+require_relative 'lib/cool.io/version'
 Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
-
   rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "cool.io #{version}"
+  rdoc.title = "cool.io #{Coolio::VERSION}"
   rdoc.rdoc_files.include('README*')
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
@@ -24,28 +19,8 @@ require 'rake/extensiontask'
 
 spec = Gem::Specification.load("cool.io.gemspec")
 
-def configure_cross_compilation(ext)
-  unless RUBY_PLATFORM =~ /mswin|mingw/
-    ext.cross_compile = true
-    ext.cross_platform = ['x86-mingw32', 'x64-mingw32']
-  end
-end
-
 Rake::ExtensionTask.new('cool.io_ext', spec) do |ext|
   ext.ext_dir = 'ext/cool.io'
-  configure_cross_compilation(ext)
-end
-
-# Note that this rake-compiler-dock rake task dose not support bundle install(1) --path option.
-# Please use bundle install instead when you execute this rake task.
-namespace :build do
-  desc 'Build gems for Windows per rake-compiler-dock'
-  task :windows do
-    require 'rake_compiler_dock'
-    RakeCompilerDock.sh <<-CROSS
-      bundle && bundle exec rake cross native gem RUBY_CC_VERSION='3.0.0:2.7.0:2.6.0:2.5.0:2.4.0'
-    CROSS
-  end
 end
 
 if RUBY_PLATFORM.include?('linux')
@@ -57,5 +32,5 @@ if RUBY_PLATFORM.include?('linux')
   end
 end
 
-CLEAN.include "**/*.rbc", "**/*.o", "**/*.so", "**/*.bundle"
-CLEAN.exclude "vendor/**/*.rbc", "vendor/**/*.o", "vendor/**/*.so", "vendor/**/*.bundle"
+CLEAN.include "**/*.o", "**/*.so", "**/*.bundle"
+CLEAN.exclude "vendor/**/*.o", "vendor/**/*.so", "vendor/**/*.bundle"

data/cool.io.gemspec

@@ -6,6 +6,12 @@ Gem::Specification.new do |s|
   s.authors     = ["Tony Arcieri", "Masahiro Nakagawa"]
   s.email       = ["tony.arcieri@gmail.com", "repeatedly@gmail.com"]
   s.homepage    = "https://github.com/socketry/cool.io"
+  s.metadata    = {
+    "bug_tracker_uri" => "https://github.com/socketry/cool.io/issues",
+    "changelog_uri" => "https://github.com/socketry/cool.io/blob/main/CHANGES.md",
+    "source_code_uri" => "https://github.com/socketry/cool.io.git",
+    "rubygems_mfa_required" => "true",
+  }
   s.summary     = "A cool framework for doing high performance I/O in Ruby"
   s.description = "Cool.io provides a high performance event framework for Ruby which uses the libev C library"
   s.extensions = ["ext/cool.io/extconf.rb"]
@@ -15,9 +21,9 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
+  s.required_ruby_version = ">= 3.2"
 
   s.add_development_dependency "rake-compiler", "~> 1.0"
-  s.add_development_dependency "rake-compiler-dock", "~> 1.0"
   s.add_development_dependency "rspec", ">= 2.13.0"
   s.add_development_dependency "rdoc", ">= 3.6.0"
 end

data/examples/dslified_echo_client.rb

@@ -2,6 +2,7 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
 require 'rubygems'
 require 'cool.io'
+require 'cool.io/dsl'
 
 ADDR = '127.0.0.1'
 PORT = 4321

data/examples/dslified_echo_server.rb

@@ -2,6 +2,7 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
 require 'rubygems'
 require 'cool.io'
+require 'cool.io/dsl'
 
 ADDR = '127.0.0.1'
 PORT = 4321

data/examples/echo_client.rb

@@ -17,16 +17,16 @@ class ClientConnection < Cool.io::TCPSocket
   end
 
   def on_read(data)
-    print "got #{data}"
+    puts "got #{data}"
     close
   end
 
   def on_resolve_failed
-    print "DNS resolve failed"
+    puts "DNS resolve failed"
   end
 
   def on_connect_failed
-    print "connect failed, meaning our connection to their port was rejected"
+    puts "connect failed, meaning our connection to their port was rejected"
   end
 
 end

data/ext/cool.io/buffer.c

@@ -20,13 +20,6 @@
 /* 1 GiB maximum buffer size */
 #define MAX_BUFFER_SIZE 0x40000000
 
-/* Macro for retrieving the file descriptor from an FPTR */
-#if !HAVE_RB_IO_T_FD
-#define FPTR_TO_FD(fptr) fileno(fptr->f)
-#else
-#define FPTR_TO_FD(fptr) fptr->fd
-#endif
-
 /* Default number of bytes in each node's buffer.  Should be >= MTU */
 #define DEFAULT_NODE_SIZE 16384
 static size_t default_node_size = DEFAULT_NODE_SIZE;
@@ -414,22 +407,14 @@ Coolio_Buffer_read_from(VALUE self, VALUE io)
 {
     struct buffer  *buf;
     ssize_t         ret;
-#if defined(HAVE_RB_IO_T) || defined(HAVE_RB_IO_DESCRIPTOR)
     rb_io_t        *fptr;
-#else
-    OpenFile       *fptr;
-#endif
 
     TypedData_Get_Struct(self, struct buffer, &Coolio_Buffer_type, buf);
     io = rb_convert_type(io, T_FILE, "IO", "to_io");
     GetOpenFile(io, fptr);
     rb_io_set_nonblock(fptr);
 
-#ifdef HAVE_RB_IO_DESCRIPTOR
     ret = buffer_read_from(buf, rb_io_descriptor(io));
-#else
-    ret = buffer_read_from(buf, FPTR_TO_FD(fptr));
-#endif
     return ret == -1 ? Qnil : SSIZET2NUM(ret);
 }
 
@@ -445,22 +430,14 @@ static VALUE
 Coolio_Buffer_write_to(VALUE self, VALUE io)
 {
     struct buffer  *buf;
-#if defined(HAVE_RB_IO_T) || defined(HAVE_RB_IO_DESCRIPTOR)
     rb_io_t        *fptr;
-#else
-    OpenFile       *fptr;
-#endif
 
     TypedData_Get_Struct(self, struct buffer, &Coolio_Buffer_type, buf);
     io = rb_convert_type(io, T_FILE, "IO", "to_io");
     GetOpenFile(io, fptr);
     rb_io_set_nonblock(fptr);
 
-#ifdef HAVE_RB_IO_DESCRIPTOR
     return SSIZET2NUM(buffer_write_to(buf, rb_io_descriptor(io)));
-#else
-    return SSIZET2NUM(buffer_write_to(buf, FPTR_TO_FD(fptr)));
-#endif
 }
 
 /*

data/ext/cool.io/cool.io.h

@@ -8,23 +8,7 @@
 #define COOLIO_H
 
 #include "ruby.h"
-#if defined(HAVE_RUBY_IO_H)
 #include "ruby/io.h"
-#else
-#include "rubyio.h"
-#endif
-
-#ifdef GetReadFile
-#define FPTR_TO_FD(fptr) (fileno(GetReadFile(fptr)))
-#else
-
-#if !HAVE_RB_IO_T || (RUBY_VERSION_MAJOR == 1 && RUBY_VERSION_MINOR == 8)
-#define FPTR_TO_FD(fptr) fileno(fptr->f)
-#else
-#define FPTR_TO_FD(fptr) fptr->fd
-#endif
-
-#endif
 
 struct Coolio_Event
 {

data/ext/cool.io/extconf.rb

@@ -1,29 +1,7 @@
 require 'mkmf'
 
-libs = []
-
-$defs << "-DRUBY_VERSION_CODE=#{RUBY_VERSION.gsub(/\D/, '')}"
-
-have_func('rb_io_descriptor')
-have_func('rb_thread_blocking_region')
-have_func('rb_thread_call_without_gvl')
-have_func('rb_thread_alone')
-have_func('rb_str_set_len')
 have_library('rt', 'clock_gettime')
 
-have_library("c", "main")
-if have_macro("HAVE_RB_IO_T", "ruby/io.h")
-  have_struct_member("rb_io_t", "fd", "ruby/io.h")
-end
-
-if have_header('ruby/io.h')
-  $defs << '-DHAVE_RUBY_IO_H'
-end
-
-if have_header('ruby/thread.h')
-  $defs << '-DHAVE_RUBY_THREAD_H'
-end
-
 if have_header('sys/select.h')
   $defs << '-DEV_USE_SELECT'
 end
@@ -61,8 +39,6 @@ if RUBY_PLATFORM =~ /solaris/
   $defs << '-D__EXTENSIONS__'
 end
 
-$LIBS << ' ' << libs.join(' ')
-
 dir_config('cool.io_ext')
 create_makefile('cool.io_ext')
 

data/ext/cool.io/iowatcher.c

@@ -5,11 +5,7 @@
  */
 
 #include "ruby.h"
-#if defined(HAVE_RUBY_IO_H)
 #include "ruby/io.h"
-#else
-#include "rubyio.h"
-#endif
 
 #include "ev_wrap.h"
 
@@ -86,17 +82,7 @@ static VALUE Coolio_IOWatcher_initialize(int argc, VALUE *argv, VALUE self)
   io = rb_convert_type(io, T_FILE, "IO", "to_io");
 
   watcher_data->dispatch_callback = Coolio_IOWatcher_dispatch_callback;
-#ifdef HAVE_RB_IO_DESCRIPTOR
   ev_io_init(&watcher_data->event_types.ev_io, Coolio_IOWatcher_libev_callback, rb_io_descriptor(io), events);
-#else
-#if defined(HAVE_RB_IO_T)
-  rb_io_t *fptr;
-#else
-  OpenFile *fptr;
-#endif
-  GetOpenFile(io, fptr);
-  ev_io_init(&watcher_data->event_types.ev_io, Coolio_IOWatcher_libev_callback, FPTR_TO_FD(fptr), events);
-#endif
   watcher_data->event_types.ev_io.data = (void *)self;
 
   return Qnil;

data/ext/cool.io/stat_watcher.c

@@ -33,9 +33,8 @@ static void Coolio_StatWatcher_libev_callback(struct ev_loop *ev_loop, struct ev
 static void Coolio_StatWatcher_dispatch_callback(VALUE self, int revents);
 
 /*
- * Coolio::StatWatcher lets you create either one-shot or periodic stats which
- * run within Coolio's event loop.  It's useful for creating timeouts or
- * events which fire periodically.
+ * Coolio::StatWatcher monitors a path and calls on_change when its stat
+ * attributes change.
  **/
 void Init_coolio_stat_watcher()
 {
@@ -77,10 +76,18 @@ void Init_coolio_stat_watcher()
  * specified how often in seconds the path should be polled for changes.
  * Setting interval to zero uses an "automatic" value (typically around 5
  * seconds) which optimizes performance.  Otherwise, values less than
- * 0.1 are not particularly meaningful.  Where available (on Linux and Windows),
- * high performance file monitoring interfaces are used.  On Windows, polling
- * remains necessary because notification timing is not guaranteed.  An attached
- * Windows watcher may also prevent renaming an ancestor directory until detached.
+ * 0.1 are not particularly meaningful.  Where available (on Linux, macOS and
+ * Windows), high performance file monitoring interfaces are used.  On macOS
+ * and Windows, polling remains enabled for changes native notifications may
+ * miss.  An attached Windows watcher may also prevent renaming an ancestor
+ * directory until detached.
+ *
+ * On macOS, each registered watcher uses one file descriptor for the path or
+ * an ancestor directory, plus one shared kqueue descriptor per loop. If the
+ * descriptor limit is reached, watchers fall back to polling.
+ *
+ * On macOS, construct the loop with :fork_check => true when continuing to
+ * use attached watchers in a forked child.
  */
 static VALUE Coolio_StatWatcher_initialize(int argc, VALUE *argv, VALUE self)
 {
@@ -135,7 +142,6 @@ static VALUE Coolio_StatWatcher_initialize(int argc, VALUE *argv, VALUE self)
  */
 static VALUE Coolio_StatWatcher_attach(VALUE self, VALUE loop)
 {
-  ev_tstamp interval, timeout;
   struct Coolio_Loop *loop_data;
   struct Coolio_Watcher *watcher_data;
 

data/ext/cool.io/watcher.c

@@ -271,7 +271,7 @@ static VALUE Coolio_Watcher_evloop(VALUE self)
  */
 static VALUE Coolio_Watcher_attached(VALUE self)
 {
-  return Coolio_Watcher_evloop(self) != Qnil;
+  return Coolio_Watcher_evloop(self) != Qnil ? Qtrue : Qfalse;
 }
 
 /**

data/ext/libev/ev.c

@@ -39,9 +39,7 @@
 
 /* ########## COOLIO PATCHERY HO! ########## */
 #include "ruby.h"
-#if defined(HAVE_RUBY_THREAD_H)
 #include "ruby/thread.h"
-#endif
 /* ######################################## */
 
 /* this big block deduces configuration from config.h */
@@ -342,6 +340,14 @@
 # endif
 #endif
 
+#ifndef EV_USE_KQUEUE_STAT
+# if EV_USE_KQUEUE && EV_STAT_ENABLE && defined __APPLE__ && defined __MACH__
+#  define EV_USE_KQUEUE_STAT 1
+# else
+#  define EV_USE_KQUEUE_STAT 0
+# endif
+#endif
+
 #ifndef EV_PID_HASHSIZE
 # define EV_PID_HASHSIZE EV_FEATURE_DATA ? 16 : 1
 #endif
@@ -1863,6 +1869,10 @@ typedef struct
 #if defined(_WIN32) && EV_STAT_ENABLE && EV_ASYNC_ENABLE
 static void win32_fs_destroy (EV_P);
 #endif
+#if EV_USE_KQUEUE_STAT
+static void kq_stat_fork (EV_P);
+static void kq_stat_destroy (EV_P);
+#endif
 
 #if EV_FEATURE_API
 # define EV_RELEASE_CB if (expect_false (release_cb)) release_cb (EV_A)
@@ -2937,6 +2947,10 @@ loop_init (EV_P_ unsigned int flags) EV_THROW
       win32_fs          = 0;
       win32_fs_disabled = (flags & EVFLAG_NOINOTIFY) != 0;
 #endif
+#if EV_USE_KQUEUE_STAT
+      kq_stat          = 0;
+      kq_stat_disabled = (flags & EVFLAG_NOINOTIFY) != 0;
+#endif
 #if EV_USE_INOTIFY
       fs_fd              = flags & EVFLAG_NOINOTIFY ? -1 : -2;
 #endif
@@ -3008,6 +3022,9 @@ ev_loop_destroy (EV_P)
 #if defined(_WIN32) && EV_STAT_ENABLE && EV_ASYNC_ENABLE
   win32_fs_destroy (EV_A);
 #endif
+#if EV_USE_KQUEUE_STAT
+  kq_stat_destroy (EV_A);
+#endif
 
   if (ev_is_active (&pipe_w))
     {
@@ -3110,6 +3127,9 @@ loop_fork (EV_P)
 #if EV_USE_INOTIFY
   infy_fork (EV_A);
 #endif
+#if EV_USE_KQUEUE_STAT
+  kq_stat_fork (EV_A);
+#endif
 
 #if EV_SIGNAL_ENABLE || EV_ASYNC_ENABLE
   if (ev_is_active (&pipe_w) && postfork != 2)
@@ -3602,7 +3622,6 @@ time_update (EV_P_ ev_tstamp max_block)
 }
 
 /* ########## COOLIO PATCHERY HO! ########## */
-#if defined(HAVE_RB_THREAD_BLOCKING_REGION) || defined(HAVE_RB_THREAD_CALL_WITHOUT_GVL)
 struct ev_poll_args {
   struct ev_loop *loop;
   ev_tstamp waittime;
@@ -3616,16 +3635,13 @@ VALUE ev_backend_poll(void *ptr)
   backend_poll (EV_A_ args->waittime);
   return Qnil;
 }
-#endif
 /* ######################################## */
 
 int
 ev_run (EV_P_ int flags)
 {
 /* ########## COOLIO PATCHERY HO! ########## */
-#if defined(HAVE_RB_THREAD_BLOCKING_REGION) || defined(HAVE_RB_THREAD_CALL_WITHOUT_GVL)
     struct ev_poll_args poll_args;
-#endif
 /* ######################################## */
 
 #if EV_FEATURE_API
@@ -3786,25 +3802,9 @@ rb_thread_unsafe_dangerous_crazy_blocking_region_end(...);
 #######################################################################
 */
 
-/*
-  simulate to rb_thread_call_without_gvl using rb_theread_blocking_region.
-  https://github.com/brianmario/mysql2/blob/master/ext/mysql2/client.h#L8
-*/
-
-#ifndef HAVE_RB_THREAD_CALL_WITHOUT_GVL
-#ifdef HAVE_RB_THREAD_BLOCKING_REGION
-#define rb_thread_call_without_gvl(func, data1, ubf, data2) \
-  rb_thread_blocking_region((rb_blocking_function_t *)func, data1, ubf, data2)
-#endif
-#endif
-
-#if defined(HAVE_RB_THREAD_BLOCKING_REGION) || defined(HAVE_RB_THREAD_CALL_WITHOUT_GVL)
         poll_args.loop = loop;
         poll_args.waittime = waittime;
         rb_thread_call_without_gvl((void *)ev_backend_poll, (void *)&poll_args, RUBY_UBF_IO, 0);
-#else
-         backend_poll (EV_A_ waittime);
-#endif
 /*
 ############################# END PATCHERY ############################
 */
@@ -4366,6 +4366,9 @@ noinline static void stat_timer_cb (EV_P_ ev_timer *w_, int revents);
 #if defined(_WIN32) && EV_ASYNC_ENABLE
 # include "ev_win32_stat.c"
 #endif
+#if EV_USE_KQUEUE_STAT
+# include "ev_kqueue_stat.c"
+#endif
 
 #if EV_USE_INOTIFY
 
@@ -4648,6 +4651,10 @@ stat_timer_cb (EV_P_ ev_timer *w_, int revents)
     win32_fs_add (EV_A_ w, 1); /* retry missing parents or failed directory handles */
 #endif
 
+#if EV_USE_KQUEUE_STAT
+  kq_stat_poll (EV_A_ w, revents);
+#endif
+
   ev_statdata prev = w->attr;
   ev_stat_stat (EV_A_ w);
 
@@ -4685,6 +4692,10 @@ stat_timer_cb (EV_P_ ev_timer *w_, int revents)
           }
       #endif
 
+#if EV_USE_KQUEUE_STAT
+      kq_stat_refresh (EV_A_ w);
+#endif
+
       ev_feed_event (EV_A_ w, EV_STAT);
     }
 }
@@ -4721,6 +4732,9 @@ ev_stat_start (EV_P_ ev_stat *w) EV_THROW
   win32_fs_add (EV_A_ w, 0);
   stat_timer_cb (EV_A_ &w->timer, 0); /* close the stat/registration race */
 #endif
+#if EV_USE_KQUEUE_STAT
+  kq_stat_start (EV_A_ w);
+#endif
 
   EV_FREQUENT_CHECK;
 }
@@ -4737,6 +4751,9 @@ ev_stat_stop (EV_P_ ev_stat *w) EV_THROW
 #if defined(_WIN32) && EV_ASYNC_ENABLE
   win32_fs_del (EV_A_ w);
 #endif
+#if EV_USE_KQUEUE_STAT
+  kq_stat_del (EV_A_ w);
+#endif
 
 #if EV_USE_INOTIFY
   infy_del (EV_A_ w);