cookstyle 7.30.1 → 7.30.3

Sign up to get free protection for your applications and to get access to all the features.
Files changed (253) hide show
  1. checksums.yaml +4 -4
  2. data/config/upstream.yml +3 -0
  3. data/lib/cookstyle/version.rb +2 -2
  4. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
  5. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +1 -1
  6. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
  7. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
  8. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
  9. data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +1 -1
  10. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
  11. data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +1 -1
  12. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
  13. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +1 -1
  14. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
  15. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
  16. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
  17. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
  18. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
  19. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
  20. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
  21. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
  22. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
  23. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
  24. data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +1 -1
  25. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  26. data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
  27. data/lib/rubocop/cop/chef/correctness/node_normal.rb +1 -1
  28. data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +1 -1
  29. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  30. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
  31. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
  32. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  33. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +1 -1
  34. data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +1 -1
  35. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
  36. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
  37. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
  38. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +1 -1
  39. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
  40. data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
  41. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
  42. data/lib/rubocop/cop/chef/correctness/tmp_path.rb +1 -1
  43. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
  44. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
  45. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
  46. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +2 -2
  47. data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +4 -4
  48. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +3 -3
  49. data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
  50. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +1 -1
  51. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
  52. data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
  53. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  54. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
  55. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +1 -1
  56. data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +1 -1
  57. data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
  58. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  59. data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +1 -1
  60. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
  61. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
  62. data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
  63. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +3 -3
  64. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
  65. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
  66. data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +1 -1
  67. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  68. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +1 -1
  69. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
  70. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  71. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  72. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
  73. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  74. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
  75. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
  76. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
  77. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +1 -1
  78. data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +1 -1
  79. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +1 -1
  80. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
  81. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
  82. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
  83. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
  84. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
  85. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +1 -1
  86. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
  87. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
  88. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
  89. data/lib/rubocop/cop/chef/deprecation/node_set.rb +1 -1
  90. data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +1 -1
  91. data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
  92. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
  93. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
  94. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
  95. data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +1 -1
  96. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
  97. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
  98. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
  99. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
  100. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
  101. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
  102. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
  103. data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +1 -1
  104. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
  105. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +1 -1
  106. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +3 -3
  107. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
  108. data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +1 -1
  109. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  110. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +1 -1
  111. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
  112. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
  113. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
  114. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
  115. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
  116. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
  117. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
  118. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  119. data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
  120. data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +2 -2
  121. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  122. data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
  123. data/lib/rubocop/cop/chef/effortless/node_environment.rb +2 -2
  124. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +2 -2
  125. data/lib/rubocop/cop/chef/effortless/node_roles.rb +2 -2
  126. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  127. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  128. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
  129. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
  130. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +1 -1
  131. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -2
  132. data/lib/rubocop/cop/chef/modernize/build_essential.rb +1 -1
  133. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
  134. data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +1 -1
  135. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +2 -2
  136. data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +1 -1
  137. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
  138. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +1 -1
  139. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +1 -1
  140. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
  141. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +1 -1
  142. data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +1 -1
  143. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
  144. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  145. data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
  146. data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +1 -1
  147. data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +1 -1
  148. data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +1 -1
  149. data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +1 -1
  150. data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +1 -1
  151. data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +1 -1
  152. data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +1 -1
  153. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
  154. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
  155. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  156. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +3 -3
  157. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -2
  158. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +3 -3
  159. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -2
  160. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +3 -3
  161. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  162. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
  163. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
  164. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +3 -3
  165. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
  166. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  167. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
  168. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
  169. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
  170. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
  171. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
  172. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
  173. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
  174. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +1 -1
  175. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
  176. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
  177. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
  178. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
  179. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
  180. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
  181. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
  182. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
  183. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +2 -2
  184. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
  185. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
  186. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +1 -1
  187. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
  188. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
  189. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +2 -2
  190. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
  191. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
  192. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  193. data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +1 -1
  194. data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +1 -1
  195. data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +1 -1
  196. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
  197. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +1 -1
  198. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  199. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
  200. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -2
  201. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
  202. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +2 -2
  203. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +1 -1
  204. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
  205. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
  206. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  207. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  208. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
  209. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +1 -1
  210. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  211. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  212. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
  213. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
  214. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
  215. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
  216. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
  217. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  218. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  219. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  220. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  221. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
  222. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +1 -1
  223. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  224. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +1 -1
  225. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
  226. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -2
  227. data/lib/rubocop/cop/chef/security/ssh_private_key.rb +1 -1
  228. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
  229. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
  230. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
  231. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  232. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  233. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
  234. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
  235. data/lib/rubocop/cop/chef/style/attribute_keys.rb +5 -5
  236. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
  237. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
  238. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +1 -1
  239. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
  240. data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
  241. data/lib/rubocop/cop/chef/style/file_mode.rb +1 -1
  242. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
  243. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +1 -1
  244. data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
  245. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
  246. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
  247. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +1 -1
  248. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +3 -3
  249. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
  250. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +3 -3
  251. data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +1 -1
  252. data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +1 -1
  253. metadata +4 -4
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: af05586e951fed9a9a11777583d2f8b0ec7634cca38b3b5b9641e2afb11be50b
4
- data.tar.gz: 8d727e0f4898bf20149fa74ee6d15782840577c98eeb9fe25048ae71ab13c4b1
3
+ metadata.gz: 94be7df501ab0a3a055ee36aab695764830d816e3db7005a7b18231d3a703505
4
+ data.tar.gz: 3cf466a2d3fec655c473df01a769bb9e577359ed04ea3569f6cc6fb0f5c59ea0
5
5
  SHA512:
6
- metadata.gz: dbd9a0129be207bd120c0ba860260726c4547b8e0356eda5c221b70d29aaf9ec92fdce5af7450b919f8a74774b79820c128220749e883c226de4c82f45c21915
7
- data.tar.gz: 74e57634c9aef93e952858a542cac3966c849fa3e1deb2dd5b0ef4b7cd9f8167eba767e55635b72c2cbc7f3d08228a3fed26ed4f2e072e4eb6d8c78a09c3b151
6
+ metadata.gz: 339ccca52365ef809d5976ceadcea5ead13bcef57b294725a26d0f6e5ddfb306f1e003c72d1fd99448640018f0da00d4188ea48adfda39593b2cc02cc541d95e
7
+ data.tar.gz: d02e13fed47f62938a3e3f3dd07c86c8873294bd9fbb96395534f33419b62084a2814581717c8540db139668a67657e009bb3060432a553b111e99c1d0830bc5
data/config/upstream.yml CHANGED
@@ -2496,6 +2496,7 @@ Naming/BlockForwarding:
2496
2496
  SupportedStyles:
2497
2497
  - anonymous
2498
2498
  - explicit
2499
+ BlockForwardingName: block
2499
2500
 
2500
2501
  Naming/BlockParameterName:
2501
2502
  Description: >-
@@ -3698,6 +3699,8 @@ Style/HashSyntax:
3698
3699
  - always
3699
3700
  # forces use of explicit hash literal value.
3700
3701
  - never
3702
+ # accepts both shorthand and explicit use of hash literal value.
3703
+ - either
3701
3704
  # Force hashes that have a symbol value to use hash rockets
3702
3705
  UseHashRocketsWithSymbolValues: false
3703
3706
  # Do not suggest { a?: 1 } over { :a? => 1 } in ruby19 style
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
  module Cookstyle
3
- VERSION = "7.30.1" # rubocop: disable Style/StringLiterals
4
- RUBOCOP_VERSION = '1.24.1'
3
+ VERSION = "7.30.3" # rubocop: disable Style/StringLiterals
4
+ RUBOCOP_VERSION = '1.25.0'
5
5
  end
@@ -48,7 +48,7 @@ module RuboCop
48
48
 
49
49
  def on_block(node)
50
50
  block_guard_with_only_string?(node) do
51
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
51
+ add_offense(node, severity: :refactor) do |corrector|
52
52
  new_val = "#{node.method_name} #{node.body.source}"
53
53
  corrector.replace(node, new_val)
54
54
  end
@@ -44,7 +44,7 @@ module RuboCop
44
44
 
45
45
  def on_send(node)
46
46
  application_fatal?(node) do |val|
47
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
47
+ add_offense(node, severity: :refactor) do |corrector|
48
48
  corrector.replace(node, "raise(#{val.source})")
49
49
  end
50
50
  end
@@ -57,7 +57,7 @@ module RuboCop
57
57
 
58
58
  def on_block(node)
59
59
  conditional_shellout?(node) do |type, val|
60
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
60
+ add_offense(node, severity: :refactor) do |corrector|
61
61
  corrector.replace(node, "#{type} #{val.source}")
62
62
  end
63
63
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_block(node)
45
45
  match_property_in_resource?(:dnf_package, :allow_downgrades, node) do |prop|
46
- add_offense(prop, message: MSG, severity: :refactor) do |corrector|
46
+ add_offense(prop, severity: :refactor) do |corrector|
47
47
  corrector.remove(range_with_surrounding_space(range: prop.loc.expression, side: :left))
48
48
  end
49
49
  end
@@ -60,7 +60,7 @@ module RuboCop
60
60
 
61
61
  def on_send(node)
62
62
  legacy_injection?(node) do
63
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
63
+ add_offense(node, severity: :refactor) do |corrector|
64
64
  if node.parent && correct_injection?(node.parent)
65
65
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
66
66
  else
@@ -37,7 +37,7 @@ module RuboCop
37
37
 
38
38
  def on_send(node)
39
39
  has_name?(node) do |val|
40
- add_offense(node, message: MSG, severity: :refactor) if val.value.include?('.')
40
+ add_offense(node, severity: :refactor) if val.value.include?('.')
41
41
  end
42
42
  end
43
43
  end
@@ -38,7 +38,7 @@ module RuboCop
38
38
  def on_send(node)
39
39
  default_action?(node) do |match|
40
40
  return if %i(send sym array).include?(match.type)
41
- add_offense(node, message: MSG, severity: :refactor)
41
+ add_offense(node, severity: :refactor)
42
42
  end
43
43
  end
44
44
  end
@@ -49,7 +49,7 @@ module RuboCop
49
49
 
50
50
  def on_send(node)
51
51
  invalid_notification?(node) do |resource|
52
- add_offense(resource, message: MSG, severity: :refactor)
52
+ add_offense(resource, severity: :refactor)
53
53
  end
54
54
  end
55
55
  end
@@ -45,7 +45,7 @@ module RuboCop
45
45
 
46
46
  def on_send(node)
47
47
  notification_with_timing?(node) do |timing|
48
- add_offense(timing, message: MSG, severity: :refactor) unless %i(immediate immediately delayed before).include?(timing.value)
48
+ add_offense(timing, severity: :refactor) unless %i(immediate immediately delayed before).include?(timing.value)
49
49
  end
50
50
  end
51
51
  end
@@ -47,7 +47,7 @@ module RuboCop
47
47
  platform_family_helper?(node) do |plats|
48
48
  plats.to_a.each do |p|
49
49
  next unless INVALID_PLATFORM_FAMILIES.key?(p.value)
50
- add_offense(p, message: MSG, severity: :refactor) do |corrector|
50
+ add_offense(p, severity: :refactor) do |corrector|
51
51
  replacement_platform = INVALID_PLATFORM_FAMILIES[p.value]
52
52
  all_passed_platforms = p.parent.arguments.map(&:value)
53
53
 
@@ -50,7 +50,7 @@ module RuboCop
50
50
  new_value = INVALID_PLATFORM_FAMILIES[con.str_content]
51
51
  next unless new_value
52
52
 
53
- add_offense(con, message: MSG, severity: :refactor) do |corrector|
53
+ add_offense(con, severity: :refactor) do |corrector|
54
54
  # if the correct value already exists in the when statement then we just want to delete this node
55
55
  if con.parent.conditions.any? { |x| x.str_content == new_value }
56
56
  range = range_with_surrounding_comma(range_with_surrounding_space(range: con.loc.expression, side: :left), :both)
@@ -46,7 +46,7 @@ module RuboCop
46
46
  def on_send(node)
47
47
  platform_helper?(node) do |plat|
48
48
  plat.to_a.each do |p|
49
- add_offense(p, message: MSG, severity: :refactor) if INVALID_PLATFORMS.key?(p.value)
49
+ add_offense(p, severity: :refactor) if INVALID_PLATFORMS.key?(p.value)
50
50
  end
51
51
  end
52
52
  end
@@ -52,7 +52,7 @@ module RuboCop
52
52
  def on_send(node)
53
53
  supports?(node) do |plat|
54
54
  next unless INVALID_PLATFORMS[plat.str_content]
55
- add_offense(plat, message: MSG, severity: :refactor) do |corrector|
55
+ add_offense(plat, severity: :refactor) do |corrector|
56
56
  correct_string = corrected_platform_source(plat)
57
57
  next unless correct_string
58
58
  corrector.replace(plat, correct_string)
@@ -64,7 +64,7 @@ module RuboCop
64
64
  supports_array?(node) do |plats|
65
65
  plats.values.each do |plat|
66
66
  next unless INVALID_PLATFORMS[plat.str_content]
67
- add_offense(plat, message: MSG, severity: :refactor) do |corrector|
67
+ add_offense(plat, severity: :refactor) do |corrector|
68
68
  correct_string = corrected_platform_source(plat)
69
69
  next unless correct_string
70
70
  corrector.replace(plat, correct_string)
@@ -50,7 +50,7 @@ module RuboCop
50
50
  # some invalid platform have no direct correction value and return nil instead
51
51
  next unless new_value
52
52
 
53
- add_offense(con, message: MSG, severity: :refactor) do |corrector|
53
+ add_offense(con, severity: :refactor) do |corrector|
54
54
  # if the correct value already exists in the when statement then we just want to delete this node
55
55
  if con.parent.conditions.any? { |x| x.str_content == new_value }
56
56
  range = range_with_surrounding_comma(range_with_surrounding_space(range: con.loc.expression, side: :left), :both)
@@ -55,10 +55,10 @@ module RuboCop
55
55
  if p_hash.key.array_type?
56
56
  p_hash.key.values.each do |plat|
57
57
  next unless INVALID_PLATFORM_FAMILIES.key?(plat.value)
58
- add_offense(plat, message: MSG, severity: :refactor)
58
+ add_offense(plat, severity: :refactor)
59
59
  end
60
60
  elsif INVALID_PLATFORM_FAMILIES.key?(p_hash.key.value)
61
- add_offense(p_hash.key, message: MSG, severity: :refactor)
61
+ add_offense(p_hash.key, severity: :refactor)
62
62
  end
63
63
  end
64
64
  end
@@ -54,10 +54,10 @@ module RuboCop
54
54
  if p_hash.key.array_type?
55
55
  p_hash.key.values.each do |plat|
56
56
  next unless INVALID_PLATFORMS.key?(plat.value)
57
- add_offense(plat, message: MSG, severity: :refactor)
57
+ add_offense(plat, severity: :refactor)
58
58
  end
59
59
  elsif INVALID_PLATFORMS.key?(p_hash.key.value)
60
- add_offense(p_hash.key, message: MSG, severity: :refactor)
60
+ add_offense(p_hash.key, severity: :refactor)
61
61
  end
62
62
  end
63
63
  end
@@ -38,7 +38,7 @@ module RuboCop
38
38
  def on_send(node)
39
39
  version?(node) do |ver|
40
40
  next if /\A\d+\.\d+(\.\d+)?\z/.match?(ver.value) # entirely borrowed from Foodcritic.
41
- add_offense(ver, message: MSG, severity: :refactor)
41
+ add_offense(ver, severity: :refactor)
42
42
  end
43
43
  end
44
44
  end
@@ -41,7 +41,7 @@ module RuboCop
41
41
 
42
42
  def on_send(node)
43
43
  non_lazy_node_attribute_default?(node) do |default|
44
- add_offense(default, message: MSG, severity: :refactor) do |corrector|
44
+ add_offense(default, severity: :refactor) do |corrector|
45
45
  corrector.replace(default, "lazy { #{default.source} }")
46
46
  end
47
47
  end
@@ -55,7 +55,7 @@ module RuboCop
55
55
 
56
56
  def on_block(node)
57
57
  lazy_in_guard?(node) do |type, code|
58
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
58
+ add_offense(node, severity: :refactor) do |corrector|
59
59
  corrector.replace(node, "#{type} { #{code.source} }")
60
60
  end
61
61
  end
@@ -54,7 +54,7 @@ module RuboCop
54
54
  match_property_in_resource?(:macos_userdefaults, 'type', node) do |type|
55
55
  type_val = method_arg_ast_to_string(type)
56
56
  return if VALID_VALUES.include?(type_val)
57
- add_offense(type, message: MSG, severity: :refactor) do |corrector|
57
+ add_offense(type, severity: :refactor) do |corrector|
58
58
  next unless INVALID_VALUE_MAP[type_val]
59
59
  corrector.replace(type, "type '#{INVALID_VALUE_MAP[type_val]}'")
60
60
  end
@@ -46,7 +46,7 @@ module RuboCop
46
46
 
47
47
  def on_send(node)
48
48
  depends_without_comma?(node) do |cb, ver|
49
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
49
+ add_offense(node, severity: :refactor) do |corrector|
50
50
  corrector.replace(node, "depends '#{cb.value}', '#{ver.value}'")
51
51
  end
52
52
  end
@@ -38,7 +38,7 @@ module RuboCop
38
38
  # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
39
39
  return if cb_name?(processed_source.ast)
40
40
  range = source_range(processed_source.buffer, 1, 0)
41
- add_offense(range, message: MSG, severity: :refactor) do |corrector|
41
+ add_offense(range, severity: :refactor) do |corrector|
42
42
  path = processed_source.path
43
43
  cb_name = File.basename(File.dirname(path))
44
44
  corrector.insert_before(processed_source.ast, "name '#{cb_name}'\n")
@@ -39,7 +39,7 @@ module RuboCop
39
39
  # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
40
40
  return if cb_version?(processed_source.ast)
41
41
  range = source_range(processed_source.buffer, 1, 0)
42
- add_offense(range, message: MSG, severity: :refactor)
42
+ add_offense(range, severity: :refactor)
43
43
  end
44
44
  end
45
45
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  node_normal?(node) do
46
- add_offense(node, message: MSG, severity: :refactor)
46
+ add_offense(node, severity: :refactor)
47
47
  end
48
48
  end
49
49
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  node_normal_unless?(node) do
46
- add_offense(node, message: MSG, severity: :refactor)
46
+ add_offense(node, severity: :refactor)
47
47
  end
48
48
  end
49
49
  end
@@ -36,7 +36,7 @@ module RuboCop
36
36
 
37
37
  def on_send(node)
38
38
  node_save?(node) do
39
- add_offense(node, message: MSG, severity: :refactor)
39
+ add_offense(node, severity: :refactor)
40
40
  end
41
41
  end
42
42
  end
@@ -51,7 +51,7 @@ module RuboCop
51
51
  match_property_in_resource?(nil, %w(notifies subscribes), node) do |notifies_property|
52
52
  return unless notifies_property.node_parts[2].str_type?
53
53
 
54
- add_offense(notifies_property, message: MSG, severity: :refactor) do |corrector|
54
+ add_offense(notifies_property, severity: :refactor) do |corrector|
55
55
  corrector.replace(notifies_property.first_argument,
56
56
  ":#{notifies_property.node_parts[2].value}")
57
57
  end
@@ -39,7 +39,7 @@ module RuboCop
39
39
 
40
40
  def on_send(node)
41
41
  return unless node.arguments.first&.str_type? && node.arguments.first.value.match?(/^0o/)
42
- add_offense(node, message: MSG, severity: :refactor)
42
+ add_offense(node, severity: :refactor)
43
43
  end
44
44
  end
45
45
  end
@@ -36,7 +36,7 @@ module RuboCop
36
36
 
37
37
  def on_const(node)
38
38
  openssl_helper?(node) do
39
- add_offense(node, message: MSG, severity: :warning)
39
+ add_offense(node, severity: :warning)
40
40
  end
41
41
  end
42
42
  end
@@ -44,7 +44,7 @@ module RuboCop
44
44
  property_data = method_arg_ast_to_string(code_property)
45
45
  return unless property_data && property_data.match?(/^remove-item/i) &&
46
46
  !property_data.include?('*')
47
- add_offense(node, message: MSG, severity: :refactor)
47
+ add_offense(node, severity: :refactor)
48
48
  end
49
49
  end
50
50
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
  def on_send(node)
41
41
  powershell_out_exists?(node) do |exists_string|
42
42
  return unless exists_string.match?(/^Test-Path/)
43
- add_offense(node, message: MSG, severity: :refactor)
43
+ add_offense(node, severity: :refactor)
44
44
  end
45
45
  end
46
46
  end
@@ -49,7 +49,7 @@ module RuboCop
49
49
  property_without_type?(node) do |hash_vals|
50
50
  return if hash_vals&.first&.keys&.include?(s(:sym, :kind_of))
51
51
 
52
- add_offense(node, message: MSG, severity: :refactor)
52
+ add_offense(node, severity: :refactor)
53
53
  end
54
54
  end
55
55
  end
@@ -41,7 +41,7 @@ module RuboCop
41
41
 
42
42
  def on_block(node)
43
43
  match_property_in_resource?(:service, 'running', node) do |prop|
44
- add_offense(prop, message: MSG, severity: :refactor)
44
+ add_offense(prop, severity: :refactor)
45
45
  end
46
46
  end
47
47
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
 
41
41
  def on_block(node)
42
42
  match_property_in_resource?(nil, 'name', node) do |name_node|
43
- add_offense(name_node, message: MSG, severity: :refactor)
43
+ add_offense(name_node, severity: :refactor)
44
44
  end
45
45
  end
46
46
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
  match_property_in_resource?(nil, 'action', node) do |action_node|
44
44
  action_node.arguments.each do |action|
45
45
  next unless action.source == ':none'
46
- add_offense(action, message: MSG, severity: :refactor) do |corrector|
46
+ add_offense(action, severity: :refactor) do |corrector|
47
47
  corrector.replace(action, ':nothing')
48
48
  end
49
49
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
 
41
41
  def on_block(node)
42
42
  unscoped_file_exist?(node) do |m|
43
- add_offense(m, message: MSG, severity: :refactor) do |corrector|
43
+ add_offense(m, severity: :refactor) do |corrector|
44
44
  corrector.replace(m, '::File')
45
45
  end
46
46
  end
@@ -37,7 +37,7 @@ module RuboCop
37
37
  def on_send(node)
38
38
  execute_command?(node) do |command|
39
39
  if starts_service?(command)
40
- add_offense(command, message: MSG, severity: :refactor)
40
+ add_offense(command, severity: :refactor)
41
41
  end
42
42
  end
43
43
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
  def on_send(node)
41
41
  supports_with_constraint?(node) do |ver|
42
42
  return if ver.source.include?('.')
43
- add_offense(ver, message: MSG, severity: :refactor) do |corrector|
43
+ add_offense(ver, severity: :refactor) do |corrector|
44
44
  corrector.replace(ver, ver.source.gsub(ver.value, (ver.value + '.0')))
45
45
  end
46
46
  end
@@ -39,7 +39,7 @@ module RuboCop
39
39
  def on_send(node)
40
40
  remote_file?(node) do |command|
41
41
  return unless hardcoded_tmp?(command) && !file_cache_path?(command)
42
- add_offense(command, message: MSG, severity: :refactor)
42
+ add_offense(command, severity: :refactor)
43
43
  end
44
44
  end
45
45
 
@@ -44,7 +44,7 @@ module RuboCop
44
44
  cb_name?(node) do
45
45
  dependencies(processed_source.ast).each do |dep|
46
46
  next unless dep.arguments == node.arguments
47
- add_offense(dep, message: MSG, severity: :refactor) do |corrector|
47
+ add_offense(dep, severity: :refactor) do |corrector|
48
48
  corrector.remove(range_with_surrounding_space(range: dep.loc.expression, side: :left))
49
49
  end
50
50
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
 
41
41
  def on_send(node)
42
42
  chef_handler_recipe?(node) do
43
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
43
+ add_offense(node, severity: :refactor) do |corrector|
44
44
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
45
45
  end
46
46
  end
@@ -41,7 +41,7 @@ module RuboCop
41
41
 
42
42
  def on_block(node)
43
43
  match_property_in_resource?(:chef_handler, 'supports', node) do |prop_node|
44
- add_offense(prop_node, message: MSG, severity: :warning) do |corrector|
44
+ add_offense(prop_node, severity: :warning) do |corrector|
45
45
  # make sure to delete leading and trailing {}s that would create invalid ruby syntax
46
46
  extracted_val = prop_node.arguments.first.source.gsub(/{|}/, '')
47
47
  corrector.replace(prop_node, "type #{extracted_val}")
@@ -41,13 +41,13 @@ module RuboCop
41
41
 
42
42
  def on_send(node)
43
43
  require_rest?(node) do
44
- add_offense(node, message: MSG, severity: :warning)
44
+ add_offense(node, severity: :warning)
45
45
  end
46
46
  end
47
47
 
48
48
  def on_const(node)
49
49
  rest_const?(node) do
50
- add_offense(node, message: MSG, severity: :warning)
50
+ add_offense(node, severity: :warning)
51
51
  end
52
52
  end
53
53
  end
@@ -64,20 +64,20 @@ module RuboCop
64
64
 
65
65
  def on_send(node)
66
66
  rewind_gem_install?(node) do
67
- add_offense(node, message: MSG, severity: :warning) do |corrector|
67
+ add_offense(node, severity: :warning) do |corrector|
68
68
  node = node.parent if node.parent&.block_type? # make sure we get the whole block not just the method in the block
69
69
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
70
70
  end
71
71
  end
72
72
 
73
73
  require_rewind?(node) do
74
- add_offense(node, message: MSG, severity: :warning) do |corrector|
74
+ add_offense(node, severity: :warning) do |corrector|
75
75
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
76
76
  end
77
77
  end
78
78
 
79
79
  rewind_resources?(node) do |string|
80
- add_offense(node, message: MSG, severity: :warning) do |corrector|
80
+ add_offense(node, severity: :warning) do |corrector|
81
81
  corrector.replace(node, node.source.gsub(string.to_s, MAPPING[string]))
82
82
  end
83
83
  end
@@ -86,7 +86,7 @@ module RuboCop
86
86
  def on_block(node)
87
87
  match_property_in_resource?(:chef_gem, 'package_name', node) do |pkg_name|
88
88
  next unless pkg_name.arguments&.first&.str_content == 'chef-rewind'
89
- add_offense(node, message: MSG, severity: :warning) do |corrector|
89
+ add_offense(node, severity: :warning) do |corrector|
90
90
  corrector.remove(node) if pkg_name.arguments&.first&.str_content == 'chef-rewind'
91
91
  end
92
92
  end
@@ -59,19 +59,19 @@ module RuboCop
59
59
 
60
60
  def on_send(node)
61
61
  include_shellout?(node) do
62
- add_offense(node, message: MSG, severity: :warning) do |corrector|
62
+ add_offense(node, severity: :warning) do |corrector|
63
63
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
64
64
  end
65
65
  end
66
66
 
67
67
  require_shellout?(node) do
68
- add_offense(node, message: MSG, severity: :warning) do |corrector|
68
+ add_offense(node, severity: :warning) do |corrector|
69
69
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
70
70
  end
71
71
  end
72
72
 
73
73
  shellout_new?(node) do
74
- add_offense(node, message: MSG, severity: :warning) do |corrector|
74
+ add_offense(node, severity: :warning) do |corrector|
75
75
  corrector.replace(node, node.source.gsub('Chef::ShellOut', 'Mixlib::ShellOut'))
76
76
  end
77
77
  end
@@ -46,7 +46,7 @@ module RuboCop
46
46
  RESTRICT_ON_SEND = [:vagrant_key?, :vagrant_domain?, :vagrant_user?, :require_chef_gem, :best_ip_for, :nexus?, :ios_xr?, :ruby_20?, :ruby_19?, :includes_recipe?, :wrlinux?, :dev_null, :nexentacore_platform?, :opensolaris_platform?, :nexentacore?, :opensolaris?].freeze
47
47
 
48
48
  def on_send(node)
49
- add_offense(node, message: MSG, severity: :refactor)
49
+ add_offense(node, severity: :refactor)
50
50
  end
51
51
  end
52
52
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  chef_platform_windows?(node) do
46
- add_offense(node, message: MSG, severity: :warning) do |corrector|
46
+ add_offense(node, severity: :warning) do |corrector|
47
47
  corrector.replace(node, "platform?('windows')")
48
48
  end
49
49
  end
@@ -45,7 +45,7 @@ module RuboCop
45
45
  # We want to catch calls like ChefCLI::CLI.whatever or places where classes are defined in the ChefDK module
46
46
  return unless node.const_name == 'ChefDK' && (node.parent&.module_type? || node.parent&.const_type?)
47
47
 
48
- add_offense(node, message: MSG, severity: :warning) do |corrector|
48
+ add_offense(node, severity: :warning) do |corrector|
49
49
  corrector.replace(node, node.source.gsub('ChefDK', 'ChefCLI'))
50
50
  end
51
51
  end
@@ -30,7 +30,7 @@ module RuboCop
30
30
  # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
31
31
  range = source_range(processed_source.buffer, 1, 0)
32
32
 
33
- add_offense(range, message: MSG, severity: :warning)
33
+ add_offense(range, severity: :warning)
34
34
  end
35
35
  end
36
36
  end
@@ -37,7 +37,7 @@ module RuboCop
37
37
 
38
38
  def on_block(node)
39
39
  coverage_reporter?(node) do
40
- add_offense(node, message: MSG, severity: :warning) do |corrector|
40
+ add_offense(node, severity: :warning) do |corrector|
41
41
  corrector.remove(node)
42
42
  end
43
43
  end
@@ -49,7 +49,7 @@ module RuboCop
49
49
 
50
50
  def on_const(node)
51
51
  chefspec_runner?(node) do
52
- add_offense(node, message: MSG, severity: :warning) do |corrector|
52
+ add_offense(node, severity: :warning) do |corrector|
53
53
  corrector.replace(node, 'ChefSpec::ServerRunner')
54
54
  end
55
55
  end