cookstyle 7.30.1 → 7.30.3
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/config/upstream.yml +3 -0
- data/lib/cookstyle/version.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_normal.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/tmp_path.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_environment.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/node_roles.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/build_essential.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -2
- data/lib/rubocop/cop/chef/security/ssh_private_key.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
- data/lib/rubocop/cop/chef/style/attribute_keys.rb +5 -5
- data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
- data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
- data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
- data/lib/rubocop/cop/chef/style/file_mode.rb +1 -1
- data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
- data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +1 -1
- data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
- data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +1 -1
- data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +3 -3
- data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
- data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +3 -3
- data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +1 -1
- data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +1 -1
- metadata +4 -4
@@ -43,7 +43,7 @@ module RuboCop
|
|
43
43
|
match_property_in_resource?(:chocolatey_package, 'action', node) do |choco_action|
|
44
44
|
choco_action.arguments.each do |action|
|
45
45
|
next unless action.source == ':uninstall'
|
46
|
-
add_offense(action,
|
46
|
+
add_offense(action, severity: :warning) do |corrector|
|
47
47
|
corrector.replace(action, ':remove')
|
48
48
|
end
|
49
49
|
end
|
@@ -42,7 +42,7 @@ module RuboCop
|
|
42
42
|
|
43
43
|
def on_send(node)
|
44
44
|
depends_compat_resource?(node) do
|
45
|
-
add_offense(node,
|
45
|
+
add_offense(node, severity: :warning) do |corrector|
|
46
46
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
47
47
|
end
|
48
48
|
end
|
@@ -39,7 +39,7 @@ module RuboCop
|
|
39
39
|
|
40
40
|
def on_send(node)
|
41
41
|
legacy_depends?(node) do
|
42
|
-
add_offense(node,
|
42
|
+
add_offense(node, severity: :warning) do |corrector|
|
43
43
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
44
44
|
end
|
45
45
|
end
|
@@ -42,7 +42,7 @@ module RuboCop
|
|
42
42
|
|
43
43
|
def on_send(node)
|
44
44
|
depends_compat_resource?(node) do
|
45
|
-
add_offense(node,
|
45
|
+
add_offense(node, severity: :warning) do |corrector|
|
46
46
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
47
47
|
end
|
48
48
|
end
|
@@ -42,7 +42,7 @@ module RuboCop
|
|
42
42
|
|
43
43
|
def on_send(node)
|
44
44
|
legacy_depends?(node) do
|
45
|
-
add_offense(node,
|
45
|
+
add_offense(node, severity: :warning) do |corrector|
|
46
46
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
47
47
|
end
|
48
48
|
end
|
@@ -38,7 +38,7 @@ module RuboCop
|
|
38
38
|
|
39
39
|
def on_send(node)
|
40
40
|
depends_method?(node) do |arg|
|
41
|
-
add_offense(node,
|
41
|
+
add_offense(node, severity: :warning) if %w(poise poise-service poise-hoist).include?(arg.value)
|
42
42
|
end
|
43
43
|
end
|
44
44
|
end
|
@@ -114,7 +114,7 @@ module RuboCop
|
|
114
114
|
def on_send(node)
|
115
115
|
chefspec_definition?(node) do |plat, ver|
|
116
116
|
next unless legacy_chefspec_platform(plat.value, ver.value)
|
117
|
-
add_offense(node,
|
117
|
+
add_offense(node, severity: :warning) do |corrector|
|
118
118
|
if replacement = replacement_string(plat.value, ver.value) # rubocop: disable Lint/AssignmentInCondition
|
119
119
|
corrector.replace(ver, "'#{replacement}'")
|
120
120
|
end
|
@@ -54,19 +54,19 @@ module RuboCop
|
|
54
54
|
|
55
55
|
def on_send(node)
|
56
56
|
deprecated_mixin?(node) do
|
57
|
-
add_offense(node,
|
57
|
+
add_offense(node, severity: :warning) do |corrector|
|
58
58
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
59
59
|
end
|
60
60
|
end
|
61
61
|
|
62
62
|
deprecated_dsl?(node) do
|
63
|
-
add_offense(node,
|
63
|
+
add_offense(node, severity: :warning) do |corrector|
|
64
64
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
65
65
|
end
|
66
66
|
end
|
67
67
|
|
68
68
|
dsl_mixin_require?(node) do
|
69
|
-
add_offense(node,
|
69
|
+
add_offense(node, severity: :warning) do |corrector|
|
70
70
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
71
71
|
end
|
72
72
|
end
|
@@ -51,7 +51,7 @@ module RuboCop
|
|
51
51
|
next unless prop_node.arguments.first.sym_type?
|
52
52
|
next unless [s(:sym, :install), s(:sym, :remove)].include?(prop_node.arguments.first)
|
53
53
|
|
54
|
-
add_offense(prop_node,
|
54
|
+
add_offense(prop_node, severity: :warning) do |corrector|
|
55
55
|
corrector.replace(prop_node, prop_node.source
|
56
56
|
.gsub('install', 'create')
|
57
57
|
.gsub('remove', 'delete'))
|
@@ -53,7 +53,7 @@ module RuboCop
|
|
53
53
|
next unless prop_node.arguments.first.sym_type?
|
54
54
|
next unless [s(:sym, :add), s(:sym, :delete)].include?(prop_node.arguments.first)
|
55
55
|
|
56
|
-
add_offense(prop_node,
|
56
|
+
add_offense(prop_node, severity: :warning) do |corrector|
|
57
57
|
corrector.replace(prop_node, prop_node.source
|
58
58
|
.gsub('add', 'create')
|
59
59
|
.gsub('delete', 'remove'))
|
@@ -53,7 +53,7 @@ module RuboCop
|
|
53
53
|
def on_block(node)
|
54
54
|
%w(url keyurl mirrorexpire).each do |prop|
|
55
55
|
match_property_in_resource?(:yum_repository, prop, node) do |prop_node|
|
56
|
-
add_offense(prop_node,
|
56
|
+
add_offense(prop_node, severity: :warning) do |corrector|
|
57
57
|
corrector.replace(prop_node, prop_node.source
|
58
58
|
.gsub(/^url/, 'baseurl')
|
59
59
|
.gsub(/^keyurl/, 'gpgkey')
|
@@ -40,7 +40,7 @@ module RuboCop
|
|
40
40
|
RESTRICT_ON_SEND = [:epic_fail].freeze
|
41
41
|
|
42
42
|
def on_send(node)
|
43
|
-
add_offense(node,
|
43
|
+
add_offense(node, severity: :warning) do |corrector|
|
44
44
|
corrector.replace(node, 'ignore_failure true')
|
45
45
|
end
|
46
46
|
end
|
@@ -40,7 +40,7 @@ module RuboCop
|
|
40
40
|
|
41
41
|
def on_block(node)
|
42
42
|
match_property_in_resource?(:execute, 'path', node) do |offense|
|
43
|
-
add_offense(offense,
|
43
|
+
add_offense(offense, severity: :warning) # @todo: we could probably autocorrect this with some work
|
44
44
|
end
|
45
45
|
end
|
46
46
|
end
|
@@ -105,7 +105,7 @@ module RuboCop
|
|
105
105
|
def on_class(node)
|
106
106
|
return if has_provides?
|
107
107
|
HWRP?(node) do |inherit|
|
108
|
-
add_offense(inherit,
|
108
|
+
add_offense(inherit, severity: :warning) do |corrector|
|
109
109
|
resource_name_ast(node) do |ast_match|
|
110
110
|
# build a new string to add after that includes the new line and the proper indentation
|
111
111
|
new_string = "\n" + ast_match.source.dup.gsub('resource_name', 'provides').prepend(' ' * indentation(ast_match))
|
@@ -47,7 +47,7 @@ module RuboCop
|
|
47
47
|
|
48
48
|
def on_class(node)
|
49
49
|
inherits_from_compat_resource?(node) do
|
50
|
-
add_offense(node,
|
50
|
+
add_offense(node, severity: :warning) do |corrector|
|
51
51
|
corrector.replace(node, node.source.gsub('ChefCompat', 'Chef'))
|
52
52
|
end
|
53
53
|
end
|
@@ -44,7 +44,7 @@ module RuboCop
|
|
44
44
|
|
45
45
|
def on_block(node)
|
46
46
|
match_property_in_resource?(:launchd, 'hash', node) do |offense|
|
47
|
-
add_offense(offense.loc.expression,
|
47
|
+
add_offense(offense.loc.expression, severity: :warning) do |corrector|
|
48
48
|
corrector.replace(offense.loc.expression, offense.loc.expression.source.gsub(/^hash/, 'plist_hash'))
|
49
49
|
end
|
50
50
|
end
|
@@ -69,7 +69,7 @@ module RuboCop
|
|
69
69
|
|
70
70
|
def on_send(node)
|
71
71
|
legacy_notify?(node) do |notify_type, action, type, name, timing|
|
72
|
-
add_offense(node,
|
72
|
+
add_offense(node, severity: :warning) do |corrector|
|
73
73
|
service_value = case name.type
|
74
74
|
when :str
|
75
75
|
"'#{type.source}[#{name.value}]'"
|
@@ -48,7 +48,7 @@ module RuboCop
|
|
48
48
|
|
49
49
|
def on_block(node)
|
50
50
|
match_property_in_resource?(:macos_userdefaults, 'global', node) do |global|
|
51
|
-
add_offense(global.loc.expression,
|
51
|
+
add_offense(global.loc.expression, severity: :warning) do |corrector|
|
52
52
|
corrector.remove(range_with_surrounding_space(range: global.loc.expression, side: :left))
|
53
53
|
end
|
54
54
|
end
|
@@ -47,7 +47,7 @@ module RuboCop
|
|
47
47
|
|
48
48
|
def on_send(node)
|
49
49
|
name_property_with_default?(node) do |default|
|
50
|
-
add_offense(node,
|
50
|
+
add_offense(node, severity: :warning) do |corrector|
|
51
51
|
range = range_with_surrounding_comma(range_with_surrounding_space(range: default.loc.expression, side: :left), :left)
|
52
52
|
corrector.remove(range)
|
53
53
|
end
|
@@ -68,7 +68,7 @@ module RuboCop
|
|
68
68
|
|
69
69
|
def on_send(node)
|
70
70
|
node_ohai_methods?(node) do
|
71
|
-
add_offense(node.loc.selector,
|
71
|
+
add_offense(node.loc.selector, severity: :warning) do |corrector|
|
72
72
|
corrector.replace(node, "node['#{node.method_name}']")
|
73
73
|
end
|
74
74
|
end
|
@@ -42,7 +42,7 @@ module RuboCop
|
|
42
42
|
|
43
43
|
def on_send(node)
|
44
44
|
node_set?(node) do
|
45
|
-
add_offense(node.loc.selector,
|
45
|
+
add_offense(node.loc.selector, severity: :warning) do |corrector|
|
46
46
|
corrector.replace(node.loc.selector, 'normal')
|
47
47
|
end
|
48
48
|
end
|
@@ -42,7 +42,7 @@ module RuboCop
|
|
42
42
|
|
43
43
|
def on_send(node)
|
44
44
|
node_set_unless?(node) do
|
45
|
-
add_offense(node.loc.selector,
|
45
|
+
add_offense(node.loc.selector, severity: :warning) do |corrector|
|
46
46
|
corrector.replace(node.loc.selector, 'normal_unless')
|
47
47
|
end
|
48
48
|
end
|
@@ -56,11 +56,11 @@ module RuboCop
|
|
56
56
|
|
57
57
|
def add_offense_for_bare_assignment(sub_node)
|
58
58
|
if sub_node.receiver == s(:send, nil, :node) # node['foo'] scenario
|
59
|
-
add_offense(sub_node.receiver.loc.selector,
|
59
|
+
add_offense(sub_node.receiver.loc.selector, severity: :warning)
|
60
60
|
elsif sub_node.receiver &&
|
61
61
|
sub_node.receiver&.node_parts[0] == s(:send, nil, :node) &&
|
62
62
|
sub_node.receiver&.node_parts[1] == :[] # node['foo']['bar'] scenario
|
63
|
-
add_offense(sub_node.receiver.node_parts.first.loc.selector,
|
63
|
+
add_offense(sub_node.receiver.node_parts.first.loc.selector, severity: :warning)
|
64
64
|
end
|
65
65
|
end
|
66
66
|
end
|
@@ -47,13 +47,13 @@ module RuboCop
|
|
47
47
|
|
48
48
|
def on_send(node)
|
49
49
|
depends_poise_archive?(node) do
|
50
|
-
add_offense(node,
|
50
|
+
add_offense(node, severity: :warning)
|
51
51
|
end
|
52
52
|
end
|
53
53
|
|
54
54
|
def on_block(node)
|
55
55
|
match_resource_type?(:poise_archive, node) do
|
56
|
-
add_offense(node,
|
56
|
+
add_offense(node, severity: :warning)
|
57
57
|
end
|
58
58
|
end
|
59
59
|
end
|
@@ -41,7 +41,7 @@ module RuboCop
|
|
41
41
|
|
42
42
|
def on_send(node)
|
43
43
|
community_source?(node) do
|
44
|
-
add_offense(node,
|
44
|
+
add_offense(node, severity: :warning) do |corrector|
|
45
45
|
corrector.replace(node, 'default_source :supermarket')
|
46
46
|
end
|
47
47
|
end
|
@@ -47,7 +47,7 @@ module RuboCop
|
|
47
47
|
|
48
48
|
def on_send(node)
|
49
49
|
ps_cb_helper?(node) do |ver|
|
50
|
-
add_offense(node,
|
50
|
+
add_offense(node, severity: :warning) do |corrector|
|
51
51
|
corrector.replace(node, "node['powershell']['version'].to_f == #{ver.source}")
|
52
52
|
end
|
53
53
|
end
|
@@ -41,7 +41,7 @@ module RuboCop
|
|
41
41
|
|
42
42
|
def on_send(node)
|
43
43
|
require_recipe?(node) do
|
44
|
-
add_offense(node.loc.selector,
|
44
|
+
add_offense(node.loc.selector, severity: :warning) do |corrector|
|
45
45
|
corrector.replace(node.loc.selector, 'include_recipe')
|
46
46
|
end
|
47
47
|
end
|
@@ -37,9 +37,9 @@ module RuboCop
|
|
37
37
|
def_node_search :calls_provides?, '(send nil? :provides ...)'
|
38
38
|
|
39
39
|
def on_def(node)
|
40
|
-
return unless node.
|
40
|
+
return unless node.method?(:provides?)
|
41
41
|
|
42
|
-
add_offense(node,
|
42
|
+
add_offense(node, severity: :warning) unless calls_provides?(processed_source.ast)
|
43
43
|
end
|
44
44
|
end
|
45
45
|
end
|
@@ -34,7 +34,7 @@ module RuboCop
|
|
34
34
|
RESTRICT_ON_SEND = [:dsl_name].freeze
|
35
35
|
|
36
36
|
def on_send(node)
|
37
|
-
add_offense(node,
|
37
|
+
add_offense(node, severity: :warning)
|
38
38
|
end
|
39
39
|
|
40
40
|
# potential autocorrect is new_resource.updated_by_last_action true, but we need to actually see what class we were called from
|
@@ -68,7 +68,7 @@ module RuboCop
|
|
68
68
|
def on_send(node)
|
69
69
|
resource_name?(node) do |name|
|
70
70
|
return if valid_provides?(name)
|
71
|
-
add_offense(node,
|
71
|
+
add_offense(node, severity: :warning) do |corrector|
|
72
72
|
if name.to_s == "#{cookbook_name}_#{File.basename(processed_source.path, '.rb')}"
|
73
73
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
74
74
|
else
|
@@ -38,7 +38,7 @@ module RuboCop
|
|
38
38
|
MSG = "Don't use updated = true/false to update resource state. This will cause failures in Chef Infra Client 13 and later."
|
39
39
|
|
40
40
|
def on_lvasgn(node)
|
41
|
-
add_offense(node,
|
41
|
+
add_offense(node, severity: :warning) if node.node_parts.first == :updated
|
42
42
|
end
|
43
43
|
|
44
44
|
# potential autocorrect is new_resource.updated_by_last_action true, but we need to actually see what class we were called from
|
@@ -60,7 +60,7 @@ module RuboCop
|
|
60
60
|
# Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
|
61
61
|
return if unified_mode?(processed_source.ast)
|
62
62
|
range = source_range(processed_source.buffer, 1, 0)
|
63
|
-
add_offense(range,
|
63
|
+
add_offense(range, severity: :refactor) do |corrector|
|
64
64
|
insert_below_provides(corrector) || insert_below_resource_name(corrector)
|
65
65
|
end
|
66
66
|
end
|
@@ -44,7 +44,7 @@ module RuboCop
|
|
44
44
|
def on_send(node)
|
45
45
|
positional_shellout?(node) do |h|
|
46
46
|
next unless h.braces?
|
47
|
-
add_offense(h,
|
47
|
+
add_offense(h, severity: :refactor) do |corrector|
|
48
48
|
corrector.replace(h, h.source[1..-2])
|
49
49
|
end
|
50
50
|
end
|
@@ -49,7 +49,7 @@ module RuboCop
|
|
49
49
|
match_property_in_resource?(:ruby_block, 'action', node) do |ruby_action|
|
50
50
|
ruby_action.arguments.each do |action|
|
51
51
|
next unless action.source == ':create'
|
52
|
-
add_offense(action,
|
52
|
+
add_offense(action, severity: :warning) do |corrector|
|
53
53
|
corrector.replace(action, ':run')
|
54
54
|
end
|
55
55
|
end
|
@@ -45,15 +45,15 @@ module RuboCop
|
|
45
45
|
|
46
46
|
def on_send(node)
|
47
47
|
calls_run_command?(node) do
|
48
|
-
add_offense(node,
|
48
|
+
add_offense(node, severity: :warning) unless defines_run_command?(processed_source.ast)
|
49
49
|
end
|
50
50
|
|
51
51
|
require_mixin_command?(node) do
|
52
|
-
add_offense(node,
|
52
|
+
add_offense(node, severity: :warning)
|
53
53
|
end
|
54
54
|
|
55
55
|
include_mixin_command?(node) do
|
56
|
-
add_offense(node,
|
56
|
+
add_offense(node, severity: :warning)
|
57
57
|
end
|
58
58
|
end
|
59
59
|
end
|
@@ -49,7 +49,7 @@ module RuboCop
|
|
49
49
|
|
50
50
|
def on_send(node)
|
51
51
|
search_method?(node) do
|
52
|
-
add_offense(node,
|
52
|
+
add_offense(node, severity: :warning) do |corrector|
|
53
53
|
corrector.replace(node, corrected_string(node))
|
54
54
|
end if positional_arguments?(node)
|
55
55
|
end
|
@@ -40,7 +40,7 @@ module RuboCop
|
|
40
40
|
RESTRICT_ON_SEND = [:use_automatic_resource_name].freeze
|
41
41
|
|
42
42
|
def on_send(node)
|
43
|
-
add_offense(node.loc.selector,
|
43
|
+
add_offense(node.loc.selector, severity: :warning) do |corrector|
|
44
44
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
45
45
|
end
|
46
46
|
end
|
@@ -46,7 +46,7 @@ module RuboCop
|
|
46
46
|
node = node.parent
|
47
47
|
end
|
48
48
|
|
49
|
-
add_offense(node,
|
49
|
+
add_offense(node, severity: :warning) do |corrector|
|
50
50
|
corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
|
51
51
|
end
|
52
52
|
end
|
@@ -36,7 +36,7 @@ module RuboCop
|
|
36
36
|
RESTRICT_ON_SEND = [:to_yaml].freeze
|
37
37
|
|
38
38
|
def on_send(node)
|
39
|
-
add_offense(node,
|
39
|
+
add_offense(node, severity: :warning) do |corrector|
|
40
40
|
corrector.replace(node, "YAML.dump(#{node.receiver.source})")
|
41
41
|
end
|
42
42
|
end
|
@@ -49,13 +49,13 @@ module RuboCop
|
|
49
49
|
|
50
50
|
def on_block(node)
|
51
51
|
match_property_in_resource?(:user, 'supports', node) do |property|
|
52
|
-
add_offense(property,
|
52
|
+
add_offense(property, severity: :warning) do |corrector|
|
53
53
|
new_text = []
|
54
54
|
|
55
55
|
property.arguments.first.each_pair do |k, v|
|
56
56
|
# account for a strange edge case where the person incorrectly makes "manage_home a method
|
57
57
|
# the code would be broken, but without this handling cookstyle would explode
|
58
|
-
key_value = (k.send_type? && k.
|
58
|
+
key_value = (k.send_type? && k.method?(:manage_home)) ? 'manage_home' : k.value
|
59
59
|
|
60
60
|
new_text << "#{key_value} #{v.source}"
|
61
61
|
end
|