cookstyle 5.1.19 → 5.2.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0bebad52b67940ef2ea18a69715758710d78e83d08e6fd3629647c44df467d79
-  data.tar.gz: 48af992c7bf5f18d5b3a948912ff57386439bbc57029ec3a6b962d5192b168f6
+  metadata.gz: 5b693c3f963fdd6689770744a4ba49fc1461c9312976cfcef2947ff938b04bc9
+  data.tar.gz: 629951dbaa3f1c0e3e116b42f0848415b524886351f67eda55c1f7208715de6f
 SHA512:
-  metadata.gz: 31950bedb48fc769d8359183b7a7f8a95bb109cd446ed55748bcb90c97688735b4dc063d12660a3573e8a299eb145ca3f912100a2f0086038eaedf714194dce5
-  data.tar.gz: 721544b1d118f01f29be8d025e927df03fd588e5379f58e7c4748cbc4b3325c225b90a32d44f15c914794bb2faf0fd93c8c214c721d3341e02689fa92b1a3187
+  metadata.gz: 92a8fca655802ef1627025fca46a23531290aba1bd7240805ba74d648b775d876bf72a5ae955b35c47852110ca05492882afb6334124b79eda310165e8930645
+  data.tar.gz: da43f5422b02cb8d57d15b13b2390f7d9064a80c4ec0b58fce0371b81eb1ab3a0ba68928475316466b52ae9f05eb7af74fa33a33be2fddd64a60da4134995ca8

data/bin/cookstyle

@@ -12,7 +12,8 @@ unless ARGV.include?('--fail-level')
   ARGV << 'C'
 end
 
-if ARGV.size == 1 && %w(-v --version).include?(ARGV.first)
+# if only -v is passed we'll get 3 args (-v, --fail-level, and C)
+if ARGV.size == 3 && %w(-v --version).include?(ARGV.first)
   puts "Cookstyle #{Cookstyle::VERSION}"
   print '  * RuboCop '
 end

data/config/cookstyle.yml

@@ -94,6 +94,20 @@ Chef/NamePropertyIsRequired:
   Enabled: true
   VersionAdded: '5.1.0'
 
+Chef/InvalidLicenseString:
+  Description: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved"
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/metadata.rb'
+
+Chef/InvalidPlatformMetadata:
+  Description: metadata.rb "supports" platform is invalid
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/metadata.rb'
+
 ###############################
 # Resolving Deprecations
 ###############################
@@ -155,6 +169,13 @@ Chef/AttributeMetadata:
   Include:
     - '**/metadata.rb'
 
+Chef/LongDescriptionMetadata:
+  Description: The long_description metadata.rb method is not used and is unnecessary in cookbooks
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/metadata.rb'
+
 Chef/CookbookDependsOnCompatResource:
   Description: Don't depend on the deprecated compat_resource cookbook made obsolete by Chef 12.19+
   Enabled: true
@@ -179,6 +200,11 @@ Chef/ErlCallResource:
   Enabled: true
   VersionAdded: '5.1.0'
 
+Chef/RequireRecipe:
+  Description: Use include_recipe instead of the require_recipe method
+  Enabled: true
+  VersionAdded: '5.2.0'
+
 ###############################
 # Cleaning up Legacy Code
 ###############################
@@ -195,25 +221,25 @@ Chef/WhyRunSupportedTrue:
   Enabled: true
   VersionAdded: '5.1.0'
   Include:
-    - '**/resources/.*\.rb'
-    - '**/providers/.*\.rb'
-    - '**/libraries/.*\.rb'
+    - '**/resources/*.rb'
+    - '**/providers/*.rb'
+    - '**/libraries/*.rb'
 
-PropertyWithNameAttribute:
+Chef/PropertyWithNameAttribute:
   Description: Resource property sets name_attribute not name_property
   Enabled: true
   VersionAdded: '5.1.0'
   Include:
-    - '**/resources/.*\.rb'
-    - '**/libraries/.*\.rb'
+    - '**/resources/*.rb'
+    - '**/libraries/*.rb'
 
-PropertyWithRequiredAndDefault:
+Chef/PropertyWithRequiredAndDefault:
   Description: Resource property should not be both required and have a default value
   Enabled: true
   VersionAdded: '5.1.0'
   Include:
-    - '**/resources/.*\.rb'
-    - '**/libraries/.*\.rb'
+    - '**/resources/*.rb'
+    - '**/libraries/*.rb'
 
 Chef/UnnecessaryDependsChef14:
   Description: Don't depend on cookbooks made obsolete by Chef 14
@@ -222,13 +248,81 @@ Chef/UnnecessaryDependsChef14:
   Include:
     - '**/metadata.rb'
 
+Chef/RespondToInMetadata:
+  Description: It is no longer necessary to use respond_to? in metadata.rb in Chef 12.15 and later
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/metadata.rb'
+
+Chef/RespondToResourceName:
+  Description: respond_to?(:resource_name) in resources is no longer necessary in Chef Infra Client 12.5+
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/resources/*.rb'
+    - '**/libraries/*.rb'
+
+Chef/RespondToProvides:
+  Description: respond_to?(:provides) in resources is no longer necessary in Chef Infra Client 12+
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/providers/*.rb'
+    - '**/libraries/*.rb'
+
+Chef/SetOrReturnInResources:
+  Description: Do not use set_or_return within a method to define a property for a resource. Use the property method instead, which supports validation, reporting, and documentation functionality.
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/resources/*.rb'
+    - '**/libraries/*.rb'
+
+Chef/CustomResourceWithAttributes:
+  Description: Custom Resources should contain properties not attributes.
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/resources/*.rb'
+
+Chef/CustomResourceWithAllowedActions:
+  Description: Custom Resources don't need to define the allowed actions with allowed_actions or actions methods
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/resources/*.rb'
+
+###############################
+# Detecting code that breaks Chef
+###############################
+
+Chef/CookbooksDependsOnSelf:
+  Description: A cookbook cannot depend on itself
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/metadata.rb'
+
+Chef/MetadataMissingName:
+  Description: MetadataMissingName
+  Enabled: true
+  VersionAdded: '5.2.0'
+  Include:
+    - '**/metadata.rb'
+
+Chef/BlockGuardWithOnlyString:
+  Description: A resource guard (not_if/only_if) that is a string should not be wrapped in {}. Wrapping a guard string in {} causes it be executed as Ruby code which will always returns true instead of a shell command that will actually run.
+  Enabled: true
+  VersionAdded: '5.2.0'
+
 ###############################
 # Utilize new built-in resources
 ###############################
 
 Chef/UseBuildEssentialResource:
-  Description: Use the build_essential resource instead of the legacy build-essential recipe
-  Enabled: false
+  Description: Use the build_essential resource instead of the legacy build-essential recipe. This resource ships in the build-essential cookbook v5.0+ and is built into Chef Infra Client 14+
+  Enabled: true
   VersionAdded: '5.1.0'
 
 ###############################

data/lib/cookstyle/version.rb

@@ -1,4 +1,4 @@
 module Cookstyle
-  VERSION = "5.1.19".freeze # rubocop: disable Style/StringLiterals
+  VERSION = "5.2.17".freeze # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '0.72.0'.freeze
 end

data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb

@@ -0,0 +1,60 @@
+#
+# Copyright:: Copyright 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      # Use secure Github and Gitlab URLs for source_url and issues_url
+      #
+      # @example
+      #
+      #   # bad
+      #   template '/etc/foo' do
+      #     mode '0644'
+      #     source 'foo.erb'
+      #     only_if { 'test -f /etc/foo' }
+      #   end
+      #
+      #   # good
+      #   template '/etc/foo' do
+      #     mode '0644'
+      #     source 'foo.erb'
+      #     only_if 'test -f /etc/foo'
+      #   end
+      #
+      class BlockGuardWithOnlyString < Cop
+        MSG = 'A resource guard (not_if/only_if) that is a string should not be wrapped in {}. Wrapping a guard string in {} causes it be executed as Ruby code which will always returns true instead of a shell command that will actually run.'.freeze
+
+        def_node_matcher :block_guard_with_only_string?, <<-PATTERN
+          (block (send nil? ${:not_if :only_if}) (args) (str $_) )
+        PATTERN
+
+        def on_block(node)
+          block_guard_with_only_string?(node) do
+            add_offense(node, location: :expression, message: MSG, severity: :refactor)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            new_val = "#{node.method_name} #{node.body.source}"
+            corrector.replace(node.loc.expression, new_val)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb

@@ -0,0 +1,57 @@
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      # Make sure a cookbook doesn't depend on itself
+      #
+      # @example
+      #
+      #   # bad
+      #   name 'foo'
+      #   depends 'foo'
+      #
+      #   # good
+      #   name 'foo'
+      #
+      class CookbooksDependsOnSelf < Cop
+        MSG = 'A cookbook cannot depend on itself'.freeze
+
+        def_node_search :dependencies, '(send nil? :depends str ...)'
+        def_node_matcher :cb_name?, '(send nil? :name str ...)'
+
+        def on_send(node)
+          cb_name?(node) do
+            dependencies(processed_source.ast).each do |dep|
+              if dep.arguments == node.arguments
+                node = dep # set our dependency node as the node for autocorrecting later
+                add_offense(node, location: dep.source_range, message: MSG, severity: :refactor)
+              end
+            end
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.remove(node.source_range)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/invalid_license_string.rb

@@ -0,0 +1,489 @@
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      # metadata.rb license field should include a SPDX compliant string
+      # or "all right reserved" (not case sensitive)
+      #
+      # @example
+      #
+      #   # bad
+      #   license 'Apache 2.0'
+      #
+      #   # good
+      #   license 'Apache-2.0'
+      #   license 'all rights reserved'
+      #
+      # list of valid SPDX.org license strings. To build an array run this:
+      # require 'json'
+      # require 'net/http'
+      # json_data = JSON.parse(Net::HTTP.get(URI('https://raw.githubusercontent.com/spdx/license-list-data/master/json/licenses.json')))
+      # licenses = json_data['licenses'].map {|l| l['licenseId'] }.sort
+      #
+
+      class InvalidLicenseString < Cop
+        VALID_LICENSE_STRING = %w(
+          0BSD
+          AAL
+          ADSL
+          AFL-1.1
+          AFL-1.2
+          AFL-2.0
+          AFL-2.1
+          AFL-3.0
+          AGPL-1.0
+          AGPL-1.0-only
+          AGPL-1.0-or-later
+          AGPL-3.0
+          AGPL-3.0-only
+          AGPL-3.0-or-later
+          AMDPLPA
+          AML
+          AMPAS
+          ANTLR-PD
+          APAFML
+          APL-1.0
+          APSL-1.0
+          APSL-1.1
+          APSL-1.2
+          APSL-2.0
+          Abstyles
+          Adobe-2006
+          Adobe-Glyph
+          Afmparse
+          Aladdin
+          Apache-1.0
+          Apache-1.1
+          Apache-2.0
+          Artistic-1.0
+          Artistic-1.0-Perl
+          Artistic-1.0-cl8
+          Artistic-2.0
+          BSD-1-Clause
+          BSD-2-Clause
+          BSD-2-Clause-FreeBSD
+          BSD-2-Clause-NetBSD
+          BSD-2-Clause-Patent
+          BSD-3-Clause
+          BSD-3-Clause-Attribution
+          BSD-3-Clause-Clear
+          BSD-3-Clause-LBNL
+          BSD-3-Clause-No-Nuclear-License
+          BSD-3-Clause-No-Nuclear-License-2014
+          BSD-3-Clause-No-Nuclear-Warranty
+          BSD-3-Clause-Open-MPI
+          BSD-4-Clause
+          BSD-4-Clause-UC
+          BSD-Protection
+          BSD-Source-Code
+          BSL-1.0
+          Bahyph
+          Barr
+          Beerware
+          BitTorrent-1.0
+          BitTorrent-1.1
+          BlueOak-1.0.0
+          Borceux
+          CATOSL-1.1
+          CC-BY-1.0
+          CC-BY-2.0
+          CC-BY-2.5
+          CC-BY-3.0
+          CC-BY-4.0
+          CC-BY-NC-1.0
+          CC-BY-NC-2.0
+          CC-BY-NC-2.5
+          CC-BY-NC-3.0
+          CC-BY-NC-4.0
+          CC-BY-NC-ND-1.0
+          CC-BY-NC-ND-2.0
+          CC-BY-NC-ND-2.5
+          CC-BY-NC-ND-3.0
+          CC-BY-NC-ND-4.0
+          CC-BY-NC-SA-1.0
+          CC-BY-NC-SA-2.0
+          CC-BY-NC-SA-2.5
+          CC-BY-NC-SA-3.0
+          CC-BY-NC-SA-4.0
+          CC-BY-ND-1.0
+          CC-BY-ND-2.0
+          CC-BY-ND-2.5
+          CC-BY-ND-3.0
+          CC-BY-ND-4.0
+          CC-BY-SA-1.0
+          CC-BY-SA-2.0
+          CC-BY-SA-2.5
+          CC-BY-SA-3.0
+          CC-BY-SA-4.0
+          CC-PDDC
+          CC0-1.0
+          CDDL-1.0
+          CDDL-1.1
+          CDLA-Permissive-1.0
+          CDLA-Sharing-1.0
+          CECILL-1.0
+          CECILL-1.1
+          CECILL-2.0
+          CECILL-2.1
+          CECILL-B
+          CECILL-C
+          CERN-OHL-1.1
+          CERN-OHL-1.2
+          CNRI-Jython
+          CNRI-Python
+          CNRI-Python-GPL-Compatible
+          CPAL-1.0
+          CPL-1.0
+          CPOL-1.02
+          CUA-OPL-1.0
+          Caldera
+          ClArtistic
+          Condor-1.1
+          Crossword
+          CrystalStacker
+          Cube
+          D-FSL-1.0
+          DOC
+          DSDP
+          Dotseqn
+          ECL-1.0
+          ECL-2.0
+          EFL-1.0
+          EFL-2.0
+          EPL-1.0
+          EPL-2.0
+          EUDatagrid
+          EUPL-1.0
+          EUPL-1.1
+          EUPL-1.2
+          Entessa
+          ErlPL-1.1
+          Eurosym
+          FSFAP
+          FSFUL
+          FSFULLR
+          FTL
+          Fair
+          Frameworx-1.0
+          FreeImage
+          GFDL-1.1
+          GFDL-1.1-only
+          GFDL-1.1-or-later
+          GFDL-1.2
+          GFDL-1.2-only
+          GFDL-1.2-or-later
+          GFDL-1.3
+          GFDL-1.3-only
+          GFDL-1.3-or-later
+          GL2PS
+          GPL-1.0
+          GPL-1.0+
+          GPL-1.0-only
+          GPL-1.0-or-later
+          GPL-2.0
+          GPL-2.0+
+          GPL-2.0-only
+          GPL-2.0-or-later
+          GPL-2.0-with-GCC-exception
+          GPL-2.0-with-autoconf-exception
+          GPL-2.0-with-bison-exception
+          GPL-2.0-with-classpath-exception
+          GPL-2.0-with-font-exception
+          GPL-3.0
+          GPL-3.0+
+          GPL-3.0-only
+          GPL-3.0-or-later
+          GPL-3.0-with-GCC-exception
+          GPL-3.0-with-autoconf-exception
+          Giftware
+          Glide
+          Glulxe
+          HPND
+          HPND-sell-variant
+          HaskellReport
+          IBM-pibs
+          ICU
+          IJG
+          IPA
+          IPL-1.0
+          ISC
+          ImageMagick
+          Imlib2
+          Info-ZIP
+          Intel
+          Intel-ACPI
+          Interbase-1.0
+          JPNIC
+          JSON
+          JasPer-2.0
+          LAL-1.2
+          LAL-1.3
+          LGPL-2.0
+          LGPL-2.0+
+          LGPL-2.0-only
+          LGPL-2.0-or-later
+          LGPL-2.1
+          LGPL-2.1+
+          LGPL-2.1-only
+          LGPL-2.1-or-later
+          LGPL-3.0
+          LGPL-3.0+
+          LGPL-3.0-only
+          LGPL-3.0-or-later
+          LGPLLR
+          LPL-1.0
+          LPL-1.02
+          LPPL-1.0
+          LPPL-1.1
+          LPPL-1.2
+          LPPL-1.3a
+          LPPL-1.3c
+          Latex2e
+          Leptonica
+          LiLiQ-P-1.1
+          LiLiQ-R-1.1
+          LiLiQ-Rplus-1.1
+          Libpng
+          Linux-OpenIB
+          MIT
+          MIT-0
+          MIT-CMU
+          MIT-advertising
+          MIT-enna
+          MIT-feh
+          MITNFA
+          MPL-1.0
+          MPL-1.1
+          MPL-2.0
+          MPL-2.0-no-copyleft-exception
+          MS-PL
+          MS-RL
+          MTLL
+          MakeIndex
+          MirOS
+          Motosoto
+          Multics
+          Mup
+          NASA-1.3
+          NBPL-1.0
+          NCSA
+          NGPL
+          NLOD-1.0
+          NLPL
+          NOSL
+          NPL-1.0
+          NPL-1.1
+          NPOSL-3.0
+          NRL
+          NTP
+          Naumen
+          Net-SNMP
+          NetCDF
+          Newsletr
+          Nokia
+          Noweb
+          Nunit
+          OCCT-PL
+          OCLC-2.0
+          ODC-By-1.0
+          ODbL-1.0
+          OFL-1.0
+          OFL-1.1
+          OGL-UK-1.0
+          OGL-UK-2.0
+          OGL-UK-3.0
+          OGTSL
+          OLDAP-1.1
+          OLDAP-1.2
+          OLDAP-1.3
+          OLDAP-1.4
+          OLDAP-2.0
+          OLDAP-2.0.1
+          OLDAP-2.1
+          OLDAP-2.2
+          OLDAP-2.2.1
+          OLDAP-2.2.2
+          OLDAP-2.3
+          OLDAP-2.4
+          OLDAP-2.5
+          OLDAP-2.6
+          OLDAP-2.7
+          OLDAP-2.8
+          OML
+          OPL-1.0
+          OSET-PL-2.1
+          OSL-1.0
+          OSL-1.1
+          OSL-2.0
+          OSL-2.1
+          OSL-3.0
+          OpenSSL
+          PDDL-1.0
+          PHP-3.0
+          PHP-3.01
+          Parity-6.0.0
+          Plexus
+          PostgreSQL
+          Python-2.0
+          QPL-1.0
+          Qhull
+          RHeCos-1.1
+          RPL-1.1
+          RPL-1.5
+          RPSL-1.0
+          RSA-MD
+          RSCPL
+          Rdisc
+          Ruby
+          SAX-PD
+          SCEA
+          SGI-B-1.0
+          SGI-B-1.1
+          SGI-B-2.0
+          SHL-0.5
+          SHL-0.51
+          SISSL
+          SISSL-1.2
+          SMLNJ
+          SMPPL
+          SNIA
+          SPL-1.0
+          SSPL-1.0
+          SWL
+          Saxpath
+          Sendmail
+          Sendmail-8.23
+          SimPL-2.0
+          Sleepycat
+          Spencer-86
+          Spencer-94
+          Spencer-99
+          StandardML-NJ
+          SugarCRM-1.1.3
+          TAPR-OHL-1.0
+          TCL
+          TCP-wrappers
+          TMate
+          TORQUE-1.1
+          TOSL
+          TU-Berlin-1.0
+          TU-Berlin-2.0
+          UPL-1.0
+          Unicode-DFS-2015
+          Unicode-DFS-2016
+          Unicode-TOU
+          Unlicense
+          VOSTROM
+          VSL-1.0
+          Vim
+          W3C
+          W3C-19980720
+          W3C-20150513
+          WTFPL
+          Watcom-1.0
+          Wsuipa
+          X11
+          XFree86-1.1
+          XSkat
+          Xerox
+          Xnet
+          YPL-1.0
+          YPL-1.1
+          ZPL-1.1
+          ZPL-2.0
+          ZPL-2.1
+          Zed
+          Zend-2.0
+          Zimbra-1.3
+          Zimbra-1.4
+          Zlib
+          blessing
+          bzip2-1.0.5
+          bzip2-1.0.6
+          copyleft-next-0.3.0
+          copyleft-next-0.3.1
+          curl
+          diffmark
+          dvipdfm
+          eCos-2.0
+          eGenix
+          gSOAP-1.3b
+          gnuplot
+          iMatix
+          libpng-2.0
+          libtiff
+          mpich2
+          psfrag
+          psutils
+          wxWindows
+          xinetd
+          xpp
+          zlib-acknowledgement
+        ).freeze
+
+        COMMON_TYPOS = {
+          "all_rights": 'all rights reserved',
+          "apache 2.0": 'Apache-2.0',
+          "apache license version 2.0": 'Apache-2.0',
+          "apache2": 'Apache-2.0',
+          "mit": 'MIT',
+          '3-clause bsd': 'BSD-3-Clause',
+          'gnu public license 3.0': 'GPL-3.0',
+          'gpl v2': 'GPL-2.0',
+          'gpl v3': 'GPL-3.0',
+          'gplv2': 'GPL-2.0',
+          'gplv3': 'GPL-3.0',
+          'mit license': 'MIT',
+        }.freeze
+
+        MSG = 'Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers.'.freeze
+
+        def_node_matcher :license?, '(send nil? :license $str ...)'
+
+        def on_send(node)
+          license?(node) do |license|
+            unless valid_license?(license.str_content)
+              add_offense(license, location: :expression, message: MSG, severity: :refactor)
+            end
+          end
+        end
+
+        def autocorrect(node)
+          correct_string = autocorrect_license_string(node.str_content)
+          if correct_string
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, "'#{correct_string}'")
+            end
+          end
+        end
+
+        # private
+
+        def autocorrect_license_string(bad_string)
+          COMMON_TYPOS[bad_string.delete(',').downcase.to_sym]
+        end
+
+        def valid_license?(license)
+          VALID_LICENSE_STRING.include?(license) ||
+            license.downcase == 'all rights reserved'
+        end
+      end
+    end
+  end
+end