cookstyle 5.1.19 → 5.2.17

data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb

@@ -0,0 +1,66 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      # In HWRPs and LWRPs you defined attributes, but custom resources changed the name to
+      # be properties to avoid confusion with chef recipe attributes. When writing a custom resource
+      # they should be called properties even though the two are aliased.
+      #
+      # @example
+      #
+      #   # bad
+      #   attribute :something, String
+      #
+      #   action :create do
+      #     # some action code because we're in a custom resource
+      #   end
+      #
+      #   # good
+      #   property :something, String
+      #
+      #   action :create do
+      #     # some action code because we're in a custom resource
+      #   end
+      #
+      class CustomResourceWithAttributes < Cop
+        MSG = 'Custom Resources should contain properties not attributes'.freeze
+
+        def_node_matcher :attribute?, <<-PATTERN
+          (send nil? $:attribute ... )
+        PATTERN
+
+        def_node_search :resource_actions?, <<-PATTERN
+          (block (send nil? :action ... ) ... )
+        PATTERN
+
+        def on_send(node)
+          attribute?(node) do
+            add_offense(node, location: :selector, message: MSG, severity: :refactor) if resource_actions?(processed_source.ast)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.loc.selector, 'property')
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb

@@ -0,0 +1,52 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      # It is not longer necessary respond_to?(:foo) in metadata. This was used to support new metadata
+      # methods in Chef 11 and early versions of Chef 12.
+      #
+      # @example
+      #
+      #   # bad
+      #   provides :foo if respond_to?(:provides)
+      #
+      #   # good
+      #   provides :foo
+      #
+      class RespondToProvides < Cop
+        MSG = 'respond_to?(:provides) in resources is no longer necessary in Chef Infra Client 12+'.freeze
+
+        def on_if(node)
+          if_respond_to_provides?(node) do
+            add_offense(node, location: :expression, message: MSG, severity: :refactor)
+          end
+        end
+
+        def_node_matcher :if_respond_to_provides?, <<~PATTERN
+        (if (send nil? :respond_to? ( :sym :provides ) ) ... )
+        PATTERN
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.loc.expression, node.children[1].source)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb

@@ -0,0 +1,53 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      # Chef 12.5 introduced the resource_name method for resources. Many cookbooks used
+      # respond_to?(:resource_name) to provide backwards compatibility with older chef-client
+      # releases. This backwards compatibility is no longer necessary.
+      #
+      # @example
+      #
+      #   # bad
+      #   resource_name :foo if respond_to?(:resource_name)
+      #
+      #   # good
+      #   resource_name :foo
+      #
+      class RespondToResourceName < Cop
+        MSG = 'respond_to?(:resource_name) in resources is no longer necessary in Chef Infra Client 12.5+'.freeze
+
+        def on_if(node)
+          if_respond_to_resource_name?(node) do
+            add_offense(node, location: :expression, message: MSG, severity: :refactor)
+          end
+        end
+
+        def_node_matcher :if_respond_to_resource_name?, <<~PATTERN
+        (if (send nil? :respond_to? ( :sym :resource_name ) ) ... )
+        PATTERN
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.loc.expression, node.children[1].source)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 5.1.19
+  version: 5.2.17
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-08 00:00:00.000000000 Z
+date: 2019-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -74,7 +74,12 @@ files:
 - lib/cookstyle/version.rb
 - lib/rubocop/chef.rb
 - lib/rubocop/chef/cookbook_only.rb
+- lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb
+- lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
 - lib/rubocop/cop/chef/correctness/insecure_cookbook_url.rb
+- lib/rubocop/cop/chef/correctness/invalid_license_string.rb
+- lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb
+- lib/rubocop/cop/chef/correctness/metadata_missing_name.rb
 - lib/rubocop/cop/chef/correctness/name_property_and_required.rb
 - lib/rubocop/cop/chef/correctness/node_normal.rb
 - lib/rubocop/cop/chef/correctness/node_normal_unless.rb
@@ -90,16 +95,24 @@ files:
 - lib/rubocop/cop/chef/deprecation/easy_install.rb
 - lib/rubocop/cop/chef/deprecation/epic_fail.rb
 - lib/rubocop/cop/chef/deprecation/erl_call.rb
+- lib/rubocop/cop/chef/deprecation/long_description_metadata.rb
 - lib/rubocop/cop/chef/deprecation/node_set.rb
 - lib/rubocop/cop/chef/deprecation/node_set_unless.rb
 - lib/rubocop/cop/chef/deprecation/provides_metadata.rb
 - lib/rubocop/cop/chef/deprecation/replaces_metadata.rb
+- lib/rubocop/cop/chef/deprecation/require_recipe.rb
+- lib/rubocop/cop/chef/deprecation/respond_to_metadata.rb
 - lib/rubocop/cop/chef/deprecation/suggests_metadata.rb
 - lib/rubocop/cop/chef/effortless/data_bags.rb
 - lib/rubocop/cop/chef/effortless/search_used.rb
 - lib/rubocop/cop/chef/modernize/berksfile_source.rb
 - lib/rubocop/cop/chef/modernize/build_essential.rb
 - lib/rubocop/cop/chef/modernize/chef_14_resources.rb
+- lib/rubocop/cop/chef/modernize/resource_set_or_return.rb
+- lib/rubocop/cop/chef/modernize/resource_with_allowed_action.rb
+- lib/rubocop/cop/chef/modernize/resource_with_attributes.rb
+- lib/rubocop/cop/chef/modernize/respond_to_provides.rb
+- lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb
 - lib/rubocop/cop/chef/modernize/why_run_supported_true.rb
 - lib/rubocop/cop/chef/style/attribute_keys.rb
 - lib/rubocop/cop/chef/style/comment_sentence_spacing.rb