cookstyle 8.7.6 → 9.0.0

data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb

@@ -38,7 +38,7 @@ module RuboCop
           def_node_matcher :chef_platform_windows?, <<-PATTERN
             (send
               (const
-                (const nil? :Chef) :Platform) :windows?)
+                (const {nil? cbase} :Chef) :Platform) :windows?)
           PATTERN
 
           def on_send(node)

data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb

@@ -41,10 +41,10 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:chocolatey_package, 'action', node) do |choco_action|
-              choco_action.arguments.each do |action|
-                next unless action.source == ':uninstall'
+              each_action_symbol(choco_action) do |action, prefix|
+                next unless action.value == :uninstall
                 add_offense(action, severity: :warning) do |corrector|
-                  corrector.replace(action, ':remove')
+                  corrector.replace(action, "#{prefix}remove")
                 end
               end
             end

data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb

@@ -26,6 +26,10 @@ module RuboCop
         #   # bad
         #   depends 'partial_search'
         #
+        #   # good
+        #   # the built-in search helper takes a filter_result option
+        #   search(:node, 'role:web', filter_result: { 'name' => ['name'], 'ip' => ['ipaddress'] })
+        #
         class CookbookDependsOnPartialSearch < Base
           extend TargetChefVersion
 

data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb

@@ -41,11 +41,11 @@ module RuboCop
           RESTRICT_ON_SEND = [:include, :require].freeze
 
           def_node_matcher :deprecated_mixin?, <<-PATTERN
-            (send nil? :include (const (const (const nil? :Chef) :Mixin) { :Language :LanguageIncludeAttribute :RecipeDefinitionDSLCore :LanguageIncludeRecipe }))
+            (send nil? :include (const (const (const {nil? cbase} :Chef) :Mixin) { :Language :LanguageIncludeAttribute :RecipeDefinitionDSLCore :LanguageIncludeRecipe }))
           PATTERN
 
           def_node_matcher :deprecated_dsl?, <<-PATTERN
-            (send nil? :include (const (const (const (const nil? :Chef) :DSL) :Recipe) :FullDSL))
+            (send nil? :include (const (const (const (const {nil? cbase} :Chef) :DSL) :Recipe) :FullDSL))
           PATTERN
 
           def_node_matcher :dsl_mixin_require?, <<-PATTERN

data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb

@@ -78,8 +78,8 @@ module RuboCop
         #     end
         #   end
         #
-        #  # better
-        #  Convert your legacy HWRPs to custom resources
+        #   # better
+        #   # Convert your legacy HWRPs to custom resources
         #
         class HWRPWithoutProvides < Base
           extend AutoCorrector
@@ -94,8 +94,8 @@ module RuboCop
               $(class
                 (const nil? ... )
                 (const
-                  (const nil? :Chef) :Resource)
-                  (begin ... ))))
+                  (const {nil? cbase} :Chef) :Resource)
+                  ...)))
           PATTERN
 
           def_node_search :provides, '(send nil? :provides (sym $_) ...)'

data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb

@@ -67,8 +67,8 @@ module RuboCop
               $(class
                 (const nil? ... )
                 (const
-                  (const nil? :Chef) :Resource)
-                  (begin ... ))))
+                  (const {nil? cbase} :Chef) :Resource)
+                  ...)))
           PATTERN
 
           def_node_search :unified_mode?, '(send nil? :unified_mode ...)'

data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb

@@ -33,8 +33,8 @@ module RuboCop
         #     # some resource code
         #   end
         #
-        #  # better
-        #  Write a custom resource using the custom resource DSL and avoid class based HWRPs entirely
+        #   # better
+        #   # Write a custom resource using the custom resource DSL and avoid class based HWRPs entirely
         #
         class ResourceInheritsFromCompatResource < Base
           extend AutoCorrector
@@ -42,7 +42,7 @@ module RuboCop
           MSG = "HWRP style resource should inherit from the 'Chef::Resource' class and not the 'ChefCompat::Resource' class from the deprecated compat_resource cookbook."
 
           def_node_matcher :inherits_from_compat_resource?, <<-PATTERN
-          (class (const nil? _ ) (const (const nil? :ChefCompat) :Resource) ... )
+          (class (const nil? _ ) (const (const {nil? cbase} :ChefCompat) :Resource) ... )
           PATTERN
 
           def on_class(node)

data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb

@@ -33,12 +33,20 @@ module RuboCop
         #   include_recipe 'yum::repoforge'
         #   include_recipe 'yum::yum'
         #
+        #   # good
+        #   include_recipe 'yum-elrepo'
+        #   include_recipe 'yum-epel'
+        #   include_recipe 'yum-ius'
+        #   include_recipe 'yum-remi'
+        #   include_recipe 'yum-repoforge'
+        #   include_recipe 'yum'
+        #
         class LegacyYumCookbookRecipes < Base
           MSG = 'The elrepo, epel, ius, remi, and repoforge recipes were split into their own cookbooks and the yum recipe was renamed to be default with the release of yum cookbook 3.0 (Dec 2013).'
           RESTRICT_ON_SEND = [:include_recipe].freeze
 
           def_node_matcher :old_yum_recipe?, <<-PATTERN
-            (send nil? :include_recipe (str {"yum::elrepo" "yum::epel" "yum::ius" "yum::remi" "yum::repoforge" "yum::yum"}))
+            (send {nil? (send nil? :run_context)} :include_recipe (str {"yum::elrepo" "yum::epel" "yum::ius" "yum::remi" "yum::repoforge" "yum::yum"}))
           PATTERN
 
           def on_send(node)

data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb

@@ -29,6 +29,11 @@ module RuboCop
         #     lc_all 'en_gb.utf-8'
         #   end
         #
+        #   # good
+        #   locale 'set locale' do
+        #     lang 'en_gb.utf-8'
+        #   end
+        #
         class LocaleDeprecatedLcAllProperty < Base
           include RuboCop::Chef::CookbookHelpers
 

data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb

@@ -24,9 +24,17 @@ module RuboCop
         # @example
         #
         #   # bad
-        #   mycookbook/resources/myresource.rb:
+        #   # mycookbook/resources/myresource.rb
         #   resource_name :mycookbook_myresource
         #
+        #   # good
+        #   # mycookbook/resources/myresource.rb
+        #   provides :mycookbook_myresource
+        #
+        #   # or, to also support Chef Infra Client < 16
+        #   resource_name :mycookbook_myresource
+        #   provides :mycookbook_myresource
+        #
         class ResourceUsesOnlyResourceName < Base
           include RuboCop::Chef::CookbookHelpers
           include RangeHelp

data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb

@@ -26,6 +26,10 @@ module RuboCop
         #   # bad
         #   provider_base ::Chef::Provider::SomethingSomething
         #
+        #   # good
+        #   # in the provider, register itself for the resource
+        #   provides :something_something
+        #
         class ResourceUsesProviderBaseMethod < Base
           MSG = "Don't use the deprecated provider_base method in a resource to specify the provider module to use. Instead, the provider should call provides to register itself, or the resource should call provider to specify the provider to use. This will cause failures in Chef Infra Client 13 and later."
           RESTRICT_ON_SEND = [:provider_base].freeze

data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb

@@ -31,6 +31,11 @@ module RuboCop
         #     action :create
         #   end
         #
+        #   # bad
+        #   template '/etc/foo.conf' do
+        #     notifies :create, 'ruby_block[my special ruby block]', :immediately
+        #   end
+        #
         #   # good
         #   ruby_block 'my special ruby block' do
         #     block do
@@ -39,22 +44,56 @@ module RuboCop
         #     action :run
         #   end
         #
+        #   # good
+        #   template '/etc/foo.conf' do
+        #     notifies :run, 'ruby_block[my special ruby block]', :immediately
+        #   end
+        #
         class RubyBlockCreateAction < Base
           include RuboCop::Chef::CookbookHelpers
           extend AutoCorrector
 
           MSG = 'Use the :run action in the ruby_block resource instead of the deprecated :create action'
+          RESTRICT_ON_SEND = [:notifies, :subscribes].freeze
+
+          def_node_matcher :notification?, <<-PATTERN
+            (send nil? {:notifies :subscribes} $(sym :create) ${str dstr} ...)
+          PATTERN
 
           def on_block(node)
             match_property_in_resource?(:ruby_block, 'action', node) do |ruby_action|
-              ruby_action.arguments.each do |action|
-                next unless action.source == ':create'
+              each_action_symbol(ruby_action) do |action, prefix|
+                next unless action.value == :create
                 add_offense(action, severity: :warning) do |corrector|
-                  corrector.replace(action, ':run')
+                  corrector.replace(action, "#{prefix}run")
                 end
               end
             end
           end
+
+          def on_send(node)
+            notification?(node) do |action, notified_resource|
+              next unless ruby_block?(notified_resource)
+
+              add_offense(action, severity: :warning) do |corrector|
+                corrector.replace(action, ':run')
+              end
+            end
+          end
+
+          private
+
+          # Does the notified resource string address a ruby_block? An interpolated name
+          # ("ruby_block[#{foo}]") still starts with a literal segment we can key off of, but a
+          # string whose resource type is itself interpolated tells us nothing, so we skip it.
+          #
+          # @param [RuboCop::AST::Node] node the str or dstr the notification points at
+          #
+          # @return [Boolean]
+          def ruby_block?(node)
+            literal = node.str_type? ? node : node.children.first
+            literal&.str_type? && literal.value.start_with?('ruby_block[')
+          end
         end
       end
     end

data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb

@@ -33,6 +33,15 @@ module RuboCop
         #     end
         #   end
         #
+        #   # good
+        #   module MyCookbook
+        #     class MyCookbookService < Chef::Resource
+        #       provides :mycookbook_service
+        #
+        #       # some additional code
+        #     end
+        #   end
+        #
         class UseAutomaticResourceName < Base
           extend RuboCop::Cop::AutoCorrector
           include RangeHelp

data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb

@@ -36,6 +36,11 @@ module RuboCop
           RESTRICT_ON_SEND = [:to_yaml].freeze
 
           def on_send(node)
+            # A receiverless to_yaml is a call to a locally defined method rather than
+            # the Ruby stdlib conversion this cop is about, and there's nothing to pass
+            # to YAML.dump. Bail out rather than dereferencing a nil receiver.
+            return unless node.receiver
+
             add_offense(node, severity: :warning) do |corrector|
               corrector.replace(node, "YAML.dump(#{node.receiver.source})")
             end

data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb

@@ -26,6 +26,10 @@ module RuboCop
         #   # bad
         #   include_recipe 'xml::ruby'
         #
+        #   # good
+        #   # nokogiri ships with Chef Infra Client, so just require it
+        #   require 'nokogiri'
+        #
         class IncludingXMLRubyRecipe < Base
           extend AutoCorrector
 
@@ -33,7 +37,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:include_recipe].freeze
 
           def_node_matcher :xml_ruby_recipe?, <<-PATTERN
-            (send nil? :include_recipe (str "xml::ruby"))
+            (send {nil? (send nil? :run_context)} :include_recipe (str "xml::ruby"))
           PATTERN
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb

@@ -39,7 +39,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:include_recipe].freeze
 
           def_node_matcher :apt_recipe_usage?, <<-PATTERN
-            (send nil? :include_recipe (str {"apt" "apt::default"}))
+            (send {nil? (send nil? :run_context)} :include_recipe (str {"apt" "apt::default"}))
           PATTERN
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/build_essential.rb

@@ -27,6 +27,7 @@ module RuboCop
         #   depends 'build-essential'
         #   include_recipe 'build-essential::default'
         #   include_recipe 'build-essential'
+        #   run_context.include_recipe 'build-essential::default'
         #
         #   # good
         #   build_essential 'install compilation tools'
@@ -37,8 +38,10 @@ module RuboCop
           MSG = 'Use the build_essential resource instead of the legacy build-essential recipe. This resource ships in the build-essential cookbook v5.0+ and is built into Chef Infra Client 14+'
           RESTRICT_ON_SEND = [:include_recipe].freeze
 
+          # matches a bare include_recipe as well as the run_context.include_recipe form used from
+          # libraries and custom resources
           def_node_matcher :build_essential_recipe_usage?, <<-PATTERN
-            (send nil? :include_recipe (str {"build-essential" "build-essential::default"}))
+            (send {nil? (send nil? :run_context)} :include_recipe (str {"build-essential" "build-essential::default"}))
           PATTERN
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb

@@ -32,6 +32,14 @@ module RuboCop
         #   depends 'swap'
         #   depends 'sysctl'
         #
+        #   # good
+        #   # the resources ship in Chef Infra Client 14+, so use them without a depends
+        #   build_essential 'install compilation tools'
+        #
+        #   sysctl 'vm.swappiness' do
+        #     value 10
+        #   end
+        #
         class UnnecessaryDependsChef14 < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb

@@ -29,6 +29,17 @@ module RuboCop
         #   depends 'windows_uac'
         #   depends 'windows_dfs'
         #
+        #   # good
+        #   # the resources ship in Chef Infra Client 15+, so use them without a depends
+        #   archive_file 'expand website' do
+        #     path '/tmp/site.zip'
+        #     destination '/var/www/html'
+        #   end
+        #
+        #   windows_uac 'set uac' do
+        #     enable_uac true
+        #   end
+        #
         class UnnecessaryDependsChef15 < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb

@@ -26,6 +26,10 @@ module RuboCop
         #   # bad
         #   chef_gem 'nokogiri'
         #
+        #   # good
+        #   # nokogiri ships with Chef Infra Client, so just require it
+        #   require 'nokogiri'
+        #
         class ChefGemNokogiri < Base
           extend AutoCorrector
           include RangeHelp

data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb

@@ -19,20 +19,27 @@ module RuboCop
   module Cop
     module Chef
       module Modernize
-        # Use ::File.exist?('/foo/bar') instead of the slower 'test -f /foo/bar' which requires shelling out
+        # Use `::File.exist?('/foo/bar')` in an `only_if` or `not_if` guard instead of the slower `'test -f /foo/bar'`, which requires shelling out. The Ruby check has to be passed as a block. Passing it directly, as `not_if ::File.exist?('/foo/bar')`, raises `ArgumentError: Invalid only_if/not_if command, expected a string`.
         #
         # @example
         #
         #   # bad
         #   only_if 'test -f /bin/foo'
+        #   not_if 'test -f /bin/foo'
+        #
+        #   # bad - a Ruby guard has to be a block, this raises at converge time
+        #   only_if ::File.exist?('/bin/foo')
         #
         #   # good
         #   only_if { ::File.exist?('/bin/foo') }
+        #   not_if { ::File.exist?('/bin/foo') }
         #
         class ConditionalUsingTest < Base
           extend AutoCorrector
 
-          MSG = "Use ::File.exist?('/foo/bar') instead of the slower 'test -f /foo/bar' which requires shelling out"
+          # %{guard} is the guard the offense was found on, so that a not_if offense isn't told to
+          # use an only_if, which would invert the condition
+          MSG = "Use %{guard} { ::File.exist?('/foo/bar') } instead of the slower %{guard} 'test -f /foo/bar' which requires shelling out"
           RESTRICT_ON_SEND = [:not_if, :only_if].freeze
 
           def_node_matcher :resource_conditional?, <<~PATTERN
@@ -42,7 +49,7 @@ module RuboCop
           def on_send(node)
             resource_conditional?(node) do |conditional|
               return unless conditional.value.match?(/^test -[ef] \S*$/)
-              add_offense(node, severity: :refactor) do |corrector|
+              add_offense(node, message: format(MSG, guard: node.method_name), severity: :refactor) do |corrector|
                 new_string = "{ ::File.exist?('#{conditional.value.match(/^test -[ef] (\S*)$/)[1]}') }"
                 corrector.replace(conditional, new_string)
               end

data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb

@@ -106,11 +106,13 @@ module RuboCop
             end
 
             match_property_in_resource?(%i(template file cookbook_file), 'path', node) do |code_property|
-              # instead of using CookbookHelpers#method_arg_ast_to_string, walk the property's descendants
-              # and check if their value contains '/etc/cron.d'
+              # instead of using CookbookHelpers#method_arg_ast_to_string, walk the property's string
+              # descendants and check if their value contains '/etc/cron.d'
               # covers the case where the argument to the path property is provided via a method like File.join
-              code_property.each_descendant do |d|
-                add_offense(node, severity: :refactor) if d.respond_to?(:value) && d.value.match?(%r{/etc/cron\.d\b}i)
+              # only string nodes are walked: other literals respond to #value too, but return types
+              # like Integer that have no #match?, which raised inside the cop (issue #957)
+              code_property.each_descendant(:str) do |d|
+                add_offense(node, severity: :refactor) if d.value.match?(%r{/etc/cron\.d\b}i)
               end
             end
           end

data/lib/rubocop/cop/chef/modernize/databag_helpers.rb

@@ -40,15 +40,18 @@ module RuboCop
           def_node_matcher :data_bag_class_load?, <<-PATTERN
           (send
             (const
-              (const nil? :Chef) {:DataBagItem :EncryptedDataBagItem}) :load
+              (const {nil? cbase} :Chef) {:DataBagItem :EncryptedDataBagItem}) :load
               ...)
           PATTERN
 
           def on_send(node)
             data_bag_class_load?(node) do
               add_offense(node, severity: :refactor) do |corrector|
-                corrector.replace(node,
-                   node.source.gsub(/Chef::(EncryptedDataBagItem|DataBagItem).load/, 'data_bag_item'))
+                # replace only the receiver and the .load selector, so that the arguments are left
+                # exactly as written. rewriting node.source would also hit any argument that
+                # happened to contain the class name, and would leave the leading :: of a scope
+                # resolved ::Chef::DataBagItem.load behind
+                corrector.replace(node.receiver.source_range.join(node.loc.selector), 'data_bag_item')
               end
             end
           end

data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb

@@ -26,6 +26,10 @@ module RuboCop
         #   # bad
         #   depends 'chef-vault'
         #
+        #   # good
+        #   # the chef-vault helpers ship in Chef Infra Client 16+, so use them without a depends
+        #   chef_vault_item('secrets', 'my_secret')
+        #
         class DependsOnChefVaultCookbook < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb

@@ -27,6 +27,13 @@ module RuboCop
         #   depends 'chocolatey_source'
         #   depends 'chocolatey_config'
         #
+        #   # good
+        #   # the resources ship in Chef Infra Client 14.3+, so use them without a depends
+        #   chocolatey_source 'internal' do
+        #     source 'https://mycorp.example/nuget'
+        #     action :add
+        #   end
+        #
         class DependsOnChocolateyCookbooks < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb

@@ -26,6 +26,12 @@ module RuboCop
         #   # bad
         #   depends 'kernel_module'
         #
+        #   # good
+        #   # the resource ships in Chef Infra Client 14.3+, so use it without a depends
+        #   kernel_module 'loop' do
+        #     action :install
+        #   end
+        #
         class DependsOnKernelModuleCookbook < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb

@@ -26,6 +26,12 @@ module RuboCop
         #   # bad
         #   depends 'locale'
         #
+        #   # good
+        #   # the resource ships in Chef Infra Client 14.5+, so use it without a depends
+        #   locale 'set locale' do
+        #     lang 'en_us.UTF-8'
+        #   end
+        #
         class DependsOnLocaleCookbook < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb

@@ -26,6 +26,15 @@ module RuboCop
         #   # bad
         #   depends 'openssl'
         #
+        #   # good
+        #   # the openssl_* resources ship in Chef Infra Client 14.4+, so use them without a depends
+        #   openssl_x509_certificate '/etc/httpd/ssl/mycert.pem' do
+        #     common_name 'www.example.com'
+        #     org 'Example Inc'
+        #     org_unit 'IT'
+        #     country 'US'
+        #   end
+        #
         class DependsOnOpensslCookbook < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb

@@ -26,6 +26,10 @@ module RuboCop
         #   # bad
         #   depends 'timezone_lwrp'
         #
+        #   # good
+        #   # the resource ships in Chef Infra Client 14.6+, so use it without a depends
+        #   timezone 'UTC'
+        #
         class DependsOnTimezoneLwrpCookbook < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb

@@ -26,6 +26,14 @@ module RuboCop
         #   # bad
         #   depends 'windows_firewall'
         #
+        #   # good
+        #   # the resource ships in Chef Infra Client 14.7+, so use it without a depends
+        #   windows_firewall_rule 'permit ssh' do
+        #     local_port '22'
+        #     protocol 'TCP'
+        #     firewall_action :allow
+        #   end
+        #
         class DependsOnWindowsFirewallCookbook < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb

@@ -26,6 +26,13 @@ module RuboCop
         #   # bad
         #   depends 'zypper'
         #
+        #   # good
+        #   # the resource ships in Chef Infra Client 13.3+, so use it without a depends
+        #   zypper_repository 'apache' do
+        #     baseurl 'https://download.opensuse.org/repositories/Apache'
+        #     action :add
+        #   end
+        #
         class DependsOnZypperCookbook < Base
           extend AutoCorrector
           extend TargetChefVersion

data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb

@@ -38,7 +38,7 @@ module RuboCop
           (send nil? :include
             (const
               (const
-                (const nil? :Chef) :DSL) {:Recipe :IncludeRecipe}))
+                (const {nil? cbase} :Chef) :DSL) {:Recipe :IncludeRecipe}))
           PATTERN
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb

@@ -53,8 +53,10 @@ module RuboCop
             (send nil? :execute (str { "apt-get update" "apt-get update -y" "apt-get -y update" }))
           PATTERN
 
+          # the notification timing is optional and defaults to :delayed, so the trailing
+          # argument is matched with ... rather than being required
           def_node_matcher :notification_property?, <<-PATTERN
-            (send nil? {:notifies :subscribes} (sym _) $(...) (sym _))
+            (send nil? {:notifies :subscribes} (sym _) $(...) ...)
           PATTERN
 
           def_node_matcher :execute_command?, <<-PATTERN