cookstyle 8.5.2 → 8.6.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/config/chefstyle.yml +11 -3
- data/config/cookstyle.yml +159 -151
- data/cookstyle.gemspec +1 -1
- data/lib/cookstyle/version.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +3 -3
- data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/empty_resource_guard.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +3 -3
- data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/node_normal.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/node_save.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +4 -4
- data/lib/rubocop/cop/chef/correctness/property_without_type.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/tmp_path.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/erl_call.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +8 -8
- data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +3 -2
- data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +8 -10
- data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +6 -6
- data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_environment.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_roles.rb +2 -2
- data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/build_essential.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +5 -5
- data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +6 -6
- data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +4 -4
- data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +14 -14
- data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +4 -4
- data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +3 -3
- data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -2
- data/lib/rubocop/cop/chef/security/ssh_private_key.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +4 -3
- data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +4 -4
- data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +288 -11
- data/lib/rubocop/cop/chef/style/attribute_keys.rb +4 -4
- data/lib/rubocop/cop/chef/style/chef_whaaat.rb +2 -2
- data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +2 -2
- data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +2 -2
- data/lib/rubocop/cop/chef/style/comments_format.rb +2 -2
- data/lib/rubocop/cop/chef/style/file_mode.rb +2 -2
- data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +2 -2
- data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +2 -2
- data/lib/rubocop/cop/chef/style/negating_only_if.rb +2 -2
- data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +4 -4
- data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
- data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +5 -5
- data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +2 -2
- data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +3 -3
- data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +2 -2
- data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +2 -2
- metadata +6 -10
|
@@ -23,7 +23,7 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# Copyright:: 2013-2022 Opscode, Inc.
|
|
28
28
|
# Copyright:: 2013-2022 Chef Inc.
|
|
29
29
|
# Copyright:: 2013-2022 Chef Software Inc.
|
|
@@ -32,7 +32,7 @@ module RuboCop
|
|
|
32
32
|
# Copyright:: Tim Smith
|
|
33
33
|
# Copyright:: Copyright (c) 2015-2022 Chef Software, Inc.
|
|
34
34
|
#
|
|
35
|
-
#
|
|
35
|
+
# # good
|
|
36
36
|
# Copyright:: 2013-2022 Chef Software, Inc.
|
|
37
37
|
# Copyright:: 2013-2022 Tim Smith
|
|
38
38
|
# Copyright:: 2019 37Signals, Inc.
|
|
@@ -23,11 +23,11 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# Copyright:: 2019 YOUR_NAME
|
|
28
28
|
# Copyright:: 2019 YOUR_COMPANY_NAME
|
|
29
29
|
#
|
|
30
|
-
#
|
|
30
|
+
# # good
|
|
31
31
|
# Copyright:: 2019 Tim Smith
|
|
32
32
|
# Copyright:: 2019 Chef Software, Inc.
|
|
33
33
|
#
|
|
@@ -23,7 +23,7 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# Copyright 2013-2016 Chef Software, Inc.
|
|
28
28
|
# Recipe default.rb
|
|
29
29
|
# Attributes default.rb
|
|
@@ -32,7 +32,7 @@ module RuboCop
|
|
|
32
32
|
# Cookbook Name:: Tomcat
|
|
33
33
|
# Attributes File:: default
|
|
34
34
|
#
|
|
35
|
-
#
|
|
35
|
+
# # good
|
|
36
36
|
# Copyright:: 2013-2016 Chef Software, Inc.
|
|
37
37
|
# Recipe:: default.rb
|
|
38
38
|
# Attributes:: default.rb
|
|
@@ -22,7 +22,7 @@ module RuboCop
|
|
|
22
22
|
#
|
|
23
23
|
# @example
|
|
24
24
|
#
|
|
25
|
-
#
|
|
25
|
+
# # bad
|
|
26
26
|
# remote_directory '/etc/my.conf' do
|
|
27
27
|
# content 'some content'
|
|
28
28
|
# mode 0600
|
|
@@ -36,7 +36,7 @@ module RuboCop
|
|
|
36
36
|
# action :create
|
|
37
37
|
# end
|
|
38
38
|
#
|
|
39
|
-
#
|
|
39
|
+
# # good
|
|
40
40
|
# remote_directory '/etc/my.conf' do
|
|
41
41
|
# content 'some content'
|
|
42
42
|
# mode '600'
|
|
@@ -23,13 +23,13 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
#
|
|
28
28
|
# template '/etc/www/configures-apache.conf' do
|
|
29
29
|
# notifies :restart, 'service[apache]', :immediate
|
|
30
30
|
# end
|
|
31
31
|
#
|
|
32
|
-
#
|
|
32
|
+
# # good
|
|
33
33
|
#
|
|
34
34
|
# template '/etc/www/configures-apache.conf' do
|
|
35
35
|
# notifies :restart, 'service[apache]', :immediately
|
|
@@ -23,7 +23,7 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
#
|
|
28
28
|
# %w( debian ubuntu ).each do |os|
|
|
29
29
|
# supports os
|
|
@@ -33,7 +33,7 @@ module RuboCop
|
|
|
33
33
|
# depends cb
|
|
34
34
|
# end
|
|
35
35
|
#
|
|
36
|
-
#
|
|
36
|
+
# # good
|
|
37
37
|
#
|
|
38
38
|
# supports 'debian'
|
|
39
39
|
# supports 'ubuntu'
|
|
@@ -23,15 +23,15 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# node['platform_version'].split('.').first
|
|
28
28
|
# node['platform_version'].split('.')[0]
|
|
29
29
|
# node['platform_version'].split('.').first.to_i
|
|
30
30
|
# node['platform_version'].split('.')[0].to_i
|
|
31
31
|
#
|
|
32
|
-
#
|
|
32
|
+
# # good
|
|
33
33
|
#
|
|
34
|
-
# # check to see if we're on RHEL 7 on a RHEL 7.6 node where node['platform_version] is 7.6.1810
|
|
34
|
+
# # check to see if we're on RHEL 7 on a RHEL 7.6 node where node['platform_version'] is 7.6.1810
|
|
35
35
|
# if node['platform_version'].to_i == 7
|
|
36
36
|
# # some code
|
|
37
37
|
# end
|
|
@@ -74,7 +74,7 @@ module RuboCop
|
|
|
74
74
|
|
|
75
75
|
# see if the parent is a method and if it equals the passed in name
|
|
76
76
|
#
|
|
77
|
-
# @param [
|
|
77
|
+
# @param [RuboCop::AST::Node] node The rubocop ast node to search
|
|
78
78
|
# @param [Symbol] name The method name
|
|
79
79
|
#
|
|
80
80
|
def parent_method_equals?(node, name)
|
|
@@ -19,26 +19,26 @@ module RuboCop
|
|
|
19
19
|
module Cop
|
|
20
20
|
module Chef
|
|
21
21
|
module Style
|
|
22
|
-
# Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match one-to-one with OS values. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic. All values of `os` from Ohai match one-to-one with `platform_family` values except for `linux`, which has no single equivalent `platform_family`.
|
|
22
|
+
# Use the platform_family?() helpers instead of node['os'] == 'foo' for platform_families that match one-to-one with OS values. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic. All values of `os` from Ohai match one-to-one with `platform_family` values except for `linux`, which has no single equivalent `platform_family`.
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# node['os'] == 'darwin'
|
|
28
28
|
# node['os'] == 'windows'
|
|
29
29
|
# node['os'].eql?('aix')
|
|
30
30
|
# %w(netbsd openbsd freebsd).include?(node['os'])
|
|
31
31
|
#
|
|
32
|
-
#
|
|
32
|
+
# # good
|
|
33
33
|
# platform_family?('mac_os_x')
|
|
34
34
|
# platform_family?('windows')
|
|
35
35
|
# platform_family?('aix')
|
|
36
|
-
# platform_family?('netbsd', 'openbsd', 'freebsd)
|
|
36
|
+
# platform_family?('netbsd', 'openbsd', 'freebsd')
|
|
37
37
|
#
|
|
38
38
|
class UnnecessaryOSCheck < Base
|
|
39
39
|
extend AutoCorrector
|
|
40
40
|
|
|
41
|
-
MSG = "Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values."
|
|
41
|
+
MSG = "Use the platform_family?() helpers instead of node['os'] == 'foo' for platform_families that match 1:1 with OS values."
|
|
42
42
|
RESTRICT_ON_SEND = [:==, :!=, :eql?, :include?].freeze
|
|
43
43
|
|
|
44
44
|
# sorted list of all the os values that match 1:1 with a platform_family
|
|
@@ -23,7 +23,7 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# case node['platform']
|
|
28
28
|
# when 'ubuntu'
|
|
29
29
|
# log "We're on Ubuntu"
|
|
@@ -35,7 +35,7 @@ module RuboCop
|
|
|
35
35
|
# include_recipe 'yum'
|
|
36
36
|
# end
|
|
37
37
|
#
|
|
38
|
-
#
|
|
38
|
+
# # good
|
|
39
39
|
# if platform?('ubuntu')
|
|
40
40
|
# log "We're on Ubuntu"
|
|
41
41
|
# apt_update
|
|
@@ -19,11 +19,11 @@ module RuboCop
|
|
|
19
19
|
module Cop
|
|
20
20
|
module Chef
|
|
21
21
|
module Style
|
|
22
|
-
# Use the platform?() and platform_family?() helpers instead of node['platform] == 'foo' and node['platform_family'] == 'bar'. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic.
|
|
22
|
+
# Use the platform?() and platform_family?() helpers instead of node['platform'] == 'foo' and node['platform_family'] == 'bar'. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic.
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# node['platform'] == 'ubuntu'
|
|
28
28
|
# node['platform_family'] == 'debian'
|
|
29
29
|
# node['platform'] != 'ubuntu'
|
|
@@ -31,7 +31,7 @@ module RuboCop
|
|
|
31
31
|
# %w(rhel suse).include?(node['platform_family'])
|
|
32
32
|
# node['platform'].eql?('ubuntu')
|
|
33
33
|
#
|
|
34
|
-
#
|
|
34
|
+
# # good
|
|
35
35
|
# platform?('ubuntu')
|
|
36
36
|
# !platform?('ubuntu')
|
|
37
37
|
# platform_family?('debian')
|
|
@@ -23,10 +23,10 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# login_defs_umask = input('login_defs_umask', default: '077', description: 'Default umask to set in login.defs')
|
|
28
28
|
#
|
|
29
|
-
#
|
|
29
|
+
# # good
|
|
30
30
|
# login_defs_umask = input('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
|
|
31
31
|
#
|
|
32
32
|
class AttributeDefault < Base
|
|
@@ -23,10 +23,10 @@ module RuboCop
|
|
|
23
23
|
#
|
|
24
24
|
# @example
|
|
25
25
|
#
|
|
26
|
-
#
|
|
26
|
+
# # bad
|
|
27
27
|
# login_defs_umask = attribute('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
|
|
28
28
|
#
|
|
29
|
-
#
|
|
29
|
+
# # good
|
|
30
30
|
# login_defs_umask = input('login_defs_umask', value: '077', description: 'Default umask to set in login.defs')
|
|
31
31
|
#
|
|
32
32
|
class AttributeHelper < Base
|
metadata
CHANGED
|
@@ -1,15 +1,14 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: cookstyle
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 8.
|
|
4
|
+
version: 8.6.4
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Thom May
|
|
8
8
|
- Tim Smith
|
|
9
|
-
autorequire:
|
|
10
9
|
bindir: bin
|
|
11
10
|
cert_chain: []
|
|
12
|
-
date:
|
|
11
|
+
date: 1980-01-02 00:00:00.000000000 Z
|
|
13
12
|
dependencies:
|
|
14
13
|
- !ruby/object:Gem::Dependency
|
|
15
14
|
name: rubocop
|
|
@@ -17,18 +16,17 @@ dependencies:
|
|
|
17
16
|
requirements:
|
|
18
17
|
- - '='
|
|
19
18
|
- !ruby/object:Gem::Version
|
|
20
|
-
version: 1.
|
|
19
|
+
version: 1.84.2
|
|
21
20
|
type: :runtime
|
|
22
21
|
prerelease: false
|
|
23
22
|
version_requirements: !ruby/object:Gem::Requirement
|
|
24
23
|
requirements:
|
|
25
24
|
- - '='
|
|
26
25
|
- !ruby/object:Gem::Version
|
|
27
|
-
version: 1.
|
|
28
|
-
description:
|
|
26
|
+
version: 1.84.2
|
|
29
27
|
email:
|
|
30
28
|
- thom@chef.io
|
|
31
|
-
- tsmith84@
|
|
29
|
+
- tsmith84@proton.me
|
|
32
30
|
executables:
|
|
33
31
|
- cookstyle
|
|
34
32
|
extensions: []
|
|
@@ -325,7 +323,6 @@ metadata:
|
|
|
325
323
|
source_code_uri: https://github.com/chef/cookstyle
|
|
326
324
|
documentation_uri: https://docs.chef.io/workstation/cookstyle/
|
|
327
325
|
bug_tracker_uri: https://github.com/chef/cookstyle/issues
|
|
328
|
-
post_install_message:
|
|
329
326
|
rdoc_options: []
|
|
330
327
|
require_paths:
|
|
331
328
|
- lib
|
|
@@ -340,8 +337,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
|
|
|
340
337
|
- !ruby/object:Gem::Version
|
|
341
338
|
version: '0'
|
|
342
339
|
requirements: []
|
|
343
|
-
rubygems_version: 3.
|
|
344
|
-
signing_key:
|
|
340
|
+
rubygems_version: 3.6.9
|
|
345
341
|
specification_version: 4
|
|
346
342
|
summary: Cookstyle is a code linting tool that helps you to write better Chef Infra
|
|
347
343
|
cookbooks by detecting and automatically correcting style, syntax, and logic mistakes
|