cookstyle 8.1.4 → 8.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b0a0f48e51e07c907ee52c36eb20c24b03e250431e6dc43da57da92d8bab57f
-  data.tar.gz: 7cdc395630dcb1218803ac218c59b8134f440ec3ce43781529e23f73b32539ca
+  metadata.gz: a112e54131a04e30238454352863d369ac970da0b4ef2ff85c0bb38ceaeec0d7
+  data.tar.gz: 65961294e7f5e942c1ad8867d72c95fb5e758f310eb517d38e8bbdfeac85d3cb
 SHA512:
-  metadata.gz: 4e5c89d3d080c42b174bca6c289afb0f20de9f1198e1d058a815494778b552bb4ce1180972b2e18079f10010f11bf967b3a35c723c2486ba64db332f70209721
-  data.tar.gz: 876cb3847fac787f1f48dd7897ea006893cc9c6009a1ced85e46a5afe9727b12504f11dec30687601cd86233ba35a1bf0d9902a0462d6b9e82b814f1caccaf28
+  metadata.gz: 40ed170a3026d9c516df5bdd6c9689556c2346f152a616e198a8c71b9ec3afbbff999298d3a62f644f8508a52edc9dd965fd69ebb182288977068163353a9269
+  data.tar.gz: 1274df60cb1b12de06ff21aa1fe58af6f80b7867db6d223c9d97fcd22640613bfee162c7ac4aa0af4c5ca4b757137cae78001ecc48467b7e52a7ec7693c7f4f7

data/config/chefstyle.yml

@@ -613,7 +613,7 @@ Bundler/OrderedGems:
 # is also perfectly descriptive even though its only 2 characters...).
 Naming/HeredocDelimiterNaming:
   Enabled: false
-Naming/PredicateName:
+Naming/PredicatePrefix:
   Enabled: false
 Naming/MethodParameterName:
   Enabled: false
@@ -852,6 +852,22 @@ Style/RedundantFormat:
 Lint/RedundantTypeConversion:
   Enabled: true
 
+# Don't use .flatten and then .join when you can use .join directly
+Style/RedundantArrayFlatten:
+  Enabled: true
+
+# Avoid the use of || when the left side will never be nil
+Lint/UselessOr:
+  Enabled: true
+
+# Warn when default values are passed that won't be used
+Lint/UselessDefaultValueArgument:
+  Enabled: true
+
+# use helpers like .any?, .none?, and .one? instead of using count on collections which is much slower
+Style/CollectionQuerying:
+  Enabled: true
+
 Chef/Deprecations/Ruby27KeywordArgumentWarnings:
   Description: Pass options to shell_out helpers without the brackets to avoid Ruby 2.7 deprecation warnings.
   Enabled: true

data/config/cookstyle.yml

@@ -3271,3 +3271,19 @@ Style/RedundantFormat:
 # Don't convert types if we don't need to
 Lint/RedundantTypeConversion:
   Enabled: true
+
+# Don't use .flatten and then .join when you can use .join directly
+Style/RedundantArrayFlatten:
+  Enabled: true
+
+# Avoid the use of || when the left side will never be nil
+Lint/UselessOr:
+  Enabled: true
+
+# Warn when default values are passed that won't be used
+Lint/UselessDefaultValueArgument:
+  Enabled: true
+
+# use helpers like .any?, .none?, and .one? instead of using count on collections which is much slower
+Style/CollectionQuerying:
+  Enabled: true

data/lib/cookstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Cookstyle
-  VERSION = "8.1.4" # rubocop: disable Style/StringLiterals
-  RUBOCOP_VERSION = '1.75.8'
+  VERSION = "8.2.1" # rubocop: disable Style/StringLiterals
+  RUBOCOP_VERSION = '1.77.0'
 end

data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb

@@ -45,7 +45,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:execute, 'creates', node) do |offense|
-              return unless offense.arguments.count == 1 # we can only analyze simple string args
+              return unless offense.arguments.one? # we can only analyze simple string args
               return unless offense.arguments.first.str_type? # we can only analyze simple string args
 
               # skip any creates that are abs paths https://rubular.com/r/3TbDsgcAa1EaIF

data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb

@@ -117,17 +117,13 @@ module RuboCop
 
           def has_provides?
             provides_ast = provides(processed_source.ast)
-            return false if provides_ast.count == 0
+            return false if provides_ast.none?
 
             resource_ast = resource_name(processed_source.ast)
 
-            if resource_ast.count == 0
-              true # no resource_name, but provides
-            else
-              # since we have a resource and provides make sure the there is a provides that
-              # matches the resource name
-              provides_ast.include?(resource_ast.first)
-            end
+            # if no resource ast then resource_name, but not provides
+            # else make sure the provides matches the resource name
+            resource_ast.none? || provides_ast.include?(resource_ast.first)
           end
 
           def indentation(node)

data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb

@@ -45,7 +45,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:windows_package, 'installer_type', node) do |offense|
-              return unless offense.arguments.count == 1 # we can only analyze simple string args
+              return unless offense.arguments.one? # we can only analyze simple string args
               return unless offense.arguments.first.str_type? # anything else is fine
 
               add_offense(offense, severity: :warning) do |corrector|

data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb

@@ -50,7 +50,7 @@ module RuboCop
             platform_version_check?(node) do
               if parent_method_equals?(node, :[])
                 node = node.parent
-                if node&.arguments.count == 1 &&
+                if node&.arguments.one? &&
                    node&.arguments&.first&.int_type? &&
                    node&.arguments&.first.source == '0'
                   add_offense_to_i_if_present(node)

data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb

@@ -55,7 +55,7 @@ module RuboCop
 
           def on_case(node)
             platform_case?(node) do |node_, type|
-              return unless node&.when_branches&.count == 1
+              return unless node&.when_branches&.one?
               add_offense(node, severity: :refactor) do |corrector|
                 # we have at least one supermarket cookbook with an entirely empty platform case statement
                 # we can't actually fix that so let's do nothing here.

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 8.1.4
+  version: 8.2.1
 platform: ruby
 authors:
 - Thom May
 - Tim Smith
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-05-30 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,15 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.75.8
+        version: 1.77.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.75.8
-description:
+        version: 1.77.0
 email:
 - thom@chef.io
 - tsmith84@gmail.com
@@ -324,7 +322,6 @@ metadata:
   source_code_uri: https://github.com/chef/cookstyle
   documentation_uri: https://docs.chef.io/workstation/cookstyle/
   bug_tracker_uri: https://github.com/chef/cookstyle/issues
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -339,8 +336,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key:
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Cookstyle is a code linting tool that helps you to write better Chef Infra
   cookbooks by detecting and automatically correcting style, syntax, and logic mistakes