cookstyle 8.1.3 → 8.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 161bc8f5ebe87cc812e0b84f30ee129607e1ff7c97774b641674793cc8a8f39b
-  data.tar.gz: b33b4b4fa978cec27f1e3e484416145f598fddb0b48581909b22f826f12a8511
+  metadata.gz: a112e54131a04e30238454352863d369ac970da0b4ef2ff85c0bb38ceaeec0d7
+  data.tar.gz: 65961294e7f5e942c1ad8867d72c95fb5e758f310eb517d38e8bbdfeac85d3cb
 SHA512:
-  metadata.gz: 650a623d66c84e15088b3f2e46244fd154ae52037b684a755405c6e3414aba148bb1ebf7ce7a9fa486ef98a5a7f5b78f3606d3e4141ed69947c51029f03c787f
-  data.tar.gz: 755abef5006416b028aef10306d434b0c5c364e918beed70fbd4097cf28c892908e5f629fc398daf65c2499a481f342196fdc0210984cb2a5c390e9cdf745a74
+  metadata.gz: 40ed170a3026d9c516df5bdd6c9689556c2346f152a616e198a8c71b9ec3afbbff999298d3a62f644f8508a52edc9dd965fd69ebb182288977068163353a9269
+  data.tar.gz: 1274df60cb1b12de06ff21aa1fe58af6f80b7867db6d223c9d97fcd22640613bfee162c7ac4aa0af4c5ca4b757137cae78001ecc48467b7e52a7ec7693c7f4f7

data/config/chefstyle.yml

@@ -477,7 +477,7 @@ Layout/TrailingWhitespace:
 Style/RedundantCapitalW:
   Enabled: true
 Style/RedundantInterpolation:
-  Enabled: false # buggy: https://github.com/rubocop-hq/rubocop/issues/6099
+  Enabled: false # buggy: https://github.com/rubocop/rubocop/issues/6099
 #Style/RedundantPercentQ:  # would like to enable this one but its buggy as of 0.35.1
 #  Enabled: true
 Naming/VariableName:
@@ -613,7 +613,7 @@ Bundler/OrderedGems:
 # is also perfectly descriptive even though its only 2 characters...).
 Naming/HeredocDelimiterNaming:
   Enabled: false
-Naming/PredicateName:
+Naming/PredicatePrefix:
   Enabled: false
 Naming/MethodParameterName:
   Enabled: false
@@ -852,6 +852,22 @@ Style/RedundantFormat:
 Lint/RedundantTypeConversion:
   Enabled: true
 
+# Don't use .flatten and then .join when you can use .join directly
+Style/RedundantArrayFlatten:
+  Enabled: true
+
+# Avoid the use of || when the left side will never be nil
+Lint/UselessOr:
+  Enabled: true
+
+# Warn when default values are passed that won't be used
+Lint/UselessDefaultValueArgument:
+  Enabled: true
+
+# use helpers like .any?, .none?, and .one? instead of using count on collections which is much slower
+Style/CollectionQuerying:
+  Enabled: true
+
 Chef/Deprecations/Ruby27KeywordArgumentWarnings:
   Description: Pass options to shell_out helpers without the brackets to avoid Ruby 2.7 deprecation warnings.
   Enabled: true

data/config/cookstyle.yml

@@ -171,7 +171,7 @@ Chef/Style/NegatingOnlyIf:
 
 Chef/Style/IncludeRecipeWithParentheses:
   Description: There is no need to wrap the recipe in parentheses when using the include_recipe helper
-  StyleGuide: '#includerecipewithparentheses'
+  StyleGuide: 'chef_style_includerecipewithparentheses'
   VersionAdded: '6.11.0'
   Enabled: true
   Exclude:
@@ -208,7 +208,7 @@ Chef/Correctness/NodeNormal:
 
 Chef/Correctness/NodeNormalUnless:
   Description: Do not use the node.normal_unless method
-  StyleGuide: 'chef_correctness_chernodenormalunless'
+  StyleGuide: 'chef_correctness_nodenormalunless'
   Enabled: true
   VersionAdded: '5.1.0'
   Exclude:
@@ -402,7 +402,7 @@ Chef/Correctness/ChefApplicationFatal:
 
 Chef/Correctness/PowershellScriptDeleteFile:
   Description: Use the `file` or `directory` resources built into Chef Infra Client with the :delete action to remove files/directories instead of using Remove-Item in a powershell_script resource
-  StyleGuide: 'chef_correctness_powershellscriptdeletefiles'
+  StyleGuide: 'chef_correctness_powershellscriptdeletefile'
   Enabled: true
   VersionAdded: '6.0.0'
   Exclude:
@@ -599,7 +599,7 @@ Chef/Sharing/EmptyMetadataField:
 
 Chef/Sharing/IncludePropertyDescriptions:
   Description: Properties should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
-  StyleGuide: 'chef_sharing_includepropetydescriptions'
+  StyleGuide: 'chef_sharing_includepropertydescriptions'
   Enabled: false
   VersionAdded: '6.1.0'
   Include:
@@ -1082,7 +1082,7 @@ Chef/Deprecations/LogResourceNotifications:
 
 Chef/Deprecations/HWRPWithoutProvides:
   Description: In Chef Infra Client 16 and later a legacy HWRP resource must use `provides` to define how the resource is called in recipes or other resources. To maintain compatibility with Chef Infra Client < 16 use both `resource_name` and `provides`.
-  StyleGuide: 'chef_deprecations_resourcewithoutnameorprovides'
+  StyleGuide: 'chef_deprecations_hwrpwithoutprovides'
   Enabled: true
   VersionAdded: '6.0.0'
   VersionChanged: '6.8.0'
@@ -1173,7 +1173,7 @@ Chef/Deprecations/MacosUserdefaultsGlobalProperty:
 
 Chef/Deprecations/CookbooksDependsOnSelf:
   Description: A cookbook cannot depend on itself in Chef Infra Client 13 or later.
-  StyleGuide: 'chef_deprecations_cookbooksdependonself'
+  StyleGuide: 'chef_deprecations_cookbooksdependsonself'
   Enabled: true
   VersionAdded: '5.2.0'
   VersionChanged: '6.16.0'
@@ -1861,7 +1861,7 @@ Chef/Modernize/NodeRolesInclude:
 
 Chef/Modernize/RespondToCompileTime:
   Description: There is no need to check if the chef_gem resource supports compile_time as Chef Infra Client 12.1 and later support the compile_time property.
-  StyleGuide: 'chef_modernize_resondtocompiletime'
+  StyleGuide: 'chef_modernize_respondtocompiletime'
   Enabled: true
   VersionAdded: '6.3.0'
   Exclude:
@@ -2269,7 +2269,7 @@ Chef/Effortless/CookbookUsesDatabags:
 # https://github.com/chef/cookstyle/issues/346
 Chef/Effortless/ChefVaultUsed:
   Description: Cookbook uses Chef Vault, which cannot be used in the Effortless Infra pattern
-  StyleGuide: 'chef_effortless_cookbookuseschefvault'
+  StyleGuide: 'chef_effortless_chefvaultused'
   Enabled: false
   VersionAdded: '6.19'
   Exclude:
@@ -2279,7 +2279,7 @@ Chef/Effortless/ChefVaultUsed:
 # https://github.com/chef/cookstyle/issues/346
 Chef/Effortless/DependsChefVault:
   Description: Cookbook depends on Chef Vault, which cannot be used in the Effortless Infra pattern
-  StyleGuide: 'chef_effortless_cookbookdependschefvault'
+  StyleGuide: 'chef_effortless_dependschefvault'
   Enabled: false
   VersionAdded: '6.19'
   Include:
@@ -3019,7 +3019,7 @@ Lint/BinaryOperatorWithIdenticalOperands:
   Enabled: true
 
 # returning at the top level with an arg is invalid
-# @TODO we can enable this once this is fixed: https://github.com/rubocop-hq/rubocop/issues/8462
+# @TODO we can enable this once this is fixed: https://github.com/rubocop/rubocop/issues/8462
 # Lint/TopLevelReturnWithArgument:
 #   Enabled: true
 
@@ -3271,3 +3271,19 @@ Style/RedundantFormat:
 # Don't convert types if we don't need to
 Lint/RedundantTypeConversion:
   Enabled: true
+
+# Don't use .flatten and then .join when you can use .join directly
+Style/RedundantArrayFlatten:
+  Enabled: true
+
+# Avoid the use of || when the left side will never be nil
+Lint/UselessOr:
+  Enabled: true
+
+# Warn when default values are passed that won't be used
+Lint/UselessDefaultValueArgument:
+  Enabled: true
+
+# use helpers like .any?, .none?, and .one? instead of using count on collections which is much slower
+Style/CollectionQuerying:
+  Enabled: true

data/lib/cookstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Cookstyle
-  VERSION = "8.1.3" # rubocop: disable Style/StringLiterals
-  RUBOCOP_VERSION = '1.75.6'
+  VERSION = "8.2.1" # rubocop: disable Style/StringLiterals
+  RUBOCOP_VERSION = '1.77.0'
 end

data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb

@@ -45,7 +45,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:execute, 'creates', node) do |offense|
-              return unless offense.arguments.count == 1 # we can only analyze simple string args
+              return unless offense.arguments.one? # we can only analyze simple string args
               return unless offense.arguments.first.str_type? # we can only analyze simple string args
 
               # skip any creates that are abs paths https://rubular.com/r/3TbDsgcAa1EaIF

data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb

@@ -117,17 +117,13 @@ module RuboCop
 
           def has_provides?
             provides_ast = provides(processed_source.ast)
-            return false if provides_ast.count == 0
+            return false if provides_ast.none?
 
             resource_ast = resource_name(processed_source.ast)
 
-            if resource_ast.count == 0
-              true # no resource_name, but provides
-            else
-              # since we have a resource and provides make sure the there is a provides that
-              # matches the resource name
-              provides_ast.include?(resource_ast.first)
-            end
+            # if no resource ast then resource_name, but not provides
+            # else make sure the provides matches the resource name
+            resource_ast.none? || provides_ast.include?(resource_ast.first)
           end
 
           def indentation(node)

data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb

@@ -45,7 +45,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:windows_package, 'installer_type', node) do |offense|
-              return unless offense.arguments.count == 1 # we can only analyze simple string args
+              return unless offense.arguments.one? # we can only analyze simple string args
               return unless offense.arguments.first.str_type? # anything else is fine
 
               add_offense(offense, severity: :warning) do |corrector|

data/lib/rubocop/cop/chef/modernize/libarchive_file.rb

@@ -49,7 +49,7 @@ module RuboCop
           PATTERN
 
           def on_send(node)
-            # The need for this goes away once https://github.com/rubocop-hq/rubocop/pull/8365 is pulled into Cookstyle
+            # The need for this goes away once https://github.com/rubocop/rubocop/pull/8365 is pulled into Cookstyle
             if node.method?(:libarchive_file)
               add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, node.source.gsub('libarchive_file', 'archive_file'))

data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb

@@ -50,7 +50,7 @@ module RuboCop
             platform_version_check?(node) do
               if parent_method_equals?(node, :[])
                 node = node.parent
-                if node&.arguments.count == 1 &&
+                if node&.arguments.one? &&
                    node&.arguments&.first&.int_type? &&
                    node&.arguments&.first.source == '0'
                   add_offense_to_i_if_present(node)

data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb

@@ -55,7 +55,7 @@ module RuboCop
 
           def on_case(node)
             platform_case?(node) do |node_, type|
-              return unless node&.when_branches&.count == 1
+              return unless node&.when_branches&.one?
               add_offense(node, severity: :refactor) do |corrector|
                 # we have at least one supermarket cookbook with an entirely empty platform case statement
                 # we can't actually fix that so let's do nothing here.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 8.1.3
+  version: 8.2.1
 platform: ruby
 authors:
 - Thom May
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.75.6
+        version: 1.77.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.75.6
+        version: 1.77.0
 email:
 - thom@chef.io
 - tsmith84@gmail.com
@@ -336,7 +336,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Cookstyle is a code linting tool that helps you to write better Chef Infra
   cookbooks by detecting and automatically correcting style, syntax, and logic mistakes