cookstyle 7.32.8 → 8.1.1

data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb

@@ -1,61 +1,61 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2019, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Deprecations
-        # Legacy partial_search usage should be updated to use :filter_result in the search helper instead
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   partial_search(:node, 'role:web',
-        #     keys: { 'name' => [ 'name' ],
-        #             'ip' => [ 'ipaddress' ],
-        #             'kernel_version' => %w(kernel version),
-        #               }
-        #   ).each do |result|
-        #     puts result['name']
-        #     puts result['ip']
-        #     puts result['kernel_version']
-        #   end
-        #
-        #   ### correct
-        #   search(:node, 'role:web',
-        #     filter_result: { 'name' => [ 'name' ],
-        #                      'ip' => [ 'ipaddress' ],
-        #                      'kernel_version' => %w(kernel version),
-        #               }
-        #   ).each do |result|
-        #     puts result['name']
-        #     puts result['ip']
-        #     puts result['kernel_version']
-        #   end
-        #
-        class PartialSearchHelperUsage < Base
-          MSG = 'Legacy partial_search usage should be updated to use :filter_result in the search helper instead'
-          RESTRICT_ON_SEND = [:partial_search].freeze
-
-          def on_send(node)
-            add_offense(node, severity: :warning)
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Deprecations
+        # Legacy partial_search usage should be updated to use :filter_result in the search helper instead
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   partial_search(:node, 'role:web',
+        #     keys: { 'name' => [ 'name' ],
+        #             'ip' => [ 'ipaddress' ],
+        #             'kernel_version' => %w(kernel version),
+        #               }
+        #   ).each do |result|
+        #     puts result['name']
+        #     puts result['ip']
+        #     puts result['kernel_version']
+        #   end
+        #
+        #   ### correct
+        #   search(:node, 'role:web',
+        #     filter_result: { 'name' => [ 'name' ],
+        #                      'ip' => [ 'ipaddress' ],
+        #                      'kernel_version' => %w(kernel version),
+        #               }
+        #   ).each do |result|
+        #     puts result['name']
+        #     puts result['ip']
+        #     puts result['kernel_version']
+        #   end
+        #
+        class PartialSearchHelperUsage < Base
+          MSG = 'Legacy partial_search usage should be updated to use :filter_result in the search helper instead'
+          RESTRICT_ON_SEND = [:partial_search].freeze
+
+          def on_send(node)
+            add_offense(node, severity: :warning)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/poise_archive.rb

@@ -1,63 +1,63 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2019, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Deprecations
-        # The poise_archive resource in the deprecated poise-archive should be replaced with the archive_file resource found in Chef Infra Client 15+.
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   poise_archive 'https://example.com/myapp.tgz' do
-        #     destination '/opt/my_app'
-        #   end
-        #
-        #   ### correct
-        #   archive_file 'https://example.com/myapp.tgz' do
-        #     destination '/opt/my_app'
-        #   end
-        #
-        class PoiseArchiveUsage < Base
-          include RuboCop::Chef::CookbookHelpers
-          extend TargetChefVersion
-          minimum_target_chef_version '15.0'
-
-          MSG = 'The poise_archive resource in the deprecated poise-archive should be replaced with the archive_file resource found in Chef Infra Client 15+'
-          RESTRICT_ON_SEND = [:depends].freeze
-
-          def_node_matcher :depends_poise_archive?, <<-PATTERN
-            (send nil? :depends (str "poise-archive"))
-          PATTERN
-
-          def on_send(node)
-            depends_poise_archive?(node) do
-              add_offense(node, severity: :warning)
-            end
-          end
-
-          def on_block(node)
-            match_resource_type?(:poise_archive, node) do
-              add_offense(node, severity: :warning)
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Deprecations
+        # The poise_archive resource in the deprecated poise-archive should be replaced with the archive_file resource found in Chef Infra Client 15+.
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   poise_archive 'https://example.com/myapp.tgz' do
+        #     destination '/opt/my_app'
+        #   end
+        #
+        #   ### correct
+        #   archive_file 'https://example.com/myapp.tgz' do
+        #     destination '/opt/my_app'
+        #   end
+        #
+        class PoiseArchiveUsage < Base
+          include RuboCop::Chef::CookbookHelpers
+          extend TargetChefVersion
+          minimum_target_chef_version '15.0'
+
+          MSG = 'The poise_archive resource in the deprecated poise-archive should be replaced with the archive_file resource found in Chef Infra Client 15+'
+          RESTRICT_ON_SEND = [:depends].freeze
+
+          def_node_matcher :depends_poise_archive?, <<-PATTERN
+            (send nil? :depends (str "poise-archive"))
+          PATTERN
+
+          def on_send(node)
+            depends_poise_archive?(node) do
+              add_offense(node, severity: :warning)
+            end
+          end
+
+          def on_block(node)
+            match_resource_type?(:poise_archive, node) do
+              add_offense(node, severity: :warning)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb

@@ -1,53 +1,53 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2021, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Deprecations
-        # The Policyfile source of `:community` has been replaced with `:supermarket`
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   default_source :community
-        #
-        #   ### correct
-        #   default_source :supermarket
-        #
-        class PolicyfileCommunitySource < Base
-          extend AutoCorrector
-
-          MSG = 'The Policyfile source of `:community` has been replaced with `:supermarket`.'
-          RESTRICT_ON_SEND = [:default_source].freeze
-
-          def_node_matcher :community_source?, <<-PATTERN
-            (send nil? :default_source (:sym :community))
-          PATTERN
-
-          def on_send(node)
-            community_source?(node) do
-              add_offense(node, severity: :warning) do |corrector|
-                corrector.replace(node, 'default_source :supermarket')
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2021, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Deprecations
+        # The Policyfile source of `:community` has been replaced with `:supermarket`
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   default_source :community
+        #
+        #   ### correct
+        #   default_source :supermarket
+        #
+        class PolicyfileCommunitySource < Base
+          extend AutoCorrector
+
+          MSG = 'The Policyfile source of `:community` has been replaced with `:supermarket`.'
+          RESTRICT_ON_SEND = [:default_source].freeze
+
+          def_node_matcher :community_source?, <<-PATTERN
+            (send nil? :default_source (:sym :community))
+          PATTERN
+
+          def on_send(node)
+            community_source?(node) do
+              add_offense(node, severity: :warning) do |corrector|
+                corrector.replace(node, 'default_source :supermarket')
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb

@@ -1,59 +1,59 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2020, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Deprecations
-        # Use `node['powershell']['version']` or the new `powershell_version` helper available in Chef Infra Client 15.8+ instead of the deprecated PowerShell cookbook helpers
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   Powershell::VersionHelper.powershell_version?('4.0')
-        #
-        #   ### correct
-        #   node['powershell']['version'].to_f == 4.0
-        #
-        #   # better (Chef Infra Client 15.8+)
-        #   powershell_version == 4.0
-        #
-        class PowershellCookbookHelpers < Base
-          extend AutoCorrector
-
-          MSG = "Use node['powershell']['version'] or the new powershell_version helper available in Chef Infra Client 15.8+ instead of the deprecated PowerShell cookbook helpers."
-          RESTRICT_ON_SEND = [:powershell_version?].freeze
-
-          def_node_matcher :ps_cb_helper?, <<-PATTERN
-          (send
-            (const
-              (const {cbase nil?} :Powershell) :VersionHelper) :powershell_version?
-            $(...))
-          PATTERN
-
-          def on_send(node)
-            ps_cb_helper?(node) do |ver|
-              add_offense(node, severity: :warning) do |corrector|
-                corrector.replace(node, "node['powershell']['version'].to_f == #{ver.source}")
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2020, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Deprecations
+        # Use `node['powershell']['version']` or the new `powershell_version` helper available in Chef Infra Client 15.8+ instead of the deprecated PowerShell cookbook helpers
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   Powershell::VersionHelper.powershell_version?('4.0')
+        #
+        #   ### correct
+        #   node['powershell']['version'].to_f == 4.0
+        #
+        #   # better (Chef Infra Client 15.8+)
+        #   powershell_version == 4.0
+        #
+        class PowershellCookbookHelpers < Base
+          extend AutoCorrector
+
+          MSG = "Use node['powershell']['version'] or the new powershell_version helper available in Chef Infra Client 15.8+ instead of the deprecated PowerShell cookbook helpers."
+          RESTRICT_ON_SEND = [:powershell_version?].freeze
+
+          def_node_matcher :ps_cb_helper?, <<-PATTERN
+          (send
+            (const
+              (const {cbase nil?} :Powershell) :VersionHelper) :powershell_version?
+            $(...))
+          PATTERN
+
+          def on_send(node)
+            ps_cb_helper?(node) do |ver|
+              add_offense(node, severity: :warning) do |corrector|
+                corrector.replace(node, "node['powershell']['version'].to_f == #{ver.source}")
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/require_recipe.rb

@@ -1,53 +1,53 @@
-# frozen_string_literal: true
-#
-# Copyright:: 2019, Chef Software Inc.
-# Author:: Tim Smith (<tsmith84@gmail.com>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      module Deprecations
-        # Make sure to use include_recipe instead of require_recipe
-        #
-        # @example
-        #
-        #   ### incorrect
-        #   require_recipe 'foo'
-        #
-        #   ### correct
-        #   include_recipe 'foo'
-        #
-        class RequireRecipe < Base
-          extend AutoCorrector
-
-          MSG = 'Use include_recipe instead of the require_recipe method'
-          RESTRICT_ON_SEND = [:require_recipe].freeze
-
-          def_node_matcher :require_recipe?, <<-PATTERN
-            (send nil? :require_recipe $str)
-          PATTERN
-
-          def on_send(node)
-            require_recipe?(node) do
-              add_offense(node.loc.selector, severity: :warning) do |corrector|
-                corrector.replace(node.loc.selector, 'include_recipe')
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Deprecations
+        # Make sure to use include_recipe instead of require_recipe
+        #
+        # @example
+        #
+        #   ### incorrect
+        #   require_recipe 'foo'
+        #
+        #   ### correct
+        #   include_recipe 'foo'
+        #
+        class RequireRecipe < Base
+          extend AutoCorrector
+
+          MSG = 'Use include_recipe instead of the require_recipe method'
+          RESTRICT_ON_SEND = [:require_recipe].freeze
+
+          def_node_matcher :require_recipe?, <<-PATTERN
+            (send nil? :require_recipe $str)
+          PATTERN
+
+          def on_send(node)
+            require_recipe?(node) do
+              add_offense(node.loc.selector, severity: :warning) do |corrector|
+                corrector.replace(node.loc.selector, 'include_recipe')
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end