cookstyle 7.32.1 → 7.32.7

data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   Windows::VersionHelper.nt_version
         #   Windows::VersionHelper.server_version?
         #   Windows::VersionHelper.core_version?
         #   Windows::VersionHelper.workstation_version?
         #
-        #   #### correct
+        #   ### correct
         #   node['platform_version'].to_f
         #   node['kernel']['product_type'] == 'Server'
         #   node['kernel']['server_core']

data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include_recipe 'xml::ruby'
         #
         class IncludingXMLRubyRecipe < Base

data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include_recipe 'yum::dnf_yum_compat'
         #
         class IncludingYumDNFCompatRecipe < Base

data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb

@@ -23,22 +23,22 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   require 'chef-vault'
         #
-        #   #### incorrect
+        #   ### incorrect
         #   ChefVault::Item
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include_recipe 'chef-vault'
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chef_gem 'chef-vault'
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chef_vault_item_for_environment(arg, arg1)
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chef_vault_item(arg, arg1)
         #
         class ChefVaultUsed < Base

data/lib/rubocop/cop/chef/effortless/data_bags.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   data_bag_item('admins', login)
         #   data_bag(data_bag_name)
         class CookbookUsesDatabags < Base

data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'chef-vault'
         #
         class DependsChefVault < Base

data/lib/rubocop/cop/chef/effortless/node_environment.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.environment == "production"
         #   node.chef_environment == "production"
         #

data/lib/rubocop/cop/chef/effortless/node_policygroup.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.policy_group == "foo"
         #
         class CookbookUsesPolicygroups < Base

data/lib/rubocop/cop/chef/effortless/node_roles.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node.role?('web_server')
         #   node.roles.include?('web_server')
         #

data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   search(:node, 'chef_environment:foo')
         #   search(:node, 'role:bar')
         #

data/lib/rubocop/cop/chef/effortless/search_used.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   search(:node, 'run_list:recipe\[bacula\:\:server\]')
         #
         class CookbookUsesSearch < Base

data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def action_create
         #    # :create action code here
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   action :create do
         #    # :create action code here
         #   end

data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def initialize(*args)
         #     super
         #     @actions = [ :create, :add ]
@@ -35,7 +35,7 @@ module RuboCop
         #     @allowed_actions = [ :create, :add ]
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   allowed_actions [ :create, :add ]
         #
         class AllowedActionsFromInitialize < Base

data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include_recipe 'apt::default'
         #   include_recipe 'apt'
         #
-        #   #### correct
+        #   ### correct
         #   apt_update
         #
         class IncludingAptDefaultRecipe < Base

data/lib/rubocop/cop/chef/modernize/berksfile_source.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   source 'http://community.opscode.com/api/v3'
         #   source 'https://supermarket.getchef.com'
         #   source 'https://api.berkshelf.com'
         #   site :opscode
         #
-        #   #### correct
+        #   ### correct
         #   source 'https://supermarket.chef.io'
         #
         class LegacyBerksfileSource < Base

data/lib/rubocop/cop/chef/modernize/build_essential.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'build-essential'
         #   include_recipe 'build-essential::default'
         #   include_recipe 'build-essential'
         #
-        #   #### correct
+        #   ### correct
         #   build_essential 'install compilation tools'
         #
         class UseBuildEssentialResource < Base

data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'build-essential'
         #   depends 'chef_handler'
         #   depends 'chef_hostname'

data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'libarchive'
         #   depends 'windows_dns'
         #   depends 'windows_uac'

data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chef_gem 'nokogiri'
         #
         class ChefGemNokogiri < Base

data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   action_class.class_eval do
         #     foo
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   action_class do
         #     foo
         #   end

data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   build_essential 'install build tools' do
         #    action :nothing
         #   end.run_action(:install)
         #
-        #   #### correct
+        #   ### correct
         #   build_essential 'install build tools' do
         #    compile_time true
         #   end

data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   only_if 'test -f /bin/foo'
         #
-        #   #### correct
+        #   ### correct
         #   only_if { ::File.exist?('bin/foo') }
         #
         class ConditionalUsingTest < Base

data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   template '/etc/cron.d/backup' do
         #     source 'cron_backup_job.erb'
         #     owner 'root'
@@ -71,7 +71,7 @@ module RuboCop
         #     action :delete
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   cron_d 'backup' do
         #     minute '1'
         #     hour '1'
@@ -101,7 +101,7 @@ module RuboCop
 
           def on_block(node)
             file_or_template?(node) do |file_name|
-              break unless file_name.start_with?('/etc/cron.d')
+              break unless file_name.start_with?(%r{/etc/cron\.d\b}i)
               add_offense(node, severity: :refactor)
             end
 
@@ -110,7 +110,7 @@ module RuboCop
               # and check if their value contains '/etc/cron.d'
               # covers the case where the argument to the path property is provided via a method like File.join
               code_property.each_descendant do |d|
-                add_offense(node, severity: :refactor) if d.respond_to?(:value) && d.value.match?(%r{/etc/cron\.d}i)
+                add_offense(node, severity: :refactor) if d.respond_to?(:value) && d.value.match?(%r{/etc/cron\.d\b}i)
               end
             end
           end

data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   cron_manage 'mike'
         #
-        #   #### correct
+        #   ### correct
         #   cron_access 'mike'
         #
         class CronManageResource < Base

data/lib/rubocop/cop/chef/modernize/databag_helpers.rb

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   plain_text_data = Chef::DataBagItem.load('foo', 'bar')
         #   encrypted_data = Chef::EncryptedDataBagItem.load('foo2', 'bar2')
         #
-        #   #### correct
+        #   ### correct
         #   plain_text_data = data_bag_item('foo', 'bar')
         #   encrypted_data = data_bag_item('foo2', 'bar2')
         #

data/lib/rubocop/cop/chef/modernize/declare_action_class.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   declare_action_class do
         #     foo
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   action_class do
         #     foo
         #   end

data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb

@@ -23,19 +23,19 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def initialize(*args)
         #     super
         #     @action = :create
         #   end
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def initialize(*args)
         #     super
         #     @default_action = :create
         #   end
         #
-        #  #### correct
+        #  ### correct
         #  default_action :create
 
         class DefaultActionFromInitialize < Base

data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   if defined?(ChefSpec)
         #     def create_yum_repository(resource_name)
         #       ChefSpec::Matchers::ResourceMatcher.new(:yum_repository, :create, resource_name)

data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'chef-vault'
         #
         class DependsOnChefVaultCookbook < Base

data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'chocolatey_source'
         #   depends 'chocolatey_config'
         #

data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'kernel_module'
         #
         class DependsOnKernelModuleCookbook < Base

data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'locale'
         #
         class DependsOnLocaleCookbook < Base

data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'openssl'
         #
         class DependsOnOpensslCookbook < Base

data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'timezone_lwrp'
         #
         class DependsOnTimezoneLwrpCookbook < Base

data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'windows_firewall'
         #
         class DependsOnWindowsFirewallCookbook < Base

data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   depends 'zypper'
         #
         class DependsOnZypperCookbook < Base

data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include Chef::DSL::Recipe
         #   include Chef::DSL::IncludeRecipe
         #

data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def initialize(*args)
         #     super
         #   end

data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   execute 'apt-get update'
         #
         #   execute 'Apt all the apt cache' do
@@ -34,7 +34,7 @@ module RuboCop
         #     notifies :run, 'execute[apt-get update]', :immediately
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   apt_update
         #
         #   apt_update 'update apt cache'

data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   execute "Delete chef-client service" do
         #     command "sc.exe delete chef-client"
         #     action :run
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   windows_service 'chef-client' do
         #     action :delete
         #   end

data/lib/rubocop/cop/chef/modernize/execute_sleep.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   execute "sleep 60" do
         #     command "sleep 60"
         #     action :run
@@ -35,7 +35,7 @@ module RuboCop
         #     code 'sleep 60'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   chef_sleep '60'
         #
         class ExecuteSleep < Cop

data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   file '/etc/sysctl.d/ipv4.conf' do
         #     notifies :run, 'execute[sysctl -p /etc/sysctl.d/ipv4.conf]', :immediately
         #     content '9000 65500'
@@ -33,7 +33,7 @@ module RuboCop
         #     action :nothing
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   sysctl 'net.ipv4.ip_local_port_range' do
         #     value '9000 65500'
         #   end

data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   execute 'set tz' do
         #     command 'tzutil.exe /s UTC'
         #   end
@@ -35,7 +35,7 @@ module RuboCop
         #     not_if { shell_out('tzutil.exe /g').stdout.include?('UTC') }
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   timezone 'UTC'
         #
         class ExecuteTzUtil < Base

data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   # ~FC013
         #
         class FoodcriticComments < Base

data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   default_action :foo if defined?(default_action)
         #
-        #   #### correct
+        #   ### correct
         #   default_action :foo
         #
         class IfProvidesDefaultAction < Base

data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   require 'chef/mixin/shell_out'
         #   include Chef::Mixin::ShellOut
         #   require 'chef/mixin/powershell_out'