cookstyle 7.30.4 → 7.31.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6043723cd21a354dc4721b561f5ce919a9769362920502b28d200f11475c1a4d
-  data.tar.gz: '08e817e80ca78e386c17ae09ed96001739ef7ef5c4e77c13495e6b6a339b637a'
+  metadata.gz: a58f07c36931ca525e09e1be9c91cc142834784bbb12a9fc83db09d527ccf078
+  data.tar.gz: c29158ed043e7c942e5e3aaa17b9d2c967e20741428f4d6a5074529acd268db9
 SHA512:
-  metadata.gz: 818a1516cdccadac3bc08ff587fac2ad0da22c56be22d03fd027adb540bf4cbb764852cf9d204745ea54e074f984e7c71607c70fe215d8de98ac27d395f18644
-  data.tar.gz: a9a3dc037d434165f73dc09658532094e19f744c7463ace68d610fbdfc8f9da6dfdbd1b525f4330d8d71aed00a8e40a8a1681c4f2bb677a5460dab60562bf10c
+  metadata.gz: 3c2c36c3fb350b28334a19c22350ce6d38e4506e18a9f4160d439a928e86678c0da051428e519aac811607305db938efa18fdc99b996eb5d7f53de11ccfca2bf
+  data.tar.gz: 6871dd79e567d39409b676d9321895d2c7c2292de2bf00d06d9fe31813ee484378acf4e46d1cbcb261ce934250ca547f7307f8b53c24bb8aea8ef9cb4b3207fd

data/config/cookstyle.yml

@@ -1264,6 +1264,14 @@ Chef/Deprecations/PolicyfileCommunitySource:
   Include:
     - '**/Policyfile.rb'
 
+Chef/Deprecations/Delivery:
+  Description: Do not include a `.delivery` directory for the `delivery` command in your cookbooks. Chef Delivery (Workflow) went EOL Dec 31st 2021 and the delivery command was removed from Chef Workstation Feb 2022.
+  StyleGuide: 'chef_deprecations_delivery'
+  Enabled: true
+  VersionAdded: '7.31.0'
+  Include:
+    - '**/metadata.rb'
+
 Chef/Deprecations/DeprecatedSudoActions:
   Description: The `sudo` resource in the sudo cookbook 5.0 (2018) or Chef Infra Client 14 and later have replaced the existing `:install` and `:remove` actions with `:create` and `:delete` actions to better match other resources in Chef Infra.
   StyleGuide: 'chef_deprecations_deprecatedsudoactions'

data/lib/cookstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Cookstyle
-  VERSION = "7.30.4" # rubocop: disable Style/StringLiterals
+  VERSION = "7.31.0" # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '1.25.0'
 end

data/lib/rubocop/cop/chef/deprecation/delivery.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+#
+# Copyright:: 2022, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Deprecations
+        # The Delivery CLI from Chef Delivery/Workflow is no longer bundled with Chef Workstation as Chef Delivery is end of life as of Dec 31st 2021.
+        #
+        # Users of Delivery / Workflow would include a `.delivery` directory in their cookbooks. This directory would include Delivery local-mode configs
+        # or Delivery cookbooks. The contents of this directory are now obsolete and should be removed.
+        #
+        class Delivery < Base
+          include RangeHelp
+
+          MSG = 'Do not include a `.delivery` directory for the `delivery` command in your cookbooks. Chef Delivery (Workflow) went EOL Dec 31st 2021 and the delivery command was removed from Chef Workstation Feb 2022.'
+
+          def on_new_investigation
+            return unless File.exist?(File.join(File.dirname(processed_source.path) + '/.delivery'))
+
+            # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
+            range = source_range(processed_source.buffer, 1, 0)
+
+            add_offense(range, severity: :warning)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 7.30.4
+  version: 7.31.0
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-24 00:00:00.000000000 Z
+date: 2022-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -103,6 +103,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb
 - lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb
 - lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb
+- lib/rubocop/cop/chef/deprecation/delivery.rb
 - lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb
 - lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb
 - lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb