cookstyle 7.30.1 → 7.31.1

data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb

@@ -42,7 +42,7 @@ module RuboCop
 
           def on_send(node)
             zypper_depends?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb

@@ -43,7 +43,7 @@ module RuboCop
 
           def on_send(node)
             dsl_include?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb

@@ -40,7 +40,7 @@ module RuboCop
 
           def on_def(node)
             empty_initialize?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb

@@ -63,15 +63,15 @@ module RuboCop
 
           def on_send(node)
             execute_apt_update?(node) do
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
 
             notification_property?(node) do |val|
-              add_offense(val, message: MSG, severity: :refactor) if val.str_content&.start_with?('execute[apt-get update]')
+              add_offense(val, severity: :refactor) if val.str_content&.start_with?('execute[apt-get update]')
             end
 
             execute_command?(node) do |val|
-              add_offense(node, message: MSG, severity: :refactor) if val.str_content == 'apt-get update'
+              add_offense(node, severity: :refactor) if val.str_content == 'apt-get update'
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb

@@ -49,7 +49,7 @@ module RuboCop
             # with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
             return unless node&.arguments.first&.source&.match?(/^("|')sc.exe/)
 
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
 
           # block execute resources
@@ -57,7 +57,7 @@ module RuboCop
             match_property_in_resource?(:execute, 'command', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               return unless property_data && property_data.match?(/^sc.exe/i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/execute_sleep.rb

@@ -52,7 +52,7 @@ module RuboCop
             # use a regex on source instead of .value in case there's string interpolation which adds a complex dstr type
             # with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
             return unless node&.arguments.first&.source&.match?(/^("|')sleep/)
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
 
           # block execute resources
@@ -60,13 +60,13 @@ module RuboCop
             match_property_in_resource?(:execute, 'command', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               next unless property_data && property_data.match?(/^sleep/i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
 
             match_property_in_resource?(:bash, 'code', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               next unless property_data && property_data.match?(/^sleep/i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb

@@ -52,7 +52,7 @@ module RuboCop
             # use a regex on source instead of .value in case there's string interpolation which adds a complex dstr type
             # with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
             return unless node&.arguments.first&.source&.match?(/^("|')sysctl -p/)
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
 
           # block execute resources
@@ -60,7 +60,7 @@ module RuboCop
             match_property_in_resource?(:execute, 'command', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               return unless property_data && property_data.match?(%r{^(/sbin/)?sysctl -p}i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb

@@ -54,19 +54,19 @@ module RuboCop
           def on_send(node)
             execute_resource?(node) do
               return unless node.arguments.first.value.match?(/^tzutil/i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
 
           def on_block(node)
             match_property_in_resource?(:execute, 'command', node) do |code_property|
               next unless calls_tzutil?(code_property)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
 
             match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
               next unless calls_tzutil?(code_property)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
 

data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb

@@ -34,7 +34,7 @@ module RuboCop
           def on_new_investigation
             processed_source.comments.each do |comment|
               next unless comment.text.match?(/#\s*~FC\d{3}.*/)
-              add_offense(comment, message: MSG, severity: :refactor) do |corrector|
+              add_offense(comment, severity: :refactor) do |corrector|
                 corrector.remove(comment)
               end
             end

data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb

@@ -37,7 +37,7 @@ module RuboCop
           def on_defined?(node)
             return unless node.arguments.first == s(:send, nil, :default_action)
             node = node.parent if node.parent.respond_to?(:if?) && node.parent.if? # we want the whole if statement
-            add_offense(node, message: MSG, severity: :refactor) do |corrector|
+            add_offense(node, severity: :refactor) do |corrector|
               corrector.replace(node, node.children[1].source)
             end
           end

data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb

@@ -61,7 +61,7 @@ module RuboCop
 
             # only add offenses when we're in a custom resource or HWRP, but not a plain old library
             if containing_dir == 'resources' || hwrp_classes?(processed_source.ast)
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/libarchive_file.rb

@@ -50,15 +50,15 @@ module RuboCop
 
           def on_send(node)
             # The need for this goes away once https://github.com/rubocop-hq/rubocop/pull/8365 is pulled into Cookstyle
-            if node.method_name == :libarchive_file
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+            if node.method?(:libarchive_file)
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, node.source.gsub('libarchive_file', 'archive_file'))
               end
             end
 
             notification_property?(node) do |val|
               next unless val.str_content&.start_with?('libarchive_file')
-              add_offense(val, message: MSG, severity: :refactor) do |corrector|
+              add_offense(val, severity: :refactor) do |corrector|
                 corrector.replace(node, node.source.gsub('libarchive_file', 'archive_file'))
               end
             end

data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb

@@ -47,7 +47,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:mac_os_x_userdefaults].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor) do |corrector|
+            add_offense(node, severity: :refactor) do |corrector|
               corrector.replace(node, node.source.gsub(/^mac_os_x_userdefaults/, 'macos_userdefaults'))
             end
           end

data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb

@@ -39,7 +39,7 @@ module RuboCop
 
           def on_send(node)
             minitest_depends?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/node_init_package.rb

@@ -71,13 +71,13 @@ module RuboCop
               # if there's a ::File.exist?('/proc/1/comm') check first we want to match that as well
               node = node.parent if node.parent&.and_type? && proc_1_comm_exists?(node.parent.conditions.first)
 
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, "node['init_package'] == 'systemd'")
               end
             end
 
             file_systemd_conditional?(node) do |conditional|
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(conditional, "{ node['init_package'] == 'systemd' }")
               end
             end

data/lib/rubocop/cop/chef/modernize/node_roles_include.rb

@@ -45,7 +45,7 @@ module RuboCop
 
           def on_send(node)
             node_role_include?(node) do |val|
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, "node.role?(#{val.source})")
               end
             end

data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb

@@ -37,7 +37,7 @@ module RuboCop
 
           def on_send(node)
             ohai_recipe_usage?(node) do
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb

@@ -43,7 +43,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:openssl_rsa_key].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor) do |corrector|
+            add_offense(node, severity: :refactor) do |corrector|
               corrector.replace(node, node.source.gsub(/^openssl_rsa_key/, 'openssl_rsa_private_key'))
             end
           end

data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb

@@ -49,7 +49,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:openssl_x509].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor) do |corrector|
+            add_offense(node, severity: :refactor) do |corrector|
               corrector.replace(node, node.source.gsub(/^openssl_x509/, 'openssl_x509_certificate'))
             end
           end

data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb

@@ -40,7 +40,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:osx_config_profile].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor) do |corrector|
+            add_offense(node, severity: :refactor) do |corrector|
               corrector.replace(node, node.source.gsub(/^osx_config_profile/, 'osx_profile'))
             end
           end

data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb

@@ -40,7 +40,7 @@ module RuboCop
             match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               return unless property_data && property_data.match?(/^expand-archive/i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb

@@ -56,7 +56,7 @@ module RuboCop
           def on_block(node)
             match_property_in_resource?(%i(powershell_script batch), 'guard_interpreter', node) do |interpreter|
               return unless interpreter.arguments.first.source == ':powershell_script'
-              add_offense(interpreter, message: MSG, severity: :refactor) do |corrector|
+              add_offense(interpreter, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: interpreter.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb

@@ -43,7 +43,7 @@ module RuboCop
             match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               return unless property_data && property_data.match?(/^install-package\s/i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb

@@ -46,7 +46,7 @@ module RuboCop
             match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               return unless property_data && property_data.match?(/^(install|add)-windowsfeature\s/i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb

@@ -44,7 +44,7 @@ module RuboCop
 
           def on_send(node)
             property_with_name_attribute?(node) do |name_attribute|
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(name_attribute, 'name_property: true')
               end
             end

data/lib/rubocop/cop/chef/modernize/provides_initializer.rb

@@ -45,7 +45,7 @@ module RuboCop
           def on_ivasgn(node)
             provides_assignment?(node) do
               return unless initialize_method(node.parent.parent).any?
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 # insert the new provides call above the initialize method, but not if one already exists (this is sadly common)
                 unless provides_method?(processed_source.ast)
                   initialize_node = initialize_method(processed_source.ast).first

data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb

@@ -39,13 +39,13 @@ module RuboCop
           MSG = 'The name of a resource can be set with the "resource_name" helper instead of using the initialize method.'
 
           def on_def(node)
-            return unless node.method_name == :initialize
+            return unless node.method?(:initialize)
             return if node.body.nil? # nil body is an empty initialize method
 
             node.body.each_node do |x|
               next unless x.assignment? && !x.node_parts.empty? && x.node_parts.first == :@resource_name
 
-              add_offense(x, message: MSG, severity: :refactor) do |corrector|
+              add_offense(x, severity: :refactor) do |corrector|
                 # insert the new resource_name call above the initialize method
                 initialize_node = initialize_method(processed_source.ast).first
                 corrector.insert_before(initialize_node.source_range, "resource_name #{x.descendants.first.source}\n\n")

data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb

@@ -40,7 +40,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:set_or_return].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
         end
       end

data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb

@@ -54,7 +54,7 @@ module RuboCop
           def on_send(node)
             return unless resource_actions?(processed_source.ast)
             attribute?(node) do
-              add_offense(node.loc.selector, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node.loc.selector, severity: :refactor) do |corrector|
                 corrector.replace(node.loc.selector, 'property')
               end
             end

data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb

@@ -81,7 +81,7 @@ module RuboCop
           def on_block(node)
             match_property_in_resource?(:chef_gem, 'compile_time', node) do |compile_time_property|
               compile_time_method_defined?(compile_time_property.parent) do |val|
-                add_offense(compile_time_property.parent, message: MSG, severity: :refactor) do |corrector|
+                add_offense(compile_time_property.parent, severity: :refactor) do |corrector|
                   corrector.replace(compile_time_property.parent, "compile_time #{val.source}")
                 end
               end

data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb

@@ -44,7 +44,7 @@ module RuboCop
 
           def on_if(node)
             if_respond_to?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 # When the if statement is if modifier like `foo if respond_to?(:foo)` then
                 # node.if_branch is the actual method call we want to extract.
                 # If a series of metadata methods are wrapped in an if statement then the content we want
@@ -62,7 +62,7 @@ module RuboCop
             # If a series of metadata methods are wrapped in an if statement then the content we want
             # is a block under the if statement and node.parent.if_branch can get us that block
             node = node.parent if node.parent.conditional? # we want the whole conditional statement
-            add_offense(node, message: MSG, severity: :refactor) do |corrector|
+            add_offense(node, severity: :refactor) do |corrector|
               corrector.replace(node, node.if_branch.source)
             end
           end

data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb

@@ -38,7 +38,7 @@ module RuboCop
 
           def on_if(node)
             if_respond_to_provides?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, node.children[1].source)
               end
             end

data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb

@@ -36,7 +36,7 @@ module RuboCop
 
           def on_if(node)
             if_respond_to_resource_name?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, node.children[1].source)
               end
             end

data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb

@@ -44,7 +44,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:sc_windows].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
         end
       end

data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb

@@ -37,7 +37,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:seven_zip_archive].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
         end
       end

data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb

@@ -48,7 +48,7 @@ module RuboCop
 
           def on_send(node)
             mixlib_shellout_run_cmd?(node) do |cmd|
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, "shell_out(#{cmd.source})")
               end
             end

data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb

@@ -42,13 +42,13 @@ module RuboCop
             match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               next unless property_data && property_data.match?(/^choco /i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
 
             match_property_in_resource?(:execute, 'command', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
               next unless property_data && property_data.match?(/^choco /i)
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb

@@ -49,7 +49,7 @@ module RuboCop
           def on_block(node)
             match_property_in_resource?(:apt_repository, 'uri', node) do |uri|
               if %r{http(s)*://ppa.launchpad.net/(.*)/ubuntu$}.match?(uri.arguments&.first&.str_content)
-                add_offense(uri, message: MSG, severity: :refactor) do |corrector|
+                add_offense(uri, severity: :refactor) do |corrector|
                   next unless (replacement_val = %r{http(s)*://ppa.launchpad.net/(.*)/ubuntu}.match(node.source)[2])
                   corrector.replace(uri, "uri 'ppa:#{replacement_val}'")
                 end

data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb

@@ -44,7 +44,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:sysctl_param].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor) do |corrector|
+            add_offense(node, severity: :refactor) do |corrector|
               corrector.replace(node, node.source.gsub(/^sysctl_param/, 'sysctl'))
             end
           end

data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb

@@ -39,7 +39,7 @@ module RuboCop
 
           def on_send(node)
             require_mixlibshellout?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb

@@ -81,7 +81,7 @@ module RuboCop
               # if they were checking for node['cloud'] and the provider replace it all
               node = node.parent if node.parent.and_type? && node_cloud?(node.left_sibling)
 
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, "#{cloud_name}?")
               end
             end

data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb

@@ -48,7 +48,7 @@ module RuboCop
           def on_send(node)
             env?(node) do |env_value|
               # we don't handle .nil? checks yet so just skip them
-              next if node.parent.send_type? && node.parent.method_name == :nil?
+              next if node.parent.send_type? && node.parent.method?(:nil?)
 
               case env_value
               when 'CI'

data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb

@@ -48,7 +48,7 @@ module RuboCop
 
           def on_send(node)
             node_init_package?(node) do |_cloud_name|
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.replace(node, 'systemd?')
               end
             end

data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb

@@ -89,7 +89,7 @@ module RuboCop
             return if node.body.nil? # don't blow up on empty whens
 
             package_array_install(node.body) do |install_block, pkgs|
-              add_offense(install_block, message: MSG, severity: :refactor) do |corrector|
+              add_offense(install_block, severity: :refactor) do |corrector|
                 corrector.replace(install_block, "package #{pkgs.source}")
               end
             end
@@ -99,7 +99,7 @@ module RuboCop
             platform_helper?(node) do |plats, blk, _pkgs|
               return unless multipackage_platforms?(plats)
 
-              add_offense(blk, message: MSG, severity: :refactor) do |corrector|
+              add_offense(blk, severity: :refactor) do |corrector|
                 package_array_install(blk) do |install_block, pkgs|
                   corrector.replace(install_block, "package #{pkgs.source}")
                 end

data/lib/rubocop/cop/chef/modernize/use_require_relative.rb

@@ -46,7 +46,7 @@ module RuboCop
           def on_send(node)
             require_with_expand_path?(node) do |file, path|
               return unless path.source == '__FILE__'
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrected_value = file.value
                 corrected_value.slice!(%r{^../}) # take the first ../ off the path
                 corrector.replace(node, "require_relative '#{corrected_value}'")

data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb

@@ -46,7 +46,7 @@ module RuboCop
 
           def on_def(node)
             whyrun_true?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb

@@ -40,7 +40,7 @@ module RuboCop
 
           def on_send(node)
             windows_recipe_usage?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              add_offense(node, severity: :refactor) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb

@@ -51,10 +51,10 @@ module RuboCop
 
           # block registry_key resources
           def on_block(node)
-            return unless node.method_name == :registry_key
+            return unless node.method?(:registry_key)
             return unless correct_key?(node)
             return unless uac_supported_values?(node)
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
 
           # make sure the values passed are all the ones in the uac resource

data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb

@@ -37,7 +37,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:windows_zipfile].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
         end
       end

data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb

@@ -43,13 +43,13 @@ module RuboCop
 
           def on_send(node)
             depends_zipfile?(node) do
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
 
           def on_block(node)
             match_resource_type?(:zipfile, node) do
-              add_offense(node, message: MSG, severity: :refactor)
+              add_offense(node, severity: :refactor)
             end
           end
         end