cookstyle 7.23.0 → 7.24.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9be1741ac594805428a4c1269af0b63e1176abf6e14aa6e04c47639c1153f083
-  data.tar.gz: b7d95d2ba12571d8a09d1a6eabaacce48e2ee0956ac91c595d7c5be5e010978b
+  metadata.gz: f15883e8b06ca175e673c9bc97a1d33f2e79da76a8f9a3a60ee0262868890ac3
+  data.tar.gz: 518d0db21d8525486fc3406898afecd84bb6d27b52ea49c155a4b8000af39cdb
 SHA512:
-  metadata.gz: 4409915af7d5e193e9fcbc49c333370aa318e50c4a798ccee1a6b619912b4ff3bd6f8016b67f96da4f3ba10bda212e453d45fbfe5ec3a611d6eb64a78911820f
-  data.tar.gz: cb2d001bd4d5fb913dbb6a14972bb341e43fa982a926ae30a37d3adcce6e5fc599a8e535ff53dd82cac3dddf8de8fde0ce49c1e1db9192e83ad51a99c609a0f2
+  metadata.gz: 53bde638d1b3829cfece0f84c9d9d25cc69c6d775181155ef154fcc40b310daefb1a01ed424db39e16fcff7fb61fe01469ee3b6cf8d1e320b2dd58f212b70145
+  data.tar.gz: d24b861cf7b56441c16e2be78fc97650ab093b70fc7734c8b3ee8fa889f2e60406026e23af3b19da3984c4050bf2c1e763d50d5f09a59c55af61bee4cc88e577

data/config/cookstyle.yml

@@ -1924,6 +1924,15 @@ Chef/Modernize/ClassEvalActionClass:
   Include:
     - '**/resources/*.rb'
 
+Chef/Modernize/UseChefLanguageSystemdHelper:
+  Description: Chef Infra Client 15.5 and later include a `systemd?` helper for checking if a Linux system uses systemd.
+  StyleGuide: 'chef_modernize_usecheflanguagesystemdhelper'
+  Enabled: true
+  VersionAdded: '7.24.0'
+  Exclude:
+    - '**/metadata.rb'
+    - '**/Berksfile'
+
 ###############################
 # Chef/RedundantCode: Cleanup unnecessary code in your cookbooks regardless of Chef Infra Client release
 ###############################

data/lib/cookstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Cookstyle
-  VERSION = "7.23.0" # rubocop: disable Style/StringLiterals
+  VERSION = "7.24.1" # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '1.20.0'
 end

data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb

@@ -49,6 +49,9 @@ module RuboCop
         #
         class UseChefLanguageCloudHelpers < Base
           extend AutoCorrector
+          extend TargetChefVersion
+
+          minimum_target_chef_version '15.5'
 
           MSG = 'Chef Infra Client 15.5 and later include cloud helpers to make detecting instances that run on public and private clouds easier.'
           RESTRICT_ON_SEND = [:==, :[]].freeze

data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb

@@ -33,6 +33,9 @@ module RuboCop
         #
         class UseChefLanguageEnvHelpers < Base
           extend AutoCorrector
+          extend TargetChefVersion
+
+          minimum_target_chef_version '15.5'
 
           RESTRICT_ON_SEND = [:[]].freeze
 

data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+#
+# Copyright:: 2021, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Modernize
+        # Chef Infra Client 15.5 and later include a `systemd?` helper for checking if a Linux system uses systemd.
+        #
+        # @example
+        #
+        #   #### incorrect
+        #   node['init_package'] == 'systemd'
+        #
+        #   #### correct
+        #   systemd?
+        #
+        class UseChefLanguageSystemdHelper < Base
+          extend AutoCorrector
+          extend TargetChefVersion
+
+          minimum_target_chef_version '15.5'
+
+          MSG = 'Chef Infra Client 15.5 and later include a `systemd?` helper for checking if a Linux system uses systemd.'
+          RESTRICT_ON_SEND = [:==].freeze
+
+          def_node_matcher :node_init_package?, <<-PATTERN
+              (send
+                (send
+                  (send nil? :node) :[]
+                  (str "init_package")) :==
+                (str "systemd"))
+            PATTERN
+
+          def on_send(node)
+            node_init_package?(node) do |_cloud_name|
+              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+                corrector.replace(node, 'systemd?')
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 7.23.0
+  version: 7.24.1
 platform: ruby
 authors:
 - Thom May
@@ -239,6 +239,7 @@ files:
 - lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb
 - lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb
 - lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb
+- lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb
 - lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb
 - lib/rubocop/cop/chef/modernize/use_require_relative.rb
 - lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb