cookstyle 7.21.0 → 7.25.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48e9eba9990f29d5ece83efea73a5ceba5c49ed781909b437c40c43da790210a
-  data.tar.gz: 9f177a0a2cadc3cb703ec87337bd4485e872ae748d9af95f53473dec22eebd7d
+  metadata.gz: 1a67abdf6a42bec1022fc57e53a61a9aa6f371641e6afe429eee6a9489ff2355
+  data.tar.gz: c3ff11c1e6ef1be4af29d034d662a6b662a731103082477b0d8d0e9e3a0455e2
 SHA512:
-  metadata.gz: fbeebdde748ba5abca797bf203ab8465c74e1b1714847d27e35576b3801daae3e962b9bfb3516c84f684e69a3088535d8811ea7df74005f6262005bb844295a7
-  data.tar.gz: 4e3c683249684fdae3717f88b9ea92c9eb26147d55eb90e43e024f7c0ce03870d03c66b4f2c7ad6eb9c057cf1eb687ce28ed44efea7b2a61e5a9002b3b143628
+  metadata.gz: 79074fc5f3c7ef245dbcb64a4739a49298cda263bc216333215599bbc7e052f0979981e67572eec6d77b33c8e620370087b32ad20f90d2c5f5ddcbfaf99182cc
+  data.tar.gz: 116535d0ada1a04fd19bb9af708390402aeeb983a962af1a681d66e9f9fa81afc515450f1bcae187dcf8de83876a8fd5c9a091ea0d93313033821f34263f51a8

data/Gemfile

@@ -6,8 +6,6 @@ gemspec
 
 group :debug do
   gem 'pry'
-  gem 'pry-byebug'
-  gem 'pry-stack_explorer', '< 0.4.13' # 0.4.13+ drops support for Ruby < 2.6
 end
 
 group :docs do
@@ -15,8 +13,10 @@ group :docs do
 end
 
 group :profiling do
-  gem 'memory_profiler'
-  gem 'stackprof'
+  platforms :ruby do
+    gem 'memory_profiler'
+    gem 'stackprof'
+  end
 end
 
 group :rubocop_gems do

data/config/cookstyle.yml

@@ -498,6 +498,14 @@ Chef/Correctness/PowershellFileExists:
     - '**/metadata.rb'
     - '**/Berksfile'
 
+Chef/Correctness/MetadataMissingVersion:
+  Description: metadata.rb should define a version for the cookbook.
+  StyleGuide: 'chef_correctness_metadatamissingversion'
+  Enabled: true
+  VersionAdded: '7.25'
+  Include:
+    - '**/metadata.rb'
+
 ###############################
 # Chef/Sharing: Issues that prevent sharing code with other teams or with the Chef community in general
 ###############################
@@ -979,7 +987,7 @@ Chef/Deprecations/DeprecatedPlatformMethods:
     - '**/providers/*.rb'
 
 Chef/Deprecations/DeprecatedChefSpecPlatform:
-  Description: Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3
+  Description: Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/main/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3
   StyleGuide: 'chef_deprecations_deprecatedchefspecplatform'
   Enabled: true
   VersionAdded: '5.20.0'
@@ -1198,7 +1206,7 @@ Chef/Deprecations/DeprecatedYumRepositoryActions:
     - '**/Rakefile'
 
 Chef/Deprecations/ChefSugarHelpers:
-  Description: Do not use legacy chef-sugar helper methods, which will not be moved into Chef Infra Client itself. For a complete set of chef-sugar helpers now shipping in Chef Infra Client itself see https://github.com/chef/chef/tree/master/chef-utils#getting-started
+  Description: Do not use legacy chef-sugar helper methods, which will not be moved into Chef Infra Client itself. For a complete set of chef-sugar helpers now shipping in Chef Infra Client itself see https://github.com/chef/chef/tree/main/chef-utils#getting-started
   StyleGuide: 'chef_deprecations_chefsugarhelpers'
   Enabled: true
   VersionAdded: '7.3.0'
@@ -1897,7 +1905,7 @@ Chef/Modernize/DependsOnOpensslCookbook:
     - '**/metadata.rb'
 
 Chef/Modernize/UseChefLanguageEnvHelpers:
-  Description: Chef Infra Client 15.5 and later include a large number of new helpers in the Chef Infra Language to simplify checking the system configuration in recipes and resources. These should be used when possible over more complex attribute or ENV var comparisons.
+  Description: Chef Infra Client 15.5 and later include a large number of new helpers in the Chef Infra Language to simplify checking the system configuration in recipes and resources. These should be used when possible over more complex attributes or ENV var comparisons.
   StyleGuide: 'chef_modernize_usecheflanguageenvhelpers'
   Enabled: true
   VersionAdded: '7.21.0'
@@ -1906,6 +1914,33 @@ Chef/Modernize/UseChefLanguageEnvHelpers:
     - '**/providers/*.rb'
     - '**/recipes/*.rb'
 
+Chef/Modernize/UseChefLanguageCloudHelpers:
+  Description: Chef Infra Client 15.5 and later include cloud helpers to make detecting instances that run on public and private clouds easier.
+  StyleGuide: 'chef_modernize_usecheflanguagecloudhelpers'
+  Enabled: true
+  VersionAdded: '7.22.0'
+  Include:
+    - '**/resources/*.rb'
+    - '**/providers/*.rb'
+    - '**/recipes/*.rb'
+    
+Chef/Modernize/ClassEvalActionClass:
+  Description: In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block.
+  StyleGuide: 'chef_modernize_classevalactionclass'
+  Enabled: true
+  VersionAdded: '7.23.0'
+  Include:
+    - '**/resources/*.rb'
+
+Chef/Modernize/UseChefLanguageSystemdHelper:
+  Description: Chef Infra Client 15.5 and later include a `systemd?` helper for checking if a Linux system uses systemd.
+  StyleGuide: 'chef_modernize_usecheflanguagesystemdhelper'
+  Enabled: true
+  VersionAdded: '7.24.0'
+  Exclude:
+    - '**/metadata.rb'
+    - '**/Berksfile'
+
 ###############################
 # Chef/RedundantCode: Cleanup unnecessary code in your cookbooks regardless of Chef Infra Client release
 ###############################
@@ -2778,6 +2813,7 @@ Style/GuardClause:
 # Users really shouldn't have a gem, but if they do they should do it securely
 Bundler/InsecureProtocolSource:
   Enabled: true
+  AllowHttpProtocol: false
 
 # It's easier to read a simple .each and they're faster
 Lint/RedundantWithIndex:

data/config/disable_all.yml

@@ -5,6 +5,8 @@ Bundler/DuplicatedGem:
   Enabled: false
 Bundler/GemComment:
   Enabled: false
+Bundler/GemFilename:
+  Enabled: false
 Bundler/GemVersion:
   Enabled: false
 Bundler/InsecureProtocolSource:
@@ -219,6 +221,8 @@ Lint/AmbiguousBlockAssociation:
   Enabled: false
 Lint/AmbiguousOperator:
   Enabled: false
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: false
 Lint/AmbiguousRange:
   Enabled: false
 Lint/AmbiguousRegexpLiteral:
@@ -305,10 +309,12 @@ Lint/IdentityComparison:
   Enabled: false
 Lint/ImplicitStringConcatenation:
   Enabled: false
-Lint/InheritException:
+Lint/IncompatibleIoSelectWithFiberScheduler:
   Enabled: false
 Lint/IneffectiveAccessModifier:
   Enabled: false
+Lint/InheritException:
+  Enabled: false
 Lint/InterpolationCheck:
   Enabled: false
 Lint/LambdaWithoutLiteralBlock:
@@ -381,6 +387,8 @@ Lint/RegexpAsCondition:
   Enabled: false
 Lint/RequireParentheses:
   Enabled: false
+Lint/RequireRelativeSelfPath:
+  Enabled: false
 Lint/RescueException:
   Enabled: false
 Lint/RescueType:
@@ -699,6 +707,8 @@ Style/MethodCallWithArgsParentheses:
   Enabled: false
 Style/MultilineInPatternThen:
   Enabled: false
+Style/NumberedParameters:
+  Enabled: false
 Style/RedundantAssignment:
   Enabled: false
 Style/RedundantFetchBlock:
@@ -771,6 +781,8 @@ Style/NonNilCheck:
   Enabled: false
 Style/Not:
   Enabled: false
+Style/NumberedParametersLimit:
+  Enabled: false
 Style/NumericLiterals:
   Enabled: false
 Style/NumericLiteralPrefix:
@@ -851,6 +863,8 @@ Style/SafeNavigation:
   Enabled: false
 Style/Sample:
   Enabled: false
+Style/SelectByRegexp:
+  Enabled: false
 Style/SelfAssignment:
   Enabled: false
 Style/Semicolon:
@@ -943,6 +957,8 @@ Style/ZeroLengthPredicate:
   Enabled: false
 Security/Eval:
   Enabled: false
+Security/IoMethods:
+  Enabled: false
 Security/JSONLoad:
   Enabled: false
 Security/MarshalLoad:

data/config/upstream.yml

@@ -130,7 +130,7 @@ AllCops:
   # What MRI version of the Ruby interpreter is the inspected code intended to
   # run on? (If there is more than one, set this to the lowest version.)
   # If a value is specified for TargetRubyVersion then it is used. Acceptable
-  # values are specificed as a float (i.e. 3.0); the teeny version of Ruby
+  # values are specified as a float (i.e. 3.0); the teeny version of Ruby
   # should not be included. If the project specifies a Ruby version in the
   # .tool-versions or .ruby-version files, Gemfile or gems.rb file, RuboCop will
   # try to determine the desired version of Ruby by inspecting the
@@ -174,6 +174,20 @@ Bundler/GemComment:
   IgnoredGems: []
   OnlyFor: []
 
+Bundler/GemFilename:
+  Description: 'Enforces the filename for managing gems.'
+  Enabled: true
+  VersionAdded: '1.20'
+  EnforcedStyle: 'Gemfile'
+  SupportedStyles:
+    - 'Gemfile'
+    - 'gems.rb'
+  Include:
+    - '**/Gemfile'
+    - '**/gems.rb'
+    - '**/Gemfile.lock'
+    - '**/gems.locked'
+
 Bundler/GemVersion:
   Description: 'Requires or forbids specifying gem versions.'
   Enabled: false
@@ -195,6 +209,7 @@ Bundler/InsecureProtocolSource:
                  'https://rubygems.org' if possible, or 'http://rubygems.org' if not.
   Enabled: true
   VersionAdded: '0.50'
+  AllowHttpProtocol: true
   Include:
     - '**/*.gemfile'
     - '**/Gemfile'
@@ -943,7 +958,6 @@ Layout/LineLength:
   Enabled: true
   VersionAdded: '0.25'
   VersionChanged: '1.4'
-  AutoCorrect: true
   Max: 120
   # To make it possible to copy or click on URIs in the code, we allow lines
   # containing a URI to be longer than Max.
@@ -1347,10 +1361,11 @@ Layout/SpaceInsideParens:
   StyleGuide: '#spaces-braces'
   Enabled: true
   VersionAdded: '0.49'
-  VersionChanged: '0.55'
+  VersionChanged: '1.22'
   EnforcedStyle: no_space
   SupportedStyles:
     - space
+    - compact
     - no_space
 
 Layout/SpaceInsidePercentLiteralDelimiters:
@@ -1434,6 +1449,13 @@ Lint/AmbiguousOperator:
   VersionAdded: '0.17'
   VersionChanged: '0.83'
 
+Lint/AmbiguousOperatorPrecedence:
+  Description: >-
+                 Checks for expressions containing multiple binary operations with
+                 ambiguous precedence.
+  Enabled: pending
+  VersionAdded: '1.21'
+
 Lint/AmbiguousRange:
   Description: Checks for ranges with ambiguous boundaries.
   Enabled: pending
@@ -1471,9 +1493,9 @@ Lint/BinaryOperatorWithIdenticalOperands:
 Lint/BooleanSymbol:
   Description: 'Check for `:true` and `:false` symbols.'
   Enabled: true
-  Safe: false
+  SafeAutoCorrect: false
   VersionAdded: '0.50'
-  VersionChanged: '0.83'
+  VersionChanged: '1.22'
 
 Lint/CircularArgumentReference:
   Description: "Default values in optional keyword arguments and optional ordinal arguments should not refer back to the name of the argument."
@@ -1519,6 +1541,11 @@ Lint/Debugger:
     Capybara:
       - save_and_open_page
       - save_and_open_screenshot
+    debug.rb:
+      - binding.b
+      - binding.break
+      - Kernel.binding.b
+      - Kernel.binding.break
     Pry:
       - binding.pry
       - binding.remote_pry
@@ -1527,6 +1554,8 @@ Lint/Debugger:
     Rails:
       - debugger
       - Kernel.debugger
+    RubyJard:
+      - jard
     WebConsole:
       - binding.console
 
@@ -1750,6 +1779,11 @@ Lint/ImplicitStringConcatenation:
   Enabled: true
   VersionAdded: '0.36'
 
+Lint/IncompatibleIoSelectWithFiberScheduler:
+  Description: 'Checks for `IO.select` that is incompatible with Fiber Scheduler.'
+  Enabled: pending
+  VersionAdded: '1.21'
+
 Lint/IneffectiveAccessModifier:
   Description: >-
                  Checks for attempts to use `private` or `protected` to set
@@ -2013,6 +2047,11 @@ Lint/RequireParentheses:
   Enabled: true
   VersionAdded: '0.18'
 
+Lint/RequireRelativeSelfPath:
+  Description: 'Checks for uses a file requiring itself with `require_relative`.'
+  Enabled: pending
+  VersionAdded: '1.22'
+
 Lint/RescueException:
   Description: 'Avoid rescuing the Exception class.'
   StyleGuide: '#no-blind-rescues'
@@ -2542,8 +2581,9 @@ Naming/HeredocDelimiterNaming:
 
 Naming/InclusiveLanguage:
   Description: 'Recommend the use of inclusive language instead of problematic terms.'
-  Enabled: pending
+  Enabled: false
   VersionAdded: '1.18'
+  VersionChanged: '1.21'
   CheckIdentifiers: true
   CheckConstants: true
   CheckVariables: true
@@ -2699,6 +2739,14 @@ Security/Eval:
   Enabled: true
   VersionAdded: '0.47'
 
+Security/IoMethods:
+  Description: >-
+                 Checks for the first argument to `IO.read`, `IO.binread`, `IO.write`, `IO.binwrite`,
+                 `IO.foreach`, and `IO.readlines`.
+  Enabled: pending
+  Safe: false
+  VersionAdded: '1.22'
+
 Security/JSONLoad:
   Description: >-
                  Prefer usage of `JSON.parse` over `JSON.load` due to potential
@@ -2775,8 +2823,9 @@ Style/AndOr:
   Description: 'Use &&/|| instead of and/or.'
   StyleGuide: '#no-and-or-or'
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.9'
-  VersionChanged: '0.25'
+  VersionChanged: '1.21'
   # Whether `and` and `or` are banned only in conditionals (conditionals)
   # or completely (always).
   EnforcedStyle: conditionals
@@ -2810,9 +2859,9 @@ Style/ArrayJoin:
 Style/AsciiComments:
   Description: 'Use only ascii symbols in comments.'
   StyleGuide: '#english-comments'
-  Enabled: true
+  Enabled: false
   VersionAdded: '0.9'
-  VersionChanged: '0.52'
+  VersionChanged: '1.21'
   AllowedChars:
     - ©
 
@@ -2974,7 +3023,7 @@ Style/CaseEquality:
   Enabled: true
   VersionAdded: '0.9'
   VersionChanged: '0.89'
-  # If AllowOnConstant is enabled, the cop will ignore violations when the receiver of
+  # If `AllowOnConstant` option is enabled, the cop will ignore violations when the receiver of
   # the case equality operator is a constant.
   #
   #   # bad
@@ -3149,7 +3198,7 @@ Style/CommentAnnotation:
   StyleGuide: '#annotate-keywords'
   Enabled: true
   VersionAdded: '0.10'
-  VersionChanged: '1.3'
+  VersionChanged: '1.20'
   Keywords:
     - TODO
     - FIXME
@@ -3669,7 +3718,7 @@ Style/InPatternThen:
 Style/InfiniteLoop:
   Description: >-
                  Use Kernel#loop for infinite loops.
-                 This cop is unsafe in the body may raise a `StopIteration` exception.
+                 This cop is unsafe if the body may raise a `StopIteration` exception.
   Safe: false
   StyleGuide: '#infinite-loop'
   Enabled: true
@@ -4095,6 +4144,21 @@ Style/Not:
   VersionAdded: '0.9'
   VersionChanged: '0.20'
 
+Style/NumberedParameters:
+  Description: 'Restrict the usage of numbered parameters.'
+  Enabled: pending
+  VersionAdded: '1.22'
+  EnforcedStyle: allow_single_line
+  SupportedStyles:
+    - allow_single_line
+    - disallow
+
+Style/NumberedParametersLimit:
+  Description: 'Avoid excessive numbered params in a single block.'
+  Enabled: pending
+  VersionAdded: '1.22'
+  Max: 1
+
 Style/NumericLiteralPrefix:
   Description: 'Use smallcase prefixes for numeric literals.'
   StyleGuide: '#numeric-literal-prefixes'
@@ -4105,7 +4169,6 @@ Style/NumericLiteralPrefix:
     - zero_with_o
     - zero_only
 
-
 Style/NumericLiterals:
   Description: >-
                  Add underscores to large numeric literals to improve their
@@ -4426,6 +4489,8 @@ Style/RedundantSort:
                   `max_by` instead of `sort_by...last`, etc.
   Enabled: true
   VersionAdded: '0.76'
+  VersionChanged: '1.22'
+  Safe: false
 
 Style/RedundantSortBy:
   Description: 'Use `sort` instead of `sort_by { |x| x }`.'
@@ -4506,6 +4571,12 @@ Style/Sample:
   Enabled: true
   VersionAdded: '0.30'
 
+Style/SelectByRegexp:
+  Description: 'Prefer grep/grep_v to select/reject with a regexp match.'
+  Enabled: pending
+  SafeAutoCorrect: false
+  VersionAdded: '1.22'
+
 Style/SelfAssignment:
   Description: >-
                  Checks for places where self-assignment shorthand should have
@@ -4692,8 +4763,9 @@ Style/StructInheritance:
   Description: 'Checks for inheritance from Struct.new.'
   StyleGuide: '#no-extend-struct-new'
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.29'
-  VersionChanged: '0.86'
+  VersionChanged: '1.20'
 
 Style/SwapValues:
   Description: 'This cop enforces the use of shorthand-style swapping of 2 variables.'

data/cookstyle.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
 
   spec.metadata = {
     'homepage_uri' => 'https://github.com/chef/cookstyle',
-    'changelog_uri' => 'https://github.com/chef/cookstyle/blob/master/CHANGELOG.md',
+    'changelog_uri' => 'https://github.com/chef/cookstyle/blob/main/CHANGELOG.md',
     'source_code_uri' => 'https://github.com/chef/cookstyle',
     'documentation_uri' => 'https://docs.chef.io/workstation/cookstyle/',
     'bug_tracker_uri' => 'https://github.com/chef/cookstyle/issues',

data/lib/cookstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Cookstyle
-  VERSION = "7.21.0" # rubocop: disable Style/StringLiterals
-  RUBOCOP_VERSION = '1.19.0'
+  VERSION = "7.25.6" # rubocop: disable Style/StringLiterals
+  RUBOCOP_VERSION = '1.22.0'
 end

data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+#
+# Copyright:: 2021, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Correctness
+        # metadata.rb should define a version for the cookbook.
+        #
+        # @example
+        #
+        #   #### correct
+        #   name 'foo'
+        #   version '1.0.0'
+        #
+        class MetadataMissingVersion < Base
+          extend AutoCorrector
+          include RangeHelp
+
+          MSG = 'metadata.rb should define a version for the cookbook.'
+
+          def_node_search :cb_version?, '(send nil? :version str ...)'
+
+          def on_new_investigation
+            # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
+            return if cb_version?(processed_source.ast)
+            range = source_range(processed_source.buffer, 1, 0)
+            add_offense(range, message: MSG, severity: :refactor)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb

@@ -19,7 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module Deprecations
-        # Do not use legacy chef-sugar helper methods, which will not be moved into Chef Infra Client itself. For a complete set of chef-sugar helpers now shipping in Chef Infra Client itself see https://github.com/chef/chef/tree/master/chef-utils#getting-started
+        # Do not use legacy chef-sugar helper methods, which will not be moved into Chef Infra Client itself. For a complete set of chef-sugar helpers now shipping in Chef Infra Client itself see https://github.com/chef/chef/tree/main/chef-utils#getting-started
         #
         # @example
         #
@@ -42,7 +42,7 @@ module RuboCop
         #   opensolaris?
         #
         class ChefSugarHelpers < Base
-          MSG = 'Do not use legacy chef-sugar helper methods, which will not be moved into Chef Infra Client itself. For a complete set of chef-sugar helpers now shipping in Chef Infra Client itself see https://github.com/chef/chef/tree/master/chef-utils#getting-started'
+          MSG = 'Do not use legacy chef-sugar helper methods, which will not be moved into Chef Infra Client itself. For a complete set of chef-sugar helpers now shipping in Chef Infra Client itself see https://github.com/chef/chef/tree/main/chef-utils#getting-started'
           RESTRICT_ON_SEND = [:vagrant_key?, :vagrant_domain?, :vagrant_user?, :require_chef_gem, :best_ip_for, :nexus?, :ios_xr?, :ruby_20?, :ruby_19?, :includes_recipe?, :wrlinux?, :dev_null, :nexentacore_platform?, :opensolaris_platform?, :nexentacore?, :opensolaris?].freeze
 
           def on_send(node)

data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb

@@ -19,7 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module Deprecations
-        # Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version values so it's always best to be less specific ie. 10 instead of 10.3
+        # Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/main/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version values so it's always best to be less specific ie. 10 instead of 10.3
         #
         # @example
         #
@@ -29,7 +29,7 @@ module RuboCop
           include RuboCop::Chef::CookbookHelpers
           extend AutoCorrector
 
-          MSG = "Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3"
+          MSG = "Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/main/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3"
 
           DEPRECATED_MAPPING = {
             'amazon' => {

data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb

@@ -19,7 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module Deprecations
-        # Chef Infra Client 15.3 and later include a new Unified Mode that simplies the execution of resoures by replace the traditional compile and converge phases with a single phase. Unified mode simplies writing advanced resources and avoids confusing errors that often occur when mixing ruby and Chef Infra resources. Chef Infra Client 17.0 and later will beging warning that `unified_mode true` should be set in all resources to validate that they will continue to function in Chef Infra Client 18.0 (April 2022) when Unified Mode becomes the default.
+        # Chef Infra Client 15.3 and later include a new Unified Mode that simplifies the execution of resources by replace the traditional compile and converge phases with a single phase. Unified mode simplifies writing advanced resources and avoids confusing errors that often occur when mixing ruby and Chef Infra resources. Chef Infra Client 17.0 and later will begin warning that `unified_mode true` should be set in all resources to validate that they will continue to function in Chef Infra Client 18.0 (April 2022) when Unified Mode becomes the default.
         #
         # @example
         #

data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb

@@ -19,7 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module Deprecations
-        # Chef Infra Client 15.3 and later include a new Unified Mode that simplies the execution of resoures by replace the traditional compile and converge phases with a single phase. Unified mode simplies writing advanced resources and avoids confusing errors that often occur when mixing ruby and Chef Infra resources. Chef Infra Client 17.0 and later will beging warning that `unified_mode true` should be set in all resources to validate that they will continue to function in Chef Infra Client 18.0 (April 2022) when Unified Mode becomes the default.
+        # Chef Infra Client 15.3 and later include a new Unified Mode that simplifies the execution of resources by replace the traditional compile and converge phases with a single phase. Unified mode simplifies writing advanced resources and avoids confusing errors that often occur when mixing ruby and Chef Infra resources. Chef Infra Client 17.0 and later will begin warning that `unified_mode true` should be set in all resources to validate that they will continue to function in Chef Infra Client 18.0 (April 2022) when Unified Mode becomes the default.
         #
         # @example
         #

data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+#
+# Copyright:: 2021, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Modernize
+        # In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block.
+        #
+        # @example
+        #
+        #   #### incorrect
+        #   action_class.class_eval do
+        #     foo
+        #   end
+        #
+        #   #### correct
+        #   action_class do
+        #     foo
+        #   end
+        #
+        class ClassEvalActionClass < Base
+          extend TargetChefVersion
+          extend AutoCorrector
+
+          minimum_target_chef_version '12.9'
+
+          MSG = 'In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block.'
+          RESTRICT_ON_SEND = [:include_recipe].freeze
+
+          def_node_matcher :class_eval_action_class?, <<-PATTERN
+            (block
+              (send
+                (send nil? :action_class) :class_eval)
+              (args)
+              ... )
+          PATTERN
+
+          def on_block(node)
+            class_eval_action_class?(node) do
+              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+                corrector.replace(node, node.source.gsub('.class_eval', ''))
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb

@@ -19,22 +19,41 @@ module RuboCop
   module Cop
     module Chef
       module Modernize
-        # Chef Infra Client 15.5 and later include cloud helpers to make detecting instance that run on public and private clouds easier.
+        # Chef Infra Client 15.5 and later include cloud helpers to make detecting instances that run on public and private clouds easier.
         #
         # @example
         #
         #   #### incorrect
-        #   ENV['CI']
-        #   ENV['TEST_KITCHEN']
+        #   node['cloud']['provider'] == 'alibaba'
+        #   node['cloud']['provider'] == 'ec2'
+        #   node['cloud']['provider'] == 'gce'
+        #   node['cloud']['provider'] == 'rackspace'
+        #   node['cloud']['provider'] == 'eucalyptus'
+        #   node['cloud']['provider'] == 'linode'
+        #   node['cloud']['provider'] == 'openstack'
+        #   node['cloud']['provider'] == 'azure'
+        #   node['cloud']['provider'] == 'digital_ocean'
+        #   node['cloud']['provider'] == 'softlayer'
         #
         #   #### correct
-        #   ci?
-        #   kitchen?
+        #   alibaba?
+        #   ec2?
+        #   gce?
+        #   rackspace?
+        #   eucalyptus?
+        #   linode?
+        #   openstack?
+        #   azure?
+        #   digital_ocean?
+        #   softlayer?
         #
         class UseChefLanguageCloudHelpers < Base
           extend AutoCorrector
+          extend TargetChefVersion
 
-          MSG = 'Chef Infra Client 15.5 and later include cloud helpers to make detecting instance that run on public and private clouds easier.'.freeze
+          minimum_target_chef_version '15.5'
+
+          MSG = 'Chef Infra Client 15.5 and later include cloud helpers to make detecting instances that run on public and private clouds easier.'
           RESTRICT_ON_SEND = [:==, :[]].freeze
           VALID_CLOUDS = %w(alibaba ec2 gce rackspace eucalyptus linode openstack azure digital_ocean softlayer).freeze
 
@@ -48,12 +67,6 @@ module RuboCop
               (str $_))
           PATTERN
 
-          def_node_matcher :node_check?, <<-PATTERN
-            (send
-              (send nil? :node) :[]
-              (str ${"ec2"}))
-          PATTERN
-
           def_node_matcher :node_cloud?, <<-PATTERN
             (send
               (send nil? :node) :[]
@@ -61,19 +74,13 @@ module RuboCop
           PATTERN
 
           def on_send(node)
-            node_check?(node) do |cloud_name|
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
-                corrector.replace(node, "#{cloud_name}?")
-              end
-            end
-
             provider_comparison?(node) do |cloud_name|
               # skip it if someone was checking for a bogus cloud provider
               next unless VALID_CLOUDS.include?(cloud_name)
 
               # if they were checking for node['cloud'] and the provider replace it all
               node = node.parent if node.parent.and_type? && node_cloud?(node.left_sibling)
-              
+
               add_offense(node, message: MSG, severity: :refactor) do |corrector|
                 corrector.replace(node, "#{cloud_name}?")
               end

data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb

@@ -19,7 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module Modernize
-        # Chef Infra Client 15.5 and later include a large number of new helpers in the Chef Infra Language to simplify checking the system configuration in recipes and resources. These should be used when possible over more complex attribute or ENV var comparisons.
+        # Chef Infra Client 15.5 and later include a large number of new helpers in the Chef Infra Language to simplify checking the system configuration in recipes and resources. These should be used when possible over more complex attributes or ENV var comparisons.
         #
         # @example
         #
@@ -33,6 +33,9 @@ module RuboCop
         #
         class UseChefLanguageEnvHelpers < Base
           extend AutoCorrector
+          extend TargetChefVersion
+
+          minimum_target_chef_version '15.5'
 
           RESTRICT_ON_SEND = [:[]].freeze
 

data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+#
+# Copyright:: 2021, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Modernize
+        # Chef Infra Client 15.5 and later include a `systemd?` helper for checking if a Linux system uses systemd.
+        #
+        # @example
+        #
+        #   #### incorrect
+        #   node['init_package'] == 'systemd'
+        #
+        #   #### correct
+        #   systemd?
+        #
+        class UseChefLanguageSystemdHelper < Base
+          extend AutoCorrector
+          extend TargetChefVersion
+
+          minimum_target_chef_version '15.5'
+
+          MSG = 'Chef Infra Client 15.5 and later include a `systemd?` helper for checking if a Linux system uses systemd.'
+          RESTRICT_ON_SEND = [:==].freeze
+
+          def_node_matcher :node_init_package?, <<-PATTERN
+              (send
+                (send
+                  (send nil? :node) :[]
+                  (str "init_package")) :==
+                (str "systemd"))
+            PATTERN
+
+          def on_send(node)
+            node_init_package?(node) do |_cloud_name|
+              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+                corrector.replace(node, 'systemd?')
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 7.21.0
+  version: 7.25.6
 platform: ruby
 authors:
 - Thom May
 - Tim Smith
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-26 00:00:00.000000000 Z
+date: 2021-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,15 +17,15 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: 1.22.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.19.0
-description:
+        version: 1.22.0
+description: 
 email:
 - thom@chef.io
 - tsmith@chef.io
@@ -71,6 +71,7 @@ files:
 - lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb
 - lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb
 - lib/rubocop/cop/chef/correctness/metadata_missing_name.rb
+- lib/rubocop/cop/chef/correctness/metadata_missing_version.rb
 - lib/rubocop/cop/chef/correctness/node_normal.rb
 - lib/rubocop/cop/chef/correctness/node_normal_unless.rb
 - lib/rubocop/cop/chef/correctness/node_save.rb
@@ -181,6 +182,7 @@ files:
 - lib/rubocop/cop/chef/modernize/chef_14_resources.rb
 - lib/rubocop/cop/chef/modernize/chef_15_resources.rb
 - lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb
+- lib/rubocop/cop/chef/modernize/class_eval_action_class.rb
 - lib/rubocop/cop/chef/modernize/compile_time_resources.rb
 - lib/rubocop/cop/chef/modernize/conditional_using_test.rb
 - lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb
@@ -238,6 +240,7 @@ files:
 - lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb
 - lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb
 - lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb
+- lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb
 - lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb
 - lib/rubocop/cop/chef/modernize/use_require_relative.rb
 - lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb
@@ -305,11 +308,11 @@ licenses:
 - Apache-2.0
 metadata:
   homepage_uri: https://github.com/chef/cookstyle
-  changelog_uri: https://github.com/chef/cookstyle/blob/master/CHANGELOG.md
+  changelog_uri: https://github.com/chef/cookstyle/blob/main/CHANGELOG.md
   source_code_uri: https://github.com/chef/cookstyle
   documentation_uri: https://docs.chef.io/workstation/cookstyle/
   bug_tracker_uri: https://github.com/chef/cookstyle/issues
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -324,8 +327,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
-signing_key:
+rubygems_version: 3.1.4
+signing_key: 
 specification_version: 4
 summary: Cookstyle is a code linting tool that helps you to write better Chef Infra
   cookbooks by detecting and automatically correcting style, syntax, and logic mistakes